)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"8a97d31c8552fd1187407efa1afe45ab5dfc1631","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cdef48bd_0a9b8a4b","updated":"2026-09-15 17:23:50.000000000","message":"This looks fine to me, but the bug report seems to have discuss changing the other side (In-band/IPA) from a string to an int rather than changing redfish\u0027s frequency to a string. Was this approach agreed upon somewhere else?","commit_id":"2290b731905462073d41eeaf72259c8ea89da92a"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"14cd11b16f4d81bd63babc59fe57ed901018bfbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b0c42878_5195a22e","updated":"2026-09-16 21:47:36.000000000","message":"lgtm","commit_id":"2290b731905462073d41eeaf72259c8ea89da92a"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"2be8f8ec3df2b4d93c0c8bbf15f18861c8c74f63","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3e4ecba4_40d87ab5","in_reply_to":"cdef48bd_0a9b8a4b","updated":"2026-09-15 18:13:49.000000000","message":"I took those as suggestions :)\n\nI went the other direction (cast Redfish\u0027s int to string) for a few reasons, but happy to revisit if the team prefers the microversion route;\n\n   simpler backportable fix with an existing, long-standing behavior (IPA\u0027s in-band path), and Redfish OOB CPU inspection was only added later (I651599b84e6b8901647960b719626489b000b65f). Gophercloud already only works with the string form, per the bug report, so no existing consumer breaks with this fix, including possibly ironic clients.","commit_id":"2290b731905462073d41eeaf72259c8ea89da92a"}],"ironic/drivers/modules/redfish/inspect.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"62b56781768cab981bd0bfb9adad7b99b3a52250","unresolved":true,"context_lines":[{"line_number":318,"context_line":"        if processor.model is not None:"},{"line_number":319,"context_line":"            cpu[\u0027model_name\u0027] \u003d str(processor.model)"},{"line_number":320,"context_line":"        if processor.max_speed_mhz is not None:"},{"line_number":321,"context_line":"            cpu[\u0027frequency\u0027] \u003d str(processor.max_speed_mhz)"},{"line_number":322,"context_line":"        cpu[\u0027architecture\u0027] \u003d PROCESSOR_INSTRUCTION_SET_MAP.get("},{"line_number":323,"context_line":"            processor.instruction_set) or \u0027\u0027"},{"line_number":324,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"49f19670_5c88c84a","line":321,"updated":"2026-09-17 12:01:25.000000000","message":"I would be afraid if some consumers are using int in some automation and this could cause problem to them .-.\nI like the idea, let\u0027s see what others think","commit_id":"2290b731905462073d41eeaf72259c8ea89da92a"}]}
