)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"fba73f4cabacedf20a9e7446f5fea8ad7f182da8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f3e84e3d_f6ae8090","updated":"2026-10-16 19:43:15.000000000","message":"recheck one more recheck","commit_id":"9fbac95b628fb600194f1ace9e53d354856a3ae7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4f28e0e36eecc9f915ee0c4bd770f3f45b4b4239","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2f08bc5d_ad2fb15d","updated":"2026-10-08 13:23:22.000000000","message":"recheck retry limit on instance launch for one of the test jobs","commit_id":"9fbac95b628fb600194f1ace9e53d354856a3ae7"}],"ironic/conf/ansible.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"360ea7da77799a5b2e133714ad8c31d4cf0dc53b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"               help\u003d_(\u0027Path to directory with playbooks, roles and \u0027"},{"line_number":44,"context_line":"                      \u0027local inventory.\u0027)),"},{"line_number":45,"context_line":"    cfg.ListOpt(\u0027playbooks_path_allowlist\u0027,"},{"line_number":46,"context_line":"                default\u003d[],"},{"line_number":47,"context_line":"                help\u003d_(\u0027List of absolute directory paths which are permitted \u0027"},{"line_number":48,"context_line":"                       \u0027as the per-node \"ansible_playbooks_path\" driver_info \u0027"},{"line_number":49,"context_line":"                       \u0027value, in addition to the directory configured in \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"916763a1_ee04db8f","line":46,"updated":"2026-09-28 10:46:52.000000000","message":"nit: we could offer some reasonable default for operator-provided playbooks, e.g. `/var/lib/ironic/ansible`. This way we\u0027ll nudge them towards something standard.","commit_id":"aa846c1a6faa287e7f4c922a5424564ff1bf5d6f"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"599d83e06abd23096e5c99de7bce7664807f3f68","unresolved":true,"context_lines":[{"line_number":43,"context_line":"               help\u003d_(\u0027Path to directory with playbooks, roles and \u0027"},{"line_number":44,"context_line":"                      \u0027local inventory.\u0027)),"},{"line_number":45,"context_line":"    cfg.ListOpt(\u0027playbooks_path_allowlist\u0027,"},{"line_number":46,"context_line":"                default\u003d[],"},{"line_number":47,"context_line":"                help\u003d_(\u0027List of absolute directory paths which are permitted \u0027"},{"line_number":48,"context_line":"                       \u0027as the per-node \"ansible_playbooks_path\" driver_info \u0027"},{"line_number":49,"context_line":"                       \u0027value, in addition to the directory configured in \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"68a475a3_9b08a471","line":46,"updated":"2026-10-19 20:32:05.000000000","message":"item_type\u003dExplicitAbsolutePath from our types, please. Right now this can fall victim to path traversal in the config file (not a vuln, but also not awesome)\n\nhttps://opendev.org/openstack/ironic/src/branch/master/ironic/conf/types.py#L22","commit_id":"9fbac95b628fb600194f1ace9e53d354856a3ae7"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"21528e54314914e30548e5eaa567d70d65d32742","unresolved":false,"context_lines":[{"line_number":43,"context_line":"               help\u003d_(\u0027Path to directory with playbooks, roles and \u0027"},{"line_number":44,"context_line":"                      \u0027local inventory.\u0027)),"},{"line_number":45,"context_line":"    cfg.ListOpt(\u0027playbooks_path_allowlist\u0027,"},{"line_number":46,"context_line":"                default\u003d[],"},{"line_number":47,"context_line":"                help\u003d_(\u0027List of absolute directory paths which are permitted \u0027"},{"line_number":48,"context_line":"                       \u0027as the per-node \"ansible_playbooks_path\" driver_info \u0027"},{"line_number":49,"context_line":"                       \u0027value, in addition to the directory configured in \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"aaad6188_442b31b4","line":46,"in_reply_to":"68a475a3_9b08a471","updated":"2026-10-23 16:20:17.000000000","message":"Done","commit_id":"9fbac95b628fb600194f1ace9e53d354856a3ae7"}],"ironic/drivers/modules/ansible/deploy.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"599d83e06abd23096e5c99de7bce7664807f3f68","unresolved":true,"context_lines":[{"line_number":120,"context_line":"    allowed.extend(CONF.ansible.playbooks_path_allowlist)"},{"line_number":121,"context_line":"    # Resolve symlinks and relative segments so the containment check"},{"line_number":122,"context_line":"    # cannot be bypassed via \u0027..\u0027 or a symlink pointing elsewhere."},{"line_number":123,"context_line":"    allowed_real \u003d [os.path.realpath(p) for p in allowed if p]"},{"line_number":124,"context_line":"    resolved \u003d os.path.realpath(override)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    permitted \u003d any(resolved \u003d\u003d base or resolved.startswith(base + os.sep)"}],"source_content_type":"text/x-python","patch_set":2,"id":"cbd5c2b8_8467430b","line":123,"updated":"2026-10-19 20:32:05.000000000","message":"I think this is not needed if you do the validation in conf as I\u0027ve commented.","commit_id":"9fbac95b628fb600194f1ace9e53d354856a3ae7"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"1ca3e1a88cd5e84fbb71aec296344ec8f527aed6","unresolved":true,"context_lines":[{"line_number":137,"context_line":"             \u0027%(allowed)s.\u0027) %"},{"line_number":138,"context_line":"           {\u0027path\u0027: override, \u0027node\u0027: node.uuid, \u0027resolved\u0027: resolved,"},{"line_number":139,"context_line":"            \u0027allowed\u0027: \u0027, \u0027.join(allowed)})"},{"line_number":140,"context_line":"    if CONF.ansible.enforce_playbooks_path:"},{"line_number":141,"context_line":"        raise exception.InvalidParameterValue(msg)"},{"line_number":142,"context_line":"    LOG.warning(\u0027%s This will be rejected in a future release once \u0027"},{"line_number":143,"context_line":"                \u0027[ansible]enforce_playbooks_path is enabled by default.\u0027, msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fdc8e670_b5d5b5de","line":140,"updated":"2026-10-23 16:22:57.000000000","message":"```suggestion\n    if not CONF.ansible.enforce_playbooks_path:\n```\n\nShouldn\u0027t that print the message when it\u0027s not enabled?","commit_id":"100451c7134e38d23ef029d93862598f2713c0d5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"36b7121f051c629a52deb35d194ea851f900e10d","unresolved":false,"context_lines":[{"line_number":137,"context_line":"             \u0027%(allowed)s.\u0027) %"},{"line_number":138,"context_line":"           {\u0027path\u0027: override, \u0027node\u0027: node.uuid, \u0027resolved\u0027: resolved,"},{"line_number":139,"context_line":"            \u0027allowed\u0027: \u0027, \u0027.join(allowed)})"},{"line_number":140,"context_line":"    if CONF.ansible.enforce_playbooks_path:"},{"line_number":141,"context_line":"        raise exception.InvalidParameterValue(msg)"},{"line_number":142,"context_line":"    LOG.warning(\u0027%s This will be rejected in a future release once \u0027"},{"line_number":143,"context_line":"                \u0027[ansible]enforce_playbooks_path is enabled by default.\u0027, msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"b86bbbc4_22b5fb34","line":140,"in_reply_to":"c597a491_a069e21a","updated":"2026-10-24 01:57:29.000000000","message":"Yeah, intentional. In the case it is set, it’s in failure case. In the future it will be hard error, but for not a warning.","commit_id":"100451c7134e38d23ef029d93862598f2713c0d5"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"38d25194ef338873c4603dc0e08e4e43769bba5d","unresolved":false,"context_lines":[{"line_number":137,"context_line":"             \u0027%(allowed)s.\u0027) %"},{"line_number":138,"context_line":"           {\u0027path\u0027: override, \u0027node\u0027: node.uuid, \u0027resolved\u0027: resolved,"},{"line_number":139,"context_line":"            \u0027allowed\u0027: \u0027, \u0027.join(allowed)})"},{"line_number":140,"context_line":"    if CONF.ansible.enforce_playbooks_path:"},{"line_number":141,"context_line":"        raise exception.InvalidParameterValue(msg)"},{"line_number":142,"context_line":"    LOG.warning(\u0027%s This will be rejected in a future release once \u0027"},{"line_number":143,"context_line":"                \u0027[ansible]enforce_playbooks_path is enabled by default.\u0027, msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"c597a491_a069e21a","line":140,"in_reply_to":"fdc8e670_b5d5b5de","updated":"2026-10-23 16:23:48.000000000","message":"I missed the un-indent for the LOG.warning.","commit_id":"100451c7134e38d23ef029d93862598f2713c0d5"}]}
