)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8bbca3ca5476125f15cca848ff348ce36b9c97ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"372d1ceb_ca262927","updated":"2026-10-02 13:04:56.000000000","message":"@alegacy@redhat.com do you think it\u0027s safe to call configure_tenant_network without deconfiguring it first?","commit_id":"6343559698c8e25263bc829a5310e560f551e00e"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"3a30af4866ea5f2e7f19e969caef92b14bfe134a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"da413f5b_e7426dfd","in_reply_to":"372d1ceb_ca262927","updated":"2026-10-02 15:15:05.000000000","message":"Unfortunately the NGS driver leaves a lot to be desired in how it \"resets\" a port or deals with applying a configuration to a port where it doesn\u0027t know the starting conditions.  It needs to be told what was already configured in order to be able to \"reset\" the port back to a cleared state before applying a new configuration.  \n\nThe answer is \"it depends\".  For access ports, yes it is probably fine to simply call configure_tenant_network and the port\u0027s configuration will be updated to reflect what is desired.  For trunk/hybrid ports, calling it without first removing what was there would end up being an additive effect and will likely leave the port in an incorrect configuration.\n\nThe neutron side of things likely suffers from the same limitation since it is going thru the same driver implementation.\n\nWhat would be the expected port state before calling this \"reattach\" interface?","commit_id":"6343559698c8e25263bc829a5310e560f551e00e"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"5b84e6bea4e49318947bf65ade7a2ef9788f07fc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ae614aaf_0add7a8f","in_reply_to":"84f94fab_66b6acb5","updated":"2026-10-02 19:00:41.000000000","message":"Ok, then as I said, for anything other than a simple access mode port NGS is not well suited for that type of operation... and that would apply to the Neutron case as well as ironic-networking.","commit_id":"6343559698c8e25263bc829a5310e560f551e00e"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"d444552442514a15c523f8ed8a713e1b297de804","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"84f94fab_66b6acb5","in_reply_to":"da413f5b_e7426dfd","updated":"2026-10-02 17:39:42.000000000","message":"Unknown/potentially broken. The point of this is to go from (any/broken state) -\u003e (working state) in a step.","commit_id":"6343559698c8e25263bc829a5310e560f551e00e"}],"ironic/drivers/modules/network/ironic_networking.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7eadb0d163c969b85b744e409decd5e0a3e3d14c","unresolved":true,"context_lines":[{"line_number":1391,"context_line":"        \"\"\""},{"line_number":1392,"context_line":"        LOG.info(\u0027Reattaching tenant networking for node %s\u0027, task.node.uuid)"},{"line_number":1393,"context_line":""},{"line_number":1394,"context_line":"        self.unconfigure_tenant_networks(task)"},{"line_number":1395,"context_line":""},{"line_number":1396,"context_line":"        # Reattach tenant networks using existing configuration"},{"line_number":1397,"context_line":"        self.configure_tenant_networks(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"26c8c1b5_17f8b5c7","line":1394,"updated":"2026-09-29 20:53:03.000000000","message":"Is this actually the right thing for this interface? This will, if my reading of the code is accurate, put the node back on the \"idle\" VLAN temporarily.\n\nI think we should have a more targeted implementation which does the reattach *without* tossing it on the idle VLAN while active.","commit_id":"6343559698c8e25263bc829a5310e560f551e00e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ae0faecbd97518cc8df3ec3a208fa7b6d3f9885a","unresolved":true,"context_lines":[{"line_number":1391,"context_line":"        \"\"\""},{"line_number":1392,"context_line":"        LOG.info(\u0027Reattaching tenant networking for node %s\u0027, task.node.uuid)"},{"line_number":1393,"context_line":""},{"line_number":1394,"context_line":"        self.unconfigure_tenant_networks(task)"},{"line_number":1395,"context_line":""},{"line_number":1396,"context_line":"        # Reattach tenant networks using existing configuration"},{"line_number":1397,"context_line":"        self.configure_tenant_networks(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"66feafde_0c9e93cc","line":1394,"in_reply_to":"26c8c1b5_17f8b5c7","updated":"2026-09-30 09:30:56.000000000","message":"Good call, I\u0027ll check with Allain","commit_id":"6343559698c8e25263bc829a5310e560f551e00e"}]}