)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8c197dfa740335113d1d96e85657f254ce206bcc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"temporarily unavailable.  Retry in 30 seconds.\u0027 This can cause issues"},{"line_number":11,"context_line":"when setting the boot device during provisioning if the request isn\u0027t"},{"line_number":12,"context_line":"retried."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I66447665e5d49fd9674a7ae4fb893c9d6fbc3edc"},{"line_number":15,"context_line":"Signed-off-by: Jed Preist \u003cjed@stackhpc.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"be5a171f_f8fac609","line":13,"updated":"2026-10-08 13:15:15.000000000","message":"Does an upstream bug exist regarding this issue? If so, please note it.","commit_id":"09b13edf32a8476af2c31ecea13eeb606d640fbb"},{"author":{"_account_id":39213,"name":"Jed Preist","display_name":"Jed Preist","email":"jed@stackhpc.com","username":"jed-preist"},"change_message_id":"c914e8ef826b9356114b55bb22cd932fabc51a3c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"temporarily unavailable.  Retry in 30 seconds.\u0027 This can cause issues"},{"line_number":11,"context_line":"when setting the boot device during provisioning if the request isn\u0027t"},{"line_number":12,"context_line":"retried."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I66447665e5d49fd9674a7ae4fb893c9d6fbc3edc"},{"line_number":15,"context_line":"Signed-off-by: Jed Preist \u003cjed@stackhpc.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9058ad6f_03e737f8","line":13,"in_reply_to":"be5a171f_f8fac609","updated":"2026-10-08 16:14:40.000000000","message":"I haven\u0027t raised one, and can\u0027t see one raised by anyone else. Happy to raise one if needed.","commit_id":"09b13edf32a8476af2c31ecea13eeb606d640fbb"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8c197dfa740335113d1d96e85657f254ce206bcc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1394b8ca_d3d0d54f","updated":"2026-10-08 13:15:15.000000000","message":"Greetings,\n\nThank you for the patch. A couple minor things, mainly a unit test is needed. A doc string on the helper method would also be good to assist AI agents and contributors who have never seen the code before to understand what is going on.","commit_id":"09b13edf32a8476af2c31ecea13eeb606d640fbb"},{"author":{"_account_id":39213,"name":"Jed Preist","display_name":"Jed Preist","email":"jed@stackhpc.com","username":"jed-preist"},"change_message_id":"c914e8ef826b9356114b55bb22cd932fabc51a3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e03bb368_239e8e7f","in_reply_to":"1394b8ca_d3d0d54f","updated":"2026-10-08 16:14:40.000000000","message":"Hello Julia, thank you for the review. I have made the changes you requested.","commit_id":"09b13edf32a8476af2c31ecea13eeb606d640fbb"}],"ironic/drivers/modules/redfish/management.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e999693fea3f4c6337b8428035cb7e36458c4daa","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    wants_retry \u003d \u0027Retry in 30 seconds\u0027 in str(exc)"},{"line_number":156,"context_line":"    if wants_retry:"},{"line_number":157,"context_line":"        LOG.debug(\u0027Detected UnableToModifyDuringSystemPOST error from BMC, \u0027"},{"line_number":158,"context_line":"                    \u0027will trigger retry logic. Error: %s\u0027, exc)"},{"line_number":159,"context_line":"    return wants_retry"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"def _set_boot_device(task, system, device, persistent\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"02409aae_e5cb2c01","line":158,"updated":"2026-10-08 12:37:32.000000000","message":"pep8: E127 continuation line over-indented for visual indent","commit_id":"6b66180cc29d51d68a54e1bef5bee84d3a5dc693"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8c197dfa740335113d1d96e85657f254ce206bcc","unresolved":true,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"def _bmc_wants_retry(exc):"},{"line_number":146,"context_line":"    \"\"\"Check if the BMC asked for the request to be retried in the exception."},{"line_number":147,"context_line":"    "},{"line_number":148,"context_line":"    Dell iDRAC BMCs reject some requests with the message \u0027The service is "},{"line_number":149,"context_line":"    temporarily unavailable.  Retry in 30 seconds.\u0027"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"13f6fb2c_694be341","line":147,"updated":"2026-10-08 13:15:15.000000000","message":"When adding a docstring below, please address the whitespace here and on line 148 at the end of the line.","commit_id":"09b13edf32a8476af2c31ecea13eeb606d640fbb"},{"author":{"_account_id":39213,"name":"Jed Preist","display_name":"Jed Preist","email":"jed@stackhpc.com","username":"jed-preist"},"change_message_id":"c914e8ef826b9356114b55bb22cd932fabc51a3c","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"def _bmc_wants_retry(exc):"},{"line_number":146,"context_line":"    \"\"\"Check if the BMC asked for the request to be retried in the exception."},{"line_number":147,"context_line":"    "},{"line_number":148,"context_line":"    Dell iDRAC BMCs reject some requests with the message \u0027The service is "},{"line_number":149,"context_line":"    temporarily unavailable.  Retry in 30 seconds.\u0027"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"35060586_239a6af9","line":147,"in_reply_to":"13f6fb2c_694be341","updated":"2026-10-08 16:14:40.000000000","message":"Done","commit_id":"09b13edf32a8476af2c31ecea13eeb606d640fbb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8c197dfa740335113d1d96e85657f254ce206bcc","unresolved":true,"context_lines":[{"line_number":152,"context_line":"    :returns: True if the BMC asked for the request to be retried, False"},{"line_number":153,"context_line":"              otherwise"},{"line_number":154,"context_line":"    \"\"\""},{"line_number":155,"context_line":"    wants_retry \u003d \u0027Retry in 30 seconds\u0027 in str(exc)"},{"line_number":156,"context_line":"    if wants_retry:"},{"line_number":157,"context_line":"        LOG.debug(\u0027BMC asked for the request to be retried. Error: %s\u0027, exc)"},{"line_number":158,"context_line":"    return wants_retry"}],"source_content_type":"text/x-python","patch_set":3,"id":"c03f49b5_ab5e0fa2","line":155,"updated":"2026-10-08 13:15:15.000000000","message":"Please add a unit test to this effect.","commit_id":"09b13edf32a8476af2c31ecea13eeb606d640fbb"},{"author":{"_account_id":39213,"name":"Jed Preist","display_name":"Jed Preist","email":"jed@stackhpc.com","username":"jed-preist"},"change_message_id":"c914e8ef826b9356114b55bb22cd932fabc51a3c","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    :returns: True if the BMC asked for the request to be retried, False"},{"line_number":153,"context_line":"              otherwise"},{"line_number":154,"context_line":"    \"\"\""},{"line_number":155,"context_line":"    wants_retry \u003d \u0027Retry in 30 seconds\u0027 in str(exc)"},{"line_number":156,"context_line":"    if wants_retry:"},{"line_number":157,"context_line":"        LOG.debug(\u0027BMC asked for the request to be retried. Error: %s\u0027, exc)"},{"line_number":158,"context_line":"    return wants_retry"}],"source_content_type":"text/x-python","patch_set":3,"id":"30b778da_f8ed8e3f","line":155,"in_reply_to":"c03f49b5_ab5e0fa2","updated":"2026-10-08 16:14:40.000000000","message":"Done","commit_id":"09b13edf32a8476af2c31ecea13eeb606d640fbb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8c197dfa740335113d1d96e85657f254ce206bcc","unresolved":true,"context_lines":[{"line_number":203,"context_line":"        enabled \u003d (desired_enabled"},{"line_number":204,"context_line":"                   if desired_enabled !\u003d current_enabled else None)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _retry_set_boot_device(exc):"},{"line_number":207,"context_line":"        return _is_during_post_error(exc) or _bmc_wants_retry(exc)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    # Logging callback for retry attempts (closure captures task)"}],"source_content_type":"text/x-python","patch_set":3,"id":"d4fbf9ba_a4f4992c","line":206,"updated":"2026-10-08 13:15:15.000000000","message":"Please add a quick docstring, even though it is a helper it helps readability and AI agents understanding what is going on.","commit_id":"09b13edf32a8476af2c31ecea13eeb606d640fbb"},{"author":{"_account_id":39213,"name":"Jed Preist","display_name":"Jed Preist","email":"jed@stackhpc.com","username":"jed-preist"},"change_message_id":"c914e8ef826b9356114b55bb22cd932fabc51a3c","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        enabled \u003d (desired_enabled"},{"line_number":204,"context_line":"                   if desired_enabled !\u003d current_enabled else None)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _retry_set_boot_device(exc):"},{"line_number":207,"context_line":"        return _is_during_post_error(exc) or _bmc_wants_retry(exc)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    # Logging callback for retry attempts (closure captures task)"}],"source_content_type":"text/x-python","patch_set":3,"id":"560ac603_4113e42c","line":206,"in_reply_to":"d4fbf9ba_a4f4992c","updated":"2026-10-08 16:14:40.000000000","message":"Done","commit_id":"09b13edf32a8476af2c31ecea13eeb606d640fbb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9795365a72f50a5b1b4381188fb8451a10020696","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    :returns: True if the BMC asked for the request to be retried, False"},{"line_number":153,"context_line":"              otherwise"},{"line_number":154,"context_line":"    \"\"\""},{"line_number":155,"context_line":"    wants_retry \u003d \u0027Retry in 30 seconds\u0027 in str(exc)"},{"line_number":156,"context_line":"    if wants_retry:"},{"line_number":157,"context_line":"        LOG.debug(\u0027BMC asked for the request to be retried. Error: %s\u0027, exc)"},{"line_number":158,"context_line":"    return wants_retry"}],"source_content_type":"text/x-python","patch_set":5,"id":"64425fb8_7a14b2f2","line":155,"updated":"2026-10-14 12:47:40.000000000","message":"Are you sure it\u0027s always 30 seconds? Maybe use a regex to check for \\d+?","commit_id":"304f80a2bc60c83a9eeca4250db94b0b2265ee51"},{"author":{"_account_id":39213,"name":"Jed Preist","display_name":"Jed Preist","email":"jed@stackhpc.com","username":"jed-preist"},"change_message_id":"15910ac5c68ff9aad7a0a488a282fcb92192f91a","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    :returns: True if the BMC asked for the request to be retried, False"},{"line_number":153,"context_line":"              otherwise"},{"line_number":154,"context_line":"    \"\"\""},{"line_number":155,"context_line":"    wants_retry \u003d \u0027Retry in 30 seconds\u0027 in str(exc)"},{"line_number":156,"context_line":"    if wants_retry:"},{"line_number":157,"context_line":"        LOG.debug(\u0027BMC asked for the request to be retried. Error: %s\u0027, exc)"},{"line_number":158,"context_line":"    return wants_retry"}],"source_content_type":"text/x-python","patch_set":5,"id":"d574bf11_8c2f4bba","line":155,"in_reply_to":"64425fb8_7a14b2f2","updated":"2026-10-14 15:26:30.000000000","message":"It\u0027s been 30 seconds on all the Dell BMCs I\u0027ve worked with, but there\u0027s no harm in using a regex","commit_id":"304f80a2bc60c83a9eeca4250db94b0b2265ee51"}]}