)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"0c4903fca83081fb690765c5d9af876ff42561d4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"703e26af_ac1c90af","updated":"2026-11-02 03:57:27.000000000","message":"Feel free to contact me by email or IRC if you want to communicate more closely.","commit_id":"3477bea1e13344176cea3a9c1c56a761e9739181"},{"author":{"_account_id":38267,"name":"Nuutti Hakala","display_name":"nuhakala","email":"nuutti.hakala@est.tech","username":"nuhakala"},"change_message_id":"8f26a6797243708a864073067335dcaf541f9f19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"463d0343_d5b1a81a","in_reply_to":"703e26af_ac1c90af","updated":"2026-11-04 10:47:37.000000000","message":"Acknowledged","commit_id":"3477bea1e13344176cea3a9c1c56a761e9739181"},{"author":{"_account_id":38267,"name":"Nuutti Hakala","display_name":"nuhakala","email":"nuutti.hakala@est.tech","username":"nuhakala"},"change_message_id":"8f26a6797243708a864073067335dcaf541f9f19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6dcdb8f5_21c23957","updated":"2026-11-04 10:47:37.000000000","message":"I added tests while waiting for more reviews. Tests were added only for different limits, i.e. I did not add multiple tests for different fields using the same string limit. I think that would not add much value.\n\nFurthermore, I noticed that the `fields` is apparently only used to tell the API which fields should be returned, and the object had enum for the different options. I hardcoded the limit to 12 for that, because there is 12 elements in the enum and no more fields can be specified.\n\nWhile adding tests, I also noticed that the fields returned from `get_test_allocation` defined in `ironic/tests/unit/db/utils.py` is not the same as defined in the allocation schema. Should these be out of sync?","commit_id":"7d5c3eccebcddb8d03c5585eb2b68ee1efc27548"}],"ironic/api/schemas/v1/allocation.py":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"242c51d881395e04b866d18d0d67f7334b59cfbf","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        },"},{"line_number":69,"context_line":"        \u0027resource_class\u0027: {"},{"line_number":70,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":71,"context_line":"            \u0027maxLength\u0027: request_types.MAX_STRING_LENGTH"},{"line_number":72,"context_line":"        },"},{"line_number":73,"context_line":"        \u0027sort_dir\u0027: request_types.sort_dir,"},{"line_number":74,"context_line":"        # TODO(stephenfin): This could probably be narrower but we need to be"}],"source_content_type":"text/x-python","patch_set":1,"id":"de53149b_b8a005d7","line":71,"updated":"2026-10-16 16:58:58.000000000","message":"```suggestion\n            \u0027maxLength\u0027: request_types.MAX_RES_CLASS_LENGTH\n```","commit_id":"139262f9fc9a40938bf75cd63bc3c83c59e0e440"},{"author":{"_account_id":38267,"name":"Nuutti Hakala","display_name":"nuhakala","email":"nuutti.hakala@est.tech","username":"nuhakala"},"change_message_id":"8a4a6d25391d363108533140eb8a7cb733847b37","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        },"},{"line_number":69,"context_line":"        \u0027resource_class\u0027: {"},{"line_number":70,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":71,"context_line":"            \u0027maxLength\u0027: request_types.MAX_STRING_LENGTH"},{"line_number":72,"context_line":"        },"},{"line_number":73,"context_line":"        \u0027sort_dir\u0027: request_types.sort_dir,"},{"line_number":74,"context_line":"        # TODO(stephenfin): This could probably be narrower but we need to be"}],"source_content_type":"text/x-python","patch_set":1,"id":"0bef3e82_26537791","line":71,"in_reply_to":"de53149b_b8a005d7","updated":"2026-10-19 05:11:34.000000000","message":"Done","commit_id":"139262f9fc9a40938bf75cd63bc3c83c59e0e440"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"a28a2f548cbcd6328e8810743b62c2c428b66d42","unresolved":true,"context_lines":[{"line_number":165,"context_line":"            \u0027items\u0027: response_types.traits,"},{"line_number":166,"context_line":"            \u0027maxItems\u0027: request_types.MAX_PROPERTIES,"},{"line_number":167,"context_line":"        },"},{"line_number":168,"context_line":"        \u0027uuid\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027], \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":169,"context_line":"    },"},{"line_number":170,"context_line":"    # TODO(stephenfin): The resource_class field is required when node is not"},{"line_number":171,"context_line":"    # provided. We\u0027d like to express this here, but doing so will change the"}],"source_content_type":"text/x-python","patch_set":2,"id":"20b27413_6ee7c4e1","line":168,"updated":"2026-11-02 03:53:28.000000000","message":"The controller treats an empty uuid as missing and generates one (ironic/api/controllers/v1/allocation.py:457). With format: uuid, \"\" is now rejected, so a POST that used to succeed returns 400. Please keep it accepted, or drop the format here.","commit_id":"3477bea1e13344176cea3a9c1c56a761e9739181"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"6cbb4173a124fa6b2fea4c63325d1fbc53e5076d","unresolved":true,"context_lines":[{"line_number":165,"context_line":"            \u0027items\u0027: response_types.traits,"},{"line_number":166,"context_line":"            \u0027maxItems\u0027: request_types.MAX_PROPERTIES,"},{"line_number":167,"context_line":"        },"},{"line_number":168,"context_line":"        \u0027uuid\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027], \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":169,"context_line":"    },"},{"line_number":170,"context_line":"    # TODO(stephenfin): The resource_class field is required when node is not"},{"line_number":171,"context_line":"    # provided. We\u0027d like to express this here, but doing so will change the"}],"source_content_type":"text/x-python","patch_set":2,"id":"36ed7773_db6347a2","line":168,"in_reply_to":"20b27413_6ee7c4e1","updated":"2026-11-02 04:34:49.000000000","message":"So I’ll disagree. There are many things that a post accepts today but then does the wrong thing or unexpected thing later on. It would be better to be more clear about that when the user calls the API.","commit_id":"3477bea1e13344176cea3a9c1c56a761e9739181"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"a28a2f548cbcd6328e8810743b62c2c428b66d42","unresolved":true,"context_lines":[{"line_number":194,"context_line":"            },"},{"line_number":195,"context_line":"            \u0027value\u0027: {"},{"line_number":196,"context_line":"                \u0027type\u0027: [\u0027string\u0027, \u0027object\u0027, \u0027null\u0027, \u0027integer\u0027, \u0027boolean\u0027],"},{"line_number":197,"context_line":"                \u0027maxLength\u0027: request_types.MAX_STRING_LENGTH,"},{"line_number":198,"context_line":"                \u0027maxProperties\u0027: request_types.MAX_PROPERTIES,"},{"line_number":199,"context_line":"            },"},{"line_number":200,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":2,"id":"f241bc75_8bf71385","line":197,"updated":"2026-11-02 03:53:28.000000000","message":"Open question on the caps for unbounded fields (this value, plus extra and the maxItems on traits/candidate_nodes). They fix a real DoS risk, but they also reject input that works today: a PATCH to /extra/foo with a string over 255 characters now returns 400, and POST still accepts it. Two ways forward:\n\n1. A much higher limit, so existing clients keep working.\n2. Keep 255 but gate it behind a new microversion. Older versions stay unbounded, so the DoS risk remains for them.\n\nI lean towards 1 for the unbounded fields. I\u0027d like Julia\u0027s and Jay\u0027s view before we pick.","commit_id":"3477bea1e13344176cea3a9c1c56a761e9739181"},{"author":{"_account_id":38267,"name":"Nuutti Hakala","display_name":"nuhakala","email":"nuutti.hakala@est.tech","username":"nuhakala"},"change_message_id":"8a4a6d25391d363108533140eb8a7cb733847b37","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            \u0027value\u0027: {"},{"line_number":196,"context_line":"                \u0027type\u0027: [\u0027string\u0027, \u0027object\u0027, \u0027null\u0027, \u0027integer\u0027, \u0027boolean\u0027],"},{"line_number":197,"context_line":"                \u0027maxLength\u0027: request_types.MAX_STRING_LENGTH,"},{"line_number":198,"context_line":"                \u0027maxProperties\u0027: request_types.MAX_PROPERTIES,"},{"line_number":199,"context_line":"            },"},{"line_number":200,"context_line":"        },"},{"line_number":201,"context_line":"        \u0027required\u0027: [\u0027op\u0027, \u0027path\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"0d2af631_262a9540","line":198,"updated":"2026-10-19 05:11:34.000000000","message":"Compared to the first patchset, I removed maxItems from here. It should not have any effect as array is not included in types.","commit_id":"3477bea1e13344176cea3a9c1c56a761e9739181"}]}
