)]}'
{"ironic/drivers/modules/switch/generic_switch.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ba06ef8cefea98b15712a1fc5a70e80916e7a8c","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        return False"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    mtu_parameter \u003d parameters.get(\u0027mtu\u0027)"},{"line_number":43,"context_line":"    return (mtu_parameter is not None and mtu_parameter.kind in ("},{"line_number":44,"context_line":"        inspect.Parameter.POSITIONAL_OR_KEYWORD,"},{"line_number":45,"context_line":"        inspect.Parameter.KEYWORD_ONLY))"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"813fa269_a2c2f7ad","line":43,"updated":"2026-10-20 10:47:33.000000000","message":"Log a deprecation warning if false?","commit_id":"9a74767890d4ed2512e024773818a838a741fd98"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9af1f3fd02c0959d0b687c831ca4f811dc13fabc","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        return False"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    mtu_parameter \u003d parameters.get(\u0027mtu\u0027)"},{"line_number":43,"context_line":"    return (mtu_parameter is not None and mtu_parameter.kind in ("},{"line_number":44,"context_line":"        inspect.Parameter.POSITIONAL_OR_KEYWORD,"},{"line_number":45,"context_line":"        inspect.Parameter.KEYWORD_ONLY))"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6759ff8f_0470f556","line":43,"in_reply_to":"23ecde98_6e47e37d","updated":"2026-10-20 12:56:12.000000000","message":"I\u0027m not sure. What worries me here is that an explicit user\u0027s request (to set an MTU) may be ignored. It\u0027s the existing state of things, but it\u0027s still not great.","commit_id":"9a74767890d4ed2512e024773818a838a741fd98"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"08c2831fadd57a47084bf702a3d7ba11eb7e577c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        return False"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    mtu_parameter \u003d parameters.get(\u0027mtu\u0027)"},{"line_number":43,"context_line":"    return (mtu_parameter is not None and mtu_parameter.kind in ("},{"line_number":44,"context_line":"        inspect.Parameter.POSITIONAL_OR_KEYWORD,"},{"line_number":45,"context_line":"        inspect.Parameter.KEYWORD_ONLY))"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"74380f1a_ad1b89d3","line":43,"in_reply_to":"6759ff8f_0470f556","updated":"2026-10-20 14:47:57.000000000","message":"log added","commit_id":"9a74767890d4ed2512e024773818a838a741fd98"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"891770228c410968f1bc4fd2b95220d91c9a6ee3","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        return False"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    mtu_parameter \u003d parameters.get(\u0027mtu\u0027)"},{"line_number":43,"context_line":"    return (mtu_parameter is not None and mtu_parameter.kind in ("},{"line_number":44,"context_line":"        inspect.Parameter.POSITIONAL_OR_KEYWORD,"},{"line_number":45,"context_line":"        inspect.Parameter.KEYWORD_ONLY))"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"23ecde98_6e47e37d","line":43,"in_reply_to":"813fa269_a2c2f7ad","updated":"2026-10-20 12:49:15.000000000","message":"Is it a \"deprecation\" though ... because we\u0027re using this as substitute for a version check it probably just means they haven\u0027t upgraded to a new NGS version.  If you\u0027d prefer to see a log every time a request is made with an `mtu` when the functionality isn\u0027t supported I can add that.","commit_id":"9a74767890d4ed2512e024773818a838a741fd98"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ba06ef8cefea98b15712a1fc5a70e80916e7a8c","unresolved":true,"context_lines":[{"line_number":221,"context_line":"            device_kwargs \u003d {"},{"line_number":222,"context_line":"                \u0027trunk_details\u0027: trunk_details,"},{"line_number":223,"context_line":"                \u0027default_vlan\u0027: default_vlan,"},{"line_number":224,"context_line":"            }"},{"line_number":225,"context_line":"            if (mtu is not None"},{"line_number":226,"context_line":"                    and _accepts_mtu(switch.plug_port_to_network)):"},{"line_number":227,"context_line":"                device_kwargs[\u0027mtu\u0027] \u003d mtu"}],"source_content_type":"text/x-python","patch_set":1,"id":"27a9bd77_6de6d0a6","line":224,"updated":"2026-10-20 10:47:33.000000000","message":"nit: you can keep passing these explicitly (same below)","commit_id":"9a74767890d4ed2512e024773818a838a741fd98"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"891770228c410968f1bc4fd2b95220d91c9a6ee3","unresolved":true,"context_lines":[{"line_number":221,"context_line":"            device_kwargs \u003d {"},{"line_number":222,"context_line":"                \u0027trunk_details\u0027: trunk_details,"},{"line_number":223,"context_line":"                \u0027default_vlan\u0027: default_vlan,"},{"line_number":224,"context_line":"            }"},{"line_number":225,"context_line":"            if (mtu is not None"},{"line_number":226,"context_line":"                    and _accepts_mtu(switch.plug_port_to_network)):"},{"line_number":227,"context_line":"                device_kwargs[\u0027mtu\u0027] \u003d mtu"}],"source_content_type":"text/x-python","patch_set":1,"id":"3c8405d0_c65f97b6","line":224,"in_reply_to":"27a9bd77_6de6d0a6","updated":"2026-10-20 12:49:15.000000000","message":"I was trying to maintain the existing behaviour where these were passed in explicitly always.  If you have a strong preference I can make them all optional.","commit_id":"9a74767890d4ed2512e024773818a838a741fd98"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9af1f3fd02c0959d0b687c831ca4f811dc13fabc","unresolved":true,"context_lines":[{"line_number":221,"context_line":"            device_kwargs \u003d {"},{"line_number":222,"context_line":"                \u0027trunk_details\u0027: trunk_details,"},{"line_number":223,"context_line":"                \u0027default_vlan\u0027: default_vlan,"},{"line_number":224,"context_line":"            }"},{"line_number":225,"context_line":"            if (mtu is not None"},{"line_number":226,"context_line":"                    and _accepts_mtu(switch.plug_port_to_network)):"},{"line_number":227,"context_line":"                device_kwargs[\u0027mtu\u0027] \u003d mtu"}],"source_content_type":"text/x-python","patch_set":1,"id":"7e4639c0_e2e6c381","line":224,"in_reply_to":"3c8405d0_c65f97b6","updated":"2026-10-20 12:56:12.000000000","message":"No, I mean, you can keep passing them explicitly as before. Only `mtu` needs to go into device_kwargs (which can otherwise stay empty)","commit_id":"9a74767890d4ed2512e024773818a838a741fd98"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"08c2831fadd57a47084bf702a3d7ba11eb7e577c","unresolved":false,"context_lines":[{"line_number":221,"context_line":"            device_kwargs \u003d {"},{"line_number":222,"context_line":"                \u0027trunk_details\u0027: trunk_details,"},{"line_number":223,"context_line":"                \u0027default_vlan\u0027: default_vlan,"},{"line_number":224,"context_line":"            }"},{"line_number":225,"context_line":"            if (mtu is not None"},{"line_number":226,"context_line":"                    and _accepts_mtu(switch.plug_port_to_network)):"},{"line_number":227,"context_line":"                device_kwargs[\u0027mtu\u0027] \u003d mtu"}],"source_content_type":"text/x-python","patch_set":1,"id":"63b0bdd0_82552dc3","line":224,"in_reply_to":"7e4639c0_e2e6c381","updated":"2026-10-20 14:47:57.000000000","message":"understood.  reverted all of the device_kwargs stuff except the `mtu` handling.","commit_id":"9a74767890d4ed2512e024773818a838a741fd98"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ba06ef8cefea98b15712a1fc5a70e80916e7a8c","unresolved":true,"context_lines":[{"line_number":449,"context_line":"            driver_config[\"ngs_save_configuration\"] \u003d False"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        # Older NGS versions ignore unknown ngs_* options."},{"line_number":452,"context_line":"        driver_config[\"ngs_manage_mtu\"] \u003d True"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"        return driver_config"}],"source_content_type":"text/x-python","patch_set":1,"id":"c74ab957_e07963f4","line":452,"updated":"2026-10-20 10:47:33.000000000","message":"Is there any use case to make it configurable on the Ironic side?","commit_id":"9a74767890d4ed2512e024773818a838a741fd98"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"891770228c410968f1bc4fd2b95220d91c9a6ee3","unresolved":true,"context_lines":[{"line_number":449,"context_line":"            driver_config[\"ngs_save_configuration\"] \u003d False"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        # Older NGS versions ignore unknown ngs_* options."},{"line_number":452,"context_line":"        driver_config[\"ngs_manage_mtu\"] \u003d True"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"        return driver_config"}],"source_content_type":"text/x-python","patch_set":1,"id":"5c233985_b2afad16","line":452,"in_reply_to":"c74ab957_e07963f4","updated":"2026-10-20 12:49:15.000000000","message":"`mtu` is optional everywhere so nothing will happen just by enabling this here, so I don\u0027t think that\u0027s necessary.","commit_id":"9a74767890d4ed2512e024773818a838a741fd98"}]}
