)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e4b69185cd07f7eab8aa54b66d4ae879efd6a056","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9c91c3d3_2000f075","updated":"2026-11-04 11:09:55.000000000","message":"recheck","commit_id":"edf5cfb00d60e3bb229bf7844c41b77409a09449"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"fe8e069c76419b1acf230e9ad677f34f66b7f401","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e8008c0c_5b46cf2b","updated":"2026-11-10 13:42:44.000000000","message":"Thank you for your review, Dmitry. Pushed revised patch, let me know what you think.","commit_id":"51bd18c12b761b8960d874378393b3e419a22efc"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"2ec61f64ce07f8a7381efa8872c09a432f590872","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"670fdb9c_7be45878","updated":"2026-11-19 05:53:20.000000000","message":"Thank you for your review Dmitry. Responses in-line, pushed new patchset.","commit_id":"0d342ad27b6604f17604c99eab93a83440f6ab96"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"bf81b8342298161f7ba899f5d8b2785dc93b601e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"74abd423_3ce9dc89","updated":"2026-11-19 12:21:35.000000000","message":"recheck","commit_id":"0d342ad27b6604f17604c99eab93a83440f6ab96"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"595bda4c8a3b169656b82b05b0e57ecea64b053f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d7e8f489_b689008e","updated":"2026-11-19 20:33:34.000000000","message":"recheck","commit_id":"0d342ad27b6604f17604c99eab93a83440f6ab96"}],"ironic/drivers/modules/redfish/firmware.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1763aba2ef519a9b069abdc120ffae2b76440b0f","unresolved":true,"context_lines":[{"line_number":1570,"context_line":"        fw_upd[VERIFY] \u003d {"},{"line_number":1571,"context_line":"            \u0027reboot_time\u0027: str(timeutils.utcnow().isoformat()),"},{"line_number":1572,"context_line":"            \u0027before\u0027: self._observe_boot(node),"},{"line_number":1573,"context_line":"            \u0027jids\u0027: jids,"},{"line_number":1574,"context_line":"            \u0027new_boot\u0027: False,"},{"line_number":1575,"context_line":"            \u0027boot_ok\u0027: False,"},{"line_number":1576,"context_line":"            \u0027lc\u0027: None,"}],"source_content_type":"text/x-python","patch_set":6,"id":"135e2442_dadba1fc","line":1573,"updated":"2026-11-09 15:29:50.000000000","message":"You also keep job IDs in dii, this is quite confusing","commit_id":"b734f7421ab2f2082c52b2ba40bcaef7c7b1175a"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"fe8e069c76419b1acf230e9ad677f34f66b7f401","unresolved":false,"context_lines":[{"line_number":1570,"context_line":"        fw_upd[VERIFY] \u003d {"},{"line_number":1571,"context_line":"            \u0027reboot_time\u0027: str(timeutils.utcnow().isoformat()),"},{"line_number":1572,"context_line":"            \u0027before\u0027: self._observe_boot(node),"},{"line_number":1573,"context_line":"            \u0027jids\u0027: jids,"},{"line_number":1574,"context_line":"            \u0027new_boot\u0027: False,"},{"line_number":1575,"context_line":"            \u0027boot_ok\u0027: False,"},{"line_number":1576,"context_line":"            \u0027lc\u0027: None,"}],"source_content_type":"text/x-python","patch_set":6,"id":"c47417ba_46ec943a","line":1573,"in_reply_to":"135e2442_dadba1fc","updated":"2026-11-10 13:42:44.000000000","message":"Agreed. In PS8 the jobs live only in DII. It has to be DII because a NIC update whose reboot is deferred has already left the update list by the time the reboot happens.","commit_id":"b734f7421ab2f2082c52b2ba40bcaef7c7b1175a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1763aba2ef519a9b069abdc120ffae2b76440b0f","unresolved":true,"context_lines":[{"line_number":1572,"context_line":"            \u0027before\u0027: self._observe_boot(node),"},{"line_number":1573,"context_line":"            \u0027jids\u0027: jids,"},{"line_number":1574,"context_line":"            \u0027new_boot\u0027: False,"},{"line_number":1575,"context_line":"            \u0027boot_ok\u0027: False,"},{"line_number":1576,"context_line":"            \u0027lc\u0027: None,"},{"line_number":1577,"context_line":"            \u0027waiting\u0027: None,"},{"line_number":1578,"context_line":"            \u0027passed\u0027: False,"}],"source_content_type":"text/x-python","patch_set":6,"id":"a7587f89_61727f87","line":1575,"updated":"2026-11-09 15:29:50.000000000","message":"It really hard to understand how `boot_ok` is different from `passed`","commit_id":"b734f7421ab2f2082c52b2ba40bcaef7c7b1175a"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"fe8e069c76419b1acf230e9ad677f34f66b7f401","unresolved":true,"context_lines":[{"line_number":1572,"context_line":"            \u0027before\u0027: self._observe_boot(node),"},{"line_number":1573,"context_line":"            \u0027jids\u0027: jids,"},{"line_number":1574,"context_line":"            \u0027new_boot\u0027: False,"},{"line_number":1575,"context_line":"            \u0027boot_ok\u0027: False,"},{"line_number":1576,"context_line":"            \u0027lc\u0027: None,"},{"line_number":1577,"context_line":"            \u0027waiting\u0027: None,"},{"line_number":1578,"context_line":"            \u0027passed\u0027: False,"}],"source_content_type":"text/x-python","patch_set":6,"id":"cba4f5d4_645cbf0b","line":1575,"in_reply_to":"a7587f89_61727f87","updated":"2026-11-10 13:42:44.000000000","message":"Good point. passed is the whole verification, while boot_ok was just the BootProgress part, kept once passed because BootProgress can change after the node is up. Renamed it to boot_passed and documented both. Is this better?","commit_id":"b734f7421ab2f2082c52b2ba40bcaef7c7b1175a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1763aba2ef519a9b069abdc120ffae2b76440b0f","unresolved":true,"context_lines":[{"line_number":1737,"context_line":"            else:"},{"line_number":1738,"context_line":"                verify[\u0027boot_ok\u0027] \u003d self._check_boot(node, system, verify)"},{"line_number":1739,"context_line":""},{"line_number":1740,"context_line":"        if verify[\u0027lc\u0027] is None:"},{"line_number":1741,"context_line":"            if verify[\u0027jids\u0027]:"},{"line_number":1742,"context_line":"                try:"},{"line_number":1743,"context_line":"                    status, detail \u003d drac_fw.check_lc_jobs(task,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7307bd93_4812829c","line":1740,"updated":"2026-11-09 15:29:50.000000000","message":"I\u0027m not sure what `lc` does and why you keep it persisted. Is it just a flag to check the LC? Why don\u0027t a list of JIDs suffice?","commit_id":"b734f7421ab2f2082c52b2ba40bcaef7c7b1175a"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"fe8e069c76419b1acf230e9ad677f34f66b7f401","unresolved":false,"context_lines":[{"line_number":1737,"context_line":"            else:"},{"line_number":1738,"context_line":"                verify[\u0027boot_ok\u0027] \u003d self._check_boot(node, system, verify)"},{"line_number":1739,"context_line":""},{"line_number":1740,"context_line":"        if verify[\u0027lc\u0027] is None:"},{"line_number":1741,"context_line":"            if verify[\u0027jids\u0027]:"},{"line_number":1742,"context_line":"                try:"},{"line_number":1743,"context_line":"                    status, detail \u003d drac_fw.check_lc_jobs(task,"}],"source_content_type":"text/x-python","patch_set":6,"id":"caa09ed2_843355fb","line":1740,"in_reply_to":"7307bd93_4812829c","updated":"2026-11-10 13:42:44.000000000","message":"Dropped. The job list is removed once the jobs have finished, so no list means nothing left to wait for (L1774–L1796).","commit_id":"b734f7421ab2f2082c52b2ba40bcaef7c7b1175a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1763aba2ef519a9b069abdc120ffae2b76440b0f","unresolved":true,"context_lines":[{"line_number":1765,"context_line":"                         \u0027finished on node %(node)s.\u0027,"},{"line_number":1766,"context_line":"                         {\u0027jids\u0027: \u0027, \u0027.join(verify[\u0027jids\u0027]),"},{"line_number":1767,"context_line":"                          \u0027node\u0027: node.uuid})"},{"line_number":1768,"context_line":"            verify[\u0027lc\u0027] \u003d status.value"},{"line_number":1769,"context_line":""},{"line_number":1770,"context_line":"        return verify[\u0027boot_ok\u0027]"},{"line_number":1771,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"57c45aa4_7f253996","line":1768,"updated":"2026-11-09 15:29:50.000000000","message":"Why store a value if anything other than None prevents this code from ever being executed again?","commit_id":"b734f7421ab2f2082c52b2ba40bcaef7c7b1175a"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"fe8e069c76419b1acf230e9ad677f34f66b7f401","unresolved":false,"context_lines":[{"line_number":1765,"context_line":"                         \u0027finished on node %(node)s.\u0027,"},{"line_number":1766,"context_line":"                         {\u0027jids\u0027: \u0027, \u0027.join(verify[\u0027jids\u0027]),"},{"line_number":1767,"context_line":"                          \u0027node\u0027: node.uuid})"},{"line_number":1768,"context_line":"            verify[\u0027lc\u0027] \u003d status.value"},{"line_number":1769,"context_line":""},{"line_number":1770,"context_line":"        return verify[\u0027boot_ok\u0027]"},{"line_number":1771,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"4f2cbd04_bbccb2f4","line":1768,"in_reply_to":"57c45aa4_7f253996","updated":"2026-11-10 13:42:44.000000000","message":"Agreed, gone with the above.","commit_id":"b734f7421ab2f2082c52b2ba40bcaef7c7b1175a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5a3c6886be6881d82b225790f706982ce4dff652","unresolved":true,"context_lines":[{"line_number":69,"context_line":"VERIFY_WAITING \u003d \u0027waiting\u0027"},{"line_number":70,"context_line":"# Whether the whole verification has passed: task, boot and Lifecycle"},{"line_number":71,"context_line":"# Controller jobs. The update then counts as applied."},{"line_number":72,"context_line":"VERIFY_PASSED \u003d \u0027passed\u0027"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"# Redfish task states of a task that has not finished."},{"line_number":75,"context_line":"_TASK_IN_PROGRESS \u003d (sushy.TASK_STATE_NEW, sushy.TASK_STATE_RUNNING,"}],"source_content_type":"text/x-python","patch_set":8,"id":"579709ba_5df6d801","line":72,"updated":"2026-11-18 13:28:11.000000000","message":"Per discussion on the previous PR: VERIFY_PASSED may not be needed","commit_id":"51bd18c12b761b8960d874378393b3e419a22efc"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"2ec61f64ce07f8a7381efa8872c09a432f590872","unresolved":false,"context_lines":[{"line_number":69,"context_line":"VERIFY_WAITING \u003d \u0027waiting\u0027"},{"line_number":70,"context_line":"# Whether the whole verification has passed: task, boot and Lifecycle"},{"line_number":71,"context_line":"# Controller jobs. The update then counts as applied."},{"line_number":72,"context_line":"VERIFY_PASSED \u003d \u0027passed\u0027"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"# Redfish task states of a task that has not finished."},{"line_number":75,"context_line":"_TASK_IN_PROGRESS \u003d (sushy.TASK_STATE_NEW, sushy.TASK_STATE_RUNNING,"}],"source_content_type":"text/x-python","patch_set":8,"id":"146528fc_5479fdf0","line":72,"in_reply_to":"579709ba_5df6d801","updated":"2026-11-19 05:53:20.000000000","message":"Good point, removed VERIFY_PASSED.","commit_id":"51bd18c12b761b8960d874378393b3e419a22efc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5a3c6886be6881d82b225790f706982ce4dff652","unresolved":true,"context_lines":[{"line_number":675,"context_line":"        \"\"\""},{"line_number":676,"context_line":"        jid \u003d drac_fw.jid_from_task_monitor(fw_upd.get(\u0027task_monitor\u0027))"},{"line_number":677,"context_line":"        if jid:"},{"line_number":678,"context_line":"            jids \u003d node.driver_internal_info.get(FIRMWARE_LC_JIDS, [])"},{"line_number":679,"context_line":"            if jid not in jids:"},{"line_number":680,"context_line":"                node.set_driver_internal_info(FIRMWARE_LC_JIDS, jids + [jid])"},{"line_number":681,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ab155490_956f300a","line":678,"updated":"2026-11-18 13:28:11.000000000","message":"nit: Why not storing LC jobs inside `fw_upd` or even inside `verify`?","commit_id":"51bd18c12b761b8960d874378393b3e419a22efc"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"2ec61f64ce07f8a7381efa8872c09a432f590872","unresolved":true,"context_lines":[{"line_number":675,"context_line":"        \"\"\""},{"line_number":676,"context_line":"        jid \u003d drac_fw.jid_from_task_monitor(fw_upd.get(\u0027task_monitor\u0027))"},{"line_number":677,"context_line":"        if jid:"},{"line_number":678,"context_line":"            jids \u003d node.driver_internal_info.get(FIRMWARE_LC_JIDS, [])"},{"line_number":679,"context_line":"            if jid not in jids:"},{"line_number":680,"context_line":"                node.set_driver_internal_info(FIRMWARE_LC_JIDS, jids + [jid])"},{"line_number":681,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fb3d43d7_75f46d0e","line":678,"in_reply_to":"ab155490_956f300a","updated":"2026-11-19 05:53:20.000000000","message":"The idea is that DII key holds information about the node, not just one specific firmware update in the list. In a scenario where NIC update has a deferred reboot (https://review.opendev.org/c/openstack/ironic/+/981627 has context), the LC job in fw_upd or verify would only live as long as that update\u0027s entry (which is removed when we move to the next component). However we may need the LC job details available for the later update whose reboot applies both. WDYT?","commit_id":"51bd18c12b761b8960d874378393b3e419a22efc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5a3c6886be6881d82b225790f706982ce4dff652","unresolved":true,"context_lines":[{"line_number":1762,"context_line":"        # 2. The node has booted past POST. Kept once passed, as"},{"line_number":1763,"context_line":"        # BootProgress can change again afterwards."},{"line_number":1764,"context_line":"        waiting \u003d None"},{"line_number":1765,"context_line":"        if not verify[VERIFY_BOOT_PASSED]:"},{"line_number":1766,"context_line":"            if system is None:"},{"line_number":1767,"context_line":"                waiting \u003d _(\u0027its System could not be read\u0027)"},{"line_number":1768,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"2ca92bbd_3de08416","line":1765,"updated":"2026-11-18 13:28:11.000000000","message":"Per discussion on the previous patch: let\u0027s use `get` here in case we\u0027re caught mid-upgrade.","commit_id":"51bd18c12b761b8960d874378393b3e419a22efc"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"2ec61f64ce07f8a7381efa8872c09a432f590872","unresolved":false,"context_lines":[{"line_number":1762,"context_line":"        # 2. The node has booted past POST. Kept once passed, as"},{"line_number":1763,"context_line":"        # BootProgress can change again afterwards."},{"line_number":1764,"context_line":"        waiting \u003d None"},{"line_number":1765,"context_line":"        if not verify[VERIFY_BOOT_PASSED]:"},{"line_number":1766,"context_line":"            if system is None:"},{"line_number":1767,"context_line":"                waiting \u003d _(\u0027its System could not be read\u0027)"},{"line_number":1768,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"ef995cef_e674610d","line":1765,"in_reply_to":"2ca92bbd_3de08416","updated":"2026-11-19 05:53:20.000000000","message":"Good point, done.","commit_id":"51bd18c12b761b8960d874378393b3e419a22efc"}]}
