)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6c141a70fcf77d4e624b3084bcac95f7768685ce","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"56cbd19e_bf4124aa","updated":"2026-10-27 17:19:05.000000000","message":"Greetings! I\u0027ve noticed some inconsistencies plus what will likely be excessive logging creeping in. I have an open concern regarding AI use, see the comment on it, and compounded by the notes. Some more clarity and minor cleanup likely needed. Thanks!","commit_id":"65eed4d28a45f0bcd498387a63383574d11c8595"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"55ad4426393662d88d91be802093d9f43e170ea3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a4d784f6_f5b2e07d","updated":"2026-10-27 19:16:30.000000000","message":"This is a good start but I see an issue. Using the kubernetes pod status phases as an example:\nhttps://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/\n\nPending is a phase which occurs before Running, and if there is a delay in scheduling the pod or the image has to be downloaded from a slow registry then is_running could return False when the pod is yet to start. This would the session to terminate before it starts. We could add Pending to the is_running check but then it is not really testing for is_running anymore.\n\nI\u0027d suggest changing the test method to is_stopped. For kubernetes this would test for phases Succeeded or Failed. Other drivers would have their own states.","commit_id":"65eed4d28a45f0bcd498387a63383574d11c8595"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"f40c93e22c953a4e97a3c08d7a12cd30d5c37da0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"eb4b8faf_3af45a1f","in_reply_to":"56cbd19e_bf4124aa","updated":"2026-11-03 09:58:36.000000000","message":"Done","commit_id":"65eed4d28a45f0bcd498387a63383574d11c8595"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e162e9b084b6214557c051e9569583a882f975ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f8fc5520_f17e7a4e","updated":"2026-11-04 21:05:38.000000000","message":"Looks good, just a comment on the comments","commit_id":"6e360656717f735b391c39bec6aa9b0cb01120a9"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"513c5f96e08db70b6cfd697fcb1985571d22b56e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dd7ed0bb_25a51b46","updated":"2026-11-02 20:11:44.000000000","message":"recheck tox-error","commit_id":"6e360656717f735b391c39bec6aa9b0cb01120a9"},{"author":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"change_message_id":"2a2626912ef31c40f9f283d8af5c6c9dd4bbc857","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"91fea0c0_e869cf57","updated":"2026-11-06 16:04:46.000000000","message":"Looks good.  Just a few comments around exception handling and logging.  Would like to see if the others reviewers/author thinks its necessary.  Thanks.","commit_id":"44b4a66ec49afdd6eb9d9434cd4dd15d0f61164b"}],"ironic/console/container/container.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6c141a70fcf77d4e624b3084bcac95f7768685ce","unresolved":true,"context_lines":[{"line_number":301,"context_line":"        uuid \u003d task.node.uuid"},{"line_number":302,"context_line":"        LOG.debug(\u0027Checking console container status for node %s\u0027, uuid)"},{"line_number":303,"context_line":"        try:"},{"line_number":304,"context_line":"            # NOTE(cid): \u0027ps\u0027 without --all only lists running containers,"},{"line_number":305,"context_line":"            # so an empty result means the container is stopped, exited or"},{"line_number":306,"context_line":"            # removed. The node label is an exact match, unlike the name"},{"line_number":307,"context_line":"            # filter which matches substrings and could match another"}],"source_content_type":"text/x-python","patch_set":3,"id":"0eef8c13_a7a27062","line":304,"updated":"2026-10-27 17:19:05.000000000","message":"Umm? I\u0027m confused, this says NOTE(cid), but wouldn\u0027t it be NOTE(abongale) ?","commit_id":"65eed4d28a45f0bcd498387a63383574d11c8595"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"a4396c1972bca42fdce8249b45abdce03fae5ce7","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        uuid \u003d task.node.uuid"},{"line_number":302,"context_line":"        LOG.debug(\u0027Checking console container status for node %s\u0027, uuid)"},{"line_number":303,"context_line":"        try:"},{"line_number":304,"context_line":"            # NOTE(cid): \u0027ps\u0027 without --all only lists running containers,"},{"line_number":305,"context_line":"            # so an empty result means the container is stopped, exited or"},{"line_number":306,"context_line":"            # removed. The node label is an exact match, unlike the name"},{"line_number":307,"context_line":"            # filter which matches substrings and could match another"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f6a69dd_2f3f2ae8","line":304,"in_reply_to":"0eef8c13_a7a27062","updated":"2026-11-02 13:00:49.000000000","message":"Done","commit_id":"65eed4d28a45f0bcd498387a63383574d11c8595"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e162e9b084b6214557c051e9569583a882f975ee","unresolved":true,"context_lines":[{"line_number":72,"context_line":"        if CONF.vnc.container_host or env:"},{"line_number":73,"context_line":"            env_variables \u003d os.environ.copy()"},{"line_number":74,"context_line":"            if CONF.vnc.container_host:"},{"line_number":75,"context_line":"                # DOCKER_HOST is honoured by the docker CLI,"},{"line_number":76,"context_line":"                # CONTAINER_HOST by the podman CLI (since Podman 4.0, where"},{"line_number":77,"context_line":"                # it also enables remote mode)."},{"line_number":78,"context_line":"                env_variables[\u0027DOCKER_HOST\u0027] \u003d CONF.vnc.container_host"}],"source_content_type":"text/x-python","patch_set":4,"id":"4aa07001_5afd44c7","line":75,"updated":"2026-11-04 21:05:38.000000000","message":"All of these NOTE(cid) should be restored","commit_id":"6e360656717f735b391c39bec6aa9b0cb01120a9"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"a737188963fcf7529e22bd740698ce65cfa7e578","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        if CONF.vnc.container_host or env:"},{"line_number":73,"context_line":"            env_variables \u003d os.environ.copy()"},{"line_number":74,"context_line":"            if CONF.vnc.container_host:"},{"line_number":75,"context_line":"                # DOCKER_HOST is honoured by the docker CLI,"},{"line_number":76,"context_line":"                # CONTAINER_HOST by the podman CLI (since Podman 4.0, where"},{"line_number":77,"context_line":"                # it also enables remote mode)."},{"line_number":78,"context_line":"                env_variables[\u0027DOCKER_HOST\u0027] \u003d CONF.vnc.container_host"}],"source_content_type":"text/x-python","patch_set":4,"id":"aae86ff3_6ed10a7f","line":75,"in_reply_to":"4017fdbf_d9eb81f7","updated":"2026-11-05 12:36:56.000000000","message":"Done","commit_id":"6e360656717f735b391c39bec6aa9b0cb01120a9"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"258c7e2be7217314790fbd532c65b8fbb281419f","unresolved":true,"context_lines":[{"line_number":72,"context_line":"        if CONF.vnc.container_host or env:"},{"line_number":73,"context_line":"            env_variables \u003d os.environ.copy()"},{"line_number":74,"context_line":"            if CONF.vnc.container_host:"},{"line_number":75,"context_line":"                # DOCKER_HOST is honoured by the docker CLI,"},{"line_number":76,"context_line":"                # CONTAINER_HOST by the podman CLI (since Podman 4.0, where"},{"line_number":77,"context_line":"                # it also enables remote mode)."},{"line_number":78,"context_line":"                env_variables[\u0027DOCKER_HOST\u0027] \u003d CONF.vnc.container_host"}],"source_content_type":"text/x-python","patch_set":4,"id":"4017fdbf_d9eb81f7","line":75,"in_reply_to":"4aa07001_5afd44c7","updated":"2026-11-05 11:14:16.000000000","message":"I used LLM for commenting, I will make sure I will make sure I will do it myself","commit_id":"6e360656717f735b391c39bec6aa9b0cb01120a9"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e162e9b084b6214557c051e9569583a882f975ee","unresolved":true,"context_lines":[{"line_number":101,"context_line":"        :param app_name: Name of the application to run in the container."},{"line_number":102,"context_line":"        :returns: A list of arguments for the container CLI."},{"line_number":103,"context_line":"        \"\"\""},{"line_number":104,"context_line":"        # TODO(abongale) Support bind-mounting certificate files to"},{"line_number":105,"context_line":"        # handle verified BMC certificates"},{"line_number":106,"context_line":"        params \u003d {"},{"line_number":107,"context_line":"            \u0027uuid\u0027: uuid,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f691a56_d9f988ea","line":104,"updated":"2026-11-04 21:05:38.000000000","message":"This should be changed back to cid, even if you intend to action the TODO","commit_id":"6e360656717f735b391c39bec6aa9b0cb01120a9"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"258c7e2be7217314790fbd532c65b8fbb281419f","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        :param app_name: Name of the application to run in the container."},{"line_number":102,"context_line":"        :returns: A list of arguments for the container CLI."},{"line_number":103,"context_line":"        \"\"\""},{"line_number":104,"context_line":"        # TODO(abongale) Support bind-mounting certificate files to"},{"line_number":105,"context_line":"        # handle verified BMC certificates"},{"line_number":106,"context_line":"        params \u003d {"},{"line_number":107,"context_line":"            \u0027uuid\u0027: uuid,"}],"source_content_type":"text/x-python","patch_set":4,"id":"50ddb9ab_3b164b19","line":104,"in_reply_to":"5f691a56_d9f988ea","updated":"2026-11-05 11:14:16.000000000","message":"Done","commit_id":"6e360656717f735b391c39bec6aa9b0cb01120a9"}],"ironic/console/container/kubernetes.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6c141a70fcf77d4e624b3084bcac95f7768685ce","unresolved":true,"context_lines":[{"line_number":346,"context_line":"        pod_name \u003d pod[\"metadata\"][\"name\"]"},{"line_number":347,"context_line":"        namespace \u003d pod[\"metadata\"][\"namespace\"]"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        # NOTE: a deleted pod yields an empty phase because of"},{"line_number":350,"context_line":"        # --ignore-not-found, an exited pod yields Succeeded or Failed;"},{"line_number":351,"context_line":"        # neither counts as running."},{"line_number":352,"context_line":"        return self._get_pod_status(pod_name, namespace) \u003d\u003d \"Running\""}],"source_content_type":"text/x-python","patch_set":3,"id":"eba15827_24333255","line":349,"updated":"2026-10-27 17:19:05.000000000","message":"This is not the OpenStack NOTE format, and is a style explicitly used by LLMs. If you used an LLM, please attribute it per the contribution policy: https://openinfra.org/legal/ai-policy","commit_id":"65eed4d28a45f0bcd498387a63383574d11c8595"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"a4396c1972bca42fdce8249b45abdce03fae5ce7","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        pod_name \u003d pod[\"metadata\"][\"name\"]"},{"line_number":347,"context_line":"        namespace \u003d pod[\"metadata\"][\"namespace\"]"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        # NOTE: a deleted pod yields an empty phase because of"},{"line_number":350,"context_line":"        # --ignore-not-found, an exited pod yields Succeeded or Failed;"},{"line_number":351,"context_line":"        # neither counts as running."},{"line_number":352,"context_line":"        return self._get_pod_status(pod_name, namespace) \u003d\u003d \"Running\""}],"source_content_type":"text/x-python","patch_set":3,"id":"a9d22a85_5ccec6d5","line":349,"in_reply_to":"8b6c1259_93e25c6a","updated":"2026-11-02 13:00:49.000000000","message":"Done","commit_id":"65eed4d28a45f0bcd498387a63383574d11c8595"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"2d2d802b8497114d79db83f4bf37a9944239a26a","unresolved":true,"context_lines":[{"line_number":346,"context_line":"        pod_name \u003d pod[\"metadata\"][\"name\"]"},{"line_number":347,"context_line":"        namespace \u003d pod[\"metadata\"][\"namespace\"]"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        # NOTE: a deleted pod yields an empty phase because of"},{"line_number":350,"context_line":"        # --ignore-not-found, an exited pod yields Succeeded or Failed;"},{"line_number":351,"context_line":"        # neither counts as running."},{"line_number":352,"context_line":"        return self._get_pod_status(pod_name, namespace) \u003d\u003d \"Running\""}],"source_content_type":"text/x-python","patch_set":3,"id":"8b6c1259_93e25c6a","line":349,"in_reply_to":"eba15827_24333255","updated":"2026-11-02 11:00:55.000000000","message":"asked LLM  only for the typo fix in auto mode. Should have verified it before putting up MR 😢","commit_id":"65eed4d28a45f0bcd498387a63383574d11c8595"}],"ironic/drivers/modules/graphical_console.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6c141a70fcf77d4e624b3084bcac95f7768685ce","unresolved":true,"context_lines":[{"line_number":94,"context_line":"            return True"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        provider \u003d console_factory.ConsoleContainerFactory().provider"},{"line_number":97,"context_line":"        LOG.debug(\u0027Checking graphical console container for node: %s and \u0027"},{"line_number":98,"context_line":"                  \u0027provider %s\u0027,"},{"line_number":99,"context_line":"                  node.uuid, provider)"},{"line_number":100,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"63b5dfad_2e212420","line":97,"updated":"2026-10-27 17:19:05.000000000","message":"We\u0027re effectively doubling the logging for each console session. I\u0027d honestly try to merge this in with the prior LOG.debug entry on line 89.","commit_id":"65eed4d28a45f0bcd498387a63383574d11c8595"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"aa2e4e8ceb7e6485c0187393ad45f4909f3c33b6","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            return True"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        provider \u003d console_factory.ConsoleContainerFactory().provider"},{"line_number":97,"context_line":"        LOG.debug(\u0027Checking graphical console container for node: %s and \u0027"},{"line_number":98,"context_line":"                  \u0027provider %s\u0027,"},{"line_number":99,"context_line":"                  node.uuid, provider)"},{"line_number":100,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"0000c462_2fae92ad","line":97,"in_reply_to":"63b5dfad_2e212420","updated":"2026-11-02 13:02:28.000000000","message":"Done","commit_id":"65eed4d28a45f0bcd498387a63383574d11c8595"},{"author":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"change_message_id":"2a2626912ef31c40f9f283d8af5c6c9dd4bbc857","unresolved":true,"context_lines":[{"line_number":86,"context_line":"        :returns: True if the console was stopped"},{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        node \u003d task.node"},{"line_number":89,"context_line":"        provider \u003d console_factory.ConsoleContainerFactory().provider"},{"line_number":90,"context_line":"        LOG.debug(\u0027Checking graphical console session for node: %s with \u0027"},{"line_number":91,"context_line":"                  \u0027provider %s\u0027, node.uuid, provider)"},{"line_number":92,"context_line":"        if vnc_utils.token_valid_until(node) \u003c timeutils.utcnow():"}],"source_content_type":"text/x-python","patch_set":5,"id":"8e5ea83d_660210ed","line":89,"updated":"2026-11-06 16:04:46.000000000","message":"May want to consider putting this in a \"try\".  This call can raise ConsoleContainerError and the commit message says \"a provider which cannot determine the container state raises ConsoleContainerError ...\"   Suggest moving the factory call inside the try (or catching ConsoleContainerError around it).","commit_id":"44b4a66ec49afdd6eb9d9434cd4dd15d0f61164b"},{"author":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"change_message_id":"1da808559109930fd8aa8c12cae4340ac1c5872f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        :returns: True if the console was stopped"},{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        node \u003d task.node"},{"line_number":89,"context_line":"        provider \u003d console_factory.ConsoleContainerFactory().provider"},{"line_number":90,"context_line":"        LOG.debug(\u0027Checking graphical console session for node: %s with \u0027"},{"line_number":91,"context_line":"                  \u0027provider %s\u0027, node.uuid, provider)"},{"line_number":92,"context_line":"        if vnc_utils.token_valid_until(node) \u003c timeutils.utcnow():"}],"source_content_type":"text/x-python","patch_set":5,"id":"4b9da892_a0925b39","line":89,"in_reply_to":"74bbb00b_89ed01df","updated":"2026-11-10 13:22:48.000000000","message":"Acknowledged","commit_id":"44b4a66ec49afdd6eb9d9434cd4dd15d0f61164b"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"9b76847566e4e44a7c1e361a5ce64247484f52be","unresolved":true,"context_lines":[{"line_number":86,"context_line":"        :returns: True if the console was stopped"},{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        node \u003d task.node"},{"line_number":89,"context_line":"        provider \u003d console_factory.ConsoleContainerFactory().provider"},{"line_number":90,"context_line":"        LOG.debug(\u0027Checking graphical console session for node: %s with \u0027"},{"line_number":91,"context_line":"                  \u0027provider %s\u0027, node.uuid, provider)"},{"line_number":92,"context_line":"        if vnc_utils.token_valid_until(node) \u003c timeutils.utcnow():"}],"source_content_type":"text/x-python","patch_set":5,"id":"74bbb00b_89ed01df","line":89,"in_reply_to":"8e5ea83d_660210ed","updated":"2026-11-10 11:05:16.000000000","message":"Since, provider \u003d console_factory.ConsoleContainerFactory() in the start and stop function is not in try \u0026 catch loop,\n\nI think we should keep it that way or else we have to do it for the start \u0026 stop methods as well. we can do it as follow-up","commit_id":"44b4a66ec49afdd6eb9d9434cd4dd15d0f61164b"},{"author":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"change_message_id":"2a2626912ef31c40f9f283d8af5c6c9dd4bbc857","unresolved":true,"context_lines":[{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        node \u003d task.node"},{"line_number":89,"context_line":"        provider \u003d console_factory.ConsoleContainerFactory().provider"},{"line_number":90,"context_line":"        LOG.debug(\u0027Checking graphical console session for node: %s with \u0027"},{"line_number":91,"context_line":"                  \u0027provider %s\u0027, node.uuid, provider)"},{"line_number":92,"context_line":"        if vnc_utils.token_valid_until(node) \u003c timeutils.utcnow():"},{"line_number":93,"context_line":"            LOG.info(\u0027Graphical console session has expired for %s, closing.\u0027,"},{"line_number":94,"context_line":"                     node.uuid)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a969bcf_7071ad4f","line":91,"range":{"start_line":90,"start_character":7,"end_line":91,"end_character":53},"updated":"2026-11-06 16:04:46.000000000","message":"provider is an object. For debug logging, I would suggest using \"provider.provider_name\" if that exists.","commit_id":"44b4a66ec49afdd6eb9d9434cd4dd15d0f61164b"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"9b76847566e4e44a7c1e361a5ce64247484f52be","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        node \u003d task.node"},{"line_number":89,"context_line":"        provider \u003d console_factory.ConsoleContainerFactory().provider"},{"line_number":90,"context_line":"        LOG.debug(\u0027Checking graphical console session for node: %s with \u0027"},{"line_number":91,"context_line":"                  \u0027provider %s\u0027, node.uuid, provider)"},{"line_number":92,"context_line":"        if vnc_utils.token_valid_until(node) \u003c timeutils.utcnow():"},{"line_number":93,"context_line":"            LOG.info(\u0027Graphical console session has expired for %s, closing.\u0027,"},{"line_number":94,"context_line":"                     node.uuid)"}],"source_content_type":"text/x-python","patch_set":5,"id":"b487102e_b83e649d","line":91,"range":{"start_line":90,"start_character":7,"end_line":91,"end_character":53},"in_reply_to":"1a969bcf_7071ad4f","updated":"2026-11-10 11:05:16.000000000","message":"Acknowledged","commit_id":"44b4a66ec49afdd6eb9d9434cd4dd15d0f61164b"},{"author":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"change_message_id":"2a2626912ef31c40f9f283d8af5c6c9dd4bbc857","unresolved":true,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        try:"},{"line_number":99,"context_line":"            stopped \u003d provider.is_stopped(task)"},{"line_number":100,"context_line":"        except Exception:"},{"line_number":101,"context_line":"            LOG.exception(\u0027Could not determine the console container state \u0027"},{"line_number":102,"context_line":"                          \u0027for node %s\u0027, node.uuid)"},{"line_number":103,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"39a1c5da_2c41cbf2","line":100,"updated":"2026-11-06 16:04:46.000000000","message":"Could use ConsoleContainerError here instead of general Exception, which may go well with my first comment.","commit_id":"44b4a66ec49afdd6eb9d9434cd4dd15d0f61164b"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"9b76847566e4e44a7c1e361a5ce64247484f52be","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        try:"},{"line_number":99,"context_line":"            stopped \u003d provider.is_stopped(task)"},{"line_number":100,"context_line":"        except Exception:"},{"line_number":101,"context_line":"            LOG.exception(\u0027Could not determine the console container state \u0027"},{"line_number":102,"context_line":"                          \u0027for node %s\u0027, node.uuid)"},{"line_number":103,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"c700d373_1435360a","line":100,"in_reply_to":"39a1c5da_2c41cbf2","updated":"2026-11-10 11:05:16.000000000","message":"Acknowledged","commit_id":"44b4a66ec49afdd6eb9d9434cd4dd15d0f61164b"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"fd27d99ac3940fbff2efafc1a2edc6960136b98a","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        try:"},{"line_number":99,"context_line":"            stopped \u003d provider.is_stopped(task)"},{"line_number":100,"context_line":"        except Exception:"},{"line_number":101,"context_line":"            LOG.exception(\u0027Could not determine the console container state \u0027"},{"line_number":102,"context_line":"                          \u0027for node %s\u0027, node.uuid)"},{"line_number":103,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf3dcd5a_3b3fea63","line":100,"in_reply_to":"c700d373_1435360a","updated":"2026-11-10 11:50:56.000000000","message":"Since we are doing LOG.exception. We can skip it.","commit_id":"44b4a66ec49afdd6eb9d9434cd4dd15d0f61164b"}]}
