)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"3351e4b6cf1393c80ee772cff0f48769e83dec59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fdd859b1_b4f4a08d","updated":"2026-11-03 16:14:21.000000000","message":"Mostly LGTM, a couple minor things though.","commit_id":"67ace758b31ed6f01094ffc0c7372993318734bb"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"439a147b9add73fb3e411e9c5cdb9fc7c7ccd351","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"382cfe6f_ab490676","updated":"2026-10-30 12:49:40.000000000","message":"recheck retry limit","commit_id":"67ace758b31ed6f01094ffc0c7372993318734bb"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"e22f995f964c15e086c64009e944f8e114cb9619","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"823f6d2c_836b2d8f","updated":"2026-11-06 16:29:36.000000000","message":"recheck tempest release process broke stuff","commit_id":"f272287063c76baeba8926ffd2991a7a6716d239"}],"ironic/common/trait_based_networking/base.py":[{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"3351e4b6cf1393c80ee772cff0f48769e83dec59","unresolved":true,"context_lines":[{"line_number":411,"context_line":"                              f\"\u0027{self.max_count}\u0027.\"))"},{"line_number":412,"context_line":"                return self._validate_params(GROUP_AND_ATTACH_PORTS_PARAMS)"},{"line_number":413,"context_line":"            case _:"},{"line_number":414,"context_line":"                return self._validate_params(())"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    def _validate_params(self, allowed):"},{"line_number":417,"context_line":"        \"\"\"Check that params only has keys allowed for this action.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"fbc12f96_672583cc","line":414,"updated":"2026-11-03 16:14:21.000000000","message":"Why use `_validate_params()` here and not just return `(True, \"\")` as before? Seems unnecessarily complicated.","commit_id":"67ace758b31ed6f01094ffc0c7372993318734bb"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"3cfdb156f6514c22cf6cfa728d670c77169c752b","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                              f\"\u0027{self.max_count}\u0027.\"))"},{"line_number":412,"context_line":"                return self._validate_params(GROUP_AND_ATTACH_PORTS_PARAMS)"},{"line_number":413,"context_line":"            case _:"},{"line_number":414,"context_line":"                return self._validate_params(())"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    def _validate_params(self, allowed):"},{"line_number":417,"context_line":"        \"\"\"Check that params only has keys allowed for this action.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"27aff083_3ff15584","line":414,"in_reply_to":"f1316124_2054c5f6","updated":"2026-11-09 17:48:24.000000000","message":"Done","commit_id":"67ace758b31ed6f01094ffc0c7372993318734bb"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"ffe40aea55c0200e2a8aa0fb64685e7825de8b39","unresolved":true,"context_lines":[{"line_number":411,"context_line":"                              f\"\u0027{self.max_count}\u0027.\"))"},{"line_number":412,"context_line":"                return self._validate_params(GROUP_AND_ATTACH_PORTS_PARAMS)"},{"line_number":413,"context_line":"            case _:"},{"line_number":414,"context_line":"                return self._validate_params(())"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    def _validate_params(self, allowed):"},{"line_number":417,"context_line":"        \"\"\"Check that params only has keys allowed for this action.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"f1316124_2054c5f6","line":414,"in_reply_to":"fbc12f96_672583cc","updated":"2026-11-06 05:53:45.000000000","message":"That is intentional. It prevents params: {mode: ... } on an attach_port for example. I extended the tests for this and this prevents that.","commit_id":"67ace758b31ed6f01094ffc0c7372993318734bb"}],"ironic/tests/unit/common/trait_based_networking/test_base.py":[{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"3351e4b6cf1393c80ee772cff0f48769e83dec59","unresolved":true,"context_lines":[{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    def test_trait_action_validate_mode_and_properties(self):"},{"line_number":627,"context_line":"        filt \u003d tbn.FilterExpression.parse(\"port.vendor \u003d\u003d \u0027cogwork\u0027\")"},{"line_number":628,"context_line":"        for mode in tbn.PORTGROUP_MODES:"},{"line_number":629,"context_line":"            with self.subTest(mode\u003dmode):"},{"line_number":630,"context_line":"                action \u003d tbn.TraitAction("},{"line_number":631,"context_line":"                    \"CUSTOM_TRAIT\", tbn.Actions.GROUP_AND_ATTACH_PORTS, filt,"}],"source_content_type":"text/x-python","patch_set":3,"id":"eafedb9e_d1ce62e3","line":628,"updated":"2026-11-03 16:14:21.000000000","message":"ddt?","commit_id":"67ace758b31ed6f01094ffc0c7372993318734bb"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"ffe40aea55c0200e2a8aa0fb64685e7825de8b39","unresolved":false,"context_lines":[{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    def test_trait_action_validate_mode_and_properties(self):"},{"line_number":627,"context_line":"        filt \u003d tbn.FilterExpression.parse(\"port.vendor \u003d\u003d \u0027cogwork\u0027\")"},{"line_number":628,"context_line":"        for mode in tbn.PORTGROUP_MODES:"},{"line_number":629,"context_line":"            with self.subTest(mode\u003dmode):"},{"line_number":630,"context_line":"                action \u003d tbn.TraitAction("},{"line_number":631,"context_line":"                    \"CUSTOM_TRAIT\", tbn.Actions.GROUP_AND_ATTACH_PORTS, filt,"}],"source_content_type":"text/x-python","patch_set":3,"id":"c34d9068_44a0b625","line":628,"in_reply_to":"eafedb9e_d1ce62e3","updated":"2026-11-06 05:53:45.000000000","message":"Done","commit_id":"67ace758b31ed6f01094ffc0c7372993318734bb"}]}
