)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b7e11282dfbd3d11fe157918e4804d95e970c795","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"da224e89_62eea3e0","updated":"2026-11-09 13:16:04.000000000","message":"Got it, thanks!","commit_id":"55a601af802e5e4063d96f2df1d294056cb85dde"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"05325d5e049badbeba93a47a312512e5c77915c9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"02606872_5ea33c32","updated":"2026-11-05 21:51:42.000000000","message":"Stephen\u0027s explanation makes sense to me.","commit_id":"55a601af802e5e4063d96f2df1d294056cb85dde"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d4990032294ea4300b1260da9e18dabf868489eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7a64140d_17da6667","updated":"2026-11-05 16:57:03.000000000","message":"This is a user-visible change, could you add a release note?","commit_id":"55a601af802e5e4063d96f2df1d294056cb85dde"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0e01aad6f29574b6f14eefaa2b2968b7b48f2739","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"206fae7a_4692f8fd","in_reply_to":"02606872_5ea33c32","updated":"2026-11-09 14:20:01.000000000","message":"Acknowledged","commit_id":"55a601af802e5e4063d96f2df1d294056cb85dde"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4cbfc95803916f1591f5c14d9d96af5dd4e57d3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"83f722e7_558e23f8","in_reply_to":"7a64140d_17da6667","updated":"2026-11-05 18:06:25.000000000","message":"I don\u0027t think it is? See my notes inline","commit_id":"55a601af802e5e4063d96f2df1d294056cb85dde"}],"ironic/api/controllers/v1/port.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4cbfc95803916f1591f5c14d9d96af5dd4e57d3d","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    if not api_utils.allow_port_internal_info():"},{"line_number":114,"context_line":"        port.pop(\u0027internal_info\u0027, None)"},{"line_number":115,"context_line":"    # if requested version is \u003c 1.19, hide local_link_connection and"},{"line_number":116,"context_line":"    # pxe_enabled fields"},{"line_number":117,"context_line":"    if not api_utils.allow_port_advanced_net_fields():"},{"line_number":118,"context_line":"        port.pop(\u0027pxe_enabled\u0027, None)"},{"line_number":119,"context_line":"        port.pop(\u0027local_link_connection\u0027, None)"},{"line_number":120,"context_line":"    # if requested version is \u003c 1.24, hide portgroup_uuid field"},{"line_number":121,"context_line":"    if not api_utils.allow_portgroups_subcontrollers():"},{"line_number":122,"context_line":"        port.pop(\u0027portgroup_uuid\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1108ee6d_ea8acced","line":119,"range":{"start_line":116,"start_character":24,"end_line":119,"end_character":47},"updated":"2026-11-05 18:06:25.000000000","message":"We call `allow_port_advanced_net_fields` function here and `.pop` the property...","commit_id":"55a601af802e5e4063d96f2df1d294056cb85dde"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4cbfc95803916f1591f5c14d9d96af5dd4e57d3d","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    # and don\u0027t want to re-add it here"},{"line_number":136,"context_line":"    if (not api_utils.allow_ovn_vtep_version()"},{"line_number":137,"context_line":"            and api_utils.allow_port_advanced_net_fields()):"},{"line_number":138,"context_line":"        local_link_connection \u003d port.get(\u0027local_link_connection\u0027, {})"},{"line_number":139,"context_line":"        if any(key for key in local_link_connection.keys()"},{"line_number":140,"context_line":"               if key in api_utils.LOCAL_LINK_OVN_90_FIELDS):"},{"line_number":141,"context_line":"            # note(JayF): In this case, the field *should* exist but should be"}],"source_content_type":"text/x-python","patch_set":2,"id":"919ad2d0_00e408c9","line":138,"updated":"2026-11-05 18:06:25.000000000","message":"...so this will always be `{}` even though `allow_port_advanced_net_fields` wasn\u0027t being called and was doing nothing here, which means the below conditional will never be true.","commit_id":"55a601af802e5e4063d96f2df1d294056cb85dde"}]}
