)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"dc76ac5ff781a4cb56c847564672eee860cf815e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ffd501d9_d3e76371","updated":"2026-11-10 06:03:09.000000000","message":"CI and lab tests running","commit_id":"dfa92f50ec5b108cca9492fa5cfa5a8165722692"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"bd430e49911f6f8ae0ab62a5149132fa26e1021f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c6e17b30_91b59bad","updated":"2026-11-10 10:54:20.000000000","message":"CI pass, lab test pass, ready for reviews","commit_id":"dfa92f50ec5b108cca9492fa5cfa5a8165722692"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"718d2ac5b81b8aba1946367b9385d052edf703df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a372ecfd_59700938","updated":"2026-11-19 11:05:50.000000000","message":"Lab test pass.","commit_id":"e5a4d2689d8496ddc25a07e3077c6cbc278baf00"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"bd0fb7e12e358f024b60e60cf079d9bb821fa44b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"59a665c6_78b70e88","updated":"2026-11-19 05:52:37.000000000","message":"Thank you for your review Dmitry. Responses in line, pushed new patchset based on your feedback.","commit_id":"e5a4d2689d8496ddc25a07e3077c6cbc278baf00"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"3d669dfd312aa583ee8539e83d0ed4096f0eb3dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ad8b8e24_406f4f0c","updated":"2026-11-19 05:54:02.000000000","message":"lab test in progress","commit_id":"e5a4d2689d8496ddc25a07e3077c6cbc278baf00"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"30137ca948283a3c9965d504783f95dd2f25496b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8d697ea7_3acbe498","updated":"2026-11-19 12:21:44.000000000","message":"recheck","commit_id":"e5a4d2689d8496ddc25a07e3077c6cbc278baf00"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"714edfba8eeb2aff143d1110d0b29fce152dec39","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"455ced01_93ddfab3","updated":"2026-11-20 21:28:57.000000000","message":"review assisted by teim-review w/GLM 5.3","commit_id":"e5a4d2689d8496ddc25a07e3077c6cbc278baf00"}],"ironic/common/exception.py":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"d3ba854ec5c87e8dfb701b4730b4481cd27aceb7","unresolved":true,"context_lines":[{"line_number":713,"context_line":"    _msg_fmt \u003d _(\"Redfish connection failed for node %(node)s: %(error)s\")"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"class RedfishResourceNotFound(RedfishError):"},{"line_number":717,"context_line":"    _msg_fmt \u003d _(\"Redfish resource not found. Error: %(error)s\")"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"class PortgroupPhysnetInconsistent(IronicException):"}],"source_content_type":"text/x-python","patch_set":1,"id":"299917a2_20d3df78","line":717,"range":{"start_line":716,"start_character":0,"end_line":717,"end_character":64},"updated":"2026-11-11 07:17:50.000000000","message":"@dtantsur@protonmail.com is this justified or overkill? Let\u0027s discuss","commit_id":"dfa92f50ec5b108cca9492fa5cfa5a8165722692"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f370b0a55dd01d24cd735b78dd631f37c5a51943","unresolved":false,"context_lines":[{"line_number":713,"context_line":"    _msg_fmt \u003d _(\"Redfish connection failed for node %(node)s: %(error)s\")"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"class RedfishResourceNotFound(RedfishError):"},{"line_number":717,"context_line":"    _msg_fmt \u003d _(\"Redfish resource not found. Error: %(error)s\")"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"class PortgroupPhysnetInconsistent(IronicException):"}],"source_content_type":"text/x-python","patch_set":1,"id":"4479fe7a_cf9b33ef","line":717,"range":{"start_line":716,"start_character":0,"end_line":717,"end_character":64},"in_reply_to":"299917a2_20d3df78","updated":"2026-11-18 13:18:22.000000000","message":"I don\u0027t hate it. Makes the error more specific.","commit_id":"dfa92f50ec5b108cca9492fa5cfa5a8165722692"}],"ironic/drivers/modules/redfish/firmware.py":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"d3ba854ec5c87e8dfb701b4730b4481cd27aceb7","unresolved":true,"context_lines":[{"line_number":1699,"context_line":"        except exception.RedfishResourceNotFound:"},{"line_number":1700,"context_line":"            LOG.warning(\u0027The %(component)s firmware update task is gone from \u0027"},{"line_number":1701,"context_line":"                        \u0027node %(node)s after the reboot to apply it, so its \u0027"},{"line_number":1702,"context_line":"                        \u0027outcome is unknown. Verifying the update with the \u0027"},{"line_number":1703,"context_line":"                        \u0027remaining checks.\u0027,"},{"line_number":1704,"context_line":"                        {\u0027component\u0027: fw_upd[\u0027component\u0027], \u0027node\u0027: node.uuid})"},{"line_number":1705,"context_line":"        else:"},{"line_number":1706,"context_line":"            if sushy_task is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"19ab4d47_692f6766","line":1703,"range":{"start_line":1702,"start_character":0,"end_line":1703,"end_character":44},"updated":"2026-11-11 07:17:50.000000000","message":"@dtantsur@protonmail.com let\u0027s touchbase on this and see if it\u0027s worth mentioning BootProgress in this patch and adding LC mention in subsequent one or do we leave it as-is.","commit_id":"dfa92f50ec5b108cca9492fa5cfa5a8165722692"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f370b0a55dd01d24cd735b78dd631f37c5a51943","unresolved":false,"context_lines":[{"line_number":1699,"context_line":"        except exception.RedfishResourceNotFound:"},{"line_number":1700,"context_line":"            LOG.warning(\u0027The %(component)s firmware update task is gone from \u0027"},{"line_number":1701,"context_line":"                        \u0027node %(node)s after the reboot to apply it, so its \u0027"},{"line_number":1702,"context_line":"                        \u0027outcome is unknown. Verifying the update with the \u0027"},{"line_number":1703,"context_line":"                        \u0027remaining checks.\u0027,"},{"line_number":1704,"context_line":"                        {\u0027component\u0027: fw_upd[\u0027component\u0027], \u0027node\u0027: node.uuid})"},{"line_number":1705,"context_line":"        else:"},{"line_number":1706,"context_line":"            if sushy_task is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"90126d0c_385f169e","line":1703,"range":{"start_line":1702,"start_character":0,"end_line":1703,"end_character":44},"in_reply_to":"19ab4d47_692f6766","updated":"2026-11-18 13:18:22.000000000","message":"I think this is fine as it is. It leaves enough breadcrumbs to follow the logic.","commit_id":"dfa92f50ec5b108cca9492fa5cfa5a8165722692"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f370b0a55dd01d24cd735b78dd631f37c5a51943","unresolved":true,"context_lines":[{"line_number":1613,"context_line":"        if waiting is not None:"},{"line_number":1614,"context_line":"            # Log what is awaited when it changes, not on every poll."},{"line_number":1615,"context_line":"            log \u003d (LOG.debug if waiting \u003d\u003d verify.get(VERIFY_WAITING)"},{"line_number":1616,"context_line":"                   else LOG.info)"},{"line_number":1617,"context_line":"            log(\u0027Firmware update of %(component)s on node %(node)s is \u0027"},{"line_number":1618,"context_line":"                \u0027not verified yet: %(reason)s.\u0027,"},{"line_number":1619,"context_line":"                {\u0027component\u0027: fw_upd[\u0027component\u0027], \u0027node\u0027: node.uuid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"8a94f690_63d977b0","line":1616,"updated":"2026-11-18 13:18:22.000000000","message":"Aside: I\u0027d not use info in either case. Info is for operator-visible units of work, \"not verified yet\" is not one.","commit_id":"3331d14e90ae5de1d66c5c8222a9b2e836aca69d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"bd0fb7e12e358f024b60e60cf079d9bb821fa44b","unresolved":false,"context_lines":[{"line_number":1613,"context_line":"        if waiting is not None:"},{"line_number":1614,"context_line":"            # Log what is awaited when it changes, not on every poll."},{"line_number":1615,"context_line":"            log \u003d (LOG.debug if waiting \u003d\u003d verify.get(VERIFY_WAITING)"},{"line_number":1616,"context_line":"                   else LOG.info)"},{"line_number":1617,"context_line":"            log(\u0027Firmware update of %(component)s on node %(node)s is \u0027"},{"line_number":1618,"context_line":"                \u0027not verified yet: %(reason)s.\u0027,"},{"line_number":1619,"context_line":"                {\u0027component\u0027: fw_upd[\u0027component\u0027], \u0027node\u0027: node.uuid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e2c954c7_6a03f29a","line":1616,"in_reply_to":"8a94f690_63d977b0","updated":"2026-11-19 05:52:37.000000000","message":"Good point, done, it\u0027s DEBUG now, with conditional removed.conditional","commit_id":"3331d14e90ae5de1d66c5c8222a9b2e836aca69d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3b4caa26ab35218812c779402db5adee5f5756e8","unresolved":true,"context_lines":[{"line_number":1624,"context_line":""},{"line_number":1625,"context_line":"        LOG.info(\u0027%(component)s firmware update applied on node %(node)s.\u0027,"},{"line_number":1626,"context_line":"                 {\u0027component\u0027: fw_upd[\u0027component\u0027], \u0027node\u0027: node.uuid})"},{"line_number":1627,"context_line":"        verify[VERIFY_PASSED] \u003d True"},{"line_number":1628,"context_line":"        self._save_updates(node, settings)"},{"line_number":1629,"context_line":"        return True"},{"line_number":1630,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69e615_c23ca811","line":1627,"updated":"2026-11-18 13:26:25.000000000","message":"Is VERIFY_PASSED now read anywhere in reality?","commit_id":"3331d14e90ae5de1d66c5c8222a9b2e836aca69d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"bd0fb7e12e358f024b60e60cf079d9bb821fa44b","unresolved":false,"context_lines":[{"line_number":1624,"context_line":""},{"line_number":1625,"context_line":"        LOG.info(\u0027%(component)s firmware update applied on node %(node)s.\u0027,"},{"line_number":1626,"context_line":"                 {\u0027component\u0027: fw_upd[\u0027component\u0027], \u0027node\u0027: node.uuid})"},{"line_number":1627,"context_line":"        verify[VERIFY_PASSED] \u003d True"},{"line_number":1628,"context_line":"        self._save_updates(node, settings)"},{"line_number":1629,"context_line":"        return True"},{"line_number":1630,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"590974c8_07f2e6a4","line":1627,"in_reply_to":"fa69e615_c23ca811","updated":"2026-11-19 05:52:37.000000000","message":"removed VERIFY_PASSED - it is no longer required after changes we made to the chain. Also removed VERIFY_WAITING","commit_id":"3331d14e90ae5de1d66c5c8222a9b2e836aca69d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f370b0a55dd01d24cd735b78dd631f37c5a51943","unresolved":true,"context_lines":[{"line_number":1789,"context_line":"                # it, is over."},{"line_number":1790,"context_line":"                LOG.warning(\u0027Node %(node)s reports no BootProgress, so its \u0027"},{"line_number":1791,"context_line":"                            \u0027boot after the reboot to apply firmware was \u0027"},{"line_number":1792,"context_line":"                            \u0027not confirmed.\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":1793,"context_line":"                return None"},{"line_number":1794,"context_line":"            # It was reported before the reboot, so this is a gap."},{"line_number":1795,"context_line":"            waiting \u003d _(\u0027BootProgress is not reported\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c63777a9_2262c862","line":1792,"updated":"2026-11-18 13:18:22.000000000","message":"nit: let\u0027s add \"Proceeding\" or something that indicates what the outcome is","commit_id":"3331d14e90ae5de1d66c5c8222a9b2e836aca69d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"bd0fb7e12e358f024b60e60cf079d9bb821fa44b","unresolved":false,"context_lines":[{"line_number":1789,"context_line":"                # it, is over."},{"line_number":1790,"context_line":"                LOG.warning(\u0027Node %(node)s reports no BootProgress, so its \u0027"},{"line_number":1791,"context_line":"                            \u0027boot after the reboot to apply firmware was \u0027"},{"line_number":1792,"context_line":"                            \u0027not confirmed.\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":1793,"context_line":"                return None"},{"line_number":1794,"context_line":"            # It was reported before the reboot, so this is a gap."},{"line_number":1795,"context_line":"            waiting \u003d _(\u0027BootProgress is not reported\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fab04940_b8a2278d","line":1792,"in_reply_to":"c63777a9_2262c862","updated":"2026-11-19 05:52:37.000000000","message":"Done: it now says what happens next, \"Continuing the firmware update step without boot confirmation.\"","commit_id":"3331d14e90ae5de1d66c5c8222a9b2e836aca69d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b39cfb7940deb41dc7eb2dbe6cb680bdedcb4c2f","unresolved":true,"context_lines":[{"line_number":1913,"context_line":"            return"},{"line_number":1914,"context_line":""},{"line_number":1915,"context_line":"        settings \u003d node.driver_internal_info[\u0027redfish_fw_updates\u0027]"},{"line_number":1916,"context_line":"        current_update \u003d settings[0]"},{"line_number":1917,"context_line":""},{"line_number":1918,"context_line":"        try:"},{"line_number":1919,"context_line":"            update_service \u003d redfish_utils.get_update_service(node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3e4b184f_471755ea","line":1916,"updated":"2026-11-18 13:21:27.000000000","message":"Something that occurred to me when reading the next patch: while it\u0027s unlikely, an upgrade to this version of Ironic may hit an operator in the middle of a firmware upgrade. Which will leave DII fields unset. Should we maybe default the DII fields we expect to safe values (all false or whatever)? If not, it may be worth an upgrade release note.","commit_id":"3331d14e90ae5de1d66c5c8222a9b2e836aca69d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"bd0fb7e12e358f024b60e60cf079d9bb821fa44b","unresolved":true,"context_lines":[{"line_number":1913,"context_line":"            return"},{"line_number":1914,"context_line":""},{"line_number":1915,"context_line":"        settings \u003d node.driver_internal_info[\u0027redfish_fw_updates\u0027]"},{"line_number":1916,"context_line":"        current_update \u003d settings[0]"},{"line_number":1917,"context_line":""},{"line_number":1918,"context_line":"        try:"},{"line_number":1919,"context_line":"            update_service \u003d redfish_utils.get_update_service(node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bc38d05b_64a76886","line":1916,"in_reply_to":"3e4b184f_471755ea","updated":"2026-11-19 05:52:37.000000000","message":"Good point. Done by using get where keys may be absent. WDYT?","commit_id":"3331d14e90ae5de1d66c5c8222a9b2e836aca69d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"06890ac540ec381d26747edd7d6b0794966ab86c","unresolved":true,"context_lines":[{"line_number":1913,"context_line":"            return"},{"line_number":1914,"context_line":""},{"line_number":1915,"context_line":"        settings \u003d node.driver_internal_info[\u0027redfish_fw_updates\u0027]"},{"line_number":1916,"context_line":"        current_update \u003d settings[0]"},{"line_number":1917,"context_line":""},{"line_number":1918,"context_line":"        try:"},{"line_number":1919,"context_line":"            update_service \u003d redfish_utils.get_update_service(node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2e90b955_9a630135","line":1916,"in_reply_to":"bc38d05b_64a76886","updated":"2026-11-19 05:57:23.000000000","message":"( this is done in 1012426 )","commit_id":"3331d14e90ae5de1d66c5c8222a9b2e836aca69d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3b4caa26ab35218812c779402db5adee5f5756e8","unresolved":true,"context_lines":[{"line_number":1949,"context_line":"        # The node was rebooted to apply the update: do not continue until"},{"line_number":1950,"context_line":"        # the update is verified."},{"line_number":1951,"context_line":"        verify \u003d current_update.get(VERIFY)"},{"line_number":1952,"context_line":"        if verify and not verify[VERIFY_PASSED]:"},{"line_number":1953,"context_line":"            if self._poll_verify(task, settings, current_update):"},{"line_number":1954,"context_line":"                self._continue_updates(task, update_service, settings)"},{"line_number":1955,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"a2076065_37a18ec0","line":1952,"updated":"2026-11-18 13:26:25.000000000","message":"In which case do we get here with VERIFY_PASSED being True? It looks like now you immediately proceed into `_continue_updates`, which will change `current_update`?","commit_id":"3331d14e90ae5de1d66c5c8222a9b2e836aca69d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"bd0fb7e12e358f024b60e60cf079d9bb821fa44b","unresolved":false,"context_lines":[{"line_number":1949,"context_line":"        # The node was rebooted to apply the update: do not continue until"},{"line_number":1950,"context_line":"        # the update is verified."},{"line_number":1951,"context_line":"        verify \u003d current_update.get(VERIFY)"},{"line_number":1952,"context_line":"        if verify and not verify[VERIFY_PASSED]:"},{"line_number":1953,"context_line":"            if self._poll_verify(task, settings, current_update):"},{"line_number":1954,"context_line":"                self._continue_updates(task, update_service, settings)"},{"line_number":1955,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"f85ad015_2a1608e6","line":1952,"in_reply_to":"a2076065_37a18ec0","updated":"2026-11-19 05:52:37.000000000","message":"Ditto due to fix to L1627","commit_id":"3331d14e90ae5de1d66c5c8222a9b2e836aca69d"}],"ironic/drivers/modules/redfish/utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f370b0a55dd01d24cd735b78dd631f37c5a51943","unresolved":true,"context_lines":[{"line_number":550,"context_line":"                  \u0027 for node %(node)s. Error %(error)s\u0027,"},{"line_number":551,"context_line":"                  {\u0027system\u0027: system_id or \u0027\u003cdefault\u003e\u0027,"},{"line_number":552,"context_line":"                   \u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":553,"context_line":"        raise exception.RedfishError(error\u003de)"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"def get_task_monitor(node, uri):"}],"source_content_type":"text/x-python","patch_set":2,"id":"957e472a_e1ed6a1f","line":553,"updated":"2026-11-18 13:18:22.000000000","message":"If we decide on RedfishResourceNotFound, let\u0027s use it everywhere.","commit_id":"3331d14e90ae5de1d66c5c8222a9b2e836aca69d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"bd0fb7e12e358f024b60e60cf079d9bb821fa44b","unresolved":true,"context_lines":[{"line_number":550,"context_line":"                  \u0027 for node %(node)s. Error %(error)s\u0027,"},{"line_number":551,"context_line":"                  {\u0027system\u0027: system_id or \u0027\u003cdefault\u003e\u0027,"},{"line_number":552,"context_line":"                   \u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":553,"context_line":"        raise exception.RedfishError(error\u003de)"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"def get_task_monitor(node, uri):"}],"source_content_type":"text/x-python","patch_set":2,"id":"b8863209_77d23ab8","line":553,"in_reply_to":"957e472a_e1ed6a1f","updated":"2026-11-19 05:52:37.000000000","message":"Good point. Done for get_system_collection() - is this the scope you had in mind or did you want me to look more broadly (get_system() calls)?","commit_id":"3331d14e90ae5de1d66c5c8222a9b2e836aca69d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7381b5dcf8bf6c326e2a28123de8344face9f87a","unresolved":true,"context_lines":[{"line_number":550,"context_line":"                  \u0027 for node %(node)s. Error %(error)s\u0027,"},{"line_number":551,"context_line":"                  {\u0027system\u0027: system_id or \u0027\u003cdefault\u003e\u0027,"},{"line_number":552,"context_line":"                   \u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":553,"context_line":"        raise exception.RedfishError(error\u003de)"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"def get_task_monitor(node, uri):"}],"source_content_type":"text/x-python","patch_set":2,"id":"488d4510_beace527","line":553,"in_reply_to":"b8863209_77d23ab8","updated":"2026-11-20 16:36:23.000000000","message":"I\u0027d apply it to all cases of the same pattern (catching ResourceNotFoundError and re-raising).","commit_id":"3331d14e90ae5de1d66c5c8222a9b2e836aca69d"}]}
