)]}'
{"ironic/drivers/base.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"494147b9207f390ce6f7215fe32968bd31e70f92","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        \"\"\""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @abc.abstractmethod"},{"line_number":210,"context_line":"    def decommission(self, task):"},{"line_number":211,"context_line":"        \"\"\"Do extended decommissioning tasks"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        Some nodes/drivers will require additional tear down which could"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a890539_7f99e06b","line":210,"updated":"2014-12-05 01:07:34.000000000","message":"This probably should not be an abstract method, lest it break out of tree drivers","commit_id":"27486a1d41178a340a2a3c625a49096e8e3a6994"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5b05d1cbe26268722041bd8b5f6a3f5eb43a3e0e","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        \"\"\""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @abc.abstractmethod"},{"line_number":210,"context_line":"    def decommission(self, task):"},{"line_number":211,"context_line":"        \"\"\"Do extended decommissioning tasks"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        Some nodes/drivers will require additional tear down which could"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a890539_8ff56cef","line":210,"in_reply_to":"5a890539_7f99e06b","updated":"2014-12-05 10:09:29.000000000","message":"+1","commit_id":"27486a1d41178a340a2a3c625a49096e8e3a6994"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"a8059f7d340d2c0c6c5992db00262665181cad80","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @abc.abstractmethod"},{"line_number":210,"context_line":"    def decommission(self, task):"},{"line_number":211,"context_line":"        \"\"\"Do extended decommissioning tasks"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        Some nodes/drivers will require additional tear down which could"},{"line_number":214,"context_line":"        take a long time to complete. If these are implemented in tear_down"}],"source_content_type":"text/x-python","patch_set":12,"id":"7ac7a964_107335ea","line":211,"updated":"2014-08-14 18:25:08.000000000","message":"Nit: end sentences with a period. :P","commit_id":"27486a1d41178a340a2a3c625a49096e8e3a6994"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5b05d1cbe26268722041bd8b5f6a3f5eb43a3e0e","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    def decommission(self, task):"},{"line_number":211,"context_line":"        \"\"\"Do extended decommissioning tasks"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        Some nodes/drivers will require additional tear down which could"},{"line_number":214,"context_line":"        take a long time to complete. If these are implemented in tear_down"},{"line_number":215,"context_line":"        or clean_up, the node stays in a DELETING state in Nova and the"},{"line_number":216,"context_line":"        Ironic Nova driver will likely timeout waiting for the tear_down"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a890539_4f2e2444","line":213,"updated":"2014-12-05 10:09:29.000000000","message":"s/drivers//\n\nYou tear down the node not the driver.","commit_id":"27486a1d41178a340a2a3c625a49096e8e3a6994"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5b05d1cbe26268722041bd8b5f6a3f5eb43a3e0e","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        Some nodes/drivers will require additional tear down which could"},{"line_number":214,"context_line":"        take a long time to complete. If these are implemented in tear_down"},{"line_number":215,"context_line":"        or clean_up, the node stays in a DELETING state in Nova and the"},{"line_number":216,"context_line":"        Ironic Nova driver will likely timeout waiting for the tear_down"},{"line_number":217,"context_line":"        to complete. This command will be run after the node has been"},{"line_number":218,"context_line":"        removed from the user\u0027s list of nodes. Examples of decommission"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a890539_afe30805","line":215,"updated":"2014-12-05 10:09:29.000000000","message":"I would rephrase it a bit, cause we say if the not require additonal tear down and then we tell the user to not implement in tear_down().\n\nI think that something like would be better:\n\n\"After tear_down() a node might require additional steps to become available for deployment again, such as: cleaning, ...\"","commit_id":"27486a1d41178a340a2a3c625a49096e8e3a6994"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"494147b9207f390ce6f7215fe32968bd31e70f92","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        take a long time to complete. If these are implemented in tear_down"},{"line_number":215,"context_line":"        or clean_up, the node stays in a DELETING state in Nova and the"},{"line_number":216,"context_line":"        Ironic Nova driver will likely timeout waiting for the tear_down"},{"line_number":217,"context_line":"        to complete. This command will be run after the node has been"},{"line_number":218,"context_line":"        removed from the user\u0027s list of nodes. Examples of decommission"},{"line_number":219,"context_line":"        steps include applying firmware updates that require rebooting the"},{"line_number":220,"context_line":"        node or securely erasing spinning disks, which can take a very long"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a890539_9fa3ec9c","line":217,"updated":"2014-12-05 01:07:34.000000000","message":"\"removed from the user\u0027s list of nodes\" ? This doesn\u0027t make sense to me.\n\nPerhaps it would be better worded as:\n\nThis interface will be called on the node after the instance deletion is completed, but before the node is made available for further use.","commit_id":"27486a1d41178a340a2a3c625a49096e8e3a6994"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"a8059f7d340d2c0c6c5992db00262665181cad80","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        removed from the user\u0027s list of nodes. Examples of decommission"},{"line_number":219,"context_line":"        steps include applying firmware updates that require rebooting the"},{"line_number":220,"context_line":"        node or securely erasing spinning disks, which can take a very long"},{"line_number":221,"context_line":"        time."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":224,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"7ac7a964_307751d6","line":221,"updated":"2014-08-14 18:25:08.000000000","message":"I don\u0027t love this docstring; it should say what the function does. e.g. \"Perform additional cleanup work on the node after tear down.\" Also mention when it is called in the tear_down sequence, etc.","commit_id":"27486a1d41178a340a2a3c625a49096e8e3a6994"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5b05d1cbe26268722041bd8b5f6a3f5eb43a3e0e","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        removed from the user\u0027s list of nodes. Examples of decommission"},{"line_number":219,"context_line":"        steps include applying firmware updates that require rebooting the"},{"line_number":220,"context_line":"        node or securely erasing spinning disks, which can take a very long"},{"line_number":221,"context_line":"        time."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":224,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"5a890539_6ff040fe","line":221,"in_reply_to":"7ac7a964_307751d6","updated":"2014-12-05 10:09:29.000000000","message":"+1","commit_id":"27486a1d41178a340a2a3c625a49096e8e3a6994"}],"ironic/drivers/modules/agent.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5b05d1cbe26268722041bd8b5f6a3f5eb43a3e0e","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        neutron.update_neutron(task, CONF.agent.agent_pxe_bootfile_name)"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def decommission(self, task):"},{"line_number":329,"context_line":"        pass"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"class AgentVendorInterface(base.VendorInterface):"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a890539_4fbc64dc","line":329,"updated":"2014-12-05 10:09:29.000000000","message":"not needed if not @abstractmethod","commit_id":"27486a1d41178a340a2a3c625a49096e8e3a6994"}],"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5b05d1cbe26268722041bd8b5f6a3f5eb43a3e0e","unresolved":false,"context_lines":[{"line_number":625,"context_line":"        neutron.update_neutron(task, dhcp_opts)"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def decommission(self, task):"},{"line_number":628,"context_line":"        pass"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"class VendorPassthru(base.VendorInterface):"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a890539_cfc77464","line":628,"updated":"2014-12-05 10:09:29.000000000","message":"ditto","commit_id":"27486a1d41178a340a2a3c625a49096e8e3a6994"}]}
