)]}'
{"ironic/common/service.py":[{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"94f000336c233e8c9cfe2c9a3a43be256cdf9481","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"def prepare_service(argv\u003dNone):"},{"line_number":94,"context_line":"    argv \u003d argv or []"},{"line_number":95,"context_line":"    config.parse_args(argv)"},{"line_number":96,"context_line":"    cfg.set_defaults(log.log_opts,"},{"line_number":97,"context_line":"                     default_log_levels\u003d[\u0027amqp\u003dWARN\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_084cba6f","line":94,"updated":"2014-07-02 15:10:48.000000000","message":"This still can mutate args.\n\nargv \u003d list(argv)","commit_id":"517b2ee8dc074ffa58c77acafa899327bb4b8690"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"c9c1e603be8a511243a1b67afdf9dcb1bdfb7564","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"def prepare_service(argv\u003dNone):"},{"line_number":94,"context_line":"    argv \u003d argv or []"},{"line_number":95,"context_line":"    config.parse_args(argv)"},{"line_number":96,"context_line":"    cfg.set_defaults(log.log_opts,"},{"line_number":97,"context_line":"                     default_log_levels\u003d[\u0027amqp\u003dWARN\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_f821f89f","line":94,"in_reply_to":"baada198_084cba6f","updated":"2014-07-03 07:03:23.000000000","message":"list(None) will raise exception...","commit_id":"517b2ee8dc074ffa58c77acafa899327bb4b8690"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"e430b4abec131362220fe8a3ae8e9e1503264cc8","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"def prepare_service(argv\u003dNone):"},{"line_number":94,"context_line":"    argv \u003d argv or []"},{"line_number":95,"context_line":"    config.parse_args(argv)"},{"line_number":96,"context_line":"    cfg.set_defaults(log.log_opts,"},{"line_number":97,"context_line":"                     default_log_levels\u003d[\u0027amqp\u003dWARN\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_cf8ea878","line":94,"in_reply_to":"baada198_6bfd143a","updated":"2014-07-08 09:38:56.000000000","message":"so how should i do? use the first or second?","commit_id":"517b2ee8dc074ffa58c77acafa899327bb4b8690"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"54c74b709e23e9e35752db0a05dc776ce82839c9","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"def prepare_service(argv\u003dNone):"},{"line_number":94,"context_line":"    argv \u003d argv or []"},{"line_number":95,"context_line":"    config.parse_args(argv)"},{"line_number":96,"context_line":"    cfg.set_defaults(log.log_opts,"},{"line_number":97,"context_line":"                     default_log_levels\u003d[\u0027amqp\u003dWARN\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_6bfd143a","line":94,"in_reply_to":"baada198_f821f89f","updated":"2014-07-03 08:16:11.000000000","message":"About multable default parameters values, AFAIUI, you better always check the placeholder value, for example, the case we have here:\n\n def prepare_service(argv\u003dNone):\n     if argv is None:\n         argv \u003d []\n\n\nIn case where the basic types are also valid types you should create a sentinel object, e.g: \n\n sentinel \u003d object()\n\n def prepare_service(argv\u003dsentinel):\n     if argv is sentinel:\n         argv \u003d []","commit_id":"517b2ee8dc074ffa58c77acafa899327bb4b8690"}]}