)]}'
{"ironic/api/acl.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e1053a70bbccba8c57993aebc319e637dea869fd","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \"\"\"Install ACL check on application."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    :param app: A WSGI applicatin."},{"line_number":28,"context_line":"    :param conf: Settings. Must include OPT_GROUP_NAME section."},{"line_number":29,"context_line":"    :param public_routes: The list of the routes which will be allowed to"},{"line_number":30,"context_line":"                          access without authentication."},{"line_number":31,"context_line":"    :return: The same WSGI application with ACL installed."}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_59ea4d78","line":28,"updated":"2014-07-29 14:38:30.000000000","message":"Should this be changed to \u0027Must include \"keystone_authtoken\" section\u0027?","commit_id":"6ffcc118ef355e50698c3bc9a3c794239392bc17"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"dd6a6a4a8cb762b371263bc80c1307c495847d3e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \"\"\"Install ACL check on application."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    :param app: A WSGI applicatin."},{"line_number":28,"context_line":"    :param conf: Settings. Must include OPT_GROUP_NAME section."},{"line_number":29,"context_line":"    :param public_routes: The list of the routes which will be allowed to"},{"line_number":30,"context_line":"                          access without authentication."},{"line_number":31,"context_line":"    :return: The same WSGI application with ACL installed."}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_d7674422","line":28,"in_reply_to":"baada198_59ea4d78","updated":"2014-08-11 21:33:28.000000000","message":"why?","commit_id":"6ffcc118ef355e50698c3bc9a3c794239392bc17"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"89316925f0984be048a3e35ccb57f6ee9dc2ea5c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \"\"\"Install ACL check on application."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    :param app: A WSGI applicatin."},{"line_number":28,"context_line":"    :param conf: Settings. Must include OPT_GROUP_NAME section."},{"line_number":29,"context_line":"    :param public_routes: The list of the routes which will be allowed to"},{"line_number":30,"context_line":"                          access without authentication."},{"line_number":31,"context_line":"    :return: The same WSGI application with ACL installed."}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_ecd47e20","line":28,"in_reply_to":"baada198_8929349e","updated":"2014-08-11 22:33:47.000000000","message":"doc string updated","commit_id":"6ffcc118ef355e50698c3bc9a3c794239392bc17"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2d834733440c2d6fd5fec0667fe7d30b781b4655","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \"\"\"Install ACL check on application."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    :param app: A WSGI applicatin."},{"line_number":28,"context_line":"    :param conf: Settings. Must include OPT_GROUP_NAME section."},{"line_number":29,"context_line":"    :param public_routes: The list of the routes which will be allowed to"},{"line_number":30,"context_line":"                          access without authentication."},{"line_number":31,"context_line":"    :return: The same WSGI application with ACL installed."}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_8929349e","line":28,"in_reply_to":"baada198_d7674422","updated":"2014-08-11 22:18:40.000000000","message":"Well, is it obvious what \u0027OPT_GROUP_NAME\u0027 is? It was in the original file, but not in this version. Am I missing something?","commit_id":"6ffcc118ef355e50698c3bc9a3c794239392bc17"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e1053a70bbccba8c57993aebc319e637dea869fd","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":"    return auth_token.AuthTokenMiddleware(app,"},{"line_number":35,"context_line":"                                          conf\u003ddict(conf),"},{"line_number":36,"context_line":"                                          public_api_routes\u003dpublic_routes)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_59c32d06","line":35,"updated":"2014-07-29 14:38:30.000000000","message":"isn\u0027t dict(conf.get(\u0027keystone_authtoken\u0027)) equivalent to the original code?","commit_id":"6ffcc118ef355e50698c3bc9a3c794239392bc17"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"89316925f0984be048a3e35ccb57f6ee9dc2ea5c","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":"    return auth_token.AuthTokenMiddleware(app,"},{"line_number":35,"context_line":"                                          conf\u003ddict(conf),"},{"line_number":36,"context_line":"                                          public_api_routes\u003dpublic_routes)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_2cdbd64e","line":35,"in_reply_to":"baada198_2c1e765e","updated":"2014-08-11 22:33:47.000000000","message":"It\u0027s a change in response to a change in a project we depend on (keystone) which is mentioned in the commit message","commit_id":"6ffcc118ef355e50698c3bc9a3c794239392bc17"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2d834733440c2d6fd5fec0667fe7d30b781b4655","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":"    return auth_token.AuthTokenMiddleware(app,"},{"line_number":35,"context_line":"                                          conf\u003ddict(conf),"},{"line_number":36,"context_line":"                                          public_api_routes\u003dpublic_routes)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_2c1e765e","line":35,"in_reply_to":"baada198_37a96025","updated":"2014-08-11 22:18:40.000000000","message":"So you want to pass all the confs, which is a change from the original code. Should that be mentioned in the commit then, cuz it is a change in behaviour?","commit_id":"6ffcc118ef355e50698c3bc9a3c794239392bc17"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"dd6a6a4a8cb762b371263bc80c1307c495847d3e","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":"    return auth_token.AuthTokenMiddleware(app,"},{"line_number":35,"context_line":"                                          conf\u003ddict(conf),"},{"line_number":36,"context_line":"                                          public_api_routes\u003dpublic_routes)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_37a96025","line":35,"in_reply_to":"baada198_59c32d06","updated":"2014-08-11 21:33:28.000000000","message":"maybe? But what I\u0027ve got here is *not* equivalent to the original code. It\u0027s passing the whole conf, rather than a single option.","commit_id":"6ffcc118ef355e50698c3bc9a3c794239392bc17"}],"ironic/api/middleware/auth_token.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e1053a70bbccba8c57993aebc319e637dea869fd","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                                       self.public_api_routes))"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        if env[\u0027is_public_api\u0027]:"},{"line_number":58,"context_line":"            return self.app(env, start_response)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        return super(AuthTokenMiddleware, self).__call__(env, start_response)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_a40b40d4","line":58,"updated":"2014-07-29 14:38:30.000000000","message":"We shouldn\u0027t use self._app?","commit_id":"6ffcc118ef355e50698c3bc9a3c794239392bc17"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"89316925f0984be048a3e35ccb57f6ee9dc2ea5c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                                       self.public_api_routes))"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        if env[\u0027is_public_api\u0027]:"},{"line_number":58,"context_line":"            return self.app(env, start_response)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        return super(AuthTokenMiddleware, self).__call__(env, start_response)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_ecd1de56","line":58,"in_reply_to":"baada198_8c178245","updated":"2014-08-11 22:33:47.000000000","message":"ahh, good point","commit_id":"6ffcc118ef355e50698c3bc9a3c794239392bc17"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"dd6a6a4a8cb762b371263bc80c1307c495847d3e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                                       self.public_api_routes))"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        if env[\u0027is_public_api\u0027]:"},{"line_number":58,"context_line":"            return self.app(env, start_response)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        return super(AuthTokenMiddleware, self).__call__(env, start_response)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_f741a862","line":58,"in_reply_to":"baada198_a40b40d4","updated":"2014-08-11 21:33:28.000000000","message":"self.app predates this patch.","commit_id":"6ffcc118ef355e50698c3bc9a3c794239392bc17"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2d834733440c2d6fd5fec0667fe7d30b781b4655","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                                       self.public_api_routes))"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        if env[\u0027is_public_api\u0027]:"},{"line_number":58,"context_line":"            return self.app(env, start_response)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        return super(AuthTokenMiddleware, self).__call__(env, start_response)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_8c178245","line":58,"in_reply_to":"baada198_f741a862","updated":"2014-08-11 22:18:40.000000000","message":"True, but then you had to add \u0027self.app \u003d app\u0027 above to handle this, instead of changing this to self._app().","commit_id":"6ffcc118ef355e50698c3bc9a3c794239392bc17"}],"ironic/tests/api/base.py":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"750bcd2d32dc50612ef0ca5bc3ae186ff78df0e5","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def setUp(self):"},{"line_number":45,"context_line":"        super(FunctionalTest, self).setUp()"},{"line_number":46,"context_line":"        cfg.CONF.set_override(\"auth_version\", \"v2.0\","},{"line_number":47,"context_line":"                              group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":48,"context_line":"        self.app \u003d self._make_app()"},{"line_number":49,"context_line":"        self.dbapi \u003d dbapi.get_instance()"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_1cd5d91a","line":46,"updated":"2014-07-23 19:22:31.000000000","message":"why hardcoding keystone version to 2.0?","commit_id":"6ffcc118ef355e50698c3bc9a3c794239392bc17"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"c10c25ab265fe425a0075fb54a1d997b568c7cb7","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def setUp(self):"},{"line_number":45,"context_line":"        super(FunctionalTest, self).setUp()"},{"line_number":46,"context_line":"        cfg.CONF.set_override(\"auth_version\", \"v2.0\","},{"line_number":47,"context_line":"                              group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":48,"context_line":"        self.app \u003d self._make_app()"},{"line_number":49,"context_line":"        self.dbapi \u003d dbapi.get_instance()"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_7cf6d591","line":46,"in_reply_to":"baada198_1cd5d91a","updated":"2014-07-23 19:30:00.000000000","message":"I\u0027m not sure the history of this line at the moment, but I\u0027m not proposing to change it either.","commit_id":"6ffcc118ef355e50698c3bc9a3c794239392bc17"}],"requirements.txt":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e1053a70bbccba8c57993aebc319e637dea869fd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"jsonpatch\u003e\u003d1.1"},{"line_number":30,"context_line":"WSME\u003e\u003d0.6"},{"line_number":31,"context_line":"Jinja2"},{"line_number":32,"context_line":"keystonemiddleware"},{"line_number":33,"context_line":"oslo.messaging\u003e\u003d1.3.0"}],"source_content_type":"text/plain","patch_set":5,"id":"baada198_6475a8ff","line":32,"updated":"2014-07-29 14:38:30.000000000","message":"Jenkins is complaining about this. In global requirements, it is \u0027keystonemiddleware\u003e\u003d1.0.0\u0027","commit_id":"6ffcc118ef355e50698c3bc9a3c794239392bc17"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"dd6a6a4a8cb762b371263bc80c1307c495847d3e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"jsonpatch\u003e\u003d1.1"},{"line_number":30,"context_line":"WSME\u003e\u003d0.6"},{"line_number":31,"context_line":"Jinja2"},{"line_number":32,"context_line":"keystonemiddleware"},{"line_number":33,"context_line":"oslo.messaging\u003e\u003d1.3.0"}],"source_content_type":"text/plain","patch_set":5,"id":"baada198_3757a028","line":32,"in_reply_to":"baada198_6475a8ff","updated":"2014-08-11 21:33:28.000000000","message":"ok, I think that changed somewhere along the way. I\u0027ll update this patch.","commit_id":"6ffcc118ef355e50698c3bc9a3c794239392bc17"}]}