)]}'
{"ironic/conductor/task_manager.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"964a222830645d563c79206aad6f3d968aceb6e7","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            stop_max_attempt_number\u003dCONF.conductor.node_locked_retry_attempts,"},{"line_number":179,"context_line":"            wait_fixed\u003dCONF.conductor.node_locked_retry_interval * 1000)"},{"line_number":180,"context_line":"        def reserve_node():"},{"line_number":181,"context_line":"            LOG.debug(_(\"Attempting to reserve node %(node)s\"),"},{"line_number":182,"context_line":"                      {\u0027node\u0027: node_id})"},{"line_number":183,"context_line":"            self.node \u003d self._dbapi.reserve_node(CONF.host, node_id)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_511dc1bd","line":181,"updated":"2014-07-22 14:48:02.000000000","message":"debug messages should not be translated","commit_id":"d02cdb62cc99be8dbd839a30632bc2923889bf5e"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"91b93bad0e771470d0a57d211585fe5b7c6336b1","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            stop_max_attempt_number\u003dCONF.conductor.node_locked_retry_attempts,"},{"line_number":179,"context_line":"            wait_fixed\u003dCONF.conductor.node_locked_retry_interval * 1000)"},{"line_number":180,"context_line":"        def reserve_node():"},{"line_number":181,"context_line":"            LOG.debug(_(\"Attempting to reserve node %(node)s\"),"},{"line_number":182,"context_line":"                      {\u0027node\u0027: node_id})"},{"line_number":183,"context_line":"            self.node \u003d self._dbapi.reserve_node(CONF.host, node_id)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_250d6736","line":181,"in_reply_to":"baada198_511dc1bd","updated":"2014-07-22 15:22:56.000000000","message":"Well spotted! My fingers are too used to typing that. Done.","commit_id":"d02cdb62cc99be8dbd839a30632bc2923889bf5e"}],"ironic/tests/conductor/test_task_manager.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ca2a4d626793262fe7b7df8be1c654e425572d21","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                         release_mock.call_args_list)"},{"line_number":116,"context_line":"        self.assertFalse(node_get_mock.called)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def test_excl_lock_reserve_exception(self, get_ports_mock,"},{"line_number":119,"context_line":"                                         get_driver_mock, reserve_mock,"},{"line_number":120,"context_line":"                                         release_mock, node_get_mock):"},{"line_number":121,"context_line":"        retry_attempts \u003d 3"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_e81c4ac4","line":118,"updated":"2014-07-22 07:07:46.000000000","message":"Just wondering if we could add one more test case where the retry_attempts\u003d3, exception is thrown first and lock is acquired on the first retry.  Eventhough it is functionality of retrying module, we could just be sure from our part since successful attempt on a retry is the major functionality of this commit. :-)","commit_id":"17d488170fe5f06a0bb4d0095dcf3c599ac35af0"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"2ce0de40b0232394ee90a11d1b0b1bba5dd2ce23","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                         release_mock.call_args_list)"},{"line_number":116,"context_line":"        self.assertFalse(node_get_mock.called)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def test_excl_lock_reserve_exception(self, get_ports_mock,"},{"line_number":119,"context_line":"                                         get_driver_mock, reserve_mock,"},{"line_number":120,"context_line":"                                         release_mock, node_get_mock):"},{"line_number":121,"context_line":"        retry_attempts \u003d 3"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_f3a8a7db","line":118,"in_reply_to":"baada198_38603e0d","updated":"2014-07-22 11:59:41.000000000","message":"http://www.voidspace.org.uk/python/mock/mock.html#mock.Mock.side_effect\n\n\u003e\u003e\u003e mock \u003d Mock()\n\n\u003e\u003e\u003e mock.side_effect \u003d [3, 2, 1]\n\n\u003e\u003e\u003e mock(), mock(), mock()\n\n(3, 2, 1)\n\nCan\u0027t we have instance of the exception as first argument and self.node as second argument ?","commit_id":"17d488170fe5f06a0bb4d0095dcf3c599ac35af0"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"4f457aaa5fcf129e1b06e129d0760023cf449301","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                         release_mock.call_args_list)"},{"line_number":116,"context_line":"        self.assertFalse(node_get_mock.called)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def test_excl_lock_reserve_exception(self, get_ports_mock,"},{"line_number":119,"context_line":"                                         get_driver_mock, reserve_mock,"},{"line_number":120,"context_line":"                                         release_mock, node_get_mock):"},{"line_number":121,"context_line":"        retry_attempts \u003d 3"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_38603e0d","line":118,"in_reply_to":"baada198_e81c4ac4","updated":"2014-07-22 11:51:38.000000000","message":"I\u0027d be glad to add that if you could show me how. I don\u0027t know how to make mock do that.","commit_id":"17d488170fe5f06a0bb4d0095dcf3c599ac35af0"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"98d306554b67d57e7d9cc671fc674141abc94092","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                         release_mock.call_args_list)"},{"line_number":116,"context_line":"        self.assertFalse(node_get_mock.called)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def test_excl_lock_reserve_exception(self, get_ports_mock,"},{"line_number":119,"context_line":"                                         get_driver_mock, reserve_mock,"},{"line_number":120,"context_line":"                                         release_mock, node_get_mock):"},{"line_number":121,"context_line":"        retry_attempts \u003d 3"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_5f478d7a","line":118,"in_reply_to":"baada198_f3a8a7db","updated":"2014-07-22 14:27:58.000000000","message":"Very cool! Thanks for point me to this. I\u0027ll see what I can do.","commit_id":"17d488170fe5f06a0bb4d0095dcf3c599ac35af0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"964a222830645d563c79206aad6f3d968aceb6e7","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                          self.context,"},{"line_number":148,"context_line":"                          \u0027fake-node-id\u0027)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        reserve_mock.assert_called(self.host, \u0027fake-node-id\u0027)"},{"line_number":151,"context_line":"        self.assertTrue(reserve_mock.call_count \u003d\u003d retry_attempts)"},{"line_number":152,"context_line":"        self.assertFalse(get_ports_mock.called)"},{"line_number":153,"context_line":"        self.assertFalse(get_driver_mock.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_519061ed","line":150,"updated":"2014-07-22 14:48:02.000000000","message":"there\u0027s not assert_called, it is called assert_called_with","commit_id":"d02cdb62cc99be8dbd839a30632bc2923889bf5e"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"91b93bad0e771470d0a57d211585fe5b7c6336b1","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                          self.context,"},{"line_number":148,"context_line":"                          \u0027fake-node-id\u0027)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        reserve_mock.assert_called(self.host, \u0027fake-node-id\u0027)"},{"line_number":151,"context_line":"        self.assertTrue(reserve_mock.call_count \u003d\u003d retry_attempts)"},{"line_number":152,"context_line":"        self.assertFalse(get_ports_mock.called)"},{"line_number":153,"context_line":"        self.assertFalse(get_driver_mock.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_e559af36","line":150,"in_reply_to":"baada198_519061ed","updated":"2014-07-22 15:22:56.000000000","message":"Done","commit_id":"d02cdb62cc99be8dbd839a30632bc2923889bf5e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"964a222830645d563c79206aad6f3d968aceb6e7","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                          \u0027fake-node-id\u0027)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        reserve_mock.assert_called(self.host, \u0027fake-node-id\u0027)"},{"line_number":151,"context_line":"        self.assertTrue(reserve_mock.call_count \u003d\u003d retry_attempts)"},{"line_number":152,"context_line":"        self.assertFalse(get_ports_mock.called)"},{"line_number":153,"context_line":"        self.assertFalse(get_driver_mock.called)"},{"line_number":154,"context_line":"        self.assertFalse(release_mock.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_d1e551a5","line":151,"updated":"2014-07-22 14:48:02.000000000","message":"this should be assertEqual(retry_attempts, reserve_mock.call_count)","commit_id":"d02cdb62cc99be8dbd839a30632bc2923889bf5e"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"91b93bad0e771470d0a57d211585fe5b7c6336b1","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                          \u0027fake-node-id\u0027)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        reserve_mock.assert_called(self.host, \u0027fake-node-id\u0027)"},{"line_number":151,"context_line":"        self.assertTrue(reserve_mock.call_count \u003d\u003d retry_attempts)"},{"line_number":152,"context_line":"        self.assertFalse(get_ports_mock.called)"},{"line_number":153,"context_line":"        self.assertFalse(get_driver_mock.called)"},{"line_number":154,"context_line":"        self.assertFalse(release_mock.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_253ba7c9","line":151,"in_reply_to":"baada198_d1e551a5","updated":"2014-07-22 15:22:56.000000000","message":"Done","commit_id":"d02cdb62cc99be8dbd839a30632bc2923889bf5e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a9c94c3e630d4a9b87c107b95db2cc9db66c54ff","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            self.assertFalse(task.shared)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        reserve_mock.assert_called(self.host, \u0027fake-node-id\u0027)"},{"line_number":134,"context_line":"        self.assertTrue(reserve_mock.call_count \u003d\u003d 2)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_excl_lock_reserve_exception(self, get_ports_mock,"},{"line_number":137,"context_line":"                                         get_driver_mock, reserve_mock,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_00f691d8","line":134,"updated":"2014-07-22 15:33:19.000000000","message":"this should be converted to assertEqual","commit_id":"b310920ee6b29a6b106aa2268cda915d578b3190"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"6f6fe0c727ffce24f4e13f0451ccae57b43aa42f","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            self.assertFalse(task.shared)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        reserve_mock.assert_called(self.host, \u0027fake-node-id\u0027)"},{"line_number":134,"context_line":"        self.assertTrue(reserve_mock.call_count \u003d\u003d 2)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_excl_lock_reserve_exception(self, get_ports_mock,"},{"line_number":137,"context_line":"                                         get_driver_mock, reserve_mock,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_b7fc460e","line":134,"in_reply_to":"baada198_00f691d8","updated":"2014-07-22 16:25:14.000000000","message":"Thanks! Done","commit_id":"b310920ee6b29a6b106aa2268cda915d578b3190"}]}
