)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"dfdbd03e7e415d62250b85e3bd7af5fa9195b720","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Clean up calls to get_chassis()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The same work have already been done by Nodes (see 2192f2848e), so right"},{"line_number":10,"context_line":"now the dbapi\u0027s are incosistent across different objects. This patch"},{"line_number":11,"context_line":"fixes it for Chassis."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch removes all direct calls to dbapi\u0027s get_chassis(). They"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_78b72186","line":10,"updated":"2014-07-29 03:29:00.000000000","message":"nit:)\ns/incosistent/inconsistent","commit_id":"4b6f4dbc282f2f6536bdea62469db1bb12f63527"}],"ironic/objects/chassis.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d9d99f5b1610f541e9965ce4c76cccc376dfebc7","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def get(cls, context, chassis_id):"},{"line_number":54,"context_line":"        \"\"\"Find a chassis based on its id or uuid and return a Chassis object."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        :param chassis_id: the id *or* uuid of a chassis."},{"line_number":57,"context_line":"        :returns: a :class:`Chassis` object."},{"line_number":58,"context_line":"        \"\"\""},{"line_number":59,"context_line":"        if utils.is_int_like(chassis_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_7ee0c226","line":56,"updated":"2014-07-29 21:58:13.000000000","message":"param context?","commit_id":"e2e89126efa1ed910f269e2798e7b8b63adaf841"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d9d99f5b1610f541e9965ce4c76cccc376dfebc7","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def get_by_id(cls, context, chassis_id):"},{"line_number":68,"context_line":"        \"\"\"Find a chassis based on its integer id and return a Chassis object."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        :param chassis_id: the id of a chassis."},{"line_number":71,"context_line":"        :returns: a :class:`Chassis` object."},{"line_number":72,"context_line":"        \"\"\""},{"line_number":73,"context_line":"        db_chassis \u003d cls.dbapi.get_chassis_by_id(chassis_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_3e8f2a78","line":70,"updated":"2014-07-29 21:58:13.000000000","message":"param context?","commit_id":"e2e89126efa1ed910f269e2798e7b8b63adaf841"}],"ironic/tests/objects/test_chassis.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d9d99f5b1610f541e9965ce4c76cccc376dfebc7","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"            objects.Chassis.get(self.context, uuid)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"            mock_get_chassis.assert_called_once_with(uuid)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def test_get_bad_id_and_uuid(self):"},{"line_number":56,"context_line":"        self.assertRaises(exception.InvalidIdentity,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_7ea36243","line":53,"updated":"2014-07-29 21:58:13.000000000","message":"I suppose these two tests are fine. They\u0027re testing objects.Chassis.get(), and that calls objects.Chassis.get_by_uuid() \u0026 get_by_id(), so that\u0027s why there are no explicit tests for .get_by_uuid() and get_by_id()?","commit_id":"e2e89126efa1ed910f269e2798e7b8b63adaf841"}]}
