)]}'
{"ironic/tests/objects/utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4e8cb72fa54cfa92a21fe3d6c924e48134622c9a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    db_port \u003d db_utils.get_test_port(**kw)"},{"line_number":50,"context_line":"    port \u003d objects.Port(context\u003dctxt)"},{"line_number":51,"context_line":"    for key in db_port:"},{"line_number":52,"context_line":"        setattr(port, key, db_port[key])"},{"line_number":53,"context_line":"    return port"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_66e52509","line":52,"updated":"2014-08-01 14:21:05.000000000","message":"if you create a new version of patch, more pythonic would be:\n\n for key, value in db_port.items():\n    setattr(port, key, value)","commit_id":"982f47af37dedddbb5848637f46b038b5fb41a25"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"31b4a794c87e3a7e99c53313ac35567fadb3c5d0","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    db_port \u003d db_utils.get_test_port(**kw)"},{"line_number":50,"context_line":"    port \u003d objects.Port(context\u003dctxt)"},{"line_number":51,"context_line":"    for key in db_port:"},{"line_number":52,"context_line":"        setattr(port, key, db_port[key])"},{"line_number":53,"context_line":"    return port"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_670c4045","line":52,"in_reply_to":"baada198_0740e4a0","updated":"2014-08-01 15:23:10.000000000","message":"Ooh.. you\u0027re right. :)  Then I would use six.iteritems() or whatever. :)  Happy Friday!","commit_id":"982f47af37dedddbb5848637f46b038b5fb41a25"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"55b92015b14ab89dd605e529c2f29fe682613a0c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    db_port \u003d db_utils.get_test_port(**kw)"},{"line_number":50,"context_line":"    port \u003d objects.Port(context\u003dctxt)"},{"line_number":51,"context_line":"    for key in db_port:"},{"line_number":52,"context_line":"        setattr(port, key, db_port[key])"},{"line_number":53,"context_line":"    return port"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_0740e4a0","line":52,"in_reply_to":"baada198_07b54418","updated":"2014-08-01 15:15:03.000000000","message":"if we seriously start discussing performance, we need to take into account, that as it is it involves redundant hash look-up for every key, that is items() is usually preferred. Of course Py2vs3 is any issue here and I\u0027m happy with leaving it as it is. Happy Friday :)","commit_id":"982f47af37dedddbb5848637f46b038b5fb41a25"},{"author":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"change_message_id":"e515b6537901ce92176fc6ec3852c86dd4d2d731","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    db_port \u003d db_utils.get_test_port(**kw)"},{"line_number":50,"context_line":"    port \u003d objects.Port(context\u003dctxt)"},{"line_number":51,"context_line":"    for key in db_port:"},{"line_number":52,"context_line":"        setattr(port, key, db_port[key])"},{"line_number":53,"context_line":"    return port"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_07b54418","line":52,"in_reply_to":"baada198_26688df3","updated":"2014-08-01 14:59:46.000000000","message":"I\u0027d leave it as it is because it\u0027s the way it works in both py3 and py2 without six or generating a list.","commit_id":"982f47af37dedddbb5848637f46b038b5fb41a25"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"4be65e6df5b59bf44b9f102d3a1cb6b5a6e8d52c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    db_port \u003d db_utils.get_test_port(**kw)"},{"line_number":50,"context_line":"    port \u003d objects.Port(context\u003dctxt)"},{"line_number":51,"context_line":"    for key in db_port:"},{"line_number":52,"context_line":"        setattr(port, key, db_port[key])"},{"line_number":53,"context_line":"    return port"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_26688df3","line":52,"in_reply_to":"baada198_66e52509","updated":"2014-08-01 14:34:27.000000000","message":"I would probably argue it\u0027s not more pythonic, or the difference is insignificant. Using items() here would be less efficient due to items() forming a new list to iterate. If you were to do this, you\u0027d want to use iteritems()... but then that would not be py3 compatible... so then you\u0027d have to do more work to import \u0027six\u0027 and so forth...   I actually like it the way it is.","commit_id":"982f47af37dedddbb5848637f46b038b5fb41a25"}]}