)]}'
{"ironic/db/sqlalchemy/models.py":[{"author":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"change_message_id":"906165e39f83e5673dced0ffc3b34bf7e431f394","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    type \u003d list"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class IronicBase(models.TimestampMixin,"},{"line_number":92,"context_line":"                 models.ModelBase):"},{"line_number":93,"context_line":"    #FIXME(akruilin): remove `created_at` and `updated_at` attributes, when"},{"line_number":94,"context_line":"    # ironic and oslo.db will use timeutils from one place (oslo.utils)."}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_6d1bac1d","line":91,"updated":"2014-08-06 14:03:51.000000000","message":"As the commit message says we should not use TimestampMixin which is still here. Shouldn\u0027t it be removed? I can see no reason for leaving it because it only mixes in created_at and updated_at.","commit_id":"0953f5bafa239afee85f421e21c5906f8e3d374b"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"d12a0e7ca6b1f2872973b7dfafe19787f6fc186b","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    type \u003d list"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class IronicBase(models.TimestampMixin,"},{"line_number":92,"context_line":"                 models.ModelBase):"},{"line_number":93,"context_line":"    #FIXME(akruilin): remove `created_at` and `updated_at` attributes, when"},{"line_number":94,"context_line":"    # ironic and oslo.db will use timeutils from one place (oslo.utils)."}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_0d05d078","line":91,"in_reply_to":"baada198_6d1bac1d","updated":"2014-08-06 14:10:31.000000000","message":"reasons why I don\u0027t remove it:\n 1. ironic and oslo.db in near future will use oslo.utils\n 2. this line recalls that models.TimestampMixin should be used instead of custom `created_at` and `updated_at` properties.\n\nBut I understand that commit message and this line is differs, so i\u0027ll remove models.TimestampMixin in next patch-set.:)","commit_id":"0953f5bafa239afee85f421e21c5906f8e3d374b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"363e3feda6de1fde0f2b6afeeaf72fdc465c8258","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from sqlalchemy.types import TypeDecorator, TEXT"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from ironic.common import paths"},{"line_number":34,"context_line":"from ironic.openstack.common import timeutils"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"sql_opts \u003d ["},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027mysql_engine\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_2c46f97e","line":34,"updated":"2014-08-07 08:34:47.000000000","message":"from oslo.utils import timeutils\n\nThe commit https://review.openstack.org/#/c/110596 has just been approved and introduced oslo.utils, so this will need to be updated","commit_id":"8a55166c7ce5ad266ace6d1ca7905c0f35ca5504"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"5d1f3963a16bba18b4140a7c1463f845c7b57c6f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from sqlalchemy.types import TypeDecorator, TEXT"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from ironic.common import paths"},{"line_number":34,"context_line":"from ironic.openstack.common import timeutils"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"sql_opts \u003d ["},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027mysql_engine\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_a72142ff","line":34,"in_reply_to":"baada198_2c46f97e","updated":"2014-08-07 08:54:58.000000000","message":"Done","commit_id":"8a55166c7ce5ad266ace6d1ca7905c0f35ca5504"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"f427d04d587550f973fe467a7a56a19902c21ef7","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from sqlalchemy.types import TypeDecorator, TEXT"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from ironic.common import paths"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"sql_opts \u003d ["},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027mysql_engine\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_df59932a","side":"PARENT","line":34,"updated":"2014-08-07 13:53:14.000000000","message":"nit: unrelated change","commit_id":"d04cc3d1af1c00ef80a534c0c370e05a670dab4b"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"bfb7b90283eaa99b6272cc767c257c6a26ada3ad","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from sqlalchemy.types import TypeDecorator, TEXT"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from ironic.common import paths"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"sql_opts \u003d ["},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027mysql_engine\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_022e52ab","side":"PARENT","line":34,"in_reply_to":"baada198_a25f660f","updated":"2014-08-07 14:44:29.000000000","message":"it is already fixed in next patch-set.","commit_id":"d04cc3d1af1c00ef80a534c0c370e05a670dab4b"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"7efc7ae115e5d0d1a67abb048aa90ae6ac321d67","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from sqlalchemy.types import TypeDecorator, TEXT"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from ironic.common import paths"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"sql_opts \u003d ["},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027mysql_engine\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_a25f660f","side":"PARENT","line":34,"in_reply_to":"baada198_df59932a","updated":"2014-08-07 14:20:24.000000000","message":"oops:) i will return this line in patch related with reusing TimestampMixin from oslo.db. ok?","commit_id":"d04cc3d1af1c00ef80a534c0c370e05a670dab4b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7364ea90656c33fbc85b69336c5137f1b86d3767","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    # FIXME(akruilin): remove `created_at` and `updated_at` attributes and use"},{"line_number":94,"context_line":"    # TimestampMixin from oslo.db.sqlalchemy.models instead, when"},{"line_number":95,"context_line":"    # ironic and oslo.db will use timeutils from one place (oslo.utils)."},{"line_number":96,"context_line":"    # Related patch in oslo.db : https://review.openstack.org/#/c/111701/"},{"line_number":97,"context_line":"    created_at \u003d Column(DateTime, default\u003dlambda: timeutils.utcnow())"},{"line_number":98,"context_line":"    updated_at \u003d Column(DateTime, onupdate\u003dlambda: timeutils.utcnow())"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_0e41060a","line":96,"updated":"2014-08-08 06:20:49.000000000","message":"Please report a bug to track this","commit_id":"c841c29e5eeb31842459b0fcc4ea70bbb4d60b70"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"37739498866cdf21f1f30742d6970eea6eda8a71","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    # FIXME(akruilin): remove `created_at` and `updated_at` attributes and use"},{"line_number":94,"context_line":"    # TimestampMixin from oslo.db.sqlalchemy.models instead, when"},{"line_number":95,"context_line":"    # ironic and oslo.db will use timeutils from one place (oslo.utils)."},{"line_number":96,"context_line":"    # Related patch in oslo.db : https://review.openstack.org/#/c/111701/"},{"line_number":97,"context_line":"    created_at \u003d Column(DateTime, default\u003dlambda: timeutils.utcnow())"},{"line_number":98,"context_line":"    updated_at \u003d Column(DateTime, onupdate\u003dlambda: timeutils.utcnow())"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_8847c779","line":96,"in_reply_to":"baada198_0e41060a","updated":"2014-08-08 08:51:34.000000000","message":"Dmitry, I don\u0027t think this is a bug. `olso.db` team will not merge some critical changes until they will be sure that changes are safe for all projects.\n\nIt seems to me that is only another way of using timeutils.\nBut if you insist, I\u0027ll report a bug in ironic or in oslo.db :)","commit_id":"c841c29e5eeb31842459b0fcc4ea70bbb4d60b70"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06a57ce388f384b09951f1248bd627095d31456b","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    # FIXME(akruilin): remove `created_at` and `updated_at` attributes and use"},{"line_number":94,"context_line":"    # TimestampMixin from oslo.db.sqlalchemy.models instead, when"},{"line_number":95,"context_line":"    # ironic and oslo.db will use timeutils from one place (oslo.utils)."},{"line_number":96,"context_line":"    # Related patch in oslo.db : https://review.openstack.org/#/c/111701/"},{"line_number":97,"context_line":"    created_at \u003d Column(DateTime, default\u003dlambda: timeutils.utcnow())"},{"line_number":98,"context_line":"    updated_at \u003d Column(DateTime, onupdate\u003dlambda: timeutils.utcnow())"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_d28a4119","line":96,"in_reply_to":"baada198_22925258","updated":"2014-08-08 13:16:34.000000000","message":"Done","commit_id":"c841c29e5eeb31842459b0fcc4ea70bbb4d60b70"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7d805f3ad61184a5c6e473443b4ed3ef161a7717","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    # FIXME(akruilin): remove `created_at` and `updated_at` attributes and use"},{"line_number":94,"context_line":"    # TimestampMixin from oslo.db.sqlalchemy.models instead, when"},{"line_number":95,"context_line":"    # ironic and oslo.db will use timeutils from one place (oslo.utils)."},{"line_number":96,"context_line":"    # Related patch in oslo.db : https://review.openstack.org/#/c/111701/"},{"line_number":97,"context_line":"    created_at \u003d Column(DateTime, default\u003dlambda: timeutils.utcnow())"},{"line_number":98,"context_line":"    updated_at \u003d Column(DateTime, onupdate\u003dlambda: timeutils.utcnow())"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_22925258","line":96,"in_reply_to":"baada198_8847c779","updated":"2014-08-08 11:38:34.000000000","message":"FIXME in the code is a good reason to file a bug, so that we don\u0027t forget about it :) please do.","commit_id":"c841c29e5eeb31842459b0fcc4ea70bbb4d60b70"}]}