)]}'
{"ironic/objects/port.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"14f5dae7d074662aba6c102b6c2ea5a7fd036415","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def create(self, context\u003dNone):"},{"line_number":111,"context_line":"        \"\"\"Create a Port record in the DB."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        Column-wise updates will be made based on the result of"},{"line_number":114,"context_line":"        self.what_changed(). If target_power_state is provided,"},{"line_number":115,"context_line":"        it will be checked against the in-database copy of the"},{"line_number":116,"context_line":"        port before updates are made."}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_0e2f2df6","line":113,"updated":"2014-08-08 17:25:37.000000000","message":"This makes it sound like this method does an UPDATE, when it should be an INSERT, yes?","commit_id":"ea0a698e439fa558ed59c807487576cd029991e9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8065d2ac67cc72a0cda644f1a67390dd82b5b98a","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def create(self, context\u003dNone):"},{"line_number":111,"context_line":"        \"\"\"Create a Port record in the DB."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        Column-wise updates will be made based on the result of"},{"line_number":114,"context_line":"        self.what_changed(). If target_power_state is provided,"},{"line_number":115,"context_line":"        it will be checked against the in-database copy of the"},{"line_number":116,"context_line":"        port before updates are made."}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_acdb824c","line":113,"in_reply_to":"baada198_0e2f2df6","updated":"2014-08-11 09:50:23.000000000","message":"Yeah it\u0027s an insert, but by reading it indeed sounds like an update.\n\nNow reading it, I think that this text is making things more confused and maybe only \"Create a port record in the DB.\" should be explanatory enough for this method.\n\nI will update it, cheers for the catch!","commit_id":"ea0a698e439fa558ed59c807487576cd029991e9"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"14f5dae7d074662aba6c102b6c2ea5a7fd036415","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        \"\"\"Create a Port record in the DB."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        Column-wise updates will be made based on the result of"},{"line_number":114,"context_line":"        self.what_changed(). If target_power_state is provided,"},{"line_number":115,"context_line":"        it will be checked against the in-database copy of the"},{"line_number":116,"context_line":"        port before updates are made."},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_2e34f147","line":114,"updated":"2014-08-08 17:25:37.000000000","message":"Unless I\u0027m horribly mistaken, port objects shouldn\u0027t have a target_power_state? :)","commit_id":"ea0a698e439fa558ed59c807487576cd029991e9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8065d2ac67cc72a0cda644f1a67390dd82b5b98a","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        \"\"\"Create a Port record in the DB."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        Column-wise updates will be made based on the result of"},{"line_number":114,"context_line":"        self.what_changed(). If target_power_state is provided,"},{"line_number":115,"context_line":"        it will be checked against the in-database copy of the"},{"line_number":116,"context_line":"        port before updates are made."},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_ac1e225c","line":114,"in_reply_to":"baada198_2e34f147","updated":"2014-08-11 09:50:23.000000000","message":"Oops, no you\u0027re correct it was mostly a copy\u0026paste + find\u0026replace from nodes...","commit_id":"ea0a698e439fa558ed59c807487576cd029991e9"}]}