)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"e013829eecc6259e586f41c8c60f10292ae80fa8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"As of now only elilo.efi bootloader is supported."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"elilo.efi bootloader requires the configuration file to be named after the"},{"line_number":24,"context_line":"ip-address assigned by the DHCP server."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I0ad399b2207d7c66f6887e56470ba553b3c87b53"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7ac7a964_013674e7","line":24,"updated":"2014-08-15 05:45:17.000000000","message":"Could you please write blueprint URL?","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"701d1c100445591cf6eee8d10f2918e1c0eaba2d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"As of now only elilo.efi bootloader is supported."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"elilo.efi bootloader requires the configuration file to be named after the"},{"line_number":24,"context_line":"ip-address assigned by the DHCP server."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I0ad399b2207d7c66f6887e56470ba553b3c87b53"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1abeadc6_05b695d9","line":24,"in_reply_to":"7ac7a964_013674e7","updated":"2014-08-18 19:46:12.000000000","message":"+1\n\nImplements: blueprint uefi-boot-for-ironic","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"25f9b65e0e9ceff3817da4e97353c4460c7163d1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"As of now only elilo.efi bootloader is supported."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"elilo.efi bootloader requires the configuration file to be named after the"},{"line_number":24,"context_line":"ip-address assigned by the DHCP server."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I0ad399b2207d7c66f6887e56470ba553b3c87b53"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1abeadc6_0574f4cd","line":24,"in_reply_to":"7ac7a964_013674e7","updated":"2014-08-20 07:35:43.000000000","message":"I will update the commit message with blueprint url.\n\nThanks for pointing this out.","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"}],"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"25172ec53f5db2edd0e6ac7fb12068c200c61356","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#rpc_conn_pool_size\u003d30"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Qpid broker hostname. (string value)"},{"line_number":18,"context_line":"#qpid_hostname\u003dironic"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Qpid broker port. (integer value)"},{"line_number":21,"context_line":"#qpid_port\u003d5672"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1abeadc6_5dedbdc2","line":18,"updated":"2014-08-18 22:16:31.000000000","message":"This change will not pass tests.","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5d4362a62c796bab1dac295de562bf83ebcfea17","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#rpc_conn_pool_size\u003d30"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Qpid broker hostname. (string value)"},{"line_number":18,"context_line":"#qpid_hostname\u003dironic"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Qpid broker port. (integer value)"},{"line_number":21,"context_line":"#qpid_port\u003d5672"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7ac7a964_af083e92","line":18,"updated":"2014-08-15 13:19:15.000000000","message":"why is this change here?","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"25f9b65e0e9ceff3817da4e97353c4460c7163d1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#rpc_conn_pool_size\u003d30"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Qpid broker hostname. (string value)"},{"line_number":18,"context_line":"#qpid_hostname\u003dironic"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Qpid broker port. (integer value)"},{"line_number":21,"context_line":"#qpid_port\u003d5672"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1abeadc6_25f2d09a","line":18,"in_reply_to":"7ac7a964_af083e92","updated":"2014-08-20 07:35:43.000000000","message":"I did this change as part of recommendation by this script.\n/opt/stack/ironic/tools/config/generate_sample.sh\n\nReverted it back as per your comments.","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"25172ec53f5db2edd0e6ac7fb12068c200c61356","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# The RabbitMQ broker address where a single node is used."},{"line_number":74,"context_line":"# (string value)"},{"line_number":75,"context_line":"#rabbit_host\u003dironic"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# The RabbitMQ broker port where a single node is used."},{"line_number":78,"context_line":"# (integer value)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1abeadc6_bddb311a","line":75,"updated":"2014-08-18 22:16:31.000000000","message":"ditto","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5d4362a62c796bab1dac295de562bf83ebcfea17","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# The RabbitMQ broker address where a single node is used."},{"line_number":74,"context_line":"# (string value)"},{"line_number":75,"context_line":"#rabbit_host\u003dironic"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# The RabbitMQ broker port where a single node is used."},{"line_number":78,"context_line":"# (integer value)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7ac7a964_cfff3a66","line":75,"updated":"2014-08-15 13:19:15.000000000","message":"ditto","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"25f9b65e0e9ceff3817da4e97353c4460c7163d1","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# The RabbitMQ broker address where a single node is used."},{"line_number":74,"context_line":"# (string value)"},{"line_number":75,"context_line":"#rabbit_host\u003dironic"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# The RabbitMQ broker port where a single node is used."},{"line_number":78,"context_line":"# (integer value)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1abeadc6_652be8eb","line":75,"in_reply_to":"7ac7a964_cfff3a66","updated":"2014-08-20 07:35:43.000000000","message":"Done.","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5d4362a62c796bab1dac295de562bf83ebcfea17","unresolved":false,"context_lines":[{"line_number":1102,"context_line":""},{"line_number":1103,"context_line":"# Maximum size (in MiB) of cache for master images, including"},{"line_number":1104,"context_line":"# those in use. (integer value)"},{"line_number":1105,"context_line":"#image_cache_size\u003d1024"},{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":"# Maximum TTL (in minutes) for old master images in cache."},{"line_number":1108,"context_line":"# (integer value)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7ac7a964_4ff32a9e","line":1105,"updated":"2014-08-15 13:19:15.000000000","message":"ditto","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"25f9b65e0e9ceff3817da4e97353c4460c7163d1","unresolved":false,"context_lines":[{"line_number":1102,"context_line":""},{"line_number":1103,"context_line":"# Maximum size (in MiB) of cache for master images, including"},{"line_number":1104,"context_line":"# those in use. (integer value)"},{"line_number":1105,"context_line":"#image_cache_size\u003d1024"},{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":"# Maximum TTL (in minutes) for old master images in cache."},{"line_number":1108,"context_line":"# (integer value)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1abeadc6_85300458","line":1105,"in_reply_to":"7ac7a964_4ff32a9e","updated":"2014-08-20 07:35:43.000000000","message":"Done.","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"}],"ironic/common/exception.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b4375954346277194cf3964d5067fa38664bc515","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    message \u003d _(\"Update DHCP options on port: %(port_id)s failed.\")"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"class FailedToGetIPaddressOnPort(IronicException):"},{"line_number":226,"context_line":"    message \u003d _(\"Retrieve IP address on port: %(port_id)s failed.\")"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_981aa76d","line":225,"updated":"2014-08-28 03:25:32.000000000","message":"hmm. Probably FailedToGetIPAddressOnPort. (Uppercase \u0027A\u0027 for address.)","commit_id":"a37fa0788987ef058f9a696d07e2a65173694be7"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"768cfc87950cfaa809c26e307278fcc9726d6720","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    message \u003d _(\"Update DHCP options on port: %(port_id)s failed.\")"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"class FailedToGetIPaddressOnPort(IronicException):"},{"line_number":226,"context_line":"    message \u003d _(\"Retrieve IP address on port: %(port_id)s failed.\")"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_be174b44","line":225,"in_reply_to":"1abeadc6_981aa76d","updated":"2014-08-28 06:54:58.000000000","message":"Done","commit_id":"a37fa0788987ef058f9a696d07e2a65173694be7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b4375954346277194cf3964d5067fa38664bc515","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    message \u003d _(\"Retrieve IP address on port: %(port_id)s failed.\")"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"class InvalidIPv4address(IronicException):"},{"line_number":230,"context_line":"    message \u003d _(\"Invalid IPv4 address %(ip_address).\")"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_181e975f","line":229,"updated":"2014-08-28 03:25:32.000000000","message":"InvalidIPv4Address (Uppercase \u0027A\u0027 for address.)","commit_id":"a37fa0788987ef058f9a696d07e2a65173694be7"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"768cfc87950cfaa809c26e307278fcc9726d6720","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    message \u003d _(\"Retrieve IP address on port: %(port_id)s failed.\")"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"class InvalidIPv4address(IronicException):"},{"line_number":230,"context_line":"    message \u003d _(\"Invalid IPv4 address %(ip_address).\")"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_de27a7b4","line":229,"in_reply_to":"1abeadc6_181e975f","updated":"2014-08-28 06:54:58.000000000","message":"Done","commit_id":"a37fa0788987ef058f9a696d07e2a65173694be7"}],"ironic/common/neutron.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5d4362a62c796bab1dac295de562bf83ebcfea17","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        try:"},{"line_number":134,"context_line":"            neutron_port \u003d self.client.show_port(port_id).get(\u0027port\u0027)"},{"line_number":135,"context_line":"        except neutron_client_exc.NeutronClientException:"},{"line_number":136,"context_line":"            LOG.exception(_(\"Failed to Get IP address on Neutron port %s.\""},{"line_number":137,"context_line":"                           ), port_id)"},{"line_number":138,"context_line":"            raise exception.FailedToGetIPaddressOnPort(port_id\u003dport_id)"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7ac7a964_ef395642","line":136,"updated":"2014-08-15 13:19:15.000000000","message":"should be using _LE instead of _","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"25f9b65e0e9ceff3817da4e97353c4460c7163d1","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        try:"},{"line_number":134,"context_line":"            neutron_port \u003d self.client.show_port(port_id).get(\u0027port\u0027)"},{"line_number":135,"context_line":"        except neutron_client_exc.NeutronClientException:"},{"line_number":136,"context_line":"            LOG.exception(_(\"Failed to Get IP address on Neutron port %s.\""},{"line_number":137,"context_line":"                           ), port_id)"},{"line_number":138,"context_line":"            raise exception.FailedToGetIPaddressOnPort(port_id\u003dport_id)"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_a50c2096","line":136,"in_reply_to":"7ac7a964_ef395642","updated":"2014-08-20 07:35:43.000000000","message":"Done the changes only to my code. Rest of the code will still be using _ instead of _LW or _LE","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"25172ec53f5db2edd0e6ac7fb12068c200c61356","unresolved":false,"context_lines":[{"line_number":212,"context_line":"    :param task: a TaskManager instance."},{"line_number":213,"context_line":"    :param port_id: ironic Node\u0027s port UUID."},{"line_number":214,"context_line":"    :returns:  Neutron port ip address associated with Node\u0027s port."},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    \"\"\""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    port_ip_address \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_bd2091f8","line":215,"updated":"2014-08-18 22:16:31.000000000","message":"we should note that we could raise FailedToGetIPaddressOnPort here.","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"25f9b65e0e9ceff3817da4e97353c4460c7163d1","unresolved":false,"context_lines":[{"line_number":212,"context_line":"    :param task: a TaskManager instance."},{"line_number":213,"context_line":"    :param port_id: ironic Node\u0027s port UUID."},{"line_number":214,"context_line":"    :returns:  Neutron port ip address associated with Node\u0027s port."},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    \"\"\""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    port_ip_address \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_77a0cd90","line":215,"in_reply_to":"1abeadc6_bd2091f8","updated":"2014-08-20 07:35:43.000000000","message":"Done.","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5d4362a62c796bab1dac295de562bf83ebcfea17","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    vifs \u003d get_node_vif_ids(task)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    if not vifs:"},{"line_number":222,"context_line":"        LOG.warning(_(\"No VIFs found for node %(node)s when attempting to \""},{"line_number":223,"context_line":"                      \"get port ip address.\"),"},{"line_number":224,"context_line":"                      {\u0027node\u0027: task.node.uuid})"},{"line_number":225,"context_line":"        raise exception.FailedToGetIPaddressOnPort(port_id\u003dport_id.uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ac7a964_4f4a4ac6","line":222,"updated":"2014-08-15 13:19:15.000000000","message":"should be using _LW instead of _","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"25f9b65e0e9ceff3817da4e97353c4460c7163d1","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    vifs \u003d get_node_vif_ids(task)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    if not vifs:"},{"line_number":222,"context_line":"        LOG.warning(_(\"No VIFs found for node %(node)s when attempting to \""},{"line_number":223,"context_line":"                      \"get port ip address.\"),"},{"line_number":224,"context_line":"                      {\u0027node\u0027: task.node.uuid})"},{"line_number":225,"context_line":"        raise exception.FailedToGetIPaddressOnPort(port_id\u003dport_id.uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_e525380b","line":222,"in_reply_to":"7ac7a964_4f4a4ac6","updated":"2014-08-20 07:35:43.000000000","message":"Done.","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5d4362a62c796bab1dac295de562bf83ebcfea17","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    try:"},{"line_number":232,"context_line":"        port_ip_address \u003d api.get_fixed_ip_address(port_vif)"},{"line_number":233,"context_line":"    except exception.FailedToGetIPaddressOnPort:"},{"line_number":234,"context_line":"        LOG.exception(_(\"Failed to Get IP address on Neutron port %s.\""},{"line_number":235,"context_line":"                       ), port_id)"},{"line_number":236,"context_line":"        raise exception.FailedToGetIPaddressOnPort(port_id\u003dport_id)"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7ac7a964_8f1382b7","line":234,"updated":"2014-08-15 13:19:15.000000000","message":"should be using _LE instead of _","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"25f9b65e0e9ceff3817da4e97353c4460c7163d1","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    try:"},{"line_number":232,"context_line":"        port_ip_address \u003d api.get_fixed_ip_address(port_vif)"},{"line_number":233,"context_line":"    except exception.FailedToGetIPaddressOnPort:"},{"line_number":234,"context_line":"        LOG.exception(_(\"Failed to Get IP address on Neutron port %s.\""},{"line_number":235,"context_line":"                       ), port_id)"},{"line_number":236,"context_line":"        raise exception.FailedToGetIPaddressOnPort(port_id\u003dport_id)"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_451d0cbd","line":234,"in_reply_to":"7ac7a964_8f1382b7","updated":"2014-08-20 07:35:43.000000000","message":"Done.","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f0eec29d32bf8a8bc2a4f9f9e793c557418119aa","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            raise exception.FailedToGetIPaddressOnPort(port_id\u003dport_id)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        fixed_ips \u003d neutron_port.get(\u0027fixed_ips\u0027)"},{"line_number":146,"context_line":"        ip_address \u003d fixed_ips[0].get(\u0027ip_address\u0027, None)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        return ip_address"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_d7fcfc74","line":146,"updated":"2014-08-20 15:50:40.000000000","message":"It seems to me that testing if fixed_ips is actually a list and/or is populated is a good idea, I\u0027m not complete sure cause I don\u0027t know much neutron but I\u0027d like to avoid IndexError\u0027s when possible.","commit_id":"49bce496a644da940ef36d669d36e24103fdbc8c"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"05f45fb622afb8a1aa777bab554afbd8dfaa5adb","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            raise exception.FailedToGetIPaddressOnPort(port_id\u003dport_id)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        fixed_ips \u003d neutron_port.get(\u0027fixed_ips\u0027)"},{"line_number":146,"context_line":"        ip_address \u003d fixed_ips[0].get(\u0027ip_address\u0027, None)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        return ip_address"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_b85043d5","line":146,"in_reply_to":"1abeadc6_d7fcfc74","updated":"2014-08-20 21:01:13.000000000","message":"sure. I will add a check on fixed_ips before accessing the variable.\nThanks.","commit_id":"49bce496a644da940ef36d669d36e24103fdbc8c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"49ad47af668d659c545c5bc9aa8bdb7403d808ad","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        fixed_ips \u003d neutron_port.get(\u0027fixed_ips\u0027)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if type(fixed_ips) is list and len(fixed_ips) \u003e 0:"},{"line_number":148,"context_line":"            ip_address \u003d fixed_ips[0].get(\u0027ip_address\u0027, None)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        return ip_address"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_47b9592d","line":147,"updated":"2014-08-26 15:48:26.000000000","message":"nit: isinstance(fixed_ips, list)","commit_id":"2e86fb7a7018a848c4a4ac0f712a51c332b66be4"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"46e446a926a2a13fb5135e3a3dd49618dd58807f","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        fixed_ips \u003d neutron_port.get(\u0027fixed_ips\u0027)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if type(fixed_ips) is list and len(fixed_ips) \u003e 0:"},{"line_number":148,"context_line":"            ip_address \u003d fixed_ips[0].get(\u0027ip_address\u0027, None)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        return ip_address"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_8e3a8fcb","line":147,"in_reply_to":"1abeadc6_47b9592d","updated":"2014-08-27 05:53:58.000000000","message":"Done.","commit_id":"2e86fb7a7018a848c4a4ac0f712a51c332b66be4"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"49ad47af668d659c545c5bc9aa8bdb7403d808ad","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        fixed_ips \u003d neutron_port.get(\u0027fixed_ips\u0027)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if type(fixed_ips) is list and len(fixed_ips) \u003e 0:"},{"line_number":148,"context_line":"            ip_address \u003d fixed_ips[0].get(\u0027ip_address\u0027, None)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        return ip_address"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_1a1b341d","line":148,"updated":"2014-08-26 15:48:26.000000000","message":"Question: Is that OK to use only the first ip address? as it\u0027s a list I suppose we could possibly have more than one there.\n\nThis function seems to be called by the methods generating the PXE config files, we do something similar when using MAC addresses, but we generate 1 PXE config per MAC address (actually we generate one and then create a symlink for the others), wouldn\u0027t it something you would like to do here to?\n\nreturn the list of IPs and create a config for each IP?","commit_id":"2e86fb7a7018a848c4a4ac0f712a51c332b66be4"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"46e446a926a2a13fb5135e3a3dd49618dd58807f","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        fixed_ips \u003d neutron_port.get(\u0027fixed_ips\u0027)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if type(fixed_ips) is list and len(fixed_ips) \u003e 0:"},{"line_number":148,"context_line":"            ip_address \u003d fixed_ips[0].get(\u0027ip_address\u0027, None)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        return ip_address"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_ce6c879f","line":148,"in_reply_to":"1abeadc6_18a33c9f","updated":"2014-08-27 05:53:58.000000000","message":"Sure, I will put the reason for picking the first fixed_ip in the comments.","commit_id":"2e86fb7a7018a848c4a4ac0f712a51c332b66be4"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3f222ee2e0d3a0d96579694714d1ee7c9da2518a","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        fixed_ips \u003d neutron_port.get(\u0027fixed_ips\u0027)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if type(fixed_ips) is list and len(fixed_ips) \u003e 0:"},{"line_number":148,"context_line":"            ip_address \u003d fixed_ips[0].get(\u0027ip_address\u0027, None)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        return ip_address"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_18a33c9f","line":148,"in_reply_to":"1abeadc6_1a1b341d","updated":"2014-08-26 16:40:04.000000000","message":"Also, even if this is the right way to do it (picking the first from the list). Do you mind adding a comment here explaining why?","commit_id":"2e86fb7a7018a848c4a4ac0f712a51c332b66be4"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"46e446a926a2a13fb5135e3a3dd49618dd58807f","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        fixed_ips \u003d neutron_port.get(\u0027fixed_ips\u0027)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if type(fixed_ips) is list and len(fixed_ips) \u003e 0:"},{"line_number":148,"context_line":"            ip_address \u003d fixed_ips[0].get(\u0027ip_address\u0027, None)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        return ip_address"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_6e5c53ee","line":148,"in_reply_to":"1abeadc6_1a1b341d","updated":"2014-08-27 05:53:58.000000000","message":"i think it should be ok to use the first fixed_ip, as the nova will allocate the network resource (fixed_ip) only once to the instance network port. For each network port of the node, nova will allocate one fixed ip, by calling allocate_for_instance() only once.\n\nSo In our case, ip-address assigned for every port of the node, we are going to create symlinks to the same config file.","commit_id":"2e86fb7a7018a848c4a4ac0f712a51c332b66be4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b4375954346277194cf3964d5067fa38664bc515","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        \"\"\"Get a port\u0027s fixed ip address."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        :param port_id: Neutron port id."},{"line_number":134,"context_line":"        :returns: Neutron port ip address."},{"line_number":135,"context_line":"        :raises: FailedToGetIPAddressonPort"},{"line_number":136,"context_line":"        \"\"\""},{"line_number":137,"context_line":"        ip_address \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_387193a8","line":134,"updated":"2014-08-28 03:25:32.000000000","message":"looks like it can also return None.","commit_id":"a37fa0788987ef058f9a696d07e2a65173694be7"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"768cfc87950cfaa809c26e307278fcc9726d6720","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        \"\"\"Get a port\u0027s fixed ip address."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        :param port_id: Neutron port id."},{"line_number":134,"context_line":"        :returns: Neutron port ip address."},{"line_number":135,"context_line":"        :raises: FailedToGetIPAddressonPort"},{"line_number":136,"context_line":"        \"\"\""},{"line_number":137,"context_line":"        ip_address \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_de908745","line":134,"in_reply_to":"1abeadc6_387193a8","updated":"2014-08-28 06:54:58.000000000","message":"I will raise exception if no ip address is assigned to the port, so that we can avoid returning None.","commit_id":"a37fa0788987ef058f9a696d07e2a65173694be7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b4375954346277194cf3964d5067fa38664bc515","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    :param task: a TaskManager instance."},{"line_number":223,"context_line":"    :param port_id: ironic Node\u0027s port UUID."},{"line_number":224,"context_line":"    :returns:  Neutron port ip address associated with Node\u0027s port."},{"line_number":225,"context_line":"    :raises: FailedToGetIPAddressonPort"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    \"\"\""},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_18a3f700","line":225,"updated":"2014-08-28 03:25:32.000000000","message":"there\u0027s a typo in that exception","commit_id":"a37fa0788987ef058f9a696d07e2a65173694be7"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"768cfc87950cfaa809c26e307278fcc9726d6720","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    :param task: a TaskManager instance."},{"line_number":223,"context_line":"    :param port_id: ironic Node\u0027s port UUID."},{"line_number":224,"context_line":"    :returns:  Neutron port ip address associated with Node\u0027s port."},{"line_number":225,"context_line":"    :raises: FailedToGetIPAddressonPort"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    \"\"\""},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_3e0fbb89","line":225,"in_reply_to":"1abeadc6_18a3f700","updated":"2014-08-28 06:54:58.000000000","message":"Done.","commit_id":"a37fa0788987ef058f9a696d07e2a65173694be7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b4375954346277194cf3964d5067fa38664bc515","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    if not vifs:"},{"line_number":233,"context_line":"        LOG.warning(_LW(\"No VIFs found for node %(node)s when attempting to \""},{"line_number":234,"context_line":"                      \"get port ip address.\"),"},{"line_number":235,"context_line":"                      {\u0027node\u0027: task.node.uuid})"},{"line_number":236,"context_line":"        raise exception.FailedToGetIPaddressOnPort(port_id\u003dport_id.uuid)"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_58b00f43","line":234,"updated":"2014-08-28 03:25:32.000000000","message":"nit: \u0027ip\u0027 -\u003e \u0027IP\u0027","commit_id":"a37fa0788987ef058f9a696d07e2a65173694be7"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"768cfc87950cfaa809c26e307278fcc9726d6720","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    if not vifs:"},{"line_number":233,"context_line":"        LOG.warning(_LW(\"No VIFs found for node %(node)s when attempting to \""},{"line_number":234,"context_line":"                      \"get port ip address.\"),"},{"line_number":235,"context_line":"                      {\u0027node\u0027: task.node.uuid})"},{"line_number":236,"context_line":"        raise exception.FailedToGetIPaddressOnPort(port_id\u003dport_id.uuid)"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_7e24d30c","line":234,"in_reply_to":"1abeadc6_58b00f43","updated":"2014-08-28 06:54:58.000000000","message":"Done","commit_id":"a37fa0788987ef058f9a696d07e2a65173694be7"}],"ironic/common/pxe_utils.py":[{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"25172ec53f5db2edd0e6ac7fb12068c200c61356","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"def _get_pxe_ip_address_path(ip_address):"},{"line_number":117,"context_line":"    \"\"\"Convert a ip address into a PXE config file name."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    :param ip_address: An ipv4 address string in the format n.n.n.n ."},{"line_number":120,"context_line":"    :returns: the path to the config file."}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_3d5ba188","line":117,"updated":"2014-08-18 22:16:31.000000000","message":"what about ipv6 addresses?","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"25f9b65e0e9ceff3817da4e97353c4460c7163d1","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"def _get_pxe_ip_address_path(ip_address):"},{"line_number":117,"context_line":"    \"\"\"Convert a ip address into a PXE config file name."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    :param ip_address: An ipv4 address string in the format n.n.n.n ."},{"line_number":120,"context_line":"    :returns: the path to the config file."}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_b71d05c0","line":117,"in_reply_to":"1abeadc6_3d5ba188","updated":"2014-08-20 07:35:43.000000000","message":"elilo bootloader works only with ipv4 address. we may not support if dhcp returns ipv6 address. \nI think it is better I should specifically check for ipv6 and returns an error message.","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f0eec29d32bf8a8bc2a4f9f9e793c557418119aa","unresolved":false,"context_lines":[{"line_number":90,"context_line":"def _link_ip_address_pxe_configs(task):"},{"line_number":91,"context_line":"    \"\"\"Link a file in the PXE config directory for the ip address assigned"},{"line_number":92,"context_line":"    to each port. So whichever port boots first, they\u0027ll get the same PXE"},{"line_number":93,"context_line":"    config."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    :param task: A TaskManager instance."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_d2e5eadc","line":93,"updated":"2014-08-20 15:50:40.000000000","message":"nit: format as per PEP 257\n\nhttp://legacy.python.org/dev/peps/pep-0257/#multi-line-docstrings","commit_id":"49bce496a644da940ef36d669d36e24103fdbc8c"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"05f45fb622afb8a1aa777bab554afbd8dfaa5adb","unresolved":false,"context_lines":[{"line_number":90,"context_line":"def _link_ip_address_pxe_configs(task):"},{"line_number":91,"context_line":"    \"\"\"Link a file in the PXE config directory for the ip address assigned"},{"line_number":92,"context_line":"    to each port. So whichever port boots first, they\u0027ll get the same PXE"},{"line_number":93,"context_line":"    config."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    :param task: A TaskManager instance."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_989d4769","line":93,"in_reply_to":"1abeadc6_d2e5eadc","updated":"2014-08-20 21:01:13.000000000","message":"I will fix it as per the PEP 257 format.","commit_id":"49bce496a644da940ef36d669d36e24103fdbc8c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ab3dcac65fcba9457b092588f0e42d38af34d1e9","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    return dhcp_opts"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"def get_node_capability(node, capability):"},{"line_number":253,"context_line":"    \"\"\"Returns \u0027capability\u0027 value from node\u0027s \u0027capabilities\u0027 property."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    :param node: Node object."}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_5a53ec38","line":252,"updated":"2014-08-26 16:04:27.000000000","message":"I\u0027ve seem this method being used for another drivers[1]\n\nmaybe we should just put this method in a common place?\n\n[1] https://review.openstack.org/#/c/116561/2/ironic/drivers/modules/ilo/common.py","commit_id":"2e86fb7a7018a848c4a4ac0f712a51c332b66be4"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"46e446a926a2a13fb5135e3a3dd49618dd58807f","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    return dhcp_opts"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"def get_node_capability(node, capability):"},{"line_number":253,"context_line":"    \"\"\"Returns \u0027capability\u0027 value from node\u0027s \u0027capabilities\u0027 property."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    :param node: Node object."}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_eec30355","line":252,"in_reply_to":"1abeadc6_5a53ec38","updated":"2014-08-27 05:53:58.000000000","message":"Since this method is in common/pxe_utils, I will use this method in the above patch and make this patch as its dependent.","commit_id":"2e86fb7a7018a848c4a4ac0f712a51c332b66be4"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"49ad47af668d659c545c5bc9aa8bdb7403d808ad","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                LOG.warn(_LW(\"Ignoring malformed capability \u0027%s\u0027. \""},{"line_number":270,"context_line":"                    \"Format should be \u0027key:val\u0027.\") % node_capability)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    return None"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"def validate_boot_mode_capability(node):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_e7850508","line":272,"updated":"2014-08-26 15:48:26.000000000","message":"nit: return None is not needed, once the function execution body ends it will return None by default","commit_id":"2e86fb7a7018a848c4a4ac0f712a51c332b66be4"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"46e446a926a2a13fb5135e3a3dd49618dd58807f","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                LOG.warn(_LW(\"Ignoring malformed capability \u0027%s\u0027. \""},{"line_number":270,"context_line":"                    \"Format should be \u0027key:val\u0027.\") % node_capability)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    return None"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"def validate_boot_mode_capability(node):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_0ea2ffad","line":272,"in_reply_to":"1abeadc6_e7850508","updated":"2014-08-27 05:53:58.000000000","message":"Done.","commit_id":"2e86fb7a7018a848c4a4ac0f712a51c332b66be4"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"49ad47af668d659c545c5bc9aa8bdb7403d808ad","unresolved":false,"context_lines":[{"line_number":282,"context_line":"    \"\"\""},{"line_number":283,"context_line":"    boot_mode \u003d get_node_capability(node, \u0027boot_mode\u0027)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    if boot_mode not in [None, \u0027bios\u0027, \u0027uefi\u0027]:"},{"line_number":286,"context_line":"        raise exception.InvalidParameterValue(_LE(\"Invalid boot_mode \""},{"line_number":287,"context_line":"                          \"parameter \u0027%s\u0027.\") % boot_mode)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_07a3e19e","line":285,"updated":"2014-08-26 15:48:26.000000000","message":"nit:\n\n if boot_mode and boot_mode not in [\u0027bios\u0027, \u0027uefi\u0027]:\n    raise","commit_id":"2e86fb7a7018a848c4a4ac0f712a51c332b66be4"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"46e446a926a2a13fb5135e3a3dd49618dd58807f","unresolved":false,"context_lines":[{"line_number":282,"context_line":"    \"\"\""},{"line_number":283,"context_line":"    boot_mode \u003d get_node_capability(node, \u0027boot_mode\u0027)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    if boot_mode not in [None, \u0027bios\u0027, \u0027uefi\u0027]:"},{"line_number":286,"context_line":"        raise exception.InvalidParameterValue(_LE(\"Invalid boot_mode \""},{"line_number":287,"context_line":"                          \"parameter \u0027%s\u0027.\") % boot_mode)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_8e952f42","line":285,"in_reply_to":"1abeadc6_07a3e19e","updated":"2014-08-27 05:53:58.000000000","message":"Done.","commit_id":"2e86fb7a7018a848c4a4ac0f712a51c332b66be4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b4375954346277194cf3964d5067fa38664bc515","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    \"\"\""},{"line_number":96,"context_line":"    pxe_config_file_path \u003d get_pxe_config_file_path(task.node.uuid)"},{"line_number":97,"context_line":"    for port in task.ports:"},{"line_number":98,"context_line":"        port_ip_address \u003d neutron.get_port_ip_address(task, port)"},{"line_number":99,"context_line":"        ip_address_path \u003d _get_pxe_ip_address_path(port_ip_address)"},{"line_number":100,"context_line":"        utils.unlink_without_raise(ip_address_path)"},{"line_number":101,"context_line":"        utils.create_link_without_raise(pxe_config_file_path, ip_address_path)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_d8d17f58","line":98,"updated":"2014-08-28 03:25:32.000000000","message":"this could raise an exception. If that happens, do you want to undo anything, or to continue/try with other ports, or ??","commit_id":"a37fa0788987ef058f9a696d07e2a65173694be7"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"768cfc87950cfaa809c26e307278fcc9726d6720","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    \"\"\""},{"line_number":96,"context_line":"    pxe_config_file_path \u003d get_pxe_config_file_path(task.node.uuid)"},{"line_number":97,"context_line":"    for port in task.ports:"},{"line_number":98,"context_line":"        port_ip_address \u003d neutron.get_port_ip_address(task, port)"},{"line_number":99,"context_line":"        ip_address_path \u003d _get_pxe_ip_address_path(port_ip_address)"},{"line_number":100,"context_line":"        utils.unlink_without_raise(ip_address_path)"},{"line_number":101,"context_line":"        utils.create_link_without_raise(pxe_config_file_path, ip_address_path)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_e43db690","line":98,"in_reply_to":"1abeadc6_d8d17f58","updated":"2014-08-28 06:54:58.000000000","message":"Added error handling code for catching exceptions.","commit_id":"a37fa0788987ef058f9a696d07e2a65173694be7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8902bbd11b2663d099b65a67969b7c709131caf9","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        try:"},{"line_number":100,"context_line":"            api \u003d dhcp_factory.DHCPFactory(token\u003dtask.context.auth_token)"},{"line_number":101,"context_line":"            api \u003d api.provider"},{"line_number":102,"context_line":"            port_ip_address \u003d api.get_port_ip_address(task, port)"},{"line_number":103,"context_line":"            ip_address_path \u003d _get_pxe_ip_address_path(port_ip_address)"},{"line_number":104,"context_line":"        except (exception.FailedToGetIPAddressOnPort,"},{"line_number":105,"context_line":"                exception.InvalidIPv4Address):"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_7b4d5a72","line":102,"updated":"2014-09-01 08:41:24.000000000","message":"nit:\n\nport_ip_address \u003d api.provider.get_port_ip_address(task, port)","commit_id":"15438e2343a167d8e89fb492aed7eea0954d3c4e"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"454c3c11973bb01404e25bfd07431d8da7211ae8","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        try:"},{"line_number":100,"context_line":"            api \u003d dhcp_factory.DHCPFactory(token\u003dtask.context.auth_token)"},{"line_number":101,"context_line":"            api \u003d api.provider"},{"line_number":102,"context_line":"            port_ip_address \u003d api.get_port_ip_address(task, port)"},{"line_number":103,"context_line":"            ip_address_path \u003d _get_pxe_ip_address_path(port_ip_address)"},{"line_number":104,"context_line":"        except (exception.FailedToGetIPAddressOnPort,"},{"line_number":105,"context_line":"                exception.InvalidIPv4Address):"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_6cbafee2","line":102,"in_reply_to":"fa98f980_7b4d5a72","updated":"2014-09-01 11:46:38.000000000","message":"done","commit_id":"15438e2343a167d8e89fb492aed7eea0954d3c4e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5accfe1832510b20473c1dba1c9637683467438d","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    if failures:"},{"line_number":113,"context_line":"        if len(failures) \u003d\u003d len(task.ports):"},{"line_number":114,"context_line":"            raise exception.FailedToGetIPAddressOnPort(_("},{"line_number":115,"context_line":"                \"Failed to get IP address for any port on node %s.\") %"},{"line_number":116,"context_line":"                task.node.uuid)"},{"line_number":117,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_1b744ece","line":114,"updated":"2014-09-01 09:03:57.000000000","message":"It raises an exception, so it should be added to docstring.","commit_id":"15438e2343a167d8e89fb492aed7eea0954d3c4e"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"454c3c11973bb01404e25bfd07431d8da7211ae8","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    if failures:"},{"line_number":113,"context_line":"        if len(failures) \u003d\u003d len(task.ports):"},{"line_number":114,"context_line":"            raise exception.FailedToGetIPAddressOnPort(_("},{"line_number":115,"context_line":"                \"Failed to get IP address for any port on node %s.\") %"},{"line_number":116,"context_line":"                task.node.uuid)"},{"line_number":117,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_4cc53a5a","line":114,"in_reply_to":"fa98f980_1b744ece","updated":"2014-09-01 11:46:38.000000000","message":"Done","commit_id":"15438e2343a167d8e89fb492aed7eea0954d3c4e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8902bbd11b2663d099b65a67969b7c709131caf9","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        #uefi config files"},{"line_number":229,"context_line":"        for port in task.ports:"},{"line_number":230,"context_line":"            api \u003d dhcp_factory.DHCPFactory(token\u003dtask.context.auth_token)"},{"line_number":231,"context_line":"            port_ip_address \u003d api.get_port_ip_address(task, port)"},{"line_number":232,"context_line":"            ip_address_path \u003d _get_pxe_ip_address_path(port_ip_address)"},{"line_number":233,"context_line":"            utils.unlink_without_raise(ip_address_path)"},{"line_number":234,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_db2566ac","line":231,"updated":"2014-09-01 08:41:24.000000000","message":"This is going to fail, I think you meant api.provider.get_port_ip_address\n\nThat also means that we don\u0027t have enough tests for the clean_up_pxe_config() method","commit_id":"15438e2343a167d8e89fb492aed7eea0954d3c4e"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"454c3c11973bb01404e25bfd07431d8da7211ae8","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        #uefi config files"},{"line_number":229,"context_line":"        for port in task.ports:"},{"line_number":230,"context_line":"            api \u003d dhcp_factory.DHCPFactory(token\u003dtask.context.auth_token)"},{"line_number":231,"context_line":"            port_ip_address \u003d api.get_port_ip_address(task, port)"},{"line_number":232,"context_line":"            ip_address_path \u003d _get_pxe_ip_address_path(port_ip_address)"},{"line_number":233,"context_line":"            utils.unlink_without_raise(ip_address_path)"},{"line_number":234,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_2c76363f","line":231,"in_reply_to":"fa98f980_db2566ac","updated":"2014-09-01 11:46:38.000000000","message":"Changed the code.\nI will add uefi specific test case also.","commit_id":"15438e2343a167d8e89fb492aed7eea0954d3c4e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c772da310e1b4d3967137fd7de66a529635218fb","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                    return parts[1]"},{"line_number":292,"context_line":"            else:"},{"line_number":293,"context_line":"                LOG.warn(_LW(\"Ignoring malformed capability \u0027%s\u0027. \""},{"line_number":294,"context_line":"                    \"Format should be \u0027key:val\u0027.\") % node_capability)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"def validate_boot_mode_capability(node):"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_5646abc0","line":294,"updated":"2014-09-01 09:20:27.000000000","message":"% should not be used here - http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages","commit_id":"15438e2343a167d8e89fb492aed7eea0954d3c4e"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"454c3c11973bb01404e25bfd07431d8da7211ae8","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                    return parts[1]"},{"line_number":292,"context_line":"            else:"},{"line_number":293,"context_line":"                LOG.warn(_LW(\"Ignoring malformed capability \u0027%s\u0027. \""},{"line_number":294,"context_line":"                    \"Format should be \u0027key:val\u0027.\") % node_capability)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"def validate_boot_mode_capability(node):"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_4cd8da1d","line":294,"in_reply_to":"fa98f980_5646abc0","updated":"2014-09-01 11:46:38.000000000","message":"Done.","commit_id":"15438e2343a167d8e89fb492aed7eea0954d3c4e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c772da310e1b4d3967137fd7de66a529635218fb","unresolved":false,"context_lines":[{"line_number":305,"context_line":"    boot_mode \u003d get_node_capability(node, \u0027boot_mode\u0027)"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    if boot_mode and boot_mode not in [\u0027bios\u0027, \u0027uefi\u0027]:"},{"line_number":308,"context_line":"        raise exception.InvalidParameterValue(_LE(\"Invalid boot_mode \""},{"line_number":309,"context_line":"                          \"parameter \u0027%s\u0027.\") % boot_mode)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_36776704","line":308,"updated":"2014-09-01 09:20:27.000000000","message":"Here _ should be used as it is passed to user facing message.","commit_id":"15438e2343a167d8e89fb492aed7eea0954d3c4e"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"454c3c11973bb01404e25bfd07431d8da7211ae8","unresolved":false,"context_lines":[{"line_number":305,"context_line":"    boot_mode \u003d get_node_capability(node, \u0027boot_mode\u0027)"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    if boot_mode and boot_mode not in [\u0027bios\u0027, \u0027uefi\u0027]:"},{"line_number":308,"context_line":"        raise exception.InvalidParameterValue(_LE(\"Invalid boot_mode \""},{"line_number":309,"context_line":"                          \"parameter \u0027%s\u0027.\") % boot_mode)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_8c09e297","line":308,"in_reply_to":"fa98f980_36776704","updated":"2014-09-01 11:46:38.000000000","message":"Done","commit_id":"15438e2343a167d8e89fb492aed7eea0954d3c4e"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"fe61819f362a05f4f514c76a7d39d6939d6b8e68","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            ip_address_path \u003d _get_pxe_ip_address_path(port_ip_address)"},{"line_number":104,"context_line":"        except (exception.FailedToGetIPAddressOnPort,"},{"line_number":105,"context_line":"                exception.InvalidIPv4Address):"},{"line_number":106,"context_line":"            failures.append(port.uuid)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        utils.unlink_without_raise(ip_address_path)"},{"line_number":109,"context_line":"        utils.create_link_without_raise(pxe_config_file_path,"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa98f980_b24faabd","line":106,"updated":"2014-09-02 05:53:45.000000000","message":"Missed to put \"continue\" after collecting failures.","commit_id":"f91cd537fad584fd808847bfd34ad79a760cff2b"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"fe61819f362a05f4f514c76a7d39d6939d6b8e68","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                ip_address_path \u003d _get_pxe_ip_address_path(port_ip_address)"},{"line_number":235,"context_line":"            except (exception.FailedToGetIPAddressOnPort,"},{"line_number":236,"context_line":"                    exception.InvalidIPv4Address):"},{"line_number":237,"context_line":"                failures.append(port.uuid)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"            utils.unlink_without_raise(ip_address_path)"},{"line_number":240,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"fa98f980_b2688a22","line":237,"updated":"2014-09-02 05:53:45.000000000","message":"Missed to put \"continue\" after collecting exception.","commit_id":"f91cd537fad584fd808847bfd34ad79a760cff2b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"43081a1a4e5bcae8c2b07b7578580b0661eac5ad","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        except (exception.FailedToGetIPAddressOnPort,"},{"line_number":105,"context_line":"                exception.InvalidIPv4Address):"},{"line_number":106,"context_line":"            failures.append(port.uuid)"},{"line_number":107,"context_line":"            continue"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        utils.unlink_without_raise(ip_address_path)"},{"line_number":110,"context_line":"        utils.create_link_without_raise(pxe_config_file_path,"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa98f980_8cf43f88","line":107,"updated":"2014-09-02 10:07:36.000000000","message":"this whole block (and probably error handling) is duplicated in clean_up_pxe_config and should be separated into smth like\n\n def _get_ip_addresses(task)","commit_id":"4ac639ff71c2fda3c62d4ad966ab3438c7c295ce"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"6812dcb088f542408e47ff095066cc09cfd7c488","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        except (exception.FailedToGetIPAddressOnPort,"},{"line_number":105,"context_line":"                exception.InvalidIPv4Address):"},{"line_number":106,"context_line":"            failures.append(port.uuid)"},{"line_number":107,"context_line":"            continue"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        utils.unlink_without_raise(ip_address_path)"},{"line_number":110,"context_line":"        utils.create_link_without_raise(pxe_config_file_path,"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa98f980_f5ef4e85","line":107,"in_reply_to":"fa98f980_8cf43f88","updated":"2014-09-02 12:51:54.000000000","message":"done.","commit_id":"4ac639ff71c2fda3c62d4ad966ab3438c7c295ce"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"43081a1a4e5bcae8c2b07b7578580b0661eac5ad","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        )"},{"line_number":155,"context_line":"    else:"},{"line_number":156,"context_line":"        LOG.exception(_LE(\"Invalid IPv4 address %s.\""},{"line_number":157,"context_line":"                       ), ip_address)"},{"line_number":158,"context_line":"        raise exception.InvalidIPv4Address(ip_address\u003dip_address)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa98f980_4c3a5737","line":157,"updated":"2014-09-02 10:07:36.000000000","message":"nit: bracket should be on previous line","commit_id":"4ac639ff71c2fda3c62d4ad966ab3438c7c295ce"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"6812dcb088f542408e47ff095066cc09cfd7c488","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        )"},{"line_number":155,"context_line":"    else:"},{"line_number":156,"context_line":"        LOG.exception(_LE(\"Invalid IPv4 address %s.\""},{"line_number":157,"context_line":"                       ), ip_address)"},{"line_number":158,"context_line":"        raise exception.InvalidIPv4Address(ip_address\u003dip_address)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa98f980_55ed7a8a","line":157,"in_reply_to":"fa98f980_4c3a5737","updated":"2014-09-02 12:51:54.000000000","message":"done.","commit_id":"4ac639ff71c2fda3c62d4ad966ab3438c7c295ce"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"43081a1a4e5bcae8c2b07b7578580b0661eac5ad","unresolved":false,"context_lines":[{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    \"\"\""},{"line_number":299,"context_line":"    capabilities \u003d node.properties.get(\u0027capabilities\u0027)"},{"line_number":300,"context_line":"    if capabilities:"},{"line_number":301,"context_line":"        for node_capability in str(capabilities).split(\u0027,\u0027):"},{"line_number":302,"context_line":"            parts \u003d node_capability.split(\u0027:\u0027)"},{"line_number":303,"context_line":"            if len(parts) \u003d\u003d 2 and parts[0] and parts[1]:"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa98f980_6c271b13","line":300,"updated":"2014-09-02 10:07:36.000000000","message":"nit: revert to avoid overindenting:\n\n if not capabilities:\n   return","commit_id":"4ac639ff71c2fda3c62d4ad966ab3438c7c295ce"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"6812dcb088f542408e47ff095066cc09cfd7c488","unresolved":false,"context_lines":[{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    \"\"\""},{"line_number":299,"context_line":"    capabilities \u003d node.properties.get(\u0027capabilities\u0027)"},{"line_number":300,"context_line":"    if capabilities:"},{"line_number":301,"context_line":"        for node_capability in str(capabilities).split(\u0027,\u0027):"},{"line_number":302,"context_line":"            parts \u003d node_capability.split(\u0027:\u0027)"},{"line_number":303,"context_line":"            if len(parts) \u003d\u003d 2 and parts[0] and parts[1]:"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa98f980_d5f88a4b","line":300,"in_reply_to":"fa98f980_6c271b13","updated":"2014-09-02 12:51:54.000000000","message":"done.","commit_id":"4ac639ff71c2fda3c62d4ad966ab3438c7c295ce"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"915f5e9b4c3a82a33f6b4777977b5fb9e721c866","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"def _get_ip_addresses(task):"},{"line_number":92,"context_line":"    \"\"\"Fetch each ip address from task.ports."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    :param task: A TaskManager instance."},{"line_number":95,"context_line":"    :raises: FailedToGetIPAddressOnPort"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_9b2d4249","line":92,"updated":"2014-09-02 19:41:43.000000000","message":"nit: ip -\u003e IP","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"cf4fe6993518c52ce6d5c5d35342085c80f255cd","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"def _get_ip_addresses(task):"},{"line_number":92,"context_line":"    \"\"\"Fetch each ip address from task.ports."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    :param task: A TaskManager instance."},{"line_number":95,"context_line":"    :raises: FailedToGetIPAddressOnPort"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_2af5daca","line":92,"in_reply_to":"fa98f980_9b2d4249","updated":"2014-09-02 23:58:13.000000000","message":"Done","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"915f5e9b4c3a82a33f6b4777977b5fb9e721c866","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    :param task: A TaskManager instance."},{"line_number":95,"context_line":"    :raises: FailedToGetIPAddressOnPort"},{"line_number":96,"context_line":"    :returns: A list of ip addresses."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    \"\"\""},{"line_number":99,"context_line":"    failures \u003d []"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_1b21524d","line":96,"updated":"2014-09-02 19:41:43.000000000","message":"ip -\u003e IP","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"cf4fe6993518c52ce6d5c5d35342085c80f255cd","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    :param task: A TaskManager instance."},{"line_number":95,"context_line":"    :raises: FailedToGetIPAddressOnPort"},{"line_number":96,"context_line":"    :returns: A list of ip addresses."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    \"\"\""},{"line_number":99,"context_line":"    failures \u003d []"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_4a04debf","line":96,"in_reply_to":"fa98f980_1b21524d","updated":"2014-09-02 23:58:13.000000000","message":"Done","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"915f5e9b4c3a82a33f6b4777977b5fb9e721c866","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    ip_addresses \u003d []"},{"line_number":101,"context_line":"    for port in task.ports:"},{"line_number":102,"context_line":"        try:"},{"line_number":103,"context_line":"            api \u003d dhcp_factory.DHCPFactory(token\u003dtask.context.auth_token)"},{"line_number":104,"context_line":"            port_ip_address \u003d api.provider.get_port_ip_address(task, port)"},{"line_number":105,"context_line":"            ip_addresses.append(port_ip_address)"},{"line_number":106,"context_line":"        except exception.FailedToGetIPAddressOnPort:"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_dbdeea3e","line":103,"updated":"2014-09-02 19:41:43.000000000","message":"why not do this before the for loop?","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"cf4fe6993518c52ce6d5c5d35342085c80f255cd","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    ip_addresses \u003d []"},{"line_number":101,"context_line":"    for port in task.ports:"},{"line_number":102,"context_line":"        try:"},{"line_number":103,"context_line":"            api \u003d dhcp_factory.DHCPFactory(token\u003dtask.context.auth_token)"},{"line_number":104,"context_line":"            port_ip_address \u003d api.provider.get_port_ip_address(task, port)"},{"line_number":105,"context_line":"            ip_addresses.append(port_ip_address)"},{"line_number":106,"context_line":"        except exception.FailedToGetIPAddressOnPort:"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_8a2de648","line":103,"in_reply_to":"fa98f980_dbdeea3e","updated":"2014-09-02 23:58:13.000000000","message":"Done","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"915f5e9b4c3a82a33f6b4777977b5fb9e721c866","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"def _link_ip_address_pxe_configs(task):"},{"line_number":124,"context_line":"    \"\"\"Link each ip address with the PXE configuration file."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    :param task: A TaskManager instance."},{"line_number":127,"context_line":"    :raises: FailedToGetIPAddressOnPort"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_3b08d62c","line":124,"updated":"2014-09-02 19:41:43.000000000","message":"nit: ip -\u003e IP","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"cf4fe6993518c52ce6d5c5d35342085c80f255cd","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"def _link_ip_address_pxe_configs(task):"},{"line_number":124,"context_line":"    \"\"\"Link each ip address with the PXE configuration file."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    :param task: A TaskManager instance."},{"line_number":127,"context_line":"    :raises: FailedToGetIPAddressOnPort"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_aa30ea9e","line":124,"in_reply_to":"fa98f980_3b08d62c","updated":"2014-09-02 23:58:13.000000000","message":"Done","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"915f5e9b4c3a82a33f6b4777977b5fb9e721c866","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    pxe_config_file_path \u003d get_pxe_config_file_path(task.node.uuid)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    for port_ip_address in _get_ip_addresses(task):"},{"line_number":134,"context_line":"        ip_address_path \u003d _get_pxe_ip_address_path(port_ip_address)"},{"line_number":135,"context_line":"        utils.unlink_without_raise(ip_address_path)"},{"line_number":136,"context_line":"        utils.create_link_without_raise(pxe_config_file_path,"},{"line_number":137,"context_line":"                                         ip_address_path)"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_fbec8e91","line":134,"updated":"2014-09-02 19:41:43.000000000","message":"This could raise InvalidIPv4Address. If it does, would we want to undo the created links, or try to create links for the other ports?","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"cf4fe6993518c52ce6d5c5d35342085c80f255cd","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    pxe_config_file_path \u003d get_pxe_config_file_path(task.node.uuid)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    for port_ip_address in _get_ip_addresses(task):"},{"line_number":134,"context_line":"        ip_address_path \u003d _get_pxe_ip_address_path(port_ip_address)"},{"line_number":135,"context_line":"        utils.unlink_without_raise(ip_address_path)"},{"line_number":136,"context_line":"        utils.create_link_without_raise(pxe_config_file_path,"},{"line_number":137,"context_line":"                                         ip_address_path)"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_85d6b4ef","line":134,"in_reply_to":"fa98f980_fbec8e91","updated":"2014-09-02 23:58:13.000000000","message":"Refactored some of this in a better way, to address this concern.","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"915f5e9b4c3a82a33f6b4777977b5fb9e721c866","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    :param ip_address: An ipv4 address string in the format n.n.n.n ."},{"line_number":159,"context_line":"    :returns: the path to the config file."},{"line_number":160,"context_line":"    :raises: InvalidIPv4address"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    \"\"\""},{"line_number":163,"context_line":"    if utils.is_valid_ipv4(ip_address):"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_1e3b00d2","line":160,"updated":"2014-09-02 19:41:43.000000000","message":"typo","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"cf4fe6993518c52ce6d5c5d35342085c80f255cd","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    :param ip_address: An ipv4 address string in the format n.n.n.n ."},{"line_number":159,"context_line":"    :returns: the path to the config file."},{"line_number":160,"context_line":"    :raises: InvalidIPv4address"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    \"\"\""},{"line_number":163,"context_line":"    if utils.is_valid_ipv4(ip_address):"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_6af8c249","line":160,"in_reply_to":"fa98f980_1e3b00d2","updated":"2014-09-02 23:58:13.000000000","message":"Done","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"915f5e9b4c3a82a33f6b4777977b5fb9e721c866","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    if boot_mode and boot_mode not in [\u0027bios\u0027, \u0027uefi\u0027]:"},{"line_number":332,"context_line":"        raise exception.InvalidParameterValue(_(\"Invalid boot_mode \""},{"line_number":333,"context_line":"                          \"parameter \u0027%s\u0027.\") % boot_mode)"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_7e16ccf2","line":333,"updated":"2014-09-02 19:41:43.000000000","message":"If capabilities had \u0027boot_mode\u003dbios\u0027 instead of \u0027boot_mode:bios\u0027, we don\u0027t want it to cause an InvalidParameterValue exception, right?","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"cf4fe6993518c52ce6d5c5d35342085c80f255cd","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    if boot_mode and boot_mode not in [\u0027bios\u0027, \u0027uefi\u0027]:"},{"line_number":332,"context_line":"        raise exception.InvalidParameterValue(_(\"Invalid boot_mode \""},{"line_number":333,"context_line":"                          \"parameter \u0027%s\u0027.\") % boot_mode)"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_25fa6875","line":333,"in_reply_to":"fa98f980_7e16ccf2","updated":"2014-09-02 23:58:13.000000000","message":"I\u0027d say that is incorrectly configured, but that\u0027s just my opinion... there\u0027s a log.warn for that case, I think this is fine.","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c872f0f975502bd8053fd571db2f94e172c69907","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            CONF.pxe.tftp_root, hex_ip + \".conf\""},{"line_number":143,"context_line":"        )"},{"line_number":144,"context_line":"    else:"},{"line_number":145,"context_line":"        LOG.exception(_LE(\"Invalid IPv4 address %s.\"), ip_address)"},{"line_number":146,"context_line":"        raise exception.InvalidIPv4Address(ip_address\u003dip_address)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"fa98f980_ede2f02d","line":145,"updated":"2014-09-03 13:56:18.000000000","message":"nit: s/exception/error/ as there\u0027s no traceback","commit_id":"500d7e8d0e6f202694d7f3e0cfd4ee4b962f5a78"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"1af2f064cf3d1eca8547fcc2226889457cf03a09","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            CONF.pxe.tftp_root, hex_ip + \".conf\""},{"line_number":143,"context_line":"        )"},{"line_number":144,"context_line":"    else:"},{"line_number":145,"context_line":"        LOG.exception(_LE(\"Invalid IPv4 address %s.\"), ip_address)"},{"line_number":146,"context_line":"        raise exception.InvalidIPv4Address(ip_address\u003dip_address)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"fa98f980_109e6bb9","line":145,"in_reply_to":"fa98f980_ede2f02d","updated":"2014-09-03 14:16:53.000000000","message":"Done","commit_id":"500d7e8d0e6f202694d7f3e0cfd4ee4b962f5a78"}],"ironic/common/utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5d4362a62c796bab1dac295de562bf83ebcfea17","unresolved":false,"context_lines":[{"line_number":510,"context_line":"    \"\"\"Returns \u0027capability\u0027 value from node\u0027s \u0027capabilities\u0027 property"},{"line_number":511,"context_line":"    node.properties[\u0027capabilities\u0027]\u003d\u0027capability:value,capability:value,...\u0027"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"    :param value: Node object."},{"line_number":514,"context_line":"    :param chars: Capability key."},{"line_number":515,"context_line":"    :return: Capability value."},{"line_number":516,"context_line":"             If capability is not present, then return \"None\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7ac7a964_cfd2dad1","line":513,"updated":"2014-08-15 13:19:15.000000000","message":"s/value/node/","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"25f9b65e0e9ceff3817da4e97353c4460c7163d1","unresolved":false,"context_lines":[{"line_number":510,"context_line":"    \"\"\"Returns \u0027capability\u0027 value from node\u0027s \u0027capabilities\u0027 property"},{"line_number":511,"context_line":"    node.properties[\u0027capabilities\u0027]\u003d\u0027capability:value,capability:value,...\u0027"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"    :param value: Node object."},{"line_number":514,"context_line":"    :param chars: Capability key."},{"line_number":515,"context_line":"    :return: Capability value."},{"line_number":516,"context_line":"             If capability is not present, then return \"None\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_c5883cea","line":513,"in_reply_to":"7ac7a964_cfd2dad1","updated":"2014-08-20 07:35:43.000000000","message":"Done. \nalso corrected the \"capability\" paramter.","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5d4362a62c796bab1dac295de562bf83ebcfea17","unresolved":false,"context_lines":[{"line_number":524,"context_line":"                if parts[0] \u003d\u003d capability:"},{"line_number":525,"context_line":"                    return parts[1]"},{"line_number":526,"context_line":"            else:"},{"line_number":527,"context_line":"                LOG.warn(_(\"Ignoring malformed capability \u0027%s\u0027. \""},{"line_number":528,"context_line":"                    \"Format should be \u0027key:val\u0027.\") % node_capability)"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"    return None"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ac7a964_8fc8e223","line":527,"updated":"2014-08-15 13:19:15.000000000","message":"should be using _LW instead of _","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"25f9b65e0e9ceff3817da4e97353c4460c7163d1","unresolved":false,"context_lines":[{"line_number":524,"context_line":"                if parts[0] \u003d\u003d capability:"},{"line_number":525,"context_line":"                    return parts[1]"},{"line_number":526,"context_line":"            else:"},{"line_number":527,"context_line":"                LOG.warn(_(\"Ignoring malformed capability \u0027%s\u0027. \""},{"line_number":528,"context_line":"                    \"Format should be \u0027key:val\u0027.\") % node_capability)"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"    return None"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_e56c5839","line":527,"in_reply_to":"7ac7a964_8fc8e223","updated":"2014-08-20 07:35:43.000000000","message":"Done","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"}],"ironic/dhcp/base.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"43081a1a4e5bcae8c2b07b7578580b0661eac5ad","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        :raises: FailedToUpdateDHCPOptOnPort"},{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def get_port_ip_address(self, task, port_id):"},{"line_number":72,"context_line":"        \"\"\"Get ip address of ironic port."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        :param task: a TaskManager instance."}],"source_content_type":"text/x-python","patch_set":15,"id":"fa98f980_ac7823f3","line":71,"updated":"2014-09-02 10:07:36.000000000","message":"shouldn\u0027t it be @abc.abstractmethod ?","commit_id":"4ac639ff71c2fda3c62d4ad966ab3438c7c295ce"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"6812dcb088f542408e47ff095066cc09cfd7c488","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        :raises: FailedToUpdateDHCPOptOnPort"},{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def get_port_ip_address(self, task, port_id):"},{"line_number":72,"context_line":"        \"\"\"Get ip address of ironic port."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        :param task: a TaskManager instance."}],"source_content_type":"text/x-python","patch_set":15,"id":"fa98f980_156852f4","line":71,"in_reply_to":"fa98f980_ac7823f3","updated":"2014-09-02 12:51:54.000000000","message":"added the above statement.\nDone.","commit_id":"4ac639ff71c2fda3c62d4ad966ab3438c7c295ce"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"915f5e9b4c3a82a33f6b4777977b5fb9e721c866","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @abc.abstractmethod"},{"line_number":72,"context_line":"    def get_port_ip_address(self, task, port_id):"},{"line_number":73,"context_line":"        \"\"\"Get ip address of ironic port."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        :param task: a TaskManager instance."},{"line_number":76,"context_line":"        :param port_id: Ironic Node\u0027s port UUID."}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_9ebb70e4","line":73,"updated":"2014-09-02 19:41:43.000000000","message":"ip -\u003e IP","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"cf4fe6993518c52ce6d5c5d35342085c80f255cd","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @abc.abstractmethod"},{"line_number":72,"context_line":"    def get_port_ip_address(self, task, port_id):"},{"line_number":73,"context_line":"        \"\"\"Get ip address of ironic port."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        :param task: a TaskManager instance."},{"line_number":76,"context_line":"        :param port_id: Ironic Node\u0027s port UUID."}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_a52d7800","line":73,"in_reply_to":"fa98f980_9ebb70e4","updated":"2014-09-02 23:58:13.000000000","message":"Done","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"915f5e9b4c3a82a33f6b4777977b5fb9e721c866","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        :param task: a TaskManager instance."},{"line_number":76,"context_line":"        :param port_id: Ironic Node\u0027s port UUID."},{"line_number":77,"context_line":"        :returns:  Port ip address associated with Node\u0027s port."},{"line_number":78,"context_line":"        :raises: FailedToGetIPAddressOnPort"},{"line_number":79,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_deac18a3","line":77,"updated":"2014-09-02 19:41:43.000000000","message":"nit: \u0027Port ip\u0027 -\u003e \u0027IP\u0027","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"cf4fe6993518c52ce6d5c5d35342085c80f255cd","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        :param task: a TaskManager instance."},{"line_number":76,"context_line":"        :param port_id: Ironic Node\u0027s port UUID."},{"line_number":77,"context_line":"        :returns:  Port ip address associated with Node\u0027s port."},{"line_number":78,"context_line":"        :raises: FailedToGetIPAddressOnPort"},{"line_number":79,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_c5327c5e","line":77,"in_reply_to":"fa98f980_deac18a3","updated":"2014-09-02 23:58:13.000000000","message":"Done","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"}],"ironic/dhcp/neutron.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"43081a1a4e5bcae8c2b07b7578580b0661eac5ad","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        #At present only the first fixed_ip assigned to this neutron port"},{"line_number":196,"context_line":"        #will be used, since nova allocates only one fixed_ip for the"},{"line_number":197,"context_line":"        #instance."},{"line_number":198,"context_line":"        if isinstance(fixed_ips, list) and len(fixed_ips) \u003e 0:"},{"line_number":199,"context_line":"            ip_address \u003d fixed_ips[0].get(\u0027ip_address\u0027, None)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        if ip_address:"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa98f980_2cea7375","line":198,"updated":"2014-09-02 10:07:36.000000000","message":"I suspect it should be just:\n\n if fixed_ips:","commit_id":"4ac639ff71c2fda3c62d4ad966ab3438c7c295ce"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"6812dcb088f542408e47ff095066cc09cfd7c488","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        #At present only the first fixed_ip assigned to this neutron port"},{"line_number":196,"context_line":"        #will be used, since nova allocates only one fixed_ip for the"},{"line_number":197,"context_line":"        #instance."},{"line_number":198,"context_line":"        if isinstance(fixed_ips, list) and len(fixed_ips) \u003e 0:"},{"line_number":199,"context_line":"            ip_address \u003d fixed_ips[0].get(\u0027ip_address\u0027, None)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        if ip_address:"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa98f980_55401a56","line":198,"in_reply_to":"fa98f980_2cea7375","updated":"2014-09-02 12:51:54.000000000","message":"I think it should work.\nWill fix this as well.","commit_id":"4ac639ff71c2fda3c62d4ad966ab3438c7c295ce"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c872f0f975502bd8053fd571db2f94e172c69907","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        fixed_ips \u003d neutron_port.get(\u0027fixed_ips\u0027)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        #At present only the first fixed_ip assigned to this neutron port"},{"line_number":197,"context_line":"        #will be used, since nova allocates only one fixed_ip for the"},{"line_number":198,"context_line":"        #instance."},{"line_number":199,"context_line":"        if fixed_ips:"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa98f980_4d0e9ce6","line":196,"updated":"2014-09-03 13:56:18.000000000","message":"nit: prefix comments with NOTE(yournick)","commit_id":"500d7e8d0e6f202694d7f3e0cfd4ee4b962f5a78"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"1af2f064cf3d1eca8547fcc2226889457cf03a09","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        fixed_ips \u003d neutron_port.get(\u0027fixed_ips\u0027)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        #At present only the first fixed_ip assigned to this neutron port"},{"line_number":197,"context_line":"        #will be used, since nova allocates only one fixed_ip for the"},{"line_number":198,"context_line":"        #instance."},{"line_number":199,"context_line":"        if fixed_ips:"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa98f980_4d6cdc08","line":196,"in_reply_to":"fa98f980_4d0e9ce6","updated":"2014-09-03 14:16:53.000000000","message":"Done","commit_id":"500d7e8d0e6f202694d7f3e0cfd4ee4b962f5a78"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c872f0f975502bd8053fd571db2f94e172c69907","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        if ip_address:"},{"line_number":203,"context_line":"            return ip_address"},{"line_number":204,"context_line":"        else:"},{"line_number":205,"context_line":"            LOG.exception(_LE(\"No IP address assigned to Neutron port %s.\"),"},{"line_number":206,"context_line":"                          port_id)"},{"line_number":207,"context_line":"            raise exception.FailedToGetIPAddressOnPort(port_id\u003dport_id)"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"fa98f980_8dfb24c0","line":205,"updated":"2014-09-03 13:56:18.000000000","message":"nit: s/exception/error/ here","commit_id":"500d7e8d0e6f202694d7f3e0cfd4ee4b962f5a78"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"1af2f064cf3d1eca8547fcc2226889457cf03a09","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        if ip_address:"},{"line_number":203,"context_line":"            return ip_address"},{"line_number":204,"context_line":"        else:"},{"line_number":205,"context_line":"            LOG.exception(_LE(\"No IP address assigned to Neutron port %s.\"),"},{"line_number":206,"context_line":"                          port_id)"},{"line_number":207,"context_line":"            raise exception.FailedToGetIPAddressOnPort(port_id\u003dport_id)"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"fa98f980_90433b41","line":205,"in_reply_to":"fa98f980_8dfb24c0","updated":"2014-09-03 14:16:53.000000000","message":"Done","commit_id":"500d7e8d0e6f202694d7f3e0cfd4ee4b962f5a78"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c872f0f975502bd8053fd571db2f94e172c69907","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        :raises: FailedToGetIPAddressOnPort"},{"line_number":216,"context_line":"        \"\"\""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        port_ip_address \u003d None"},{"line_number":219,"context_line":"        vifs \u003d network.get_node_vif_ids(task)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        if not vifs:"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa98f980_2d34f891","line":218,"updated":"2014-09-03 13:56:18.000000000","message":"nit: redundant","commit_id":"500d7e8d0e6f202694d7f3e0cfd4ee4b962f5a78"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"1af2f064cf3d1eca8547fcc2226889457cf03a09","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        :raises: FailedToGetIPAddressOnPort"},{"line_number":216,"context_line":"        \"\"\""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        port_ip_address \u003d None"},{"line_number":219,"context_line":"        vifs \u003d network.get_node_vif_ids(task)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        if not vifs:"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa98f980_30552ffb","line":218,"in_reply_to":"fa98f980_2d34f891","updated":"2014-09-03 14:16:53.000000000","message":"Done","commit_id":"500d7e8d0e6f202694d7f3e0cfd4ee4b962f5a78"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c872f0f975502bd8053fd571db2f94e172c69907","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                        {\u0027node\u0027: task.node.uuid})"},{"line_number":225,"context_line":"            raise exception.FailedToGetIPAddressOnPort(port_id\u003dport_id.uuid)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        port_vif \u003d vifs[port_id.uuid]"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        try:"},{"line_number":230,"context_line":"            port_ip_address \u003d self._get_fixed_ip_address(port_vif)"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa98f980_6de1a0fd","line":227,"updated":"2014-09-03 13:56:18.000000000","message":"\":param port_id: ironic Node\u0027s port UUID\". what type is it actually?","commit_id":"500d7e8d0e6f202694d7f3e0cfd4ee4b962f5a78"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"1af2f064cf3d1eca8547fcc2226889457cf03a09","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                        {\u0027node\u0027: task.node.uuid})"},{"line_number":225,"context_line":"            raise exception.FailedToGetIPAddressOnPort(port_id\u003dport_id.uuid)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        port_vif \u003d vifs[port_id.uuid]"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        try:"},{"line_number":230,"context_line":"            port_ip_address \u003d self._get_fixed_ip_address(port_vif)"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa98f980_f02f2786","line":227,"in_reply_to":"fa98f980_6de1a0fd","updated":"2014-09-03 14:16:53.000000000","message":"Good catch, done","commit_id":"500d7e8d0e6f202694d7f3e0cfd4ee4b962f5a78"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c872f0f975502bd8053fd571db2f94e172c69907","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        except exception.FailedToGetIPAddressOnPort:"},{"line_number":232,"context_line":"            LOG.exception(_LE(\"Failed to Get IP address on Neutron port %s.\"),"},{"line_number":233,"context_line":"                          port_id)"},{"line_number":234,"context_line":"            raise exception.FailedToGetIPAddressOnPort(port_id\u003dport_id)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        return port_ip_address"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"fa98f980_8dd08420","line":234,"updated":"2014-09-03 13:56:18.000000000","message":"should be just:\n\n raise\n\notherwise you\u0027re losing traceback\n\nActually I don\u0027t think you should catch this error at all, please just let it go upper","commit_id":"500d7e8d0e6f202694d7f3e0cfd4ee4b962f5a78"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"1af2f064cf3d1eca8547fcc2226889457cf03a09","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        except exception.FailedToGetIPAddressOnPort:"},{"line_number":232,"context_line":"            LOG.exception(_LE(\"Failed to Get IP address on Neutron port %s.\"),"},{"line_number":233,"context_line":"                          port_id)"},{"line_number":234,"context_line":"            raise exception.FailedToGetIPAddressOnPort(port_id\u003dport_id)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        return port_ip_address"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"fa98f980_6dba806f","line":234,"in_reply_to":"fa98f980_8dd08420","updated":"2014-09-03 14:16:53.000000000","message":"Done","commit_id":"500d7e8d0e6f202694d7f3e0cfd4ee4b962f5a78"}],"ironic/drivers/base.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c872f0f975502bd8053fd571db2f94e172c69907","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":129,"context_line":"        :raises: InvalidParameterValue"},{"line_number":130,"context_line":"        :raises: MissingParameterValue"},{"line_number":131,"context_line":"        :raises: ConfigInvalid"},{"line_number":132,"context_line":"        \"\"\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa98f980_6d860015","line":131,"updated":"2014-09-03 13:56:18.000000000","message":"is it here by mistake?","commit_id":"500d7e8d0e6f202694d7f3e0cfd4ee4b962f5a78"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"1af2f064cf3d1eca8547fcc2226889457cf03a09","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":129,"context_line":"        :raises: InvalidParameterValue"},{"line_number":130,"context_line":"        :raises: MissingParameterValue"},{"line_number":131,"context_line":"        :raises: ConfigInvalid"},{"line_number":132,"context_line":"        \"\"\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa98f980_8d56c45a","line":131,"in_reply_to":"fa98f980_6d860015","updated":"2014-09-03 14:16:53.000000000","message":"The subclass now raises ConfigInvalid, so rloo asked for this to be here.","commit_id":"500d7e8d0e6f202694d7f3e0cfd4ee4b962f5a78"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5d4362a62c796bab1dac295de562bf83ebcfea17","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    with open(path) as f:"},{"line_number":170,"context_line":"        lines \u003d f.readlines()"},{"line_number":171,"context_line":"    root \u003d \u0027UUID\u003d%s\u0027 % root_uuid"},{"line_number":172,"context_line":"    #pxe_cmd \u003d \u0027goto\u0027 if CONF.pxe.ipxe_enabled else \u0027default\u0027"},{"line_number":173,"context_line":"    rre \u003d re.compile(r\u0027\\{\\{ ROOT \\}\\}\u0027)"},{"line_number":174,"context_line":"    if boot_mode \u003d\u003d \u0027uefi\u0027:"},{"line_number":175,"context_line":"        dre \u003d re.compile(\u0027^default\u003d.*$\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ac7a964_2ffeee38","line":172,"updated":"2014-08-15 13:19:15.000000000","message":"I suspect, this should not be commented out","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"25f9b65e0e9ceff3817da4e97353c4460c7163d1","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    with open(path) as f:"},{"line_number":170,"context_line":"        lines \u003d f.readlines()"},{"line_number":171,"context_line":"    root \u003d \u0027UUID\u003d%s\u0027 % root_uuid"},{"line_number":172,"context_line":"    #pxe_cmd \u003d \u0027goto\u0027 if CONF.pxe.ipxe_enabled else \u0027default\u0027"},{"line_number":173,"context_line":"    rre \u003d re.compile(r\u0027\\{\\{ ROOT \\}\\}\u0027)"},{"line_number":174,"context_line":"    if boot_mode \u003d\u003d \u0027uefi\u0027:"},{"line_number":175,"context_line":"        dre \u003d re.compile(\u0027^default\u003d.*$\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_c55f5c71","line":172,"in_reply_to":"7ac7a964_2ffeee38","updated":"2014-08-20 07:35:43.000000000","message":"I did this change as part of pep8 recommendation.\n\nReverted this change back to original.\n\nDone.","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"}],"ironic/drivers/modules/elilo_efi_pxe_config.template":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f0eec29d32bf8a8bc2a4f9f9e793c557418119aa","unresolved":false,"context_lines":[{"line_number":8,"context_line":"image\u003d{{pxe_options.aki_path}}"},{"line_number":9,"context_line":"        label\u003dboot"},{"line_number":10,"context_line":"        initrd\u003d{{pxe_options.ari_path}}"},{"line_number":11,"context_line":"        append\u003d\"root\u003d{{ ROOT }} ro {{ pxe_options.pxe_append_params|default(\"\", true) }} ip\u003d%I:{{pxe_options.tftp_server}}:%G:%M:%H:eth0:on\""},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1abeadc6_b854cdff","line":11,"updated":"2014-08-20 15:50:40.000000000","message":"Question (I don\u0027t know much about UEFI):\n\nThese \u0027ip\u003d\u0027 lines are initializing the network interface eth0 with a static IP address right? Why is that needed?\n\nAlso, if there\u0027s no eth0? is that the expected name for the interface or a symbolic name for the first active NIC?","commit_id":"49bce496a644da940ef36d669d36e24103fdbc8c"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"05f45fb622afb8a1aa777bab554afbd8dfaa5adb","unresolved":false,"context_lines":[{"line_number":8,"context_line":"image\u003d{{pxe_options.aki_path}}"},{"line_number":9,"context_line":"        label\u003dboot"},{"line_number":10,"context_line":"        initrd\u003d{{pxe_options.ari_path}}"},{"line_number":11,"context_line":"        append\u003d\"root\u003d{{ ROOT }} ro {{ pxe_options.pxe_append_params|default(\"\", true) }} ip\u003d%I:{{pxe_options.tftp_server}}:%G:%M:%H:eth0:on\""},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1abeadc6_385ef376","line":11,"in_reply_to":"1abeadc6_b854cdff","updated":"2014-08-20 21:01:13.000000000","message":"Yes thats correct, This is need becasue elilo.efi bootloader does not set \"ip\" kernel parameter by default, unlike pxelinux.0. This \"ip\" kernel parameter is then read by deploy_kernel init scripts to initialize network interface and other parameters like BOOT_SERVER, BOOT_INTERFACE, BOOT_IP_ADDRESS, etc.\n\nI eth0 is the device name for the first active nic. If not specified it takes the default as the one which is active. \n\nI will remove the network device name, after doing some test and update in the next patch.\n\n\nthanks.","commit_id":"49bce496a644da940ef36d669d36e24103fdbc8c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b70bd62e8021abafe3412ec8b5e467e961da7a23","unresolved":false,"context_lines":[{"line_number":3,"context_line":"image\u003d{{pxe_options.deployment_aki_path}}"},{"line_number":4,"context_line":"        label\u003ddeploy"},{"line_number":5,"context_line":"        initrd\u003d{{pxe_options.deployment_ari_path}}"},{"line_number":6,"context_line":"        append\u003d\"selinux\u003d0 disk\u003dcciss/c0d0,sda,hda,vda iscsi_target_iqn\u003d{{ pxe_options.deployment_iscsi_iqn }} deployment_id\u003d{{ pxe_options.deployment_id }} deployment_key\u003d{{ pxe_options.deployment_key }} ironic_api_url\u003d{{ pxe_options.ironic_api_url }} troubleshoot\u003d0  {{ pxe_options.pxe_append_params|default(\"\", true) }} ip\u003d%I:{{pxe_options.tftp_server}}:%G:%M:%H::on\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"image\u003d{{pxe_options.aki_path}}"},{"line_number":9,"context_line":"        label\u003dboot"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"1abeadc6_e9c1cae4","line":6,"updated":"2014-08-29 12:28:37.000000000","message":"Patch https://review.openstack.org/#/c/98050/ adds \"text\" parameter to kernel command line in templates, please add to this template file also.","commit_id":"ce8365d600cce0d8dc0d2aafaf4d8d4994386fb5"}],"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5d4362a62c796bab1dac295de562bf83ebcfea17","unresolved":false,"context_lines":[{"line_number":83,"context_line":"               default\u003d\u0027elilo.efi\u0027,"},{"line_number":84,"context_line":"               help\u003d\u0027Neutron bootfile DHCP parameter for UEFI boot mode.\u0027),"},{"line_number":85,"context_line":"   cfg.IntOpt(\u0027image_cache_size\u0027,"},{"line_number":86,"context_line":"               default\u003d1024,"},{"line_number":87,"context_line":"               help\u003d\u0027Maximum size (in MiB) of cache for master images, \u0027"},{"line_number":88,"context_line":"               \u0027including those in use.\u0027),"},{"line_number":89,"context_line":"    # 10080 here is 1 week - 60*24*7. It is entirely arbitrary in the absence"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ac7a964_6f8f06cd","line":86,"updated":"2014-08-15 13:19:15.000000000","message":"please don\u0027t change it","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"25f9b65e0e9ceff3817da4e97353c4460c7163d1","unresolved":false,"context_lines":[{"line_number":83,"context_line":"               default\u003d\u0027elilo.efi\u0027,"},{"line_number":84,"context_line":"               help\u003d\u0027Neutron bootfile DHCP parameter for UEFI boot mode.\u0027),"},{"line_number":85,"context_line":"   cfg.IntOpt(\u0027image_cache_size\u0027,"},{"line_number":86,"context_line":"               default\u003d1024,"},{"line_number":87,"context_line":"               help\u003d\u0027Maximum size (in MiB) of cache for master images, \u0027"},{"line_number":88,"context_line":"               \u0027including those in use.\u0027),"},{"line_number":89,"context_line":"    # 10080 here is 1 week - 60*24*7. It is entirely arbitrary in the absence"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_859ac412","line":86,"in_reply_to":"7ac7a964_6f8f06cd","updated":"2014-08-20 07:35:43.000000000","message":"I did this change as part the recommendation by this script.\n/opt/stack/ironic/tools/config/generate_sample.sh\n\nReverted it back.","commit_id":"fdcad019b4febc265f1a354165099c3d549ee4c8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f0eec29d32bf8a8bc2a4f9f9e793c557418119aa","unresolved":false,"context_lines":[{"line_number":516,"context_line":"            if boot_mode \u003d\u003d \u0027uefi\u0027:"},{"line_number":517,"context_line":"                LOG.exception(_LE("},{"line_number":518,"context_line":"                  \"UEFI boot mode is not supported with iPXE boot enabled.\"))"},{"line_number":519,"context_line":"                raise exception.InvalidConfig(_LE("},{"line_number":520,"context_line":"                  \"Ironic should be configured with either iPXE or UEFI boot\"))"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        # Try to get the URL of the Ironic API"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_586019cf","line":519,"updated":"2014-08-20 15:50:40.000000000","message":"InvalidConfig is not a valid exception. I think you\u0027re looking at InvalidParameterValue\n\nAlso, it\u0027s missing unittests to capture this failure ^","commit_id":"49bce496a644da940ef36d669d36e24103fdbc8c"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"05f45fb622afb8a1aa777bab554afbd8dfaa5adb","unresolved":false,"context_lines":[{"line_number":516,"context_line":"            if boot_mode \u003d\u003d \u0027uefi\u0027:"},{"line_number":517,"context_line":"                LOG.exception(_LE("},{"line_number":518,"context_line":"                  \"UEFI boot mode is not supported with iPXE boot enabled.\"))"},{"line_number":519,"context_line":"                raise exception.InvalidConfig(_LE("},{"line_number":520,"context_line":"                  \"Ironic should be configured with either iPXE or UEFI boot\"))"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        # Try to get the URL of the Ironic API"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_fb0b958b","line":519,"in_reply_to":"1abeadc6_586019cf","updated":"2014-08-20 21:01:13.000000000","message":"I can add one more validation for ParamterValue \"bios\" or \"uefi\" and raise an exception if user provided boot_mode value other than bios or uefi.\n\nBut this validation is to check if boot_mode is set to uefi and iPXE is configured. I believe as of now, iPXE does not support UEFI boot. So if operator sets the ironic pxe configuration to use iPXE, then we cannot support UEFI boot.\n\nSure, I will a unit test case for this exception.","commit_id":"49bce496a644da940ef36d669d36e24103fdbc8c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f0eec29d32bf8a8bc2a4f9f9e793c557418119aa","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        boot_mode \u003d pxe_utils.get_node_capability(task.node,"},{"line_number":559,"context_line":"                                                  \u0027boot_mode\u0027) or \u0027bios\u0027"},{"line_number":560,"context_line":"        if boot_mode !\u003d \u0027uefi\u0027:"},{"line_number":561,"context_line":"            manager_utils.node_set_boot_device(task, \u0027pxe\u0027, persistent\u003dTrue)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":564,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_786795b7","line":561,"updated":"2014-08-20 15:50:40.000000000","message":"why we wouldn\u0027t set the boot device when it\u0027s uefi?\n\nCan you add a comment please explaining the reason? So other people will know when looking at the code.","commit_id":"49bce496a644da940ef36d669d36e24103fdbc8c"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"05f45fb622afb8a1aa777bab554afbd8dfaa5adb","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        boot_mode \u003d pxe_utils.get_node_capability(task.node,"},{"line_number":559,"context_line":"                                                  \u0027boot_mode\u0027) or \u0027bios\u0027"},{"line_number":560,"context_line":"        if boot_mode !\u003d \u0027uefi\u0027:"},{"line_number":561,"context_line":"            manager_utils.node_set_boot_device(task, \u0027pxe\u0027, persistent\u003dTrue)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":564,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_7b53056b","line":561,"in_reply_to":"1abeadc6_786795b7","updated":"2014-08-20 21:01:13.000000000","message":"I could not use ipmitool to set the boot device when the server is in uefi mode even though there is an option to specify bootmode while changing the boot device. Since ipmitool does not support to query the boot modes and also may not work well to set the boot device in uefi mode, I wanted to avoid setting boot device if server is set in uefi boot mode.\n\nSure, I will add the reason to do this in the code.\n\nThanks","commit_id":"49bce496a644da940ef36d669d36e24103fdbc8c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f0eec29d32bf8a8bc2a4f9f9e793c557418119aa","unresolved":false,"context_lines":[{"line_number":600,"context_line":"        if boot_mode \u003d\u003d \u0027uefi\u0027:"},{"line_number":601,"context_line":"            pxe_config_template \u003d CONF.pxe.uefi_pxe_config_template"},{"line_number":602,"context_line":"        else:"},{"line_number":603,"context_line":"            pxe_config_template \u003d CONF.pxe.pxe_config_template"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"        pxe_utils.create_pxe_config(task, pxe_options,"},{"line_number":606,"context_line":"                                    pxe_config_template)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_38e6fd15","line":603,"updated":"2014-08-20 15:50:40.000000000","message":"I\u0027ve seem this block of code before at pxe_utils.py, I would recommend you to create a helper function at pxe_utils.py with this logic so we don\u0027t duplicate the same block of codes in multiple parts","commit_id":"49bce496a644da940ef36d669d36e24103fdbc8c"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"05f45fb622afb8a1aa777bab554afbd8dfaa5adb","unresolved":false,"context_lines":[{"line_number":600,"context_line":"        if boot_mode \u003d\u003d \u0027uefi\u0027:"},{"line_number":601,"context_line":"            pxe_config_template \u003d CONF.pxe.uefi_pxe_config_template"},{"line_number":602,"context_line":"        else:"},{"line_number":603,"context_line":"            pxe_config_template \u003d CONF.pxe.pxe_config_template"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"        pxe_utils.create_pxe_config(task, pxe_options,"},{"line_number":606,"context_line":"                                    pxe_config_template)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_3e809b45","line":603,"in_reply_to":"1abeadc6_38e6fd15","updated":"2014-08-20 21:01:13.000000000","message":"ok. Let me try.","commit_id":"49bce496a644da940ef36d669d36e24103fdbc8c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f0eec29d32bf8a8bc2a4f9f9e793c557418119aa","unresolved":false,"context_lines":[{"line_number":668,"context_line":""},{"line_number":669,"context_line":"        # boot_mode \u003d \u0027uefi\u0027 or \u0027bios\u0027"},{"line_number":670,"context_line":"        boot_mode \u003d pxe_utils.get_node_capability(node, \u0027boot_mode\u0027) or \u0027bios\u0027"},{"line_number":671,"context_line":"        params[\u0027boot_mode\u0027] \u003d boot_mode"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"        return params"},{"line_number":674,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_789a356f","line":671,"updated":"2014-08-20 15:50:40.000000000","message":"it would be good to actually validate if that\u0027s \u0027uefi\u0027 or \u0027bios\u0027\n\nand if people set the capability to boot_mode\u003dfoo ?","commit_id":"49bce496a644da940ef36d669d36e24103fdbc8c"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"05f45fb622afb8a1aa777bab554afbd8dfaa5adb","unresolved":false,"context_lines":[{"line_number":668,"context_line":""},{"line_number":669,"context_line":"        # boot_mode \u003d \u0027uefi\u0027 or \u0027bios\u0027"},{"line_number":670,"context_line":"        boot_mode \u003d pxe_utils.get_node_capability(node, \u0027boot_mode\u0027) or \u0027bios\u0027"},{"line_number":671,"context_line":"        params[\u0027boot_mode\u0027] \u003d boot_mode"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"        return params"},{"line_number":674,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_7edcd373","line":671,"in_reply_to":"1abeadc6_789a356f","updated":"2014-08-20 21:01:13.000000000","message":"Sure, I will add this in check in validate method.\n\nthanks.","commit_id":"49bce496a644da940ef36d669d36e24103fdbc8c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"49ad47af668d659c545c5bc9aa8bdb7403d808ad","unresolved":false,"context_lines":[{"line_number":288,"context_line":"            if pxe_utils.get_node_capability(task.node, \u0027boot_mode\u0027) \u003d\u003d \u0027uefi\u0027:"},{"line_number":289,"context_line":"                LOG.exception(_LE("},{"line_number":290,"context_line":"                  \"UEFI boot mode is not supported with iPXE boot enabled.\"))"},{"line_number":291,"context_line":"                raise exception.ConfigInvalid(_LE("},{"line_number":292,"context_line":"                  \"Ironic should be configured with either iPXE or UEFI boot\"))"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        d_info \u003d _parse_deploy_info(task.node)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_e786e5da","line":291,"updated":"2014-08-26 15:48:26.000000000","message":"_LE is for logs, this is a user facing message so should not use _LE for that exception \n\n\nsee: http://docs.openstack.org/developer/oslo.i18n/guidelines.html","commit_id":"2e86fb7a7018a848c4a4ac0f712a51c332b66be4"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"46e446a926a2a13fb5135e3a3dd49618dd58807f","unresolved":false,"context_lines":[{"line_number":288,"context_line":"            if pxe_utils.get_node_capability(task.node, \u0027boot_mode\u0027) \u003d\u003d \u0027uefi\u0027:"},{"line_number":289,"context_line":"                LOG.exception(_LE("},{"line_number":290,"context_line":"                  \"UEFI boot mode is not supported with iPXE boot enabled.\"))"},{"line_number":291,"context_line":"                raise exception.ConfigInvalid(_LE("},{"line_number":292,"context_line":"                  \"Ironic should be configured with either iPXE or UEFI boot\"))"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        d_info \u003d _parse_deploy_info(task.node)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_8e7c4f22","line":291,"in_reply_to":"1abeadc6_e786e5da","updated":"2014-08-27 05:53:58.000000000","message":"Done.","commit_id":"2e86fb7a7018a848c4a4ac0f712a51c332b66be4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5accfe1832510b20473c1dba1c9637683467438d","unresolved":false,"context_lines":[{"line_number":288,"context_line":"            if pxe_utils.get_node_capability(task.node, \u0027boot_mode\u0027) \u003d\u003d \u0027uefi\u0027:"},{"line_number":289,"context_line":"                LOG.exception(_LE("},{"line_number":290,"context_line":"                  \"UEFI boot mode is not supported with iPXE boot enabled.\"))"},{"line_number":291,"context_line":"                raise exception.ConfigInvalid(_("},{"line_number":292,"context_line":"                  \"Ironic should be configured with either iPXE or UEFI boot\"))"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        d_info \u003d _parse_deploy_info(task.node)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_fb014a3a","line":291,"updated":"2014-09-01 09:03:57.000000000","message":"ConfigInvalid exception also should be added to docstring.","commit_id":"15438e2343a167d8e89fb492aed7eea0954d3c4e"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"454c3c11973bb01404e25bfd07431d8da7211ae8","unresolved":false,"context_lines":[{"line_number":288,"context_line":"            if pxe_utils.get_node_capability(task.node, \u0027boot_mode\u0027) \u003d\u003d \u0027uefi\u0027:"},{"line_number":289,"context_line":"                LOG.exception(_LE("},{"line_number":290,"context_line":"                  \"UEFI boot mode is not supported with iPXE boot enabled.\"))"},{"line_number":291,"context_line":"                raise exception.ConfigInvalid(_("},{"line_number":292,"context_line":"                  \"Ironic should be configured with either iPXE or UEFI boot\"))"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        d_info \u003d _parse_deploy_info(task.node)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_4ceffab0","line":291,"in_reply_to":"fa98f980_fb014a3a","updated":"2014-09-01 11:46:38.000000000","message":"Done.","commit_id":"15438e2343a167d8e89fb492aed7eea0954d3c4e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bee378c9f5e35c92d60e32e4ff4bcf3026dc9871","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":277,"context_line":"        :raises: InvalidParameterValue."},{"line_number":278,"context_line":"        :raises: MissingParameterValue"},{"line_number":279,"context_line":"        :raises: ConfigInvalid"},{"line_number":280,"context_line":"        \"\"\""},{"line_number":281,"context_line":"        # Check the boot_mode capability parameter value."},{"line_number":282,"context_line":"        pxe_utils.validate_boot_mode_capability(task.node)"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_51bad923","line":279,"updated":"2014-09-02 21:08:26.000000000","message":"In drivers/base.py, the docstring for DeployInterface.validate() shows InvalidParameterValue and MissingParameterValue exceptions. If this raises ConfigInvalid, do we need to update the docstring in base.py?","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"cf4fe6993518c52ce6d5c5d35342085c80f255cd","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":277,"context_line":"        :raises: InvalidParameterValue."},{"line_number":278,"context_line":"        :raises: MissingParameterValue"},{"line_number":279,"context_line":"        :raises: ConfigInvalid"},{"line_number":280,"context_line":"        \"\"\""},{"line_number":281,"context_line":"        # Check the boot_mode capability parameter value."},{"line_number":282,"context_line":"        pxe_utils.validate_boot_mode_capability(task.node)"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_8544f4b7","line":279,"in_reply_to":"fa98f980_51bad923","updated":"2014-09-02 23:58:13.000000000","message":"Done","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bee378c9f5e35c92d60e32e4ff4bcf3026dc9871","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                LOG.exception(_LE("},{"line_number":292,"context_line":"                  \"UEFI boot mode is not supported with iPXE boot enabled.\"))"},{"line_number":293,"context_line":"                raise exception.ConfigInvalid(_("},{"line_number":294,"context_line":"                  \"Ironic should be configured with either iPXE or UEFI boot\"))"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        d_info \u003d _parse_deploy_info(task.node)"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_d1ffa965","line":294,"updated":"2014-09-02 21:08:26.000000000","message":"I\u0027m a bit concerned that this message may not be clear enough. iPXE is enabled via a config pxe.ipxe_enabled. But the uefi boot is enabled via the node\u0027s capabilities property.\n\nWould something like this be clearer: \u0027Conflict. The config \"pxe.ipxe_enabled\" cannot be set to True when node %(node_uuid)s includes \"boot_mode\u003duefi\" in its \"capabilities\" property.\" Or is that too much detail/confusing?\n\nMaybe outside the scope of this patch, but would it make sense to decide that if both are enabled, log it and do uefi (or ipxe), but if uefi is specified at the node level, would it make sense that uefi is the desired mode?","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"cf4fe6993518c52ce6d5c5d35342085c80f255cd","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                LOG.exception(_LE("},{"line_number":292,"context_line":"                  \"UEFI boot mode is not supported with iPXE boot enabled.\"))"},{"line_number":293,"context_line":"                raise exception.ConfigInvalid(_("},{"line_number":294,"context_line":"                  \"Ironic should be configured with either iPXE or UEFI boot\"))"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        d_info \u003d _parse_deploy_info(task.node)"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_c5cefc2d","line":294,"in_reply_to":"fa98f980_d1ffa965","updated":"2014-09-02 23:58:13.000000000","message":"Done, updated error message","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bee378c9f5e35c92d60e32e4ff4bcf3026dc9871","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        provider.update_dhcp(task, dhcp_opts)"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        # Under UEFI boot mode, setting of boot device may differ between"},{"line_number":329,"context_line":"        # different mahcines. IPMITool does not work for setting boot devices"},{"line_number":330,"context_line":"        # in UEFI mode for certain machines."},{"line_number":331,"context_line":"        if pxe_utils.get_node_capability(task.node, \u0027boot_mode\u0027) !\u003d \u0027uefi\u0027:"},{"line_number":332,"context_line":"            manager_utils.node_set_boot_device(task, \u0027pxe\u0027, persistent\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_b12f85f5","line":329,"updated":"2014-09-02 21:08:26.000000000","message":"typo \u0027mahcines\u0027 -\u003e \u0027machines\u0027","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"cf4fe6993518c52ce6d5c5d35342085c80f255cd","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        provider.update_dhcp(task, dhcp_opts)"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        # Under UEFI boot mode, setting of boot device may differ between"},{"line_number":329,"context_line":"        # different mahcines. IPMITool does not work for setting boot devices"},{"line_number":330,"context_line":"        # in UEFI mode for certain machines."},{"line_number":331,"context_line":"        if pxe_utils.get_node_capability(task.node, \u0027boot_mode\u0027) !\u003d \u0027uefi\u0027:"},{"line_number":332,"context_line":"            manager_utils.node_set_boot_device(task, \u0027pxe\u0027, persistent\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_05b484cf","line":329,"in_reply_to":"fa98f980_b12f85f5","updated":"2014-09-02 23:58:13.000000000","message":"Done","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bee378c9f5e35c92d60e32e4ff4bcf3026dc9871","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        # different mahcines. IPMITool does not work for setting boot devices"},{"line_number":330,"context_line":"        # in UEFI mode for certain machines."},{"line_number":331,"context_line":"        if pxe_utils.get_node_capability(task.node, \u0027boot_mode\u0027) !\u003d \u0027uefi\u0027:"},{"line_number":332,"context_line":"            manager_utils.node_set_boot_device(task, \u0027pxe\u0027, persistent\u003dTrue)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":335,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_b17dc5e9","line":332,"updated":"2014-09-02 21:08:26.000000000","message":"Dumb question. I don\u0027t see the relationship between this code and the comment above it.","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"cf4fe6993518c52ce6d5c5d35342085c80f255cd","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        # different mahcines. IPMITool does not work for setting boot devices"},{"line_number":330,"context_line":"        # in UEFI mode for certain machines."},{"line_number":331,"context_line":"        if pxe_utils.get_node_capability(task.node, \u0027boot_mode\u0027) !\u003d \u0027uefi\u0027:"},{"line_number":332,"context_line":"            manager_utils.node_set_boot_device(task, \u0027pxe\u0027, persistent\u003dTrue)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":335,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_e5422067","line":332,"in_reply_to":"fa98f980_b17dc5e9","updated":"2014-09-02 23:58:13.000000000","message":"This brings up a bigger question... going to re-raise on the next review.","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"8c2e3c7321e57451ee669ae8b45626090a41d995","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        # different machines. IPMITool does not work for setting boot devices"},{"line_number":332,"context_line":"        # in UEFI mode for certain machines."},{"line_number":333,"context_line":"        if pxe_utils.get_node_capability(task.node, \u0027boot_mode\u0027) !\u003d \u0027uefi\u0027:"},{"line_number":334,"context_line":"            manager_utils.node_set_boot_device(task, \u0027pxe\u0027, persistent\u003dTrue)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"fa98f980_a8f0ef67","line":334,"updated":"2014-09-03 00:00:07.000000000","message":"How is a deployer expected to put a node into PXE mode?\n\nI think this needs some work, I don\u0027t want to blindly ignore this just because a node is uefi capable. I think we can do better here, try to set it and catch a specific error, etc.","commit_id":"7603d5c647fecf40e397aa63ef798cf8edd484c5"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"54a3989891b07150d505e7d12aca2a022e5a1e44","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        # different machines. IPMITool does not work for setting boot devices"},{"line_number":332,"context_line":"        # in UEFI mode for certain machines."},{"line_number":333,"context_line":"        if pxe_utils.get_node_capability(task.node, \u0027boot_mode\u0027) !\u003d \u0027uefi\u0027:"},{"line_number":334,"context_line":"            manager_utils.node_set_boot_device(task, \u0027pxe\u0027, persistent\u003dTrue)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"fa98f980_7fc94d58","line":334,"in_reply_to":"fa98f980_a8f0ef67","updated":"2014-09-03 11:42:32.000000000","message":"I have put this because ipmitool does not support querying/setting the boot modes. Also it does not support changing the boot device if the machine is in uefi boot mode. Also I did not want the deploy to be aborted because of this, since for pxe driver, the deploy and the subsequent boot will happen always from pxe/netboot instead of HDD. So for a deployer it is one time activity of putting the node uefi boot mode as well as setting the boot device to pxe before creating the node.\n\nI agree that such case should be handled in Management interface.  So that other management interfaces can set the boot device irrespective of the boot mode.\n\nI will give it a try calling set_boot_mode() and catching IPMIFailure.","commit_id":"7603d5c647fecf40e397aa63ef798cf8edd484c5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c872f0f975502bd8053fd571db2f94e172c69907","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                    \"root was specified.\"))"},{"line_number":289,"context_line":"            # iPXE and UEFI should not be configured together."},{"line_number":290,"context_line":"            if pxe_utils.get_node_capability(task.node, \u0027boot_mode\u0027) \u003d\u003d \u0027uefi\u0027:"},{"line_number":291,"context_line":"                LOG.exception(_LE("},{"line_number":292,"context_line":"                  \"UEFI boot mode is not supported with iPXE boot enabled.\"))"},{"line_number":293,"context_line":"                raise exception.ConfigInvalid(_("},{"line_number":294,"context_line":"                    \"Conflict: iPXE is enabled, but cannot be used with node\""}],"source_content_type":"text/x-python","patch_set":20,"id":"fa98f980_4d985c6a","line":291,"updated":"2014-09-03 13:56:18.000000000","message":"nit: no traceback here so s/exception/error/","commit_id":"500d7e8d0e6f202694d7f3e0cfd4ee4b962f5a78"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"1af2f064cf3d1eca8547fcc2226889457cf03a09","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                    \"root was specified.\"))"},{"line_number":289,"context_line":"            # iPXE and UEFI should not be configured together."},{"line_number":290,"context_line":"            if pxe_utils.get_node_capability(task.node, \u0027boot_mode\u0027) \u003d\u003d \u0027uefi\u0027:"},{"line_number":291,"context_line":"                LOG.exception(_LE("},{"line_number":292,"context_line":"                  \"UEFI boot mode is not supported with iPXE boot enabled.\"))"},{"line_number":293,"context_line":"                raise exception.ConfigInvalid(_("},{"line_number":294,"context_line":"                    \"Conflict: iPXE is enabled, but cannot be used with node\""}],"source_content_type":"text/x-python","patch_set":20,"id":"fa98f980_10858b59","line":291,"in_reply_to":"fa98f980_4d985c6a","updated":"2014-09-03 14:16:53.000000000","message":"Done","commit_id":"500d7e8d0e6f202694d7f3e0cfd4ee4b962f5a78"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4c0159d5f489db550b35a0cfd6a5a15db1dc98cd","unresolved":false,"context_lines":[{"line_number":340,"context_line":"                                \"the node is in UEFI boot mode.\""},{"line_number":341,"context_line":"                                \"Please set the boot device manually.\"))"},{"line_number":342,"context_line":"            else:"},{"line_number":343,"context_line":"                raise exception.IPMIFailure"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":346,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"fa98f980_2d2eb892","line":343,"updated":"2014-09-03 13:46:13.000000000","message":"this reraise will get rid of the message returned with the IPMIFailure, the way to do it is to just use \"raise\", for e.g\n\n else:\n     raise\n\n\nMore examples:\n\n1)\n\n try:\n     raise Exception(\"message\")\n except Exception:\n     raise Exception\n\n OUT: Exception:\n\n2)\n\n try:\n     raise Exception(\"message\")\n except Exception:\n     raise\n\n OUT: Exception: message","commit_id":"500d7e8d0e6f202694d7f3e0cfd4ee4b962f5a78"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c872f0f975502bd8053fd571db2f94e172c69907","unresolved":false,"context_lines":[{"line_number":340,"context_line":"                                \"the node is in UEFI boot mode.\""},{"line_number":341,"context_line":"                                \"Please set the boot device manually.\"))"},{"line_number":342,"context_line":"            else:"},{"line_number":343,"context_line":"                raise exception.IPMIFailure"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":346,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"fa98f980_4da4dc07","line":343,"in_reply_to":"fa98f980_2d2eb892","updated":"2014-09-03 13:56:18.000000000","message":"also you should never raise a class, only instance","commit_id":"500d7e8d0e6f202694d7f3e0cfd4ee4b962f5a78"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"1af2f064cf3d1eca8547fcc2226889457cf03a09","unresolved":false,"context_lines":[{"line_number":340,"context_line":"                                \"the node is in UEFI boot mode.\""},{"line_number":341,"context_line":"                                \"Please set the boot device manually.\"))"},{"line_number":342,"context_line":"            else:"},{"line_number":343,"context_line":"                raise exception.IPMIFailure"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":346,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"fa98f980_b0d03ff7","line":343,"in_reply_to":"fa98f980_4da4dc07","updated":"2014-09-03 14:16:53.000000000","message":"Done","commit_id":"500d7e8d0e6f202694d7f3e0cfd4ee4b962f5a78"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1c56bb13371e72446b974d4724bdbdf67364783a","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            manager_utils.node_set_boot_device(task, \u0027pxe\u0027, persistent\u003dTrue)"},{"line_number":336,"context_line":"        except exception.IPMIFailure:"},{"line_number":337,"context_line":"            if pxe_utils.get_node_capability(task.node, \u0027boot_mode\u0027) \u003d\u003d \u0027uefi\u0027:"},{"line_number":338,"context_line":"                LOG.warning(_LW(\"ipmitool is unable to set boot device while \""},{"line_number":339,"context_line":"                                \"the node is in UEFI boot mode.\""},{"line_number":340,"context_line":"                                \"Please set the boot device manually.\"))"},{"line_number":341,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":23,"id":"fa98f980_8115ab41","line":338,"updated":"2014-09-03 15:04:41.000000000","message":"nit: \u0027ipmitool\u0027 -\u003e \u0027ipmi\u0027 (if you do another patch)","commit_id":"1718a5f32ead9f2f10e2045a3080a3c4074236d1"}],"ironic/tests/dhcp/test_neutron.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"43081a1a4e5bcae8c2b07b7578580b0661eac5ad","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        port \u003d {\u0027port\u0027: port_data}"},{"line_number":252,"context_line":"        mock_show_port.return_value \u003d port"},{"line_number":253,"context_line":"        result \u003d api._get_fixed_ip_address(port_id)"},{"line_number":254,"context_line":"        self.assertEqual(result, expected)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    @mock.patch.object(client.Client, \u0027show_port\u0027)"},{"line_number":257,"context_line":"    @mock.patch.object(client.Client, \u0027__init__\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa98f980_0cc12fe4","line":254,"updated":"2014-09-02 10:07:36.000000000","message":"nit:\n\n self.assertEqual(expected, result)","commit_id":"4ac639ff71c2fda3c62d4ad966ab3438c7c295ce"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"6812dcb088f542408e47ff095066cc09cfd7c488","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        port \u003d {\u0027port\u0027: port_data}"},{"line_number":252,"context_line":"        mock_show_port.return_value \u003d port"},{"line_number":253,"context_line":"        result \u003d api._get_fixed_ip_address(port_id)"},{"line_number":254,"context_line":"        self.assertEqual(result, expected)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    @mock.patch.object(client.Client, \u0027show_port\u0027)"},{"line_number":257,"context_line":"    @mock.patch.object(client.Client, \u0027__init__\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa98f980_803b1ed0","line":254,"in_reply_to":"fa98f980_0cc12fe4","updated":"2014-09-02 12:51:54.000000000","message":"Done.","commit_id":"4ac639ff71c2fda3c62d4ad966ab3438c7c295ce"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"43081a1a4e5bcae8c2b07b7578580b0661eac5ad","unresolved":false,"context_lines":[{"line_number":283,"context_line":"            api \u003d dhcp_factory.DHCPFactory(token\u003dtask.context.auth_token)"},{"line_number":284,"context_line":"            api \u003d api.provider"},{"line_number":285,"context_line":"            result \u003d api.get_port_ip_address(task, port)"},{"line_number":286,"context_line":"        self.assertEqual(result, expected)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    @mock.patch(\u0027ironic.dhcp.neutron.NeutronDHCPApi._get_fixed_ip_address\u0027)"},{"line_number":289,"context_line":"    @mock.patch(\u0027ironic.common.network.get_node_vif_ids\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa98f980_6cb1db8e","line":286,"updated":"2014-09-02 10:07:36.000000000","message":"ditto","commit_id":"4ac639ff71c2fda3c62d4ad966ab3438c7c295ce"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"6812dcb088f542408e47ff095066cc09cfd7c488","unresolved":false,"context_lines":[{"line_number":283,"context_line":"            api \u003d dhcp_factory.DHCPFactory(token\u003dtask.context.auth_token)"},{"line_number":284,"context_line":"            api \u003d api.provider"},{"line_number":285,"context_line":"            result \u003d api.get_port_ip_address(task, port)"},{"line_number":286,"context_line":"        self.assertEqual(result, expected)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    @mock.patch(\u0027ironic.dhcp.neutron.NeutronDHCPApi._get_fixed_ip_address\u0027)"},{"line_number":289,"context_line":"    @mock.patch(\u0027ironic.common.network.get_node_vif_ids\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa98f980_004f2e6c","line":286,"in_reply_to":"fa98f980_6cb1db8e","updated":"2014-09-02 12:51:54.000000000","message":"Done","commit_id":"4ac639ff71c2fda3c62d4ad966ab3438c7c295ce"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bee378c9f5e35c92d60e32e4ff4bcf3026dc9871","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        mock_show_port.side_effect \u003d ("},{"line_number":265,"context_line":"                                neutron_client_exc.NeutronClientException())"},{"line_number":266,"context_line":"        self.assertRaises(exception.FailedToGetIPAddressOnPort,"},{"line_number":267,"context_line":"                          api._get_fixed_ip_address, port_id)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    @mock.patch(\u0027ironic.dhcp.neutron.NeutronDHCPApi._get_fixed_ip_address\u0027)"},{"line_number":270,"context_line":"    @mock.patch(\u0027ironic.common.network.get_node_vif_ids\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_af78fc8f","line":267,"updated":"2014-09-02 21:08:26.000000000","message":"I always like to add a check to make sure that something was called. In this case, if mock_show_port was called. It seems obvious that it was called, but if someone changes the code, this code could succeed for the wrong reasons.","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"cf4fe6993518c52ce6d5c5d35342085c80f255cd","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        mock_show_port.side_effect \u003d ("},{"line_number":265,"context_line":"                                neutron_client_exc.NeutronClientException())"},{"line_number":266,"context_line":"        self.assertRaises(exception.FailedToGetIPAddressOnPort,"},{"line_number":267,"context_line":"                          api._get_fixed_ip_address, port_id)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    @mock.patch(\u0027ironic.dhcp.neutron.NeutronDHCPApi._get_fixed_ip_address\u0027)"},{"line_number":270,"context_line":"    @mock.patch(\u0027ironic.common.network.get_node_vif_ids\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_080d7b37","line":267,"in_reply_to":"fa98f980_af78fc8f","updated":"2014-09-02 23:58:13.000000000","message":"Done","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"}],"ironic/tests/drivers/test_deploy_utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bee378c9f5e35c92d60e32e4ff4bcf3026dc9871","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        fname \u003d self._create_config(ipxe\u003dTrue)"},{"line_number":417,"context_line":"        utils.switch_pxe_config(fname,"},{"line_number":418,"context_line":"                               \u002712345678-1234-1234-1234-1234567890abcdef\u0027,"},{"line_number":419,"context_line":"                               boot_mode)"},{"line_number":420,"context_line":"        with open(fname, \u0027r\u0027) as f:"},{"line_number":421,"context_line":"            pxeconf \u003d f.read()"},{"line_number":422,"context_line":"        self.assertEqual(_IPXECONF_BOOT, pxeconf)"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_8f3898a1","line":419,"updated":"2014-09-02 21:08:26.000000000","message":"are there tests with boot_mode \u003d\u003d uefi and None?","commit_id":"8922e2231308ed9e57a4c69c3cc6de8d20de0511"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"8c2e3c7321e57451ee669ae8b45626090a41d995","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        fname \u003d self._create_config(ipxe\u003dTrue)"},{"line_number":417,"context_line":"        utils.switch_pxe_config(fname,"},{"line_number":418,"context_line":"                               \u002712345678-1234-1234-1234-1234567890abcdef\u0027,"},{"line_number":419,"context_line":"                               boot_mode)"},{"line_number":420,"context_line":"        with open(fname, \u0027r\u0027) as f:"},{"line_number":421,"context_line":"            pxeconf \u003d f.read()"},{"line_number":422,"context_line":"        self.assertEqual(_IPXECONF_BOOT, pxeconf)"}],"source_content_type":"text/x-python","patch_set":19,"id":"fa98f980_e8e677af","line":419,"updated":"2014-09-03 00:00:07.000000000","message":"(rloo said) are there tests with boot_mode \u003d\u003d uefi and None?","commit_id":"7603d5c647fecf40e397aa63ef798cf8edd484c5"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"54a3989891b07150d505e7d12aca2a022e5a1e44","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        fname \u003d self._create_config(ipxe\u003dTrue)"},{"line_number":417,"context_line":"        utils.switch_pxe_config(fname,"},{"line_number":418,"context_line":"                               \u002712345678-1234-1234-1234-1234567890abcdef\u0027,"},{"line_number":419,"context_line":"                               boot_mode)"},{"line_number":420,"context_line":"        with open(fname, \u0027r\u0027) as f:"},{"line_number":421,"context_line":"            pxeconf \u003d f.read()"},{"line_number":422,"context_line":"        self.assertEqual(_IPXECONF_BOOT, pxeconf)"}],"source_content_type":"text/x-python","patch_set":19,"id":"fa98f980_5f41e9a7","line":419,"in_reply_to":"fa98f980_e8e677af","updated":"2014-09-03 11:42:32.000000000","message":"I will add testcases for uefi also.","commit_id":"7603d5c647fecf40e397aa63ef798cf8edd484c5"}],"ironic/tests/test_pxe_utils.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"07c33e68928cb423b3a55c28f6de41d74c09b9e3","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        expected \u003d None"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        result \u003d pxe_utils.get_node_capability(self.node, \u0027capX\u0027)"},{"line_number":275,"context_line":"        self.assertEqual(result, expected)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def test_validate_boot_mode_capability(self):"},{"line_number":278,"context_line":"        properties \u003d {\u0027capabilities\u0027: \u0027boot_mode:uefi,cap2:value2\u0027}"}],"source_content_type":"text/x-python","patch_set":9,"id":"1abeadc6_ca48b72f","line":275,"updated":"2014-08-28 12:54:54.000000000","message":"nit: \n\n self.assertIsNone(result)","commit_id":"ce8365d600cce0d8dc0d2aafaf4d8d4994386fb5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"07c33e68928cb423b3a55c28f6de41d74c09b9e3","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        expected \u003d None"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        result \u003d pxe_utils.validate_boot_mode_capability(self.node)"},{"line_number":283,"context_line":"        self.assertEqual(result, expected)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def test_validate_boot_mode_capability_with_exception(self):"},{"line_number":286,"context_line":"        properties \u003d {\u0027capabilities\u0027: \u0027boot_mode:foo,cap2:value2\u0027}"}],"source_content_type":"text/x-python","patch_set":9,"id":"1abeadc6_ea51f3d9","line":283,"updated":"2014-08-28 12:54:54.000000000","message":"nit: \n\n self.assertIsNone(result)","commit_id":"ce8365d600cce0d8dc0d2aafaf4d8d4994386fb5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8902bbd11b2663d099b65a67969b7c709131caf9","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        self.node.properties \u003d properties"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        self.assertRaises(exception.InvalidParameterValue,"},{"line_number":294,"context_line":"                          pxe_utils.validate_boot_mode_capability, self.node)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_bba50206","line":294,"updated":"2014-09-01 08:41:24.000000000","message":"Please add a test for the clean up\n \n def test_clean_up_pxe_config_uefi(self):\n     ...","commit_id":"15438e2343a167d8e89fb492aed7eea0954d3c4e"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"454c3c11973bb01404e25bfd07431d8da7211ae8","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        self.node.properties \u003d properties"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        self.assertRaises(exception.InvalidParameterValue,"},{"line_number":294,"context_line":"                          pxe_utils.validate_boot_mode_capability, self.node)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_2c49d6d0","line":294,"in_reply_to":"fa98f980_bba50206","updated":"2014-09-01 11:46:38.000000000","message":"Sure. I will add a testcase here.","commit_id":"15438e2343a167d8e89fb492aed7eea0954d3c4e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"43081a1a4e5bcae8c2b07b7578580b0661eac5ad","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            pxe_utils._link_ip_address_pxe_configs(task)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        unlink_mock.assert_has_calls(unlink_calls)"},{"line_number":118,"context_line":"        create_link_mock.assert_has_calls(create_link_calls)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027)"},{"line_number":121,"context_line":"    @mock.patch.object(pxe_utils, \u0027_build_pxe_config\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa98f980_2c46f37c","line":118,"updated":"2014-09-02 10:07:36.000000000","message":"I guess you could use\n\n unlink_mock.assert_called_once_with(\u0027/tftpboot/0A0A0001.conf\u0027)\n\nand the same with create_link_mock","commit_id":"4ac639ff71c2fda3c62d4ad966ab3438c7c295ce"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"6812dcb088f542408e47ff095066cc09cfd7c488","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            pxe_utils._link_ip_address_pxe_configs(task)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        unlink_mock.assert_has_calls(unlink_calls)"},{"line_number":118,"context_line":"        create_link_mock.assert_has_calls(create_link_calls)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027)"},{"line_number":121,"context_line":"    @mock.patch.object(pxe_utils, \u0027_build_pxe_config\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa98f980_a03d82bd","line":118,"in_reply_to":"fa98f980_2c46f37c","updated":"2014-09-02 12:51:54.000000000","message":"There are two create link calls, so I will change it only for unlink_mock call","commit_id":"4ac639ff71c2fda3c62d4ad966ab3438c7c295ce"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"43081a1a4e5bcae8c2b07b7578580b0661eac5ad","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        expected \u003d \u0027value1\u0027"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        result \u003d pxe_utils.get_node_capability(self.node, \u0027cap1\u0027)"},{"line_number":273,"context_line":"        self.assertEqual(result, expected)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def test_get_node_capability_returns_none(self):"},{"line_number":276,"context_line":"        properties \u003d {\u0027capabilities\u0027: \u0027cap1:value1,cap2:value2\u0027}"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa98f980_ec322b0f","line":273,"updated":"2014-09-02 10:07:36.000000000","message":"nit: self.assertEqual(expected, result)","commit_id":"4ac639ff71c2fda3c62d4ad966ab3438c7c295ce"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"6812dcb088f542408e47ff095066cc09cfd7c488","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        expected \u003d \u0027value1\u0027"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        result \u003d pxe_utils.get_node_capability(self.node, \u0027cap1\u0027)"},{"line_number":273,"context_line":"        self.assertEqual(result, expected)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def test_get_node_capability_returns_none(self):"},{"line_number":276,"context_line":"        properties \u003d {\u0027capabilities\u0027: \u0027cap1:value1,cap2:value2\u0027}"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa98f980_407e966c","line":273,"in_reply_to":"fa98f980_ec322b0f","updated":"2014-09-02 12:51:54.000000000","message":"done","commit_id":"4ac639ff71c2fda3c62d4ad966ab3438c7c295ce"}]}
