)]}'
{"ironic/tests/drivers/test_ipmitool.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"341c738e5f8d5ffa0360f4e5436d8956af0660e8","unresolved":false,"context_lines":[{"line_number":490,"context_line":"        expected \u003d ipmi.COMMON_PROPERTIES"},{"line_number":491,"context_line":"        self.assertEqual(expected, self.driver.power.get_properties())"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        expected \u003d list(ipmi.COMMON_PROPERTIES) + list(ipmi.CONSOLE_PROPERTIES)"},{"line_number":494,"context_line":"        self.assertEqual(sorted(expected),"},{"line_number":495,"context_line":"                         sorted(self.driver.console.get_properties().keys()))"},{"line_number":496,"context_line":"        self.assertEqual(sorted(expected),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_2e36f2e7","line":493,"updated":"2014-08-19 12:33:12.000000000","message":"heh, I would even rewrite it as set(..) | set(..) and then get rid of sorted() calls. Nitpicking of course :)","commit_id":"28892279b26325ae45b118ebc29ba5f38fa253e5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"550881ef1cb8e67ce76085d97c1913482746a306","unresolved":false,"context_lines":[{"line_number":490,"context_line":"        expected \u003d ipmi.COMMON_PROPERTIES"},{"line_number":491,"context_line":"        self.assertEqual(expected, self.driver.power.get_properties())"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        expected \u003d list(ipmi.COMMON_PROPERTIES) + list(ipmi.CONSOLE_PROPERTIES)"},{"line_number":494,"context_line":"        self.assertEqual(sorted(expected),"},{"line_number":495,"context_line":"                         sorted(self.driver.console.get_properties().keys()))"},{"line_number":496,"context_line":"        self.assertEqual(sorted(expected),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_81cef4b2","line":493,"in_reply_to":"1abeadc6_2e36f2e7","updated":"2014-08-19 14:41:08.000000000","message":"We use sorted() in various tests, instead of set(). But yes, set() seems to be clearer. Do we want to change them all?","commit_id":"28892279b26325ae45b118ebc29ba5f38fa253e5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"de185a2eb92715c55f3819c97716cf145f1fd83e","unresolved":false,"context_lines":[{"line_number":490,"context_line":"        expected \u003d ipmi.COMMON_PROPERTIES"},{"line_number":491,"context_line":"        self.assertEqual(expected, self.driver.power.get_properties())"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        expected \u003d list(ipmi.COMMON_PROPERTIES) + list(ipmi.CONSOLE_PROPERTIES)"},{"line_number":494,"context_line":"        self.assertEqual(sorted(expected),"},{"line_number":495,"context_line":"                         sorted(self.driver.console.get_properties().keys()))"},{"line_number":496,"context_line":"        self.assertEqual(sorted(expected),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_fcfe6bad","line":493,"in_reply_to":"1abeadc6_81cef4b2","updated":"2014-08-19 14:57:28.000000000","message":"I don\u0027t think so, we have more pressing things to do :) we may start using sets in a new code, though","commit_id":"28892279b26325ae45b118ebc29ba5f38fa253e5"}]}