)]}'
{"ironic/drivers/ilo.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"afa52544133938f474bc626ca199177f8c38f411","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self.power \u003d power.IloPower()"},{"line_number":71,"context_line":"        self.deploy \u003d deploy.IloVirtualMediaAgentDeploy()"},{"line_number":72,"context_line":"        self.rescue \u003d None"},{"line_number":73,"context_line":"        self.agent_vendor \u003d agent.AgentVendorInterface()"},{"line_number":74,"context_line":"        self.console \u003d ipmitool.IPMIShellinaboxConsole()"},{"line_number":75,"context_line":"        self.management \u003d ipmitool.IPMIManagement()"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_1ae241d5","line":72,"updated":"2014-09-02 10:54:39.000000000","message":"redundant IIRC","commit_id":"cd6c356f6cb3c02ec7d77ad7899e3565b6e3aa2a"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"5b8533e92424d7655595d410217f457b0f1438c3","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self.power \u003d power.IloPower()"},{"line_number":71,"context_line":"        self.deploy \u003d deploy.IloVirtualMediaAgentDeploy()"},{"line_number":72,"context_line":"        self.rescue \u003d None"},{"line_number":73,"context_line":"        self.agent_vendor \u003d agent.AgentVendorInterface()"},{"line_number":74,"context_line":"        self.console \u003d ipmitool.IPMIShellinaboxConsole()"},{"line_number":75,"context_line":"        self.management \u003d ipmitool.IPMIManagement()"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_a05ae24d","line":72,"in_reply_to":"fa98f980_1ae241d5","updated":"2014-09-03 06:34:24.000000000","message":"Done","commit_id":"cd6c356f6cb3c02ec7d77ad7899e3565b6e3aa2a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"afa52544133938f474bc626ca199177f8c38f411","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.mapping \u003d {\u0027heartbeat\u0027: self.agent_vendor}"},{"line_number":77,"context_line":"        self.dl_mapping \u003d {\u0027lookup\u0027: self.agent_vendor}"},{"line_number":78,"context_line":"        self.vendor \u003d utils.MixinVendorInterface(self.mapping,"},{"line_number":79,"context_line":"                driver_passthru_mapping\u003dself.dl_mapping)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_9af47188","line":79,"updated":"2014-09-02 10:54:39.000000000","message":"Why not\n\n self.vendor \u003d agent.AgentVendorInterface()\n\ndo you expect more vendor interfaces?","commit_id":"cd6c356f6cb3c02ec7d77ad7899e3565b6e3aa2a"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"5b8533e92424d7655595d410217f457b0f1438c3","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.mapping \u003d {\u0027heartbeat\u0027: self.agent_vendor}"},{"line_number":77,"context_line":"        self.dl_mapping \u003d {\u0027lookup\u0027: self.agent_vendor}"},{"line_number":78,"context_line":"        self.vendor \u003d utils.MixinVendorInterface(self.mapping,"},{"line_number":79,"context_line":"                driver_passthru_mapping\u003dself.dl_mapping)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_805f9e40","line":79,"in_reply_to":"fa98f980_95d9a285","updated":"2014-09-03 06:34:24.000000000","message":"Done","commit_id":"cd6c356f6cb3c02ec7d77ad7899e3565b6e3aa2a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9f39d4e4178ee81c923b6cb177d3c64563126ad9","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.mapping \u003d {\u0027heartbeat\u0027: self.agent_vendor}"},{"line_number":77,"context_line":"        self.dl_mapping \u003d {\u0027lookup\u0027: self.agent_vendor}"},{"line_number":78,"context_line":"        self.vendor \u003d utils.MixinVendorInterface(self.mapping,"},{"line_number":79,"context_line":"                driver_passthru_mapping\u003dself.dl_mapping)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_95d9a285","line":79,"in_reply_to":"fa98f980_9af47188","updated":"2014-09-02 11:23:00.000000000","message":"+1\n\nAs both methods come from the same interface I don\u0027t think we need mapping here do we?","commit_id":"cd6c356f6cb3c02ec7d77ad7899e3565b6e3aa2a"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"5b8533e92424d7655595d410217f457b0f1438c3","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.mapping \u003d {\u0027heartbeat\u0027: self.agent_vendor}"},{"line_number":77,"context_line":"        self.dl_mapping \u003d {\u0027lookup\u0027: self.agent_vendor}"},{"line_number":78,"context_line":"        self.vendor \u003d utils.MixinVendorInterface(self.mapping,"},{"line_number":79,"context_line":"                driver_passthru_mapping\u003dself.dl_mapping)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_6049da8a","line":79,"in_reply_to":"fa98f980_9af47188","updated":"2014-09-03 06:34:24.000000000","message":"Done","commit_id":"cd6c356f6cb3c02ec7d77ad7899e3565b6e3aa2a"}],"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"afa52544133938f474bc626ca199177f8c38f411","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    return info"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"def _build_agent_options():"},{"line_number":191,"context_line":"    \"\"\"Build the options to be passed to the agent ramdisk."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    :returns: a dictionary containing the parameters to be passed to"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_7a40ada5","line":190,"updated":"2014-09-02 10:54:39.000000000","message":"maybe this should be moved to agent.py ?","commit_id":"cd6c356f6cb3c02ec7d77ad7899e3565b6e3aa2a"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"5b8533e92424d7655595d410217f457b0f1438c3","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    return info"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"def _build_agent_options():"},{"line_number":191,"context_line":"    \"\"\"Build the options to be passed to the agent ramdisk."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    :returns: a dictionary containing the parameters to be passed to"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_4d27ae12","line":190,"in_reply_to":"fa98f980_7a40ada5","updated":"2014-09-03 06:34:24.000000000","message":"Done","commit_id":"cd6c356f6cb3c02ec7d77ad7899e3565b6e3aa2a"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f7fa2da58ae452313a13831679cef6cebcd97e4e","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        deploy_ramdisk_opts \u003d agent.build_agent_options()"},{"line_number":325,"context_line":"        deploy_iso_uuid \u003d task.node.driver_info[\u0027ilo_deploy_iso\u0027]"},{"line_number":326,"context_line":"        deploy_iso \u003d \u0027glance:\u0027 + deploy_iso_uuid"},{"line_number":327,"context_line":"        ilo_common.setup_vmedia_for_boot(task, deploy_iso, deploy_ramdisk_opts)"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        node \u003d task.node"},{"line_number":330,"context_line":"        node.instance_info \u003d agent.build_instance_info_for_deploy(task)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa98f980_08a9fbde","line":327,"updated":"2014-09-02 23:54:52.000000000","message":"(shamelessly plagiarized from myself in ilo iscsi review)\n\nThis should happen in deploy() as it starts the \u0027timer\u0027 for the swift temp url.\n\nI think there\u0027s actually a place here for a generally useful method, something like:\n\n    def _reboot_into(task, iso, opts):\n        ilo_common_setup_vmedia_for_boot(task, iso, opts)\n        ilo_common.set_boot_device(task.node, \u0027CDROM\u0027)\n        manager_utils.node_power_action(task, states.REBOOT)\n\nAnd call this for any reboot, so that way you always do it as an atomic action: attach iso, set boot device to iso, reboot into it.\n\nWDYT?","commit_id":"ffb13e91a08966eba5309bac6ef6bc56e39ac402"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"88000c4d01cb9353fd842443a3a2e1cfedd8a97c","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        deploy_ramdisk_opts \u003d agent.build_agent_options()"},{"line_number":325,"context_line":"        deploy_iso_uuid \u003d task.node.driver_info[\u0027ilo_deploy_iso\u0027]"},{"line_number":326,"context_line":"        deploy_iso \u003d \u0027glance:\u0027 + deploy_iso_uuid"},{"line_number":327,"context_line":"        ilo_common.setup_vmedia_for_boot(task, deploy_iso, deploy_ramdisk_opts)"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        node \u003d task.node"},{"line_number":330,"context_line":"        node.instance_info \u003d agent.build_instance_info_for_deploy(task)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa98f980_e254cb00","line":327,"in_reply_to":"fa98f980_08a9fbde","updated":"2014-09-03 06:34:09.000000000","message":"Done","commit_id":"ffb13e91a08966eba5309bac6ef6bc56e39ac402"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f7fa2da58ae452313a13831679cef6cebcd97e4e","unresolved":false,"context_lines":[{"line_number":334,"context_line":"        \"\"\"Clean up the deployment environment for this node."},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        :param task: a TaskManager instance."},{"line_number":337,"context_line":"        \"\"\""},{"line_number":338,"context_line":"        pass"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    def take_over(self, task):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa98f980_082adb2b","line":337,"updated":"2014-09-02 23:54:52.000000000","message":"This should probably clean up some stuff? Make sure deploy iso is detached and all swift temp urls expired possibly among other things?","commit_id":"ffb13e91a08966eba5309bac6ef6bc56e39ac402"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"88000c4d01cb9353fd842443a3a2e1cfedd8a97c","unresolved":false,"context_lines":[{"line_number":334,"context_line":"        \"\"\"Clean up the deployment environment for this node."},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        :param task: a TaskManager instance."},{"line_number":337,"context_line":"        \"\"\""},{"line_number":338,"context_line":"        pass"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    def take_over(self, task):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa98f980_426af7b3","line":337,"in_reply_to":"fa98f980_082adb2b","updated":"2014-09-03 06:34:09.000000000","message":"Done","commit_id":"ffb13e91a08966eba5309bac6ef6bc56e39ac402"}],"ironic/tests/drivers/agent_pxe_config.template":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f7fa2da58ae452313a13831679cef6cebcd97e4e","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"label deploy"},{"line_number":4,"context_line":"kernel {{ pxe_options.deployment_aki_path }}"},{"line_number":5,"context_line":"append initrd\u003d{{ pxe_options.deployment_ari_path }} root\u003dsquashfs: {% if pxe_options.pxe_append_params %}{{ pxe_options.pxe_append_params }}{% endif %} state\u003dtmpfs: ipa-api-url\u003d{{ pxe_options.ipa-api-url }} {% if pxe_options.ipa-advertise-host %}ipa-advertise-host\u003d{{ pxe_options.ipa-advertise-host }}{% endif %}"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"fa98f980_08b49bcf","line":5,"updated":"2014-09-02 23:54:52.000000000","message":"Nothing seems like it should require these template changes. Even if they are required, they should be mentioned in the commit message :)","commit_id":"ffb13e91a08966eba5309bac6ef6bc56e39ac402"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"88000c4d01cb9353fd842443a3a2e1cfedd8a97c","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"label deploy"},{"line_number":4,"context_line":"kernel {{ pxe_options.deployment_aki_path }}"},{"line_number":5,"context_line":"append initrd\u003d{{ pxe_options.deployment_ari_path }} root\u003dsquashfs: {% if pxe_options.pxe_append_params %}{{ pxe_options.pxe_append_params }}{% endif %} state\u003dtmpfs: ipa-api-url\u003d{{ pxe_options.ipa-api-url }} {% if pxe_options.ipa-advertise-host %}ipa-advertise-host\u003d{{ pxe_options.ipa-advertise-host }}{% endif %}"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"fa98f980_e2892b76","line":5,"in_reply_to":"fa98f980_08b49bcf","updated":"2014-09-03 06:34:09.000000000","message":"These template changes are required to make the arguments generated and the ones expected by agent ramdisk to be same.  For example, the arguments generated by code was ipa_api_url whereas the agent ramdisk expected ipa-api-url.  Currently it was the template which converted this ipa_api_url to ipa-api-url.  If both were same, irrespective of boot mechanism, we could pass the information to agent ramdisk.  I will add this to commit message.","commit_id":"ffb13e91a08966eba5309bac6ef6bc56e39ac402"}]}