)]}'
{"ironic/nova/virt/ironic/driver.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7866674b1a56ce988988d267d4f455bed3137c2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from ironic.nova.virt.ironic import client_wrapper"},{"line_number":29,"context_line":"from ironic.nova.virt.ironic import ironic_states"},{"line_number":30,"context_line":"from ironic.nova.virt.ironic import patcher"},{"line_number":31,"context_line":"from nova import context as nova_context"},{"line_number":32,"context_line":"from nova.compute import arch"},{"line_number":33,"context_line":"from nova.compute import power_state"},{"line_number":34,"context_line":"from nova.compute import task_states"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_092cef49","line":31,"updated":"2014-08-26 03:28:02.000000000","message":"why is this before nova.compute?","commit_id":"05b6a6a06e1e248692378a38c9e45d9f43d469b8"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"aa1f0800df2600f3410a39d7009564c1db66fb03","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from ironic.nova.virt.ironic import client_wrapper"},{"line_number":29,"context_line":"from ironic.nova.virt.ironic import ironic_states"},{"line_number":30,"context_line":"from ironic.nova.virt.ironic import patcher"},{"line_number":31,"context_line":"from nova import context as nova_context"},{"line_number":32,"context_line":"from nova.compute import arch"},{"line_number":33,"context_line":"from nova.compute import power_state"},{"line_number":34,"context_line":"from nova.compute import task_states"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_e902530a","line":31,"in_reply_to":"1abeadc6_092cef49","updated":"2014-08-26 03:51:31.000000000","message":"This is an unrelated change, but I\u0027m happy to correct it while I\u0027m here :)","commit_id":"05b6a6a06e1e248692378a38c9e45d9f43d469b8"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"afe39283a28dcbadb991e15b88c79eb6cd1c705c","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        memory_mb \u003d int(node.properties.get(\u0027memory_mb\u0027, 0))"},{"line_number":186,"context_line":"        local_gb \u003d int(node.properties.get(\u0027local_gb\u0027, 0))"},{"line_number":187,"context_line":"        cpu_arch \u003d arch.canonicalize(str(node.properties.get("},{"line_number":188,"context_line":"            \u0027cpu_arch\u0027, arch.from_host())))"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        nodes_extra_specs \u003d self.extra_specs.copy()"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_b5f33809","line":188,"updated":"2014-08-26 14:18:43.000000000","message":"Hmm, I don\u0027t love this from_host() thing for ironic. This is going to end up being the arch for the nova-compute host, which in our case has nothing to do with what the arch is for the actual node.\n\nBut... not sure what else to do here :/","commit_id":"e547e4053210e27261c14de3852e96c1c9e25e0b"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"f06ca0e50461dd1b68330d4df1a4855ffca7263c","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        memory_mb \u003d int(node.properties.get(\u0027memory_mb\u0027, 0))"},{"line_number":186,"context_line":"        local_gb \u003d int(node.properties.get(\u0027local_gb\u0027, 0))"},{"line_number":187,"context_line":"        cpu_arch \u003d arch.canonicalize(str(node.properties.get("},{"line_number":188,"context_line":"            \u0027cpu_arch\u0027, arch.from_host())))"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        nodes_extra_specs \u003d self.extra_specs.copy()"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_1032d90f","line":188,"updated":"2014-08-28 15:21:08.000000000","message":"I tend to agree that arch.from_host() is not right for Ironic\u0027s use case.","commit_id":"e547e4053210e27261c14de3852e96c1c9e25e0b"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"6a5e794edb8626820f243d26f97668f2a3530b3e","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        memory_mb \u003d int(node.properties.get(\u0027memory_mb\u0027, 0))"},{"line_number":186,"context_line":"        local_gb \u003d int(node.properties.get(\u0027local_gb\u0027, 0))"},{"line_number":187,"context_line":"        cpu_arch \u003d arch.canonicalize(str(node.properties.get("},{"line_number":188,"context_line":"            \u0027cpu_arch\u0027, arch.from_host())))"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        nodes_extra_specs \u003d self.extra_specs.copy()"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_f31cde6c","line":188,"in_reply_to":"1abeadc6_b5f33809","updated":"2014-08-26 19:06:21.000000000","message":"The NotFound answer made sense to me.","commit_id":"e547e4053210e27261c14de3852e96c1c9e25e0b"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"4162fc2ffab55d2eea9d429c334b24eaef9e13c9","unresolved":false,"context_lines":[{"line_number":120,"context_line":"def _get_nodes_supported_instances(cpu_arch\u003dNone):"},{"line_number":121,"context_line":"    \"\"\"Return supported instances for a node.\"\"\""},{"line_number":122,"context_line":"    if cpu_arch is None:"},{"line_number":123,"context_line":"        return []"},{"line_number":124,"context_line":"    return [(cpu_arch, \u0027baremetal\u0027, \u0027baremetal\u0027)]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_069623f0","line":123,"updated":"2014-08-28 16:06:22.000000000","message":"Returning an empty list semantically indicates that there are no supported instances for this node, which is a good fit when no architecture is set. So this approach gets my vote.","commit_id":"ccbcfce5044ff3ec35c8a24dc0c26b8580feeac8"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"07055ffee76b25fa9a178d9f86c2ffdebb3ec650","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    \"\"\"Return supported instances for a node.\"\"\""},{"line_number":122,"context_line":"    if cpu_arch is None:"},{"line_number":123,"context_line":"        return []"},{"line_number":124,"context_line":"    return [(cpu_arch, \u0027baremetal\u0027, \u0027baremetal\u0027)]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"def _log_ironic_polling(what, node, instance):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_a4cac74c","line":124,"updated":"2014-08-28 16:54:32.000000000","message":"From what I can tell... this looks broken in general.  The image_props_filter in nova seems to think supported_instances should be a dict?","commit_id":"bdb5657fbfb43961c8bea3adeeb744738aac9ad6"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"d94f29cc5a391709a23433010f7b960a3e97c0a8","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    \"\"\"Return supported instances for a node.\"\"\""},{"line_number":122,"context_line":"    if cpu_arch is None:"},{"line_number":123,"context_line":"        return []"},{"line_number":124,"context_line":"    return [(cpu_arch, \u0027baremetal\u0027, \u0027baremetal\u0027)]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"def _log_ironic_polling(what, node, instance):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_39334c15","line":124,"in_reply_to":"1abeadc6_a4cac74c","updated":"2014-09-03 22:01:33.000000000","message":"nevermind that previous comment... I was wrong. :)","commit_id":"bdb5657fbfb43961c8bea3adeeb744738aac9ad6"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"a0c1e055362fa443a96c7e58970727e549e30127","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    \"\"\"Return supported instances for a node.\"\"\""},{"line_number":122,"context_line":"    if not cpu_arch:"},{"line_number":123,"context_line":"        cpu_arch \u003d \u0027\u0027"},{"line_number":124,"context_line":"    return [(cpu_arch, \u0027baremetal\u0027, \u0027baremetal\u0027)]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"def _log_ironic_polling(what, node, instance):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_49a83077","line":124,"updated":"2014-09-04 09:01:22.000000000","message":"Using an empty string for the arch is not going to fly. When nova enforces valid arch names, ironic is going to crash \u0026 burn with this empty string. If we don\u0027t have a valid arch, then we should return the empty list, as the previous patch did, in order to indicate that there are not valid instances supported.","commit_id":"847a7f69ded2f135b0c491f5d37a925614c208d7"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"16b8566b570ed86f77bec2e7b5b1ce0635867713","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    \"\"\"Return supported instances for a node.\"\"\""},{"line_number":122,"context_line":"    if not cpu_arch:"},{"line_number":123,"context_line":"        cpu_arch \u003d \u0027\u0027"},{"line_number":124,"context_line":"    return [(cpu_arch, \u0027baremetal\u0027, \u0027baremetal\u0027)]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"def _log_ironic_polling(what, node, instance):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_ec4012a7","line":124,"in_reply_to":"fa98f980_49a83077","updated":"2014-09-04 09:34:49.000000000","message":"Thanks Daniel for the review.  I\u0027ve made this change and updated it.","commit_id":"847a7f69ded2f135b0c491f5d37a925614c208d7"}]}
