)]}'
{"ironic/drivers/drac.py":[{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"089ed1128453ff2275e7103ba137d5dbad5b1b72","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class PXEDracDriver(base.BaseDriver):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    \"\"\"Drac driver using PXE for deploy.\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_555b2821","line":26,"updated":"2014-08-29 15:54:55.000000000","message":"Blank line not needed. Please correct if another patch is pushed up. Other wise I\u0027m ok if it\u0027s fix in a follow up patch.","commit_id":"594f1b355ef0b9c2b85a34be6ea45fff2ddda286"}],"ironic/drivers/modules/drac/common.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c5a0b8d295045dbcf5bc93999497de1efac803f","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    :param doc: the element tree object."},{"line_number":107,"context_line":"    :param namespace: the namespace of the element."},{"line_number":108,"context_line":"    :param find_all: boolean value, if True find all elements, if False"},{"line_number":109,"context_line":"                     find only the first one. Defaults to False."},{"line_number":110,"context_line":"    :returns: The element object if find_all is False or a list of"},{"line_number":111,"context_line":"              element objects if find_all is True."}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_d11ebf6f","line":108,"updated":"2014-08-28 02:55:44.000000000","message":"nit: boolean -\u003e Boolean","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"27b6dd5aa24ac0336ec7aef20ee3766ecfceef58","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    :param doc: the element tree object."},{"line_number":107,"context_line":"    :param namespace: the namespace of the element."},{"line_number":108,"context_line":"    :param find_all: boolean value, if True find all elements, if False"},{"line_number":109,"context_line":"                     find only the first one. Defaults to False."},{"line_number":110,"context_line":"    :returns: The element object if find_all is False or a list of"},{"line_number":111,"context_line":"              element objects if find_all is True."}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_419d7709","line":108,"in_reply_to":"1abeadc6_d11ebf6f","updated":"2014-08-28 09:51:48.000000000","message":"Done","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2738ef2b0c9e2d4491aa378b569cc945740c0e3e","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    :param namespace: the namespace of the element."},{"line_number":109,"context_line":"    :param find_all: Boolean value, if True find all elements, if False"},{"line_number":110,"context_line":"                     find only the first one. Defaults to False."},{"line_number":111,"context_line":"    :returns: The element object if find_all is False or a list of"},{"line_number":112,"context_line":"              element objects if find_all is True."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_26b0c7f3","line":111,"updated":"2014-09-02 14:21:10.000000000","message":"nit: the original had \u0027element object or None if the element is not found\u0027 -- do we want to mention that here too?","commit_id":"2eb3c12ce3fb2b2eb4408367f2c950724a098d93"}],"ironic/drivers/modules/drac/management.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e9919f34a7a6d4102ca71950a5ad9ff47e299a5b","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        instance_id \u003d drac_common.find_xml(doc, \u0027InstanceID\u0027,"},{"line_number":272,"context_line":"                                     resource_uris.DCIM_BootSourceSetting).text"},{"line_number":273,"context_line":"        boot_device \u003d None"},{"line_number":274,"context_line":"        for device, device_string in _BOOT_DEVICES_MAP.iteritems():"},{"line_number":275,"context_line":"            device_re \u003d re.compile(device_string)"},{"line_number":276,"context_line":"            if device_re.search(instance_id):"},{"line_number":277,"context_line":"                boot_device \u003d device"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_c7448976","line":274,"updated":"2014-08-26 15:43:07.000000000","message":"iteritems() is Python3 incompatible, please do not use.","commit_id":"338e1b91df9599c76fc6ce1aa8030f9959d9aa9b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c1a22f33777071c2f22b7c9aba07379e1667063a","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        instance_id \u003d drac_common.find_xml(doc, \u0027InstanceID\u0027,"},{"line_number":272,"context_line":"                                     resource_uris.DCIM_BootSourceSetting).text"},{"line_number":273,"context_line":"        boot_device \u003d None"},{"line_number":274,"context_line":"        for device, device_string in _BOOT_DEVICES_MAP.iteritems():"},{"line_number":275,"context_line":"            device_re \u003d re.compile(device_string)"},{"line_number":276,"context_line":"            if device_re.search(instance_id):"},{"line_number":277,"context_line":"                boot_device \u003d device"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_2efd123c","line":274,"in_reply_to":"1abeadc6_c7448976","updated":"2014-08-26 17:36:01.000000000","message":"done thanks","commit_id":"338e1b91df9599c76fc6ce1aa8030f9959d9aa9b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e9919f34a7a6d4102ca71950a5ad9ff47e299a5b","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        boot_device \u003d None"},{"line_number":274,"context_line":"        for device, device_string in _BOOT_DEVICES_MAP.iteritems():"},{"line_number":275,"context_line":"            device_re \u003d re.compile(device_string)"},{"line_number":276,"context_line":"            if device_re.search(instance_id):"},{"line_number":277,"context_line":"                boot_device \u003d device"},{"line_number":278,"context_line":"                break"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_baca409f","line":276,"updated":"2014-08-26 15:43:07.000000000","message":"if device_string in instance_id:","commit_id":"338e1b91df9599c76fc6ce1aa8030f9959d9aa9b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c1a22f33777071c2f22b7c9aba07379e1667063a","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        boot_device \u003d None"},{"line_number":274,"context_line":"        for device, device_string in _BOOT_DEVICES_MAP.iteritems():"},{"line_number":275,"context_line":"            device_re \u003d re.compile(device_string)"},{"line_number":276,"context_line":"            if device_re.search(instance_id):"},{"line_number":277,"context_line":"                boot_device \u003d device"},{"line_number":278,"context_line":"                break"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_0e02163e","line":276,"in_reply_to":"1abeadc6_baca409f","updated":"2014-08-26 17:36:01.000000000","message":"done thanks","commit_id":"338e1b91df9599c76fc6ce1aa8030f9959d9aa9b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"17beafef9982f39c4ef2d6f8460a938e29c02569","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    \u0027persistent\u0027: \u00271\u0027,"},{"line_number":46,"context_line":"    \u0027not_next\u0027: \u00272\u0027,"},{"line_number":47,"context_line":"    \u0027one_time_boot\u0027: \u00273\u0027,"},{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def get_next_boot_mode(node):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_d42b2ce9","line":48,"updated":"2014-08-27 11:40:21.000000000","message":"Looks like these can be just 3 constants:\n\n PERSISTENT \u003d \u00271\u0027\n\netc","commit_id":"45668d0cc0e572a6bd510f8fcbb448c6ff146676"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d2b97af58374fcbcdcf0003225181e1497591950","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    \u0027persistent\u0027: \u00271\u0027,"},{"line_number":46,"context_line":"    \u0027not_next\u0027: \u00272\u0027,"},{"line_number":47,"context_line":"    \u0027one_time_boot\u0027: \u00273\u0027,"},{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def get_next_boot_mode(node):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_3f726ce3","line":48,"in_reply_to":"1abeadc6_d42b2ce9","updated":"2014-08-27 16:48:22.000000000","message":"Done","commit_id":"45668d0cc0e572a6bd510f8fcbb448c6ff146676"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"17beafef9982f39c4ef2d6f8460a938e29c02569","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    #                    job created (but changes will be applied after"},{"line_number":129,"context_line":"    #                    the reboot)"},{"line_number":130,"context_line":"    # Boot Management Documentation: http://goo.gl/aEsvUH (Section 8.4)"},{"line_number":131,"context_line":"    if return_value \u003d\u003d \u00272\u0027:"},{"line_number":132,"context_line":"        raise exception.DracConfigJobAlreadyCreated()"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_9449b4d2","line":131,"updated":"2014-08-27 11:40:21.000000000","message":"2 should be a top level constant","commit_id":"45668d0cc0e572a6bd510f8fcbb448c6ff146676"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d2b97af58374fcbcdcf0003225181e1497591950","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    #                    job created (but changes will be applied after"},{"line_number":129,"context_line":"    #                    the reboot)"},{"line_number":130,"context_line":"    # Boot Management Documentation: http://goo.gl/aEsvUH (Section 8.4)"},{"line_number":131,"context_line":"    if return_value \u003d\u003d \u00272\u0027:"},{"line_number":132,"context_line":"        raise exception.DracConfigJobAlreadyCreated()"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_ff70f4dd","line":131,"in_reply_to":"1abeadc6_9449b4d2","updated":"2014-08-27 16:48:22.000000000","message":"Done","commit_id":"45668d0cc0e572a6bd510f8fcbb448c6ff146676"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"17beafef9982f39c4ef2d6f8460a938e29c02569","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":192,"context_line":"                LOG.error(_LE(\u0027DRAC driver failed to set the boot device \u0027"},{"line_number":193,"context_line":"                              \u0027for node %(node_uuid)s. Can\\\u0027t find the ID \u0027"},{"line_number":194,"context_line":"                              \u0027 for the %(device)s type. Reason: %(error)s.\u0027),"},{"line_number":195,"context_line":"                          {\u0027node_uuid\u0027: task.node.uuid, \u0027error\u0027: exc,"},{"line_number":196,"context_line":"                           \u0027device\u0027: device})"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_747258e4","line":194,"updated":"2014-08-27 11:40:21.000000000","message":"nit: redundant space in the beginning","commit_id":"45668d0cc0e572a6bd510f8fcbb448c6ff146676"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d2b97af58374fcbcdcf0003225181e1497591950","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":192,"context_line":"                LOG.error(_LE(\u0027DRAC driver failed to set the boot device \u0027"},{"line_number":193,"context_line":"                              \u0027for node %(node_uuid)s. Can\\\u0027t find the ID \u0027"},{"line_number":194,"context_line":"                              \u0027 for the %(device)s type. Reason: %(error)s.\u0027),"},{"line_number":195,"context_line":"                          {\u0027node_uuid\u0027: task.node.uuid, \u0027error\u0027: exc,"},{"line_number":196,"context_line":"                           \u0027device\u0027: device})"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_df6df805","line":194,"in_reply_to":"1abeadc6_747258e4","updated":"2014-08-27 16:48:22.000000000","message":"Done","commit_id":"45668d0cc0e572a6bd510f8fcbb448c6ff146676"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"17beafef9982f39c4ef2d6f8460a938e29c02569","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        # NOTE(lucasagomes): Don\u0027t ask me why \u0027BootSourceType\u0027 is set"},{"line_number":207,"context_line":"        # for \u0027InstanceID\u0027 and \u0027InstanceID\u0027 is set for \u0027source\u0027! You"},{"line_number":208,"context_line":"        # know enterprisey..."},{"line_number":209,"context_line":"        options \u003d pywsman.ClientOptions()"},{"line_number":210,"context_line":"        options.add_selector(\u0027InstanceID\u0027, source)"},{"line_number":211,"context_line":"        options.add_property(\u0027source\u0027, instance_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_343f00d8","line":208,"updated":"2014-08-27 11:40:21.000000000","message":"lol. do you have some link explaining this?","commit_id":"45668d0cc0e572a6bd510f8fcbb448c6ff146676"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d2b97af58374fcbcdcf0003225181e1497591950","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        # NOTE(lucasagomes): Don\u0027t ask me why \u0027BootSourceType\u0027 is set"},{"line_number":207,"context_line":"        # for \u0027InstanceID\u0027 and \u0027InstanceID\u0027 is set for \u0027source\u0027! You"},{"line_number":208,"context_line":"        # know enterprisey..."},{"line_number":209,"context_line":"        options \u003d pywsman.ClientOptions()"},{"line_number":210,"context_line":"        options.add_selector(\u0027InstanceID\u0027, source)"},{"line_number":211,"context_line":"        options.add_property(\u0027source\u0027, instance_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_3fab4c1f","line":208,"in_reply_to":"1abeadc6_343f00d8","updated":"2014-08-27 16:48:22.000000000","message":"will try to find some, but it blew my mind at one point....","commit_id":"45668d0cc0e572a6bd510f8fcbb448c6ff146676"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"17beafef9982f39c4ef2d6f8460a938e29c02569","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        #                    0 for success or 4096 job created (but"},{"line_number":218,"context_line":"        #                    changes will be applied after the reboot)"},{"line_number":219,"context_line":"        # Boot Management Documentation: http://goo.gl/aEsvUH (Section 8.7)"},{"line_number":220,"context_line":"        if return_value \u003d\u003d \u00272\u0027:"},{"line_number":221,"context_line":"            error_message \u003d drac_common.find_xml(doc, \u0027Message\u0027,"},{"line_number":222,"context_line":"                                     resource_uris.DCIM_BootConfigSetting).text"},{"line_number":223,"context_line":"            raise exception.DracOperationError(operation\u003d\u0027set_boot_device\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_742098b0","line":220,"updated":"2014-08-27 11:40:21.000000000","message":"ditto about constant","commit_id":"45668d0cc0e572a6bd510f8fcbb448c6ff146676"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d2b97af58374fcbcdcf0003225181e1497591950","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        #                    0 for success or 4096 job created (but"},{"line_number":218,"context_line":"        #                    changes will be applied after the reboot)"},{"line_number":219,"context_line":"        # Boot Management Documentation: http://goo.gl/aEsvUH (Section 8.7)"},{"line_number":220,"context_line":"        if return_value \u003d\u003d \u00272\u0027:"},{"line_number":221,"context_line":"            error_message \u003d drac_common.find_xml(doc, \u0027Message\u0027,"},{"line_number":222,"context_line":"                                     resource_uris.DCIM_BootConfigSetting).text"},{"line_number":223,"context_line":"            raise exception.DracOperationError(operation\u003d\u0027set_boot_device\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_7f7ce4b5","line":220,"in_reply_to":"1abeadc6_742098b0","updated":"2014-08-27 16:48:22.000000000","message":"Done","commit_id":"45668d0cc0e572a6bd510f8fcbb448c6ff146676"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"17beafef9982f39c4ef2d6f8460a938e29c02569","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        client \u003d drac_common.get_wsman_client(task.node)"},{"line_number":244,"context_line":"        boot_mode \u003d get_next_boot_mode(task.node)"},{"line_number":245,"context_line":"        if not boot_mode:"},{"line_number":246,"context_line":"            raise Exception(\u0027adsds\u0027)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        persistent \u003d boot_mode[\u0027is_next\u0027] \u003d\u003d IS_NEXT[\u0027persistent\u0027]"},{"line_number":249,"context_line":"        instance_id \u003d boot_mode[\u0027instance_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_1413e466","line":246,"updated":"2014-08-27 11:40:21.000000000","message":"hmmmm","commit_id":"45668d0cc0e572a6bd510f8fcbb448c6ff146676"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d2b97af58374fcbcdcf0003225181e1497591950","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        client \u003d drac_common.get_wsman_client(task.node)"},{"line_number":244,"context_line":"        boot_mode \u003d get_next_boot_mode(task.node)"},{"line_number":245,"context_line":"        if not boot_mode:"},{"line_number":246,"context_line":"            raise Exception(\u0027adsds\u0027)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        persistent \u003d boot_mode[\u0027is_next\u0027] \u003d\u003d IS_NEXT[\u0027persistent\u0027]"},{"line_number":249,"context_line":"        instance_id \u003d boot_mode[\u0027instance_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_bf667c27","line":246,"in_reply_to":"1abeadc6_1413e466","updated":"2014-08-27 16:48:22.000000000","message":"hah forgot it there sorry","commit_id":"45668d0cc0e572a6bd510f8fcbb448c6ff146676"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c5a0b8d295045dbcf5bc93999497de1efac803f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014 Red Hat, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_312613cf","line":1,"updated":"2014-08-28 02:55:44.000000000","message":"I mentioned this in the dependent patch so whatever you responded to there, is the same here ;)","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"27b6dd5aa24ac0336ec7aef20ee3766ecfceef58","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014 Red Hat, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_a1ae4b2c","line":1,"in_reply_to":"1abeadc6_312613cf","updated":"2014-08-28 09:51:48.000000000","message":"I replied it there, thanks","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c5a0b8d295045dbcf5bc93999497de1efac803f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"def _get_next_boot_mode(node):"},{"line_number":57,"context_line":"    \"\"\"Get the next boot mode."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    To see a list of supported boot modes see: http://goo.gl/aEsvUH"},{"line_number":60,"context_line":"    (Section 7.2)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    :param node: an ironic node object."}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_3bd27200","line":59,"updated":"2014-08-28 02:55:44.000000000","message":"Do we really want to use Google URL shortener? I\u0027d prefer to see the actual URL, even if it is very long.","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"27b6dd5aa24ac0336ec7aef20ee3766ecfceef58","unresolved":false,"context_lines":[{"line_number":56,"context_line":"def _get_next_boot_mode(node):"},{"line_number":57,"context_line":"    \"\"\"Get the next boot mode."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    To see a list of supported boot modes see: http://goo.gl/aEsvUH"},{"line_number":60,"context_line":"    (Section 7.2)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    :param node: an ironic node object."}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_3407d719","line":59,"in_reply_to":"1abeadc6_3bd27200","updated":"2014-08-28 09:51:48.000000000","message":"hmm I did because the original URL is _very_ long :/ I don\u0027t know if I have an opinion of that tho. I know we can use #noqa for longer lines but IMO I prefer to respect the 79 characters line length imposed by PEP8[1] and use a URL shortener.\n\nSo I will keep it like this for the next patch-set.\n\n[1] http://legacy.python.org/dev/peps/pep-0008/#maximum-line-length","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c5a0b8d295045dbcf5bc93999497de1efac803f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    :returns: a dictionary containing:"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        :instance_id: the instance id of the boot device."},{"line_number":66,"context_line":"        :is_next: whether it\u0027s the next device to boot or not."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    \"\"\""},{"line_number":69,"context_line":"    client \u003d drac_common.get_wsman_client(node)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_7b4b0ab1","line":66,"updated":"2014-08-28 02:55:44.000000000","message":"Is it returning a Boolean? The code looks like it might be returning (I\u0027m guessing) one of PERSISTENT, NOT_NEXT, ONE_TIME_BOOT?","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"27b6dd5aa24ac0336ec7aef20ee3766ecfceef58","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    :returns: a dictionary containing:"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        :instance_id: the instance id of the boot device."},{"line_number":66,"context_line":"        :is_next: whether it\u0027s the next device to boot or not."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    \"\"\""},{"line_number":69,"context_line":"    client \u003d drac_common.get_wsman_client(node)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_545a932a","line":66,"in_reply_to":"1abeadc6_7b4b0ab1","updated":"2014-08-28 09:51:48.000000000","message":"Yup it does return one of PERSIST, NOT_NEXT or ONE_TIME_BOOT. I will update the string.","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c5a0b8d295045dbcf5bc93999497de1efac803f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        :instance_id: the instance id of the boot device."},{"line_number":66,"context_line":"        :is_next: whether it\u0027s the next device to boot or not."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    \"\"\""},{"line_number":69,"context_line":"    client \u003d drac_common.get_wsman_client(node)"},{"line_number":70,"context_line":"    options \u003d pywsman.ClientOptions()"},{"line_number":71,"context_line":"    filter \u003d pywsman.Filter()"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_5bd9eef1","line":68,"updated":"2014-08-28 02:55:44.000000000","message":"maybe add :raises: DracClientError?","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"27b6dd5aa24ac0336ec7aef20ee3766ecfceef58","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        :instance_id: the instance id of the boot device."},{"line_number":66,"context_line":"        :is_next: whether it\u0027s the next device to boot or not."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    \"\"\""},{"line_number":69,"context_line":"    client \u003d drac_common.get_wsman_client(node)"},{"line_number":70,"context_line":"    options \u003d pywsman.ClientOptions()"},{"line_number":71,"context_line":"    filter \u003d pywsman.Filter()"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_74422f3f","line":68,"in_reply_to":"1abeadc6_5bd9eef1","updated":"2014-08-28 09:51:48.000000000","message":"Done","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c5a0b8d295045dbcf5bc93999497de1efac803f","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        if boot_mode and is_next \u003d\u003d ONE_TIME_BOOT:"},{"line_number":102,"context_line":"            boot_mode \u003d {\u0027instance_id\u0027: instance_id, \u0027is_next\u0027: is_next}"},{"line_number":103,"context_line":"        else:"},{"line_number":104,"context_line":"            boot_mode \u003d {\u0027instance_id\u0027: instance_id, \u0027is_next\u0027: is_next}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    return boot_mode"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_1b8696db","line":104,"updated":"2014-08-28 02:55:44.000000000","message":"I don\u0027t see a difference between this boot_mode \u003d, and the one above (at line 102)?","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"27b6dd5aa24ac0336ec7aef20ee3766ecfceef58","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        if boot_mode and is_next \u003d\u003d ONE_TIME_BOOT:"},{"line_number":102,"context_line":"            boot_mode \u003d {\u0027instance_id\u0027: instance_id, \u0027is_next\u0027: is_next}"},{"line_number":103,"context_line":"        else:"},{"line_number":104,"context_line":"            boot_mode \u003d {\u0027instance_id\u0027: instance_id, \u0027is_next\u0027: is_next}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    return boot_mode"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_54a8d3da","line":104,"in_reply_to":"1abeadc6_1b8696db","updated":"2014-08-28 09:51:48.000000000","message":"yeah there\u0027s no difference, I will make it look a bit better","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c5a0b8d295045dbcf5bc93999497de1efac803f","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                              options, \u0027CreateTargetedConfigJob\u0027)"},{"line_number":129,"context_line":"    return_value \u003d drac_common.find_xml(doc, \u0027ReturnValue\u0027,"},{"line_number":130,"context_line":"                                        resource_uris.DCIM_BIOSService).text"},{"line_number":131,"context_line":"    # NOTE(lucasagomes): Possible return values are: 2 for error or 4096"},{"line_number":132,"context_line":"    #                    job created (but changes will be applied after"},{"line_number":133,"context_line":"    #                    the reboot)"},{"line_number":134,"context_line":"    # Boot Management Documentation: http://goo.gl/aEsvUH (Section 8.4)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_5b0ace26","line":131,"updated":"2014-08-28 02:55:44.000000000","message":"not sure if you want \n\u00272\u0027 -\u003e RET_ERROR \n\u00274096\u0027 -\u003e RET_CREATED","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"27b6dd5aa24ac0336ec7aef20ee3766ecfceef58","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                              options, \u0027CreateTargetedConfigJob\u0027)"},{"line_number":129,"context_line":"    return_value \u003d drac_common.find_xml(doc, \u0027ReturnValue\u0027,"},{"line_number":130,"context_line":"                                        resource_uris.DCIM_BIOSService).text"},{"line_number":131,"context_line":"    # NOTE(lucasagomes): Possible return values are: 2 for error or 4096"},{"line_number":132,"context_line":"    #                    job created (but changes will be applied after"},{"line_number":133,"context_line":"    #                    the reboot)"},{"line_number":134,"context_line":"    # Boot Management Documentation: http://goo.gl/aEsvUH (Section 8.4)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_d4eb03da","line":131,"in_reply_to":"1abeadc6_5b0ace26","updated":"2014-08-28 09:51:48.000000000","message":"Done","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c5a0b8d295045dbcf5bc93999497de1efac803f","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    if return_value \u003d\u003d RET_ERROR:"},{"line_number":136,"context_line":"        reason \u003d _(\u0027Job is already created, cannot create another \u0027"},{"line_number":137,"context_line":"                   \u0027configuration job until existing job is completed \u0027"},{"line_number":138,"context_line":"                   \u0027or is cancelled\u0027)"},{"line_number":139,"context_line":"        raise exception.DracConfigJobAlreadyCreated(error\u003dreason)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_761a4170","line":138,"updated":"2014-08-28 02:55:44.000000000","message":"If there is an error, it looks like it returns a message, messageID. Would it be useful to log those? Looks there there are other reasons for an error, besides a job already created.","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"27b6dd5aa24ac0336ec7aef20ee3766ecfceef58","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    if return_value \u003d\u003d RET_ERROR:"},{"line_number":136,"context_line":"        reason \u003d _(\u0027Job is already created, cannot create another \u0027"},{"line_number":137,"context_line":"                   \u0027configuration job until existing job is completed \u0027"},{"line_number":138,"context_line":"                   \u0027or is cancelled\u0027)"},{"line_number":139,"context_line":"        raise exception.DracConfigJobAlreadyCreated(error\u003dreason)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_f4a2bfac","line":138,"in_reply_to":"1abeadc6_761a4170","updated":"2014-08-28 09:51:48.000000000","message":"That\u0027s a good point, I will log the message being returned by the BMC. Thanks","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c5a0b8d295045dbcf5bc93999497de1efac803f","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                                          resource_uris.DCIM_LifecycleJob).text"},{"line_number":167,"context_line":"            # If job is already completed or failed we can"},{"line_number":168,"context_line":"            # create another one"},{"line_number":169,"context_line":"            if job_status.lower() not in (\u0027completed\u0027, \u0027failed\u0027):"},{"line_number":170,"context_line":"                job_id \u003d drac_common.find_xml(i, \u0027InstanceID\u0027,"},{"line_number":171,"context_line":"                                          resource_uris.DCIM_LifecycleJob).text"},{"line_number":172,"context_line":"                reason \u003d (_(\u0027Another job with ID \"%s\" is already created \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_364c4942","line":169,"updated":"2014-08-28 02:55:44.000000000","message":"can job_status be None? if so, this won\u0027t work.","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"27b6dd5aa24ac0336ec7aef20ee3766ecfceef58","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                                          resource_uris.DCIM_LifecycleJob).text"},{"line_number":167,"context_line":"            # If job is already completed or failed we can"},{"line_number":168,"context_line":"            # create another one"},{"line_number":169,"context_line":"            if job_status.lower() not in (\u0027completed\u0027, \u0027failed\u0027):"},{"line_number":170,"context_line":"                job_id \u003d drac_common.find_xml(i, \u0027InstanceID\u0027,"},{"line_number":171,"context_line":"                                          resource_uris.DCIM_LifecycleJob).text"},{"line_number":172,"context_line":"                reason \u003d (_(\u0027Another job with ID \"%s\" is already created \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_746eaf30","line":169,"in_reply_to":"1abeadc6_364c4942","updated":"2014-08-28 09:51:48.000000000","message":"JobStatus is a mandatory field[1], so can\u0027t be None.\n\n[1] http://en.community.dell.com/techcenter/extras/m/white_papers/20399991.aspx","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c5a0b8d295045dbcf5bc93999497de1efac803f","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        return drac_common.COMMON_PROPERTIES"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def validate(self, task):"},{"line_number":184,"context_line":"        \"\"\"Validate the driver-specific Node power info."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        This method validates whether the \u0027driver_info\u0027 property of the"},{"line_number":187,"context_line":"        supplied node contains the required information for this driver to"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_d54eaa6e","line":184,"updated":"2014-08-28 02:55:44.000000000","message":"just wondering \u0027power info\u0027?","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"27b6dd5aa24ac0336ec7aef20ee3766ecfceef58","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        return drac_common.COMMON_PROPERTIES"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def validate(self, task):"},{"line_number":184,"context_line":"        \"\"\"Validate the driver-specific Node power info."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        This method validates whether the \u0027driver_info\u0027 property of the"},{"line_number":187,"context_line":"        supplied node contains the required information for this driver to"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_3458b789","line":184,"in_reply_to":"1abeadc6_d54eaa6e","updated":"2014-08-28 09:51:48.000000000","message":"heh copy\u0026paste from the power driver","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c5a0b8d295045dbcf5bc93999497de1efac803f","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        This method validates whether the \u0027driver_info\u0027 property of the"},{"line_number":187,"context_line":"        supplied node contains the required information for this driver to"},{"line_number":188,"context_line":"        manage the power state of the node."},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":191,"context_line":"        :raises: InvalidParameterValue if required driver_info attribute"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_155582f9","line":188,"updated":"2014-08-28 02:55:44.000000000","message":"Is this managing the power state of the node?","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"27b6dd5aa24ac0336ec7aef20ee3766ecfceef58","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        This method validates whether the \u0027driver_info\u0027 property of the"},{"line_number":187,"context_line":"        supplied node contains the required information for this driver to"},{"line_number":188,"context_line":"        manage the power state of the node."},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":191,"context_line":"        :raises: InvalidParameterValue if required driver_info attribute"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_94526b65","line":188,"in_reply_to":"1abeadc6_155582f9","updated":"2014-08-28 09:51:48.000000000","message":"Done","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c5a0b8d295045dbcf5bc93999497de1efac803f","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                           Default: False."},{"line_number":217,"context_line":"        :raises: InvalidParameterValue if an invalid boot device is"},{"line_number":218,"context_line":"                 specified."},{"line_number":219,"context_line":"        :raises: DracConfigJobAlreadyCreated if the job is already created."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        \"\"\""},{"line_number":222,"context_line":"        # Check for an existing configuration job"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_15a3c200","line":219,"updated":"2014-08-28 02:55:44.000000000","message":"could also raise DracClientError?","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"27b6dd5aa24ac0336ec7aef20ee3766ecfceef58","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                           Default: False."},{"line_number":217,"context_line":"        :raises: InvalidParameterValue if an invalid boot device is"},{"line_number":218,"context_line":"                 specified."},{"line_number":219,"context_line":"        :raises: DracConfigJobAlreadyCreated if the job is already created."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        \"\"\""},{"line_number":222,"context_line":"        # Check for an existing configuration job"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_d4f6a35c","line":219,"in_reply_to":"1abeadc6_15a3c200","updated":"2014-08-28 09:51:48.000000000","message":"Done","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c5a0b8d295045dbcf5bc93999497de1efac803f","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        client \u003d drac_common.get_wsman_client(task.node)"},{"line_number":226,"context_line":"        options \u003d pywsman.ClientOptions()"},{"line_number":227,"context_line":"        filter \u003d pywsman.Filter()"},{"line_number":228,"context_line":"        filter_dialect \u003d \u0027http://schemas.dmtf.org/wbem/cql/1/dsp0202.pdf\u0027"},{"line_number":229,"context_line":"        filter_query \u003d (\"select * from DCIM_BootSourceSetting where \""},{"line_number":230,"context_line":"                        \"InstanceID like \u0027%%#%s%%\u0027\" %"},{"line_number":231,"context_line":"                        _BOOT_DEVICES_MAP[device])"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_7594f68a","line":228,"updated":"2014-08-28 02:55:44.000000000","message":"hey, is this filter_dialect the same value as in _get_next_boot_mode()? If so, maybe make it a constant?","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"27b6dd5aa24ac0336ec7aef20ee3766ecfceef58","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        client \u003d drac_common.get_wsman_client(task.node)"},{"line_number":226,"context_line":"        options \u003d pywsman.ClientOptions()"},{"line_number":227,"context_line":"        filter \u003d pywsman.Filter()"},{"line_number":228,"context_line":"        filter_dialect \u003d \u0027http://schemas.dmtf.org/wbem/cql/1/dsp0202.pdf\u0027"},{"line_number":229,"context_line":"        filter_query \u003d (\"select * from DCIM_BootSourceSetting where \""},{"line_number":230,"context_line":"                        \"InstanceID like \u0027%%#%s%%\u0027\" %"},{"line_number":231,"context_line":"                        _BOOT_DEVICES_MAP[device])"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_d4a4e34c","line":228,"in_reply_to":"1abeadc6_7594f68a","updated":"2014-08-28 09:51:48.000000000","message":"Done","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c5a0b8d295045dbcf5bc93999497de1efac803f","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        # know enterprisey..."},{"line_number":256,"context_line":"        options \u003d pywsman.ClientOptions()"},{"line_number":257,"context_line":"        options.add_selector(\u0027InstanceID\u0027, source)"},{"line_number":258,"context_line":"        options.add_property(\u0027source\u0027, instance_id)"},{"line_number":259,"context_line":"        doc \u003d client.wsman_invoke(resource_uris.DCIM_BootConfigSetting,"},{"line_number":260,"context_line":"                                     options, \u0027ChangeBootOrderByInstanceID\u0027)"},{"line_number":261,"context_line":"        return_value \u003d drac_common.find_xml(doc, \u0027ReturnValue\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_15e582db","line":258,"updated":"2014-08-28 02:55:44.000000000","message":"I think I understand this if source is \u0027OneTime\u0027 (from the \u0027OneTimeBoot\u0027 in table 29 in section 7.2), but if it isn\u0027t \u0027OneTime\u0027, I don\u0027t see how you get this. (But I\u0027m only skimming the docn.) I\u0027m assuming you know ;)","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"27b6dd5aa24ac0336ec7aef20ee3766ecfceef58","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        # know enterprisey..."},{"line_number":256,"context_line":"        options \u003d pywsman.ClientOptions()"},{"line_number":257,"context_line":"        options.add_selector(\u0027InstanceID\u0027, source)"},{"line_number":258,"context_line":"        options.add_property(\u0027source\u0027, instance_id)"},{"line_number":259,"context_line":"        doc \u003d client.wsman_invoke(resource_uris.DCIM_BootConfigSetting,"},{"line_number":260,"context_line":"                                     options, \u0027ChangeBootOrderByInstanceID\u0027)"},{"line_number":261,"context_line":"        return_value \u003d drac_common.find_xml(doc, \u0027ReturnValue\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_b455a71f","line":258,"in_reply_to":"1abeadc6_15e582db","updated":"2014-08-28 09:51:48.000000000","message":"Yeah... it\u0027s very confusing. I did this by looking at some examples. I will try to clarify it, but this bit seems a bit non-logical for me.","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c5a0b8d295045dbcf5bc93999497de1efac803f","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        return_value \u003d drac_common.find_xml(doc, \u0027ReturnValue\u0027,"},{"line_number":262,"context_line":"                                     resource_uris.DCIM_BootConfigSetting).text"},{"line_number":263,"context_line":"        # NOTE(lucasagomes): Possible return values are: 2 for error,"},{"line_number":264,"context_line":"        #                    0 for success or 4096 job created (but"},{"line_number":265,"context_line":"        #                    changes will be applied after the reboot)"},{"line_number":266,"context_line":"        # Boot Management Documentation: http://goo.gl/aEsvUH (Section 8.7)"},{"line_number":267,"context_line":"        if return_value \u003d\u003d RET_ERROR:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_f532c6a5","line":264,"updated":"2014-08-28 02:55:44.000000000","message":"not sure if you want \n\u00270\u0027 -\u003e RET_SUCCESS\n\u00272\u0027 -\u003e RET_ERROR \n\u00274096\u0027 -\u003e RET_CREATED","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"27b6dd5aa24ac0336ec7aef20ee3766ecfceef58","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        return_value \u003d drac_common.find_xml(doc, \u0027ReturnValue\u0027,"},{"line_number":262,"context_line":"                                     resource_uris.DCIM_BootConfigSetting).text"},{"line_number":263,"context_line":"        # NOTE(lucasagomes): Possible return values are: 2 for error,"},{"line_number":264,"context_line":"        #                    0 for success or 4096 job created (but"},{"line_number":265,"context_line":"        #                    changes will be applied after the reboot)"},{"line_number":266,"context_line":"        # Boot Management Documentation: http://goo.gl/aEsvUH (Section 8.7)"},{"line_number":267,"context_line":"        if return_value \u003d\u003d RET_ERROR:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_543e13db","line":264,"in_reply_to":"1abeadc6_f532c6a5","updated":"2014-08-28 09:51:48.000000000","message":"Done","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c5a0b8d295045dbcf5bc93999497de1efac803f","unresolved":false,"context_lines":[{"line_number":275,"context_line":"    def get_boot_device(self, task):"},{"line_number":276,"context_line":"        \"\"\"Get the current boot device for a node."},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        Provides the current boot device of the node. Be aware that not"},{"line_number":279,"context_line":"        all drivers support this."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        :param task: a task from TaskManager."}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_d5d4ea21","line":278,"updated":"2014-08-28 02:55:44.000000000","message":"nit: \u0027Provides\u0027 -\u003e you mean it \u0027Returns\u0027?","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"27b6dd5aa24ac0336ec7aef20ee3766ecfceef58","unresolved":false,"context_lines":[{"line_number":275,"context_line":"    def get_boot_device(self, task):"},{"line_number":276,"context_line":"        \"\"\"Get the current boot device for a node."},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        Provides the current boot device of the node. Be aware that not"},{"line_number":279,"context_line":"        all drivers support this."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        :param task: a task from TaskManager."}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_b42cc7ad","line":278,"in_reply_to":"1abeadc6_d5d4ea21","updated":"2014-08-28 09:51:48.000000000","message":"Done","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c5a0b8d295045dbcf5bc93999497de1efac803f","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        \"\"\"Get the current boot device for a node."},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        Provides the current boot device of the node. Be aware that not"},{"line_number":279,"context_line":"        all drivers support this."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        :param task: a task from TaskManager."},{"line_number":282,"context_line":"        :returns: a dictionary containing:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_75e5d607","line":279,"updated":"2014-08-28 02:55:44.000000000","message":"Is this driver going to support this? If so, does it make sense to put \u0027Be aware that not all...\"","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"27b6dd5aa24ac0336ec7aef20ee3766ecfceef58","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        \"\"\"Get the current boot device for a node."},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        Provides the current boot device of the node. Be aware that not"},{"line_number":279,"context_line":"        all drivers support this."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        :param task: a task from TaskManager."},{"line_number":282,"context_line":"        :returns: a dictionary containing:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_d429439c","line":279,"in_reply_to":"1abeadc6_75e5d607","updated":"2014-08-28 09:51:48.000000000","message":"Done","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c5a0b8d295045dbcf5bc93999497de1efac803f","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                :mod:`ironic.common.boot_devices` or None if it is unknown."},{"line_number":286,"context_line":"            :persistent: Whether the boot device will persist to all"},{"line_number":287,"context_line":"                future boots or not, None if it is unknown."},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        \"\"\""},{"line_number":290,"context_line":"        client \u003d drac_common.get_wsman_client(task.node)"},{"line_number":291,"context_line":"        boot_mode \u003d _get_next_boot_mode(task.node)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_15a90290","line":288,"updated":"2014-08-28 02:55:44.000000000","message":"It could raise DracClientError","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"27b6dd5aa24ac0336ec7aef20ee3766ecfceef58","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                :mod:`ironic.common.boot_devices` or None if it is unknown."},{"line_number":286,"context_line":"            :persistent: Whether the boot device will persist to all"},{"line_number":287,"context_line":"                future boots or not, None if it is unknown."},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        \"\"\""},{"line_number":290,"context_line":"        client \u003d drac_common.get_wsman_client(task.node)"},{"line_number":291,"context_line":"        boot_mode \u003d _get_next_boot_mode(task.node)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_f419df88","line":288,"in_reply_to":"1abeadc6_15a90290","updated":"2014-08-28 09:51:48.000000000","message":"Done","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c5a0b8d295045dbcf5bc93999497de1efac803f","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        options \u003d pywsman.ClientOptions()"},{"line_number":297,"context_line":"        filter \u003d pywsman.Filter()"},{"line_number":298,"context_line":"        filter_dialect \u003d \u0027http://schemas.dmtf.org/wbem/cql/1/dsp0202.pdf\u0027"},{"line_number":299,"context_line":"        filter_query \u003d (\u0027select * from DCIM_BootSourceSetting where \u0027"},{"line_number":300,"context_line":"                        \u0027PendingAssignedSequence\u003d0 and \u0027"},{"line_number":301,"context_line":"                        \u0027BootSourceType\u003d\"%s\"\u0027 % instance_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_d5894a27","line":298,"updated":"2014-08-28 02:55:44.000000000","message":"ditto about this being same value as other filter_dialect above","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"27b6dd5aa24ac0336ec7aef20ee3766ecfceef58","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        options \u003d pywsman.ClientOptions()"},{"line_number":297,"context_line":"        filter \u003d pywsman.Filter()"},{"line_number":298,"context_line":"        filter_dialect \u003d \u0027http://schemas.dmtf.org/wbem/cql/1/dsp0202.pdf\u0027"},{"line_number":299,"context_line":"        filter_query \u003d (\u0027select * from DCIM_BootSourceSetting where \u0027"},{"line_number":300,"context_line":"                        \u0027PendingAssignedSequence\u003d0 and \u0027"},{"line_number":301,"context_line":"                        \u0027BootSourceType\u003d\"%s\"\u0027 % instance_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_141f3b6d","line":298,"in_reply_to":"1abeadc6_d5894a27","updated":"2014-08-28 09:51:48.000000000","message":"Done","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f35fe0612b5d3d60fc31e4dac8cdddd00d084e61","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# IsNext constants"},{"line_number":46,"context_line":"PERSISTENT \u003d \u00271\u0027"},{"line_number":47,"context_line":"NOT_NEXT \u003d \u00272\u0027"},{"line_number":48,"context_line":"ONE_TIME_BOOT \u003d \u00273\u0027"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# ReturnValue constants"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_a7d5e744","line":47,"updated":"2014-09-01 07:11:31.000000000","message":"Could you write docstrings for the constants. E.g. I have no idea what NOT_NEXT means :)","commit_id":"319c7953993704070dda44c144501a1e3adafb02"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1194468dfa4c592ea72114e274756414dc691b80","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# IsNext constants"},{"line_number":46,"context_line":"PERSISTENT \u003d \u00271\u0027"},{"line_number":47,"context_line":"NOT_NEXT \u003d \u00272\u0027"},{"line_number":48,"context_line":"ONE_TIME_BOOT \u003d \u00273\u0027"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# ReturnValue constants"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_bbb0a2de","line":47,"in_reply_to":"fa98f980_a7d5e744","updated":"2014-09-01 09:44:51.000000000","message":"Done","commit_id":"319c7953993704070dda44c144501a1e3adafb02"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f35fe0612b5d3d60fc31e4dac8cdddd00d084e61","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    if return_value \u003d\u003d RET_ERROR:"},{"line_number":139,"context_line":"        error_message \u003d drac_common.find_xml(doc, \u0027Message\u0027,"},{"line_number":140,"context_line":"                                           resource_uris.DCIM_BIOSService).text"},{"line_number":141,"context_line":"        raise exception.DracConfigJobAlreadyCreated(error\u003derror_message)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"def _check_for_config_job(node):"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_a73167a4","line":141,"updated":"2014-09-01 07:11:31.000000000","message":"Judging by the docs, JobAlreadyCreated is not the only possible error, you should check for BIOS007 in error message.","commit_id":"319c7953993704070dda44c144501a1e3adafb02"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1194468dfa4c592ea72114e274756414dc691b80","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    if return_value \u003d\u003d RET_ERROR:"},{"line_number":139,"context_line":"        error_message \u003d drac_common.find_xml(doc, \u0027Message\u0027,"},{"line_number":140,"context_line":"                                           resource_uris.DCIM_BIOSService).text"},{"line_number":141,"context_line":"        raise exception.DracConfigJobAlreadyCreated(error\u003derror_message)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"def _check_for_config_job(node):"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_f624ffc7","line":141,"in_reply_to":"fa98f980_a73167a4","updated":"2014-09-01 09:44:51.000000000","message":"This is a good point. Should I maybe do a more generic exception for job creation error?\n\nE.g DracConfigJobCreationFailure()\n\nI think it sounds good","commit_id":"319c7953993704070dda44c144501a1e3adafb02"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f35fe0612b5d3d60fc31e4dac8cdddd00d084e61","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                                 find_all\u003dTrue)"},{"line_number":165,"context_line":"    for i in items:"},{"line_number":166,"context_line":"        name \u003d drac_common.find_xml(i, \u0027Name\u0027, resource_uris.DCIM_LifecycleJob)"},{"line_number":167,"context_line":"        if \u0027BIOS.Setup.1-1\u0027 in name.text:"},{"line_number":168,"context_line":"            job_status \u003d drac_common.find_xml(i, \u0027JobStatus\u0027,"},{"line_number":169,"context_line":"                                          resource_uris.DCIM_LifecycleJob).text"},{"line_number":170,"context_line":"            # If job is already completed or failed we can"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_27e4970c","line":167,"updated":"2014-09-01 07:11:31.000000000","message":"can we revert if do avoid indents:\n\n if \u0027BIOS.Setup.1-1\u0027 not in name.text:\n   continue","commit_id":"319c7953993704070dda44c144501a1e3adafb02"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1194468dfa4c592ea72114e274756414dc691b80","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                                 find_all\u003dTrue)"},{"line_number":165,"context_line":"    for i in items:"},{"line_number":166,"context_line":"        name \u003d drac_common.find_xml(i, \u0027Name\u0027, resource_uris.DCIM_LifecycleJob)"},{"line_number":167,"context_line":"        if \u0027BIOS.Setup.1-1\u0027 in name.text:"},{"line_number":168,"context_line":"            job_status \u003d drac_common.find_xml(i, \u0027JobStatus\u0027,"},{"line_number":169,"context_line":"                                          resource_uris.DCIM_LifecycleJob).text"},{"line_number":170,"context_line":"            # If job is already completed or failed we can"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_fbd06af9","line":167,"in_reply_to":"fa98f980_27e4970c","updated":"2014-09-01 09:44:51.000000000","message":"Done","commit_id":"319c7953993704070dda44c144501a1e3adafb02"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f35fe0612b5d3d60fc31e4dac8cdddd00d084e61","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                reason \u003d (_(\u0027Another job with ID \"%s\" is already created \u0027"},{"line_number":177,"context_line":"                            \u0027to configure the BIOS. Wait until existing job \u0027"},{"line_number":178,"context_line":"                            \u0027is completed or is cancelled\u0027) % job_id)"},{"line_number":179,"context_line":"                raise exception.DracConfigJobAlreadyCreated(error\u003dreason)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"class DracManagement(base.ManagementInterface):"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_87baa3df","line":179,"updated":"2014-09-01 07:11:31.000000000","message":"ditto about possible errors","commit_id":"319c7953993704070dda44c144501a1e3adafb02"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1194468dfa4c592ea72114e274756414dc691b80","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                reason \u003d (_(\u0027Another job with ID \"%s\" is already created \u0027"},{"line_number":177,"context_line":"                            \u0027to configure the BIOS. Wait until existing job \u0027"},{"line_number":178,"context_line":"                            \u0027is completed or is cancelled\u0027) % job_id)"},{"line_number":179,"context_line":"                raise exception.DracConfigJobAlreadyCreated(error\u003dreason)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"class DracManagement(base.ManagementInterface):"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_b109a12e","line":179,"in_reply_to":"fa98f980_87baa3df","updated":"2014-09-01 09:44:51.000000000","message":"This one I\u0027m generating the message","commit_id":"319c7953993704070dda44c144501a1e3adafb02"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f35fe0612b5d3d60fc31e4dac8cdddd00d084e61","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        instance_id \u003d drac_common.find_xml(doc, \u0027InstanceID\u0027,"},{"line_number":250,"context_line":"                                     resource_uris.DCIM_BootSourceSetting).text"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        source \u003d \u0027OneTime\u0027"},{"line_number":253,"context_line":"        if persistent:"},{"line_number":254,"context_line":"            source \u003d drac_common.find_xml(doc, \u0027BootSourceType\u0027,"},{"line_number":255,"context_line":"                                     resource_uris.DCIM_BootSourceSetting).text"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_c7abcb87","line":252,"updated":"2014-09-01 07:11:31.000000000","message":"could you move this to a top-level constant?","commit_id":"319c7953993704070dda44c144501a1e3adafb02"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1194468dfa4c592ea72114e274756414dc691b80","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        instance_id \u003d drac_common.find_xml(doc, \u0027InstanceID\u0027,"},{"line_number":250,"context_line":"                                     resource_uris.DCIM_BootSourceSetting).text"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        source \u003d \u0027OneTime\u0027"},{"line_number":253,"context_line":"        if persistent:"},{"line_number":254,"context_line":"            source \u003d drac_common.find_xml(doc, \u0027BootSourceType\u0027,"},{"line_number":255,"context_line":"                                     resource_uris.DCIM_BootSourceSetting).text"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_7b12bab5","line":252,"in_reply_to":"fa98f980_c7abcb87","updated":"2014-09-01 09:44:51.000000000","message":"hmm I could, tho I don\u0027t know if I would cause it\u0027s only used here in this bit of code.","commit_id":"319c7953993704070dda44c144501a1e3adafb02"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f35fe0612b5d3d60fc31e4dac8cdddd00d084e61","unresolved":false,"context_lines":[{"line_number":322,"context_line":"            device_string \u003d _BOOT_DEVICES_MAP[device]"},{"line_number":323,"context_line":"            if device_string in instance_id:"},{"line_number":324,"context_line":"                boot_device \u003d device"},{"line_number":325,"context_line":"                break"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        return {\u0027boot_device\u0027: boot_device, \u0027persistent\u0027: persistent}"},{"line_number":328,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_47ad1b88","line":325,"updated":"2014-09-01 07:11:31.000000000","message":"one-liner:\n\n boot_device \u003d next((key for (key, value) in _BOOT_DEVICES_MAP.items() if value in instance_id), None)\n\njust a suggestion though :)","commit_id":"319c7953993704070dda44c144501a1e3adafb02"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1194468dfa4c592ea72114e274756414dc691b80","unresolved":false,"context_lines":[{"line_number":322,"context_line":"            device_string \u003d _BOOT_DEVICES_MAP[device]"},{"line_number":323,"context_line":"            if device_string in instance_id:"},{"line_number":324,"context_line":"                boot_device \u003d device"},{"line_number":325,"context_line":"                break"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        return {\u0027boot_device\u0027: boot_device, \u0027persistent\u0027: persistent}"},{"line_number":328,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_f65ddf49","line":325,"in_reply_to":"fa98f980_47ad1b88","updated":"2014-09-01 09:44:51.000000000","message":"Done","commit_id":"319c7953993704070dda44c144501a1e3adafb02"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9926281683ef1356ca2c13ce387b0b0795defae8","unresolved":false,"context_lines":[{"line_number":53,"context_line":"# ReturnValue constants"},{"line_number":54,"context_line":"RET_SUCCESS \u003d \u00270\u0027"},{"line_number":55,"context_line":"RET_ERROR \u003d \u00272\u0027"},{"line_number":56,"context_line":"RET_CREATED \u003d \u00274096\u0027"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"FILTER_DIALECT \u003d \u0027http://schemas.dmtf.org/wbem/cql/1/dsp0202.pdf\u0027"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_02b5b6ed","line":56,"updated":"2014-09-01 12:29:37.000000000","message":"Maybe this can be moved to drac.client and refactored in the power driver as well","commit_id":"2eb3c12ce3fb2b2eb4408367f2c950724a098d93"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9926281683ef1356ca2c13ce387b0b0795defae8","unresolved":false,"context_lines":[{"line_number":55,"context_line":"RET_ERROR \u003d \u00272\u0027"},{"line_number":56,"context_line":"RET_CREATED \u003d \u00274096\u0027"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"FILTER_DIALECT \u003d \u0027http://schemas.dmtf.org/wbem/cql/1/dsp0202.pdf\u0027"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def _get_next_boot_mode(node):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_74e564a7","line":58,"updated":"2014-09-01 12:29:37.000000000","message":"same here","commit_id":"2eb3c12ce3fb2b2eb4408367f2c950724a098d93"}],"ironic/tests/drivers/drac/test_common.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c5a0b8d295045dbcf5bc93999497de1efac803f","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        namespace \u003d \u0027http://fake\u0027"},{"line_number":124,"context_line":"        value1 \u003d \u0027fake_value1\u0027"},{"line_number":125,"context_line":"        value2 \u003d \u0027fake_value2\u0027"},{"line_number":126,"context_line":"        test_doc \u003d ElementTree.fromstring(\"\"\"\u003cEnvelop xmlns:ns1\u003d\"%(ns)s\"\u003e"},{"line_number":127,"context_line":"                         \u003cBody\u003e"},{"line_number":128,"context_line":"                           \u003cns1:test_element\u003e%(value1)s\u003c/ns1:test_element\u003e"},{"line_number":129,"context_line":"                           \u003cns1:cat\u003emeow\u003c/ns1:cat\u003e"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_7524f60c","line":126,"updated":"2014-08-28 02:55:44.000000000","message":"typo \u0027Envelop\u0027 -\u003e \u0027Envelope\u0027","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"27b6dd5aa24ac0336ec7aef20ee3766ecfceef58","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        namespace \u003d \u0027http://fake\u0027"},{"line_number":124,"context_line":"        value1 \u003d \u0027fake_value1\u0027"},{"line_number":125,"context_line":"        value2 \u003d \u0027fake_value2\u0027"},{"line_number":126,"context_line":"        test_doc \u003d ElementTree.fromstring(\"\"\"\u003cEnvelop xmlns:ns1\u003d\"%(ns)s\"\u003e"},{"line_number":127,"context_line":"                         \u003cBody\u003e"},{"line_number":128,"context_line":"                           \u003cns1:test_element\u003e%(value1)s\u003c/ns1:test_element\u003e"},{"line_number":129,"context_line":"                           \u003cns1:cat\u003emeow\u003c/ns1:cat\u003e"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_740dcf3d","line":126,"in_reply_to":"1abeadc6_7524f60c","updated":"2014-08-28 09:51:48.000000000","message":"Done","commit_id":"00f6b0bfa809b518edd3c1b94f2e73e9c7ee4ce5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f35fe0612b5d3d60fc31e4dac8cdddd00d084e61","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        result \u003d drac_common.find_xml(test_doc, \u0027test_element\u0027,"},{"line_number":137,"context_line":"                                      namespace, find_all\u003dTrue)"},{"line_number":138,"context_line":"        self.assertThat(result, HasLength(2))"},{"line_number":139,"context_line":"        result_text \u003d [v.text for v in result]"},{"line_number":140,"context_line":"        self.assertEqual(sorted([value1, value2]), sorted(result_text))"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_e7ec4fca","line":138,"updated":"2014-09-01 07:11:31.000000000","message":"is it any better than\n\n assertEqual(2, len(result))\n\n?","commit_id":"319c7953993704070dda44c144501a1e3adafb02"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1194468dfa4c592ea72114e274756414dc691b80","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        result \u003d drac_common.find_xml(test_doc, \u0027test_element\u0027,"},{"line_number":137,"context_line":"                                      namespace, find_all\u003dTrue)"},{"line_number":138,"context_line":"        self.assertThat(result, HasLength(2))"},{"line_number":139,"context_line":"        result_text \u003d [v.text for v in result]"},{"line_number":140,"context_line":"        self.assertEqual(sorted([value1, value2]), sorted(result_text))"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_9bf3de72","line":138,"in_reply_to":"fa98f980_e7ec4fca","updated":"2014-09-01 09:44:51.000000000","message":"So this was raised long time ago (don\u0027t remember by who, I think lifeless) saying that it\u0027s better to use HasLength because of the message it gives on errors. So, I\u0027ve been using HasLength since...","commit_id":"319c7953993704070dda44c144501a1e3adafb02"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c7af8bda24d25359c2ac02613c6867b05f7d4874","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                                      namespace, find_all\u003dTrue)"},{"line_number":138,"context_line":"        self.assertThat(result, HasLength(2))"},{"line_number":139,"context_line":"        result_text \u003d [v.text for v in result]"},{"line_number":140,"context_line":"        self.assertEqual(sorted([value1, value2]), sorted(result_text))"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_b7126eb2","line":140,"updated":"2014-09-01 11:59:35.000000000","message":"nit:\n\n result_text \u003d set(v.text for v in result)\n self.assertEqual(set([value1, value2]), result_text)","commit_id":"2eb3c12ce3fb2b2eb4408367f2c950724a098d93"}],"ironic/tests/drivers/drac/test_management.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"4414040a6b1a8c4a0d37a290f0b7410e377bda84","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        mock_pywsman.enumerate.assert_called_once_with(mock.ANY, mock.ANY,"},{"line_number":79,"context_line":"            resource_uris.DCIM_BootConfigSetting)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def test__get_next_boot_mode_ontime(self, mock_client_pywsman):"},{"line_number":82,"context_line":"        result_xml \u003d test_utils.build_soap_xml([{\u0027DCIM_BootConfigSetting\u0027:"},{"line_number":83,"context_line":"                                                    {\u0027InstanceID\u0027: \u0027IPL\u0027,"},{"line_number":84,"context_line":"                                                     \u0027IsNext\u0027:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_d8cbe850","line":81,"updated":"2014-08-29 18:55:54.000000000","message":"ontime \u003d\u003d onetime","commit_id":"9e5e770f94ac6db4d0e63039c4b8d5b5e6419169"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f35fe0612b5d3d60fc31e4dac8cdddd00d084e61","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    def test__create_config_job_already_exist(self, mock_client_pywsman):"},{"line_number":151,"context_line":"        result_xml \u003d test_utils.build_soap_xml([{\u0027ReturnValue\u0027:"},{"line_number":152,"context_line":"                                                    drac_mgmt.RET_ERROR,"},{"line_number":153,"context_line":"                                                 \u0027Message\u0027: \u0027E_FAKE\u0027}],"},{"line_number":154,"context_line":"                                               resource_uris.DCIM_BIOSService)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        mock_xml \u003d _mock_wsman_root(result_xml)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_27f57783","line":153,"updated":"2014-09-01 07:11:31.000000000","message":"It is BIOS007 IIUC","commit_id":"319c7953993704070dda44c144501a1e3adafb02"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1194468dfa4c592ea72114e274756414dc691b80","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    def test__create_config_job_already_exist(self, mock_client_pywsman):"},{"line_number":151,"context_line":"        result_xml \u003d test_utils.build_soap_xml([{\u0027ReturnValue\u0027:"},{"line_number":152,"context_line":"                                                    drac_mgmt.RET_ERROR,"},{"line_number":153,"context_line":"                                                 \u0027Message\u0027: \u0027E_FAKE\u0027}],"},{"line_number":154,"context_line":"                                               resource_uris.DCIM_BIOSService)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        mock_xml \u003d _mock_wsman_root(result_xml)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_71d01954","line":153,"in_reply_to":"fa98f980_27f57783","updated":"2014-09-01 09:44:51.000000000","message":"I will create a more generic exception that will be raised on errors when creating a config job","commit_id":"319c7953993704070dda44c144501a1e3adafb02"}],"ironic/tests/drivers/drac/utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f35fe0612b5d3d60fc31e4dac8cdddd00d084e61","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                                                      \u0027item\u0027: xml_string}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        element \u003d ElementTree.Element(xml_string)"},{"line_number":39,"context_line":"        element.text \u003d value"},{"line_number":40,"context_line":"        return element"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    soap_namespace \u003d \"http://www.w3.org/2003/05/soap-envelope\""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_671dbfbd","line":39,"updated":"2014-09-01 07:11:31.000000000","message":"nit: When value is not provided, element is expected to be used as insertion point. So I think it\u0027s better to default value to None and not assign text in this case at all.","commit_id":"319c7953993704070dda44c144501a1e3adafb02"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1194468dfa4c592ea72114e274756414dc691b80","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                                                      \u0027item\u0027: xml_string}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        element \u003d ElementTree.Element(xml_string)"},{"line_number":39,"context_line":"        element.text \u003d value"},{"line_number":40,"context_line":"        return element"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    soap_namespace \u003d \"http://www.w3.org/2003/05/soap-envelope\""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_5bf9764c","line":39,"in_reply_to":"fa98f980_671dbfbd","updated":"2014-09-01 09:44:51.000000000","message":"Done","commit_id":"319c7953993704070dda44c144501a1e3adafb02"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f35fe0612b5d3d60fc31e4dac8cdddd00d084e61","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        for i in item:"},{"line_number":48,"context_line":"            insertion_point \u003d _create_element(i)"},{"line_number":49,"context_line":"            if isinstance(item[i], dict):"},{"line_number":50,"context_line":"                for j in item[i]:"},{"line_number":51,"context_line":"                    insertion_point.append(_create_element(j, item[i][j]))"},{"line_number":52,"context_line":"            else:"},{"line_number":53,"context_line":"                insertion_point.text \u003d item[i]"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_474efbc2","line":50,"updated":"2014-09-01 07:11:31.000000000","message":"I usually don\u0027t object, but item[i][j] is too much :) please use\n\n for j, value in item[i].items():","commit_id":"319c7953993704070dda44c144501a1e3adafb02"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1194468dfa4c592ea72114e274756414dc691b80","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        for i in item:"},{"line_number":48,"context_line":"            insertion_point \u003d _create_element(i)"},{"line_number":49,"context_line":"            if isinstance(item[i], dict):"},{"line_number":50,"context_line":"                for j in item[i]:"},{"line_number":51,"context_line":"                    insertion_point.append(_create_element(j, item[i][j]))"},{"line_number":52,"context_line":"            else:"},{"line_number":53,"context_line":"                insertion_point.text \u003d item[i]"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_fbaf8a29","line":50,"in_reply_to":"fa98f980_474efbc2","updated":"2014-09-01 09:44:51.000000000","message":"Done","commit_id":"319c7953993704070dda44c144501a1e3adafb02"}]}
