)]}'
{"ironic/conductor/utils.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"cb3487c03fd46a9c4b624c80a96359ee62e97e36","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from ironic.common import states"},{"line_number":19,"context_line":"from ironic.conductor import task_manager"},{"line_number":20,"context_line":"from ironic.openstack.common.gettextutils import _LI"},{"line_number":21,"context_line":"from ironic.openstack.common.gettextutils import _LW"},{"line_number":22,"context_line":"from ironic.openstack.common import log"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d log.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_aa5e1b43","line":21,"updated":"2014-08-28 13:13:41.000000000","message":"nit: We are trying to get rid of the common.gettextutils and use olso.i18n instead[1]. Mind updating it here?\n\n[1] https://review.openstack.org/#/c/116303/","commit_id":"7984b2e02a4e35b6e748b60af7c6a909a5f9c5ce"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d572bedba96d77d3d90da0d59b1d1fac6b95f8cd","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from ironic.common import states"},{"line_number":19,"context_line":"from ironic.conductor import task_manager"},{"line_number":20,"context_line":"from ironic.openstack.common.gettextutils import _LI"},{"line_number":21,"context_line":"from ironic.openstack.common.gettextutils import _LW"},{"line_number":22,"context_line":"from ironic.openstack.common import log"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d log.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_1b459f42","line":21,"in_reply_to":"1abeadc6_5069b6f7","updated":"2014-08-28 14:19:45.000000000","message":"Ack, you can put a dependency on that patch. Or simply use oslo.i18n here","commit_id":"7984b2e02a4e35b6e748b60af7c6a909a5f9c5ce"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"2ae4dab83a8292068c2a7c539c64a312e3e15ef6","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from ironic.common import states"},{"line_number":19,"context_line":"from ironic.conductor import task_manager"},{"line_number":20,"context_line":"from ironic.openstack.common.gettextutils import _LI"},{"line_number":21,"context_line":"from ironic.openstack.common.gettextutils import _LW"},{"line_number":22,"context_line":"from ironic.openstack.common import log"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d log.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_5069b6f7","line":21,"in_reply_to":"1abeadc6_aa5e1b43","updated":"2014-08-28 13:42:49.000000000","message":"I can wait for 116303.","commit_id":"7984b2e02a4e35b6e748b60af7c6a909a5f9c5ce"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"ed0553af28bf8764eb41614d99367c2cc1d0d371","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        if curr_state \u003d\u003d states.ERROR:"},{"line_number":95,"context_line":"            # be optimistic and continue action"},{"line_number":96,"context_line":"            LOG.warn(_LW(\"Driver returns ERROR power state for node %(node)s.\")"},{"line_number":97,"context_line":"                          % {\u0027node\u0027: node.uuid})"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # Set the target_power_state and clear any last_error, since we\u0027re"},{"line_number":100,"context_line":"    # starting a new operation. This will expose to other processes"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_15437513","line":97,"updated":"2014-08-29 14:05:18.000000000","message":"Please use the standard defined here (comma instead of %):\n\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages","commit_id":"1b31f98fd8e344011bd2a791ae46b53a568d9714"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"2189139561aa2a3ca40e7d71e0c78f8b3960a4de","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        if curr_state \u003d\u003d states.ERROR:"},{"line_number":95,"context_line":"            # be optimistic and continue action"},{"line_number":96,"context_line":"            LOG.warn(_LW(\"Driver returns ERROR power state for node %(node)s.\")"},{"line_number":97,"context_line":"                          % {\u0027node\u0027: node.uuid})"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # Set the target_power_state and clear any last_error, since we\u0027re"},{"line_number":100,"context_line":"    # starting a new operation. This will expose to other processes"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_32a8821f","line":97,"in_reply_to":"1abeadc6_15437513","updated":"2014-08-29 15:48:39.000000000","message":"Done","commit_id":"1b31f98fd8e344011bd2a791ae46b53a568d9714"}]}