)]}'
{"ironic/drivers/modules/drac/common.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0bf0dbeee179e49d41a8aa04e78e7926036ce1d6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"RET_ERROR \u003d \u00272\u0027"},{"line_number":43,"context_line":"RET_CREATED \u003d \u00274096\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"FILTER_DIALECT \u003d \u0027http://schemas.dmtf.org/wbem/cql/1/dsp0202.pdf\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def parse_driver_info(node):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_1d2b0d31","line":45,"updated":"2014-09-02 17:09:07.000000000","message":"Just wondering. Do you (or Imre?) know whether this ought to go in resource_uris.py?","commit_id":"c71d19493ae725c6ebf33542ea18f12d64eee024"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"860d3628ffe8e8d95b5685d5cb4e289eb9c3d33d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"RET_ERROR \u003d \u00272\u0027"},{"line_number":43,"context_line":"RET_CREATED \u003d \u00274096\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"FILTER_DIALECT \u003d \u0027http://schemas.dmtf.org/wbem/cql/1/dsp0202.pdf\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def parse_driver_info(node):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_b3b93717","line":45,"in_reply_to":"fa98f980_1d2b0d31","updated":"2014-09-03 08:08:16.000000000","message":"@Ruby: It\u0027s the schema definition for the cql query language, not a resource uri. So I don\u0027t think it fits to resource_uris.py. But I have another suggestion, see drac/management.py.","commit_id":"c71d19493ae725c6ebf33542ea18f12d64eee024"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0bf0dbeee179e49d41a8aa04e78e7926036ce1d6","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                     find only the first one. Defaults to False."},{"line_number":119,"context_line":"    :returns: if find_all is False the element object will be returned"},{"line_number":120,"context_line":"              if found, None if not found. If find_all is True a list of"},{"line_number":121,"context_line":"              elements objects will be returned or an empty list is  if"},{"line_number":122,"context_line":"              no elements were found."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_ba64c722","line":121,"updated":"2014-09-02 17:09:07.000000000","message":"nit (if you do another patch) \n\n\u0027elements objects\u0027 -\u003e do you mean \u0027element objects\u0027? (or \u0027elements\u0027 is good too)\n\n\u0027list is  \u0027 -\u003e \u0027list \u0027","commit_id":"c71d19493ae725c6ebf33542ea18f12d64eee024"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d95880693ca135d19fde3418d1dd69938e761258","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                     find only the first one. Defaults to False."},{"line_number":119,"context_line":"    :returns: if find_all is False the element object will be returned"},{"line_number":120,"context_line":"              if found, None if not found. If find_all is True a list of"},{"line_number":121,"context_line":"              elements objects will be returned or an empty list is  if"},{"line_number":122,"context_line":"              no elements were found."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_b64762bb","line":121,"in_reply_to":"fa98f980_ba64c722","updated":"2014-09-03 11:11:12.000000000","message":"Done","commit_id":"c71d19493ae725c6ebf33542ea18f12d64eee024"}],"ironic/drivers/modules/drac/management.py":[{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"860d3628ffe8e8d95b5685d5cb4e289eb9c3d33d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    filter \u003d pywsman.Filter()"},{"line_number":72,"context_line":"    filter_query \u003d (\u0027select * from DCIM_BootConfigSetting where IsNext\u003d%s \u0027"},{"line_number":73,"context_line":"                    \u0027or IsNext\u003d%s\u0027 % (PERSISTENT, ONE_TIME_BOOT))"},{"line_number":74,"context_line":"    filter.simple(drac_common.FILTER_DIALECT, filter_query)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    try:"},{"line_number":77,"context_line":"        doc \u003d client.wsman_enumerate(resource_uris.DCIM_BootConfigSetting,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_d3df9b0b","line":74,"updated":"2014-09-03 08:08:16.000000000","message":"How about moving this whole filter creation logic to inside the wsman_enumerate method? This way, you would pass only the filter_query and let the client deal with the rest. \neg: doc \u003d client.wsman_enumerate(resource_uris.DCIM_BootConfigSetting, options, filter_query)\n(Of course, the drac_client would only accept filters using cql dialects, but I think that\u0027s fine.)\n\nThis way, you can also move the drac_common.FILTER_DIALECT to drac_client because it won\u0027t be used elsewhere.\n\nWhat do you think?","commit_id":"c71d19493ae725c6ebf33542ea18f12d64eee024"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d95880693ca135d19fde3418d1dd69938e761258","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    filter \u003d pywsman.Filter()"},{"line_number":72,"context_line":"    filter_query \u003d (\u0027select * from DCIM_BootConfigSetting where IsNext\u003d%s \u0027"},{"line_number":73,"context_line":"                    \u0027or IsNext\u003d%s\u0027 % (PERSISTENT, ONE_TIME_BOOT))"},{"line_number":74,"context_line":"    filter.simple(drac_common.FILTER_DIALECT, filter_query)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    try:"},{"line_number":77,"context_line":"        doc \u003d client.wsman_enumerate(resource_uris.DCIM_BootConfigSetting,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_c4e0ac98","line":74,"in_reply_to":"fa98f980_d3df9b0b","updated":"2014-09-03 11:11:12.000000000","message":"Done","commit_id":"c71d19493ae725c6ebf33542ea18f12d64eee024"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1745251cea8b6ce2ff66c14433d5ae5b2b172f8a","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        try:"},{"line_number":231,"context_line":"            doc \u003d client.wsman_enumerate(resource_uris.DCIM_BootSourceSetting,"},{"line_number":232,"context_line":"                                          options, filter_query\u003dfilter_query)"},{"line_number":233,"context_line":"        except exception.DracClientError as exc:"},{"line_number":234,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":235,"context_line":"                LOG.error(_LE(\u0027DRAC driver failed to set the boot device \u0027"},{"line_number":236,"context_line":"                              \u0027for node %(node_uuid)s. Can\\\u0027t find the ID \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_d71e9dba","line":233,"updated":"2014-09-03 13:10:42.000000000","message":"For this and the other places that call client.wsman_enumerate, do you also want to handle exception.DracInvalidFilterDialect?","commit_id":"ca2c5a434a9a1ccc278db83c9e8c6defb4f6e851"}]}