)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0949b1cb568c196b8c4a17973f9625e939e27b4e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     David Shrewsbury \u003cshrewsbury.dave@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-09-02 17:04:06 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update ironic states and documentation."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds doc strings for the various states, and updates the documentation"},{"line_number":10,"context_line":"header to reflect the current state of states."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa98f980_ea7d60b3","line":7,"updated":"2014-09-12 09:45:39.000000000","message":"the period at the end of the first line will make pep8 to fail (hacking rules)","commit_id":"db92038b2b67d3b49e97e93d2499f1d704972ed9"}],"ironic/common/states.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"64d8c8b0c18e7f06d8cde41ac01426daeb373317","unresolved":false,"context_lines":[{"line_number":35,"context_line":"\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"ACTIVE \u003d \u0027active\u0027"},{"line_number":38,"context_line":"\"\"\" Node is successfully deployed and associated with a tenant. \"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"DEPLOYWAIT \u003d \u0027wait call-back\u0027"},{"line_number":41,"context_line":"\"\"\" Node is waiting to be deployed."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_2fcdec5d","line":38,"updated":"2014-09-02 21:11:50.000000000","message":"I\u0027m not sure \u0027associated with a tenant\u0027 is correct here? At least in the sense of a Nova tenant...","commit_id":"db92038b2b67d3b49e97e93d2499f1d704972ed9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f4f7dda16a8966b0bcbd22018a1e28cdb89a6e41","unresolved":false,"context_lines":[{"line_number":35,"context_line":"\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"ACTIVE \u003d \u0027active\u0027"},{"line_number":38,"context_line":"\"\"\" Node is successfully deployed and associated with a tenant. \"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"DEPLOYWAIT \u003d \u0027wait call-back\u0027"},{"line_number":41,"context_line":"\"\"\" Node is waiting to be deployed."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_a46008d0","line":38,"in_reply_to":"fa98f980_2fcdec5d","updated":"2014-09-03 10:50:03.000000000","message":"I guess \u0027instance\u0027 or \u0027nova instance\u0027 will be correct","commit_id":"db92038b2b67d3b49e97e93d2499f1d704972ed9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0949b1cb568c196b8c4a17973f9625e939e27b4e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"ACTIVE \u003d \u0027active\u0027"},{"line_number":38,"context_line":"\"\"\" Node is successfully deployed and associated with a tenant. \"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"DEPLOYWAIT \u003d \u0027wait call-back\u0027"},{"line_number":41,"context_line":"\"\"\" Node is waiting to be deployed."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_ca225cb8","line":38,"in_reply_to":"fa98f980_a46008d0","updated":"2014-09-12 09:45:39.000000000","message":"+1 yeah and have a instance associated sounds better. But I bet that \u0027tentant\u0027 may be also correct because the instance is owned by a tenant and once Ironic deploy that instance and associate it with the node, the tenant owns that node.\n\nPlease correct me if I\u0027m wrong","commit_id":"db92038b2b67d3b49e97e93d2499f1d704972ed9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"5bd44592b324c29d8a0f1325d51d9403b526c472","unresolved":false,"context_lines":[{"line_number":35,"context_line":"\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"ACTIVE \u003d \u0027active\u0027"},{"line_number":38,"context_line":"\"\"\" Node is successfully deployed and associated with a tenant. \"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"DEPLOYWAIT \u003d \u0027wait call-back\u0027"},{"line_number":41,"context_line":"\"\"\" Node is waiting to be deployed."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_bda60c0d","line":38,"in_reply_to":"fa98f980_ca225cb8","updated":"2014-09-15 15:23:44.000000000","message":"Done","commit_id":"db92038b2b67d3b49e97e93d2499f1d704972ed9"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"64d8c8b0c18e7f06d8cde41ac01426daeb373317","unresolved":false,"context_lines":[{"line_number":40,"context_line":"DEPLOYWAIT \u003d \u0027wait call-back\u0027"},{"line_number":41,"context_line":"\"\"\" Node is waiting to be deployed."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"This will be the node `provision_state` when the node is being rebooted with"},{"line_number":44,"context_line":"the deployment ramdisk. Once rebooted, it triggers a callback to the API"},{"line_number":45,"context_line":"server and waits for the deployment to continue."},{"line_number":46,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_8f05f87b","line":43,"updated":"2014-09-02 21:11:50.000000000","message":"This documentation is pxe-driver specific, I believe.","commit_id":"db92038b2b67d3b49e97e93d2499f1d704972ed9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"5bd44592b324c29d8a0f1325d51d9403b526c472","unresolved":false,"context_lines":[{"line_number":40,"context_line":"DEPLOYWAIT \u003d \u0027wait call-back\u0027"},{"line_number":41,"context_line":"\"\"\" Node is waiting to be deployed."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"This will be the node `provision_state` when the node is being rebooted with"},{"line_number":44,"context_line":"the deployment ramdisk. Once rebooted, it triggers a callback to the API"},{"line_number":45,"context_line":"server and waits for the deployment to continue."},{"line_number":46,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_5da360b1","line":43,"in_reply_to":"fa98f980_6c17cd45","updated":"2014-09-15 15:23:44.000000000","message":"I chose to narrow down the deployment description here by simply stating that the node is waiting for the driver to complete deployment. A broader discussion of the deployment steps is beyond the scope of this docstring, IMO.\n\nLet me know how you all feel about that.","commit_id":"db92038b2b67d3b49e97e93d2499f1d704972ed9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0949b1cb568c196b8c4a17973f9625e939e27b4e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"DEPLOYWAIT \u003d \u0027wait call-back\u0027"},{"line_number":41,"context_line":"\"\"\" Node is waiting to be deployed."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"This will be the node `provision_state` when the node is being rebooted with"},{"line_number":44,"context_line":"the deployment ramdisk. Once rebooted, it triggers a callback to the API"},{"line_number":45,"context_line":"server and waits for the deployment to continue."},{"line_number":46,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_6c17cd45","line":43,"in_reply_to":"fa98f980_8f05f87b","updated":"2014-09-12 09:45:39.000000000","message":"Yeah +1 to make it more generic, something along the lines:\n\n\"The deployment of a node happens in two phases, the first phase was done by the ironic-condutor and now the node is waiting for driver to finish the deployment\"","commit_id":"db92038b2b67d3b49e97e93d2499f1d704972ed9"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"751c9a8cc7d1693a35efd4b14d4ce9fd0c50acb0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"\"\"\" Node is actively being torn down. \"\"\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"DELETED \u003d \u0027deleted\u0027"},{"line_number":71,"context_line":"\"\"\" Node tear down was sucessful."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"This is mainly a target provision state used during node tear down. A"},{"line_number":74,"context_line":"successful tear down leaves the node with a `provision_status` of NOSTATE."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_85e92db9","line":71,"updated":"2014-09-12 03:18:46.000000000","message":"s/sucessful/successful","commit_id":"db92038b2b67d3b49e97e93d2499f1d704972ed9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"5bd44592b324c29d8a0f1325d51d9403b526c472","unresolved":false,"context_lines":[{"line_number":68,"context_line":"\"\"\" Node is actively being torn down. \"\"\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"DELETED \u003d \u0027deleted\u0027"},{"line_number":71,"context_line":"\"\"\" Node tear down was sucessful."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"This is mainly a target provision state used during node tear down. A"},{"line_number":74,"context_line":"successful tear down leaves the node with a `provision_status` of NOSTATE."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_9d6ce8d1","line":71,"in_reply_to":"fa98f980_85e92db9","updated":"2014-09-15 15:23:44.000000000","message":"Done","commit_id":"db92038b2b67d3b49e97e93d2499f1d704972ed9"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"751c9a8cc7d1693a35efd4b14d4ce9fd0c50acb0","unresolved":false,"context_lines":[{"line_number":71,"context_line":"\"\"\" Node tear down was sucessful."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"This is mainly a target provision state used during node tear down. A"},{"line_number":74,"context_line":"successful tear down leaves the node with a `provision_status` of NOSTATE."},{"line_number":75,"context_line":"\"\"\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"ERROR \u003d \u0027error\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_e5d759ec","line":74,"updated":"2014-09-12 03:18:46.000000000","message":"s/provision_status/provision_state","commit_id":"db92038b2b67d3b49e97e93d2499f1d704972ed9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"5bd44592b324c29d8a0f1325d51d9403b526c472","unresolved":false,"context_lines":[{"line_number":71,"context_line":"\"\"\" Node tear down was sucessful."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"This is mainly a target provision state used during node tear down. A"},{"line_number":74,"context_line":"successful tear down leaves the node with a `provision_status` of NOSTATE."},{"line_number":75,"context_line":"\"\"\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"ERROR \u003d \u0027error\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_7d790492","line":74,"in_reply_to":"fa98f980_e5d759ec","updated":"2014-09-15 15:23:44.000000000","message":"Done","commit_id":"db92038b2b67d3b49e97e93d2499f1d704972ed9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0949b1cb568c196b8c4a17973f9625e939e27b4e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"ERROR \u003d \u0027error\u0027"},{"line_number":78,"context_line":"\"\"\" An error occurred during node processing."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"The `last_error` value of the node details should contain an error message."},{"line_number":81,"context_line":"\"\"\""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"REBUILD \u003d \u0027rebuild\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_6c2eed8d","line":80,"updated":"2014-09-12 09:45:39.000000000","message":"value \u003d\u003d attribute?","commit_id":"db92038b2b67d3b49e97e93d2499f1d704972ed9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"5bd44592b324c29d8a0f1325d51d9403b526c472","unresolved":false,"context_lines":[{"line_number":77,"context_line":"ERROR \u003d \u0027error\u0027"},{"line_number":78,"context_line":"\"\"\" An error occurred during node processing."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"The `last_error` value of the node details should contain an error message."},{"line_number":81,"context_line":"\"\"\""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"REBUILD \u003d \u0027rebuild\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_5d7600a5","line":80,"in_reply_to":"fa98f980_6c2eed8d","updated":"2014-09-15 15:23:44.000000000","message":"Done","commit_id":"db92038b2b67d3b49e97e93d2499f1d704972ed9"}]}