)]}'
{"ironic/nova/virt/ironic/driver.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"1e9cc06dafd8038d99f0a70f57af4f727e9016ac","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        Determines whether the node\u0027s resources should be presented"},{"line_number":166,"context_line":"        to Nova for use based on the current power and maintenance state."},{"line_number":167,"context_line":"        Returns True if unacceptable."},{"line_number":168,"context_line":"        \"\"\""},{"line_number":169,"context_line":"        bad_states \u003d [ironic_states.ERROR, ironic_states.NOSTATE]"},{"line_number":170,"context_line":"        return (node_obj.maintenance or"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_6a7a5078","line":167,"updated":"2014-09-03 23:19:03.000000000","message":"nit if another patch is pushed: this should probably be: \":returns: True if unacceptable\"","commit_id":"2492e0807bdca4010378dd4ea3fc928e7164f3dc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8bb0e3a9c80a3f60983925c6afc9ac1cbe4adac9","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        Determines whether the node\u0027s resources should be presented"},{"line_number":166,"context_line":"        to Nova for use based on the current power and maintenance state."},{"line_number":167,"context_line":"        Returns True if unacceptable."},{"line_number":168,"context_line":"        \"\"\""},{"line_number":169,"context_line":"        bad_states \u003d [ironic_states.ERROR, ironic_states.NOSTATE]"},{"line_number":170,"context_line":"        return (node_obj.maintenance or"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_4cfa0944","line":167,"in_reply_to":"fa98f980_6a7a5078","updated":"2014-09-04 00:33:44.000000000","message":"Actually, best to leave it as is. If we do :returns:, we ought to to do :params: too, and I was trying to minimize the number of changes. There doesn\u0027t seem to be consistency in this file wrt docstrings for internal methods, so what we have there is probably fine. I wouldn\u0027t have even put \u0027Returns\u0027 but I wanted to make sure it was clear what was being returned.","commit_id":"2492e0807bdca4010378dd4ea3fc928e7164f3dc"}]}
