)]}'
{"ironic/nova/scheduler/ironic_host_manager.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"e001916de57d7b6da8ff473cfbb0982cc9de1b3f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\"Ironic HostManager class that subclasses the Nova in-tree version.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _do_deprecation_warning(self):"},{"line_number":33,"context_line":"        LOG.warning(_(\u0027This Ironic scheduler_host_mananager is deprecated \u0027"},{"line_number":34,"context_line":"                      \u0027and has moved into the Nova tree. Please set \u0027"},{"line_number":35,"context_line":"                      \u0027scheduler_host_manager \u003d \u0027"},{"line_number":36,"context_line":"                      \u0027nova.scheduler.ironic_host_manager.IronicHostManager.\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_3eb9cbcb","line":33,"updated":"2014-09-09 18:31:18.000000000","message":"I think we should s/This Ironic scheduler_host_mananager/ironic.nova.scheduler.ironic_host_manager.IronicHostManager/, but this isn\u0027t too bad as is.\n\nThough we should at least s/mananager/manager/\n\nAlso, _LW()","commit_id":"48e4395752ce99c1d898fe764eb14a11887b9ce2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9ab7ba98c0f34e9fdd812df3ebf7ea73ef9587e5","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\"Ironic HostManager class that subclasses the Nova in-tree version.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _do_deprecation_warning(self):"},{"line_number":33,"context_line":"        LOG.warning(_(\u0027This Ironic scheduler_host_mananager is deprecated \u0027"},{"line_number":34,"context_line":"                      \u0027and has moved into the Nova tree. Please set \u0027"},{"line_number":35,"context_line":"                      \u0027scheduler_host_manager \u003d \u0027"},{"line_number":36,"context_line":"                      \u0027nova.scheduler.ironic_host_manager.IronicHostManager.\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_8ddc4776","line":33,"in_reply_to":"fa98f980_3eb9cbcb","updated":"2014-09-09 21:26:53.000000000","message":"+1. I think that gives the reader something easier to eg compare to the value they have set for scheduler_host_manager :-)","commit_id":"48e4395752ce99c1d898fe764eb14a11887b9ce2"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"203316b963395cf46637d6061ccbf4d879c78d00","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\"Ironic HostManager class that subclasses the Nova in-tree version.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _do_deprecation_warning(self):"},{"line_number":33,"context_line":"        LOG.warning(_(\u0027This Ironic scheduler_host_mananager is deprecated \u0027"},{"line_number":34,"context_line":"                      \u0027and has moved into the Nova tree. Please set \u0027"},{"line_number":35,"context_line":"                      \u0027scheduler_host_manager \u003d \u0027"},{"line_number":36,"context_line":"                      \u0027nova.scheduler.ironic_host_manager.IronicHostManager.\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_bfda12e7","line":33,"in_reply_to":"fa98f980_3eb9cbcb","updated":"2014-09-09 22:36:42.000000000","message":"Done","commit_id":"48e4395752ce99c1d898fe764eb14a11887b9ce2"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"90cbaeecb189caf440a76593c2c08ac01043aa60","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\"Ironic HostManager class that subclasses the Nova in-tree version.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _do_deprecation_warning(self):"},{"line_number":33,"context_line":"        LOG.warning(_(\u0027This Ironic scheduler_host_mananager is deprecated \u0027"},{"line_number":34,"context_line":"                      \u0027and has moved into the Nova tree. Please set \u0027"},{"line_number":35,"context_line":"                      \u0027scheduler_host_manager \u003d \u0027"},{"line_number":36,"context_line":"                      \u0027nova.scheduler.ironic_host_manager.IronicHostManager.\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_0d885721","line":33,"in_reply_to":"fa98f980_8ddc4776","updated":"2014-09-09 21:41:42.000000000","message":"Just a note than s/mananager/manager/ -- I know the string will be updated anyway don\u0027t want the spelling missed.","commit_id":"48e4395752ce99c1d898fe764eb14a11887b9ce2"}],"ironic/nova/virt/ironic/__init__.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"e001916de57d7b6da8ff473cfbb0982cc9de1b3f","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from ironic.nova.virt.ironic import driver"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"IronicDriver \u003d driver.IronicDriver"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_7e38b33d","side":"PARENT","line":18,"updated":"2014-09-09 18:31:18.000000000","message":"Still need this here to be able to set the compute driver to `ironic.nova.virt.ironic.IronicDriver`.","commit_id":"95d1262450bd81ffdcb3fae2711db945a9da3068"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"203316b963395cf46637d6061ccbf4d879c78d00","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from ironic.nova.virt.ironic import driver"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"IronicDriver \u003d driver.IronicDriver"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_7fe8aa7c","side":"PARENT","line":18,"in_reply_to":"fa98f980_7e38b33d","updated":"2014-09-09 22:36:42.000000000","message":"Done","commit_id":"95d1262450bd81ffdcb3fae2711db945a9da3068"}],"ironic/nova/virt/ironic/driver.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9ab7ba98c0f34e9fdd812df3ebf7ea73ef9587e5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":"A driver which subclasses the new location in the Nova tree."},{"line_number":21,"context_line":"This is a placeholder so that end users can gradually upgrade to use the"},{"line_number":22,"context_line":"new settings. TODO: remove in the K release"},{"line_number":23,"context_line":"\"\"\""},{"line_number":24,"context_line":"from nova.openstack.common import log as logging"},{"line_number":25,"context_line":"from nova.virt.ironic import driver"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_cde64f44","line":22,"updated":"2014-09-09 21:26:53.000000000","message":"nit: K -\u003e Kilo","commit_id":"48e4395752ce99c1d898fe764eb14a11887b9ce2"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"e001916de57d7b6da8ff473cfbb0982cc9de1b3f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \"\"\"Nova Ironic driver that subclasses the Nova in-tree version.\"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _do_deprecation_warning(self):"},{"line_number":34,"context_line":"        LOG.warning(_(\u0027This Ironic compute driver is deprecated and has moved \u0027"},{"line_number":35,"context_line":"                      \u0027into the Nova tree. Please set compute_driver \u003d \u0027"},{"line_number":36,"context_line":"                      \u0027nova.virt.ironic.driver.IronicDriver.\u0027))"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_7eea73ad","line":34,"updated":"2014-09-09 18:31:18.000000000","message":"Again, probably should s/This Ironic compute_driver/ironic.nova.virt.ironic.IronicDriver/\n\nAnd _LW() again.","commit_id":"48e4395752ce99c1d898fe764eb14a11887b9ce2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9ab7ba98c0f34e9fdd812df3ebf7ea73ef9587e5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \"\"\"Nova Ironic driver that subclasses the Nova in-tree version.\"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _do_deprecation_warning(self):"},{"line_number":34,"context_line":"        LOG.warning(_(\u0027This Ironic compute driver is deprecated and has moved \u0027"},{"line_number":35,"context_line":"                      \u0027into the Nova tree. Please set compute_driver \u003d \u0027"},{"line_number":36,"context_line":"                      \u0027nova.virt.ironic.driver.IronicDriver.\u0027))"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_323ada98","line":34,"in_reply_to":"fa98f980_7eea73ad","updated":"2014-09-09 21:26:53.000000000","message":"+1.","commit_id":"48e4395752ce99c1d898fe764eb14a11887b9ce2"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"203316b963395cf46637d6061ccbf4d879c78d00","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \"\"\"Nova Ironic driver that subclasses the Nova in-tree version.\"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _do_deprecation_warning(self):"},{"line_number":34,"context_line":"        LOG.warning(_(\u0027This Ironic compute driver is deprecated and has moved \u0027"},{"line_number":35,"context_line":"                      \u0027into the Nova tree. Please set compute_driver \u003d \u0027"},{"line_number":36,"context_line":"                      \u0027nova.virt.ironic.driver.IronicDriver.\u0027))"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_ff92daf4","line":34,"in_reply_to":"fa98f980_7eea73ad","updated":"2014-09-09 22:36:42.000000000","message":"Done","commit_id":"48e4395752ce99c1d898fe764eb14a11887b9ce2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9ab7ba98c0f34e9fdd812df3ebf7ea73ef9587e5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def _do_deprecation_warning(self):"},{"line_number":34,"context_line":"        LOG.warning(_(\u0027This Ironic compute driver is deprecated and has moved \u0027"},{"line_number":35,"context_line":"                      \u0027into the Nova tree. Please set compute_driver \u003d \u0027"},{"line_number":36,"context_line":"                      \u0027nova.virt.ironic.driver.IronicDriver.\u0027))"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __init__(self, virtapi, read_only\u003dFalse):"},{"line_number":39,"context_line":"        super(IronicDriver, self).__init__(virtapi)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_32a49ab8","line":36,"updated":"2014-09-09 21:26:53.000000000","message":"it\u0027s nova.virt.ironic.IronicDriver","commit_id":"48e4395752ce99c1d898fe764eb14a11887b9ce2"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"203316b963395cf46637d6061ccbf4d879c78d00","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def _do_deprecation_warning(self):"},{"line_number":34,"context_line":"        LOG.warning(_(\u0027This Ironic compute driver is deprecated and has moved \u0027"},{"line_number":35,"context_line":"                      \u0027into the Nova tree. Please set compute_driver \u003d \u0027"},{"line_number":36,"context_line":"                      \u0027nova.virt.ironic.driver.IronicDriver.\u0027))"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __init__(self, virtapi, read_only\u003dFalse):"},{"line_number":39,"context_line":"        super(IronicDriver, self).__init__(virtapi)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_7f6d0a04","line":36,"in_reply_to":"fa98f980_32a49ab8","updated":"2014-09-09 22:36:42.000000000","message":"Done","commit_id":"48e4395752ce99c1d898fe764eb14a11887b9ce2"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"5b4ded6e8bb62c81f1734c3633fda116a823d7e8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class IronicDriver(driver.IronicDriver):"},{"line_number":33,"context_line":"    \"\"\"Nova Ironic driver that subclasses the Nova in-tree version.\"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def _do_deprecation_warning(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_ff057a14","line":32,"updated":"2014-09-09 22:40:38.000000000","message":"I know this works, but would we prefer this?\n\n    from nova.virt import ironic\n    class IronicDriver(ironic.IronicDriver):","commit_id":"93edd4f3804ed90cc2ff0e3f9f3142cabfe64e30"}]}