)]}'
{"ironic/objects/base.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3ae87baf47f8edfd08edc116a1623f4f01f3e440","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    \"\"\""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    # Version of this object (see rules above check_object_version())"},{"line_number":183,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    # The fields present in this object as key:typefn pairs. For example:"},{"line_number":186,"context_line":"    #"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_0762f615","line":183,"updated":"2014-09-18 22:05:19.000000000","message":"Do you know if this change affects the VERSION?","commit_id":"20e062b70f5f98fc014e81f688ab2a8bc29ff4ed"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8b6a8c8a9252f5983e878a1d1efcf0899e043a64","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    \"\"\""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    # Version of this object (see rules above check_object_version())"},{"line_number":183,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    # The fields present in this object as key:typefn pairs. For example:"},{"line_number":186,"context_line":"    #"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_84433912","line":183,"in_reply_to":"fa98f980_0762f615","updated":"2014-09-19 07:14:10.000000000","message":"IIRC version is anyway overriden for any meaningful subclass","commit_id":"20e062b70f5f98fc014e81f688ab2a8bc29ff4ed"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"41a8b39541c160cf8c38dafa90ca3519ef1243b8","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    \"\"\""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    # Version of this object (see rules above check_object_version())"},{"line_number":183,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    # The fields present in this object as key:typefn pairs. For example:"},{"line_number":186,"context_line":"    #"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_490fa988","line":183,"in_reply_to":"fa98f980_84433912","updated":"2014-09-19 09:03:26.000000000","message":"I don\u0027t think so, the base class is just a skeleton for the objects you can\u0027t use it directly","commit_id":"20e062b70f5f98fc014e81f688ab2a8bc29ff4ed"}],"ironic/objects/chassis.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3ae87baf47f8edfd08edc116a1623f4f01f3e440","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        chassis \u003d Chassis._from_db_object(cls(context), db_chassis)"},{"line_number":77,"context_line":"        # FIXME(comstud): Setting of the context should be moved to"},{"line_number":78,"context_line":"        # _from_db_object()."},{"line_number":79,"context_line":"        chassis._context \u003d context"},{"line_number":80,"context_line":"        return chassis"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @base.remotable_classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_27653a1d","line":79,"updated":"2014-09-18 22:05:19.000000000","message":"This might be a dumb question. Are the above 3 lines needed still? Isn\u0027t the context set already? (Similar question for other two changes below.) I see it in other files too.","commit_id":"20e062b70f5f98fc014e81f688ab2a8bc29ff4ed"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"a3090a685d4ba01ec65f8ac985540bd85b8045e0","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        chassis \u003d Chassis._from_db_object(cls(context), db_chassis)"},{"line_number":77,"context_line":"        # FIXME(comstud): Setting of the context should be moved to"},{"line_number":78,"context_line":"        # _from_db_object()."},{"line_number":79,"context_line":"        chassis._context \u003d context"},{"line_number":80,"context_line":"        return chassis"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @base.remotable_classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_95ad2d9e","line":79,"in_reply_to":"fa98f980_27653a1d","updated":"2014-09-19 01:21:09.000000000","message":"Ruby, this is covered in the next review that depends on this one (122401).","commit_id":"20e062b70f5f98fc014e81f688ab2a8bc29ff4ed"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8b6a8c8a9252f5983e878a1d1efcf0899e043a64","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        chassis \u003d Chassis._from_db_object(cls(context), db_chassis)"},{"line_number":77,"context_line":"        # FIXME(comstud): Setting of the context should be moved to"},{"line_number":78,"context_line":"        # _from_db_object()."},{"line_number":79,"context_line":"        chassis._context \u003d context"},{"line_number":80,"context_line":"        return chassis"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @base.remotable_classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_a4703d74","line":79,"in_reply_to":"fa98f980_95ad2d9e","updated":"2014-09-19 07:14:10.000000000","message":"I would still delete these lines right here, but I don\u0027t insist","commit_id":"20e062b70f5f98fc014e81f688ab2a8bc29ff4ed"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"41a8b39541c160cf8c38dafa90ca3519ef1243b8","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        chassis \u003d Chassis._from_db_object(cls(context), db_chassis)"},{"line_number":77,"context_line":"        # FIXME(comstud): Setting of the context should be moved to"},{"line_number":78,"context_line":"        # _from_db_object()."},{"line_number":79,"context_line":"        chassis._context \u003d context"},{"line_number":80,"context_line":"        return chassis"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @base.remotable_classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_a94d75c6","line":79,"in_reply_to":"fa98f980_a4703d74","updated":"2014-09-19 09:03:26.000000000","message":"I wanted to separate one change for the other, first make it mandatory to the base class and then in the next review remove all this lines and add tests to make sure the context still being set etc... I can merge both patches if you guys prefer tho, I tried to break the the patches into small changes to make it easier to review and rebase too (since they change a lot of files)","commit_id":"20e062b70f5f98fc014e81f688ab2a8bc29ff4ed"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4d7ce3852c19d98f241be1bce5228522e5fef621","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        chassis \u003d Chassis._from_db_object(cls(context), db_chassis)"},{"line_number":77,"context_line":"        # FIXME(comstud): Setting of the context should be moved to"},{"line_number":78,"context_line":"        # _from_db_object()."},{"line_number":79,"context_line":"        chassis._context \u003d context"},{"line_number":80,"context_line":"        return chassis"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @base.remotable_classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"da9df570_7649eacf","line":79,"in_reply_to":"fa98f980_a94d75c6","updated":"2014-09-22 16:10:58.000000000","message":"The comment/code is not needed due to the fix, so it really confused me that it was still here when I was reviewing. I thought maybe I misunderstood the code. I like to think of a patch as being stand alone so I couidn\u0027t figure out why this was still here ;)","commit_id":"20e062b70f5f98fc014e81f688ab2a8bc29ff4ed"}],"ironic/objects/node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2cf80fb3c8864496f42ff41dc720d6b959812ae8","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        values \u003d self.obj_get_changes()"},{"line_number":213,"context_line":"        db_node \u003d self.dbapi.create_node(values)"},{"line_number":214,"context_line":"        with open(\"/tmp/lalau\", \"w\") as f:"},{"line_number":215,"context_line":"            f.write(str(self._context))"},{"line_number":216,"context_line":"        self._from_db_object(self, db_node)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    @base.remotable"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_38d66ac4","line":215,"updated":"2014-09-17 14:23:02.000000000","message":"hmmm :)","commit_id":"79583d578583f170b643e9d8225f47246bb12a6e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"21fa1cb36a7b05ba147acc48860f51e6205ea41e","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        values \u003d self.obj_get_changes()"},{"line_number":213,"context_line":"        db_node \u003d self.dbapi.create_node(values)"},{"line_number":214,"context_line":"        with open(\"/tmp/lalau\", \"w\") as f:"},{"line_number":215,"context_line":"            f.write(str(self._context))"},{"line_number":216,"context_line":"        self._from_db_object(self, db_node)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    @base.remotable"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_180a8627","line":215,"in_reply_to":"fa98f980_38d66ac4","updated":"2014-09-17 14:28:28.000000000","message":"oh urgh hah debug code!","commit_id":"79583d578583f170b643e9d8225f47246bb12a6e"}]}