)]}'
{"ironic/tests/drivers/test_snmp.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"74e55765e41bbd418f49f0eea13268a39dba9711","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @mock.patch.object(snmp.SNMPClient, \u0027_get_transport\u0027)"},{"line_number":106,"context_line":"    @mock.patch.object(snmp.SNMPClient, \u0027_get_auth\u0027)"},{"line_number":107,"context_line":"    def test_get_err_transport(self, mock_auth, mock_transport, mock_cmdgen):"},{"line_number":108,"context_line":"        mock_transport.side_effect \u003d snmp_error.PySnmpError"},{"line_number":109,"context_line":"        var_bind \u003d (self.oid, self.value)"},{"line_number":110,"context_line":"        mock_cmdgenerator \u003d mock_cmdgen.return_value"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_a43d9d2e","line":107,"updated":"2014-09-19 07:28:47.000000000","message":"nit:\n\n test__get_transport_err\n test_get_err_transport\n\nlook too similar to me.  maybe\n\n test__get_transport_raises\n test_get_snmp_exception\n\nor something?","commit_id":"26310362504304dfcc7ec4540ef2cbe8230900de"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a810ffa8046739c140e891dc0c83a9b8ef64804","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @mock.patch.object(snmp.SNMPClient, \u0027_get_transport\u0027)"},{"line_number":106,"context_line":"    @mock.patch.object(snmp.SNMPClient, \u0027_get_auth\u0027)"},{"line_number":107,"context_line":"    def test_get_err_transport(self, mock_auth, mock_transport, mock_cmdgen):"},{"line_number":108,"context_line":"        mock_transport.side_effect \u003d snmp_error.PySnmpError"},{"line_number":109,"context_line":"        var_bind \u003d (self.oid, self.value)"},{"line_number":110,"context_line":"        mock_cmdgenerator \u003d mock_cmdgen.return_value"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_22bc7869","line":107,"in_reply_to":"fa98f980_a43d9d2e","updated":"2014-09-22 18:21:46.000000000","message":"Thanks for pointing that out. Since these were tests, it didn\u0027t bother me that they were somewhat similar, but yes, I could have changed the names. Sorry, I didn\u0027t see this before it was approved.","commit_id":"26310362504304dfcc7ec4540ef2cbe8230900de"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"74e55765e41bbd418f49f0eea13268a39dba9711","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        var_bind \u003d (self.oid, self.value)"},{"line_number":145,"context_line":"        mock_cmdgenerator \u003d mock_cmdgen.return_value"},{"line_number":146,"context_line":"        mock_cmdgenerator.setCmd.return_value \u003d (\"engine error\", None, 0,"},{"line_number":147,"context_line":"                                                 [var_bind])"},{"line_number":148,"context_line":"        client \u003d snmp.SNMPClient(self.address, self.port, snmp.SNMP_V3)"},{"line_number":149,"context_line":"        self.assertRaises(exception.SNMPFailure,"},{"line_number":150,"context_line":"                          client.set, self.oid, self.value)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_0443c9af","line":147,"updated":"2014-09-19 07:28:47.000000000","message":"nit: these 3 lines are not needed","commit_id":"26310362504304dfcc7ec4540ef2cbe8230900de"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"16ab894f374b82ca963cc645a05f32f966599158","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        var_bind \u003d (self.oid, self.value)"},{"line_number":145,"context_line":"        mock_cmdgenerator \u003d mock_cmdgen.return_value"},{"line_number":146,"context_line":"        mock_cmdgenerator.setCmd.return_value \u003d (\"engine error\", None, 0,"},{"line_number":147,"context_line":"                                                 [var_bind])"},{"line_number":148,"context_line":"        client \u003d snmp.SNMPClient(self.address, self.port, snmp.SNMP_V3)"},{"line_number":149,"context_line":"        self.assertRaises(exception.SNMPFailure,"},{"line_number":150,"context_line":"                          client.set, self.oid, self.value)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_2c58b3f9","line":147,"in_reply_to":"fa98f980_0443c9af","updated":"2014-09-19 09:27:01.000000000","message":"3 lines above?\n\nThe L145 still needed no? So it can be checked whether it mock_cmdgenerator.setCmd has been called (see L151)","commit_id":"26310362504304dfcc7ec4540ef2cbe8230900de"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a810ffa8046739c140e891dc0c83a9b8ef64804","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        var_bind \u003d (self.oid, self.value)"},{"line_number":145,"context_line":"        mock_cmdgenerator \u003d mock_cmdgen.return_value"},{"line_number":146,"context_line":"        mock_cmdgenerator.setCmd.return_value \u003d (\"engine error\", None, 0,"},{"line_number":147,"context_line":"                                                 [var_bind])"},{"line_number":148,"context_line":"        client \u003d snmp.SNMPClient(self.address, self.port, snmp.SNMP_V3)"},{"line_number":149,"context_line":"        self.assertRaises(exception.SNMPFailure,"},{"line_number":150,"context_line":"                          client.set, self.oid, self.value)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_82e524aa","line":147,"in_reply_to":"fa98f980_2c58b3f9","updated":"2014-09-22 18:21:46.000000000","message":"Yes, it\u0027s true it isn\u0027t needed. I could have changed L151 to use mock_cmdgen.return_value instead. I did it to make it easier to compare with test_set() \u0026 test_set_err_engine(). What are your thoughts? Just do the minimum needed for a test?","commit_id":"26310362504304dfcc7ec4540ef2cbe8230900de"}]}