)]}'
{"ironic/objects/chassis.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"13fb4e79c1d10fecbd4c9f8eabfc92b88ac5b147","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                                                sort_key\u003dsort_key,"},{"line_number":108,"context_line":"                                                sort_dir\u003dsort_dir)"},{"line_number":109,"context_line":"        for obj in db_chassis:"},{"line_number":110,"context_line":"            chassis_list.append(Chassis._from_db_object(cls(context), obj))"},{"line_number":111,"context_line":"        return chassis_list"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @base.remotable"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_0be79e13","line":110,"updated":"2014-09-22 09:30:43.000000000","message":"nit:\n\n return [Chassis._from_db_object(cls(context), obj) for obj in db_chassis]","commit_id":"f92ebb9946877ec3db07c19b62a1d5f589caf049"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ea6a693e3e993610c6b2230c19495164ed7c042a","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                                                sort_key\u003dsort_key,"},{"line_number":108,"context_line":"                                                sort_dir\u003dsort_dir)"},{"line_number":109,"context_line":"        for obj in db_chassis:"},{"line_number":110,"context_line":"            chassis_list.append(Chassis._from_db_object(cls(context), obj))"},{"line_number":111,"context_line":"        return chassis_list"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @base.remotable"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_0df96de9","line":110,"in_reply_to":"da9df570_0be79e13","updated":"2014-09-22 14:09:37.000000000","message":"Done","commit_id":"f92ebb9946877ec3db07c19b62a1d5f589caf049"}],"ironic/objects/node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"13fb4e79c1d10fecbd4c9f8eabfc92b88ac5b147","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                                           sort_dir\u003dsort_dir)"},{"line_number":145,"context_line":"        for obj in db_nodes:"},{"line_number":146,"context_line":"            node \u003d Node._from_db_object(cls(context), obj)"},{"line_number":147,"context_line":"            node_list.append(node)"},{"line_number":148,"context_line":"        return node_list"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    @base.remotable_classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_cbb4b6f4","line":147,"updated":"2014-09-22 09:30:43.000000000","message":"nit:\n\n return [Node._from_db_object(cls(context), obj) for obj in db_nodes]","commit_id":"f92ebb9946877ec3db07c19b62a1d5f589caf049"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ea6a693e3e993610c6b2230c19495164ed7c042a","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                                           sort_dir\u003dsort_dir)"},{"line_number":145,"context_line":"        for obj in db_nodes:"},{"line_number":146,"context_line":"            node \u003d Node._from_db_object(cls(context), obj)"},{"line_number":147,"context_line":"            node_list.append(node)"},{"line_number":148,"context_line":"        return node_list"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    @base.remotable_classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_8de47d3c","line":147,"in_reply_to":"da9df570_cbb4b6f4","updated":"2014-09-22 14:09:37.000000000","message":"Done","commit_id":"f92ebb9946877ec3db07c19b62a1d5f589caf049"}],"ironic/objects/port.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"13fb4e79c1d10fecbd4c9f8eabfc92b88ac5b147","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        \"\"\"Converts a list of database entities to a list of formal objects.\"\"\""},{"line_number":54,"context_line":"        port_list \u003d []"},{"line_number":55,"context_line":"        for obj in db_objects:"},{"line_number":56,"context_line":"            port_list.append(Port._from_db_object(cls(context), obj))"},{"line_number":57,"context_line":"        return port_list"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @base.remotable_classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_6bc58a5a","line":56,"updated":"2014-09-22 09:30:43.000000000","message":"nit:\n\n return [Port._from_db_object(cls(context), obj) for obj in db_objects]\n\nactually it makes sense to me to bring this method to base class","commit_id":"f92ebb9946877ec3db07c19b62a1d5f589caf049"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ea6a693e3e993610c6b2230c19495164ed7c042a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        \"\"\"Converts a list of database entities to a list of formal objects.\"\"\""},{"line_number":54,"context_line":"        port_list \u003d []"},{"line_number":55,"context_line":"        for obj in db_objects:"},{"line_number":56,"context_line":"            port_list.append(Port._from_db_object(cls(context), obj))"},{"line_number":57,"context_line":"        return port_list"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @base.remotable_classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_2dc47191","line":56,"in_reply_to":"da9df570_6bc58a5a","updated":"2014-09-22 14:09:37.000000000","message":"Yeah, it sounds like something we could do to move it to the base class. I\u0027m not doing it in this patch tho, but I will take a look into it","commit_id":"f92ebb9946877ec3db07c19b62a1d5f589caf049"}],"ironic/tests/objects/test_chassis.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"07fe72eff377cc60e080a57a2aad7fc0aa0f88a1","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            chassis \u003d objects.Chassis.get(self.context, chassis_id)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"            mock_get_chassis.assert_called_once_with(chassis_id)"},{"line_number":44,"context_line":"            self.assertEqual(chassis._context, self.context)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def test_get_by_uuid(self):"},{"line_number":47,"context_line":"        uuid \u003d self.fake_chassis[\u0027uuid\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_c170dedc","line":44,"updated":"2014-09-18 20:47:57.000000000","message":"I think we need to switch these arguments. Should be (\u003cexpected\u003e, \u003cactual\u003e) instead of the other way around.\n\nSame for the assertEqual() calls below this.","commit_id":"f8a0719a0ee5e11e80de7ac59aac9efd5db078ab"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6bc1a9643d2d73d21cb864426c3fd7619cd92f0e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            chassis \u003d objects.Chassis.get(self.context, chassis_id)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"            mock_get_chassis.assert_called_once_with(chassis_id)"},{"line_number":44,"context_line":"            self.assertEqual(chassis._context, self.context)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def test_get_by_uuid(self):"},{"line_number":47,"context_line":"        uuid \u003d self.fake_chassis[\u0027uuid\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_49eb2978","line":44,"in_reply_to":"fa98f980_c170dedc","updated":"2014-09-19 09:04:00.000000000","message":"ah good catch I will change the order for all them. Thanks","commit_id":"f8a0719a0ee5e11e80de7ac59aac9efd5db078ab"}],"ironic/tests/objects/test_conductor.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"07fe72eff377cc60e080a57a2aad7fc0aa0f88a1","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            c.refresh()"},{"line_number":82,"context_line":"            self.assertEqual(obj_utils.datetime_or_none(t1), c.updated_at)"},{"line_number":83,"context_line":"            self.assertEqual(expected, mock_get_cdr.call_args_list)"},{"line_number":84,"context_line":"            self.assertEqual(c._context, self.context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_2c28c184","line":84,"updated":"2014-09-18 20:47:57.000000000","message":"Same: expected vs. actual order","commit_id":"f8a0719a0ee5e11e80de7ac59aac9efd5db078ab"}],"ironic/tests/objects/test_node.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"07fe72eff377cc60e080a57a2aad7fc0aa0f88a1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            node \u003d objects.Node.get(self.context, node_id)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"            mock_get_node.assert_called_once_with(node_id)"},{"line_number":42,"context_line":"            self.assertEqual(node._context, self.context)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def test_get_by_uuid(self):"},{"line_number":45,"context_line":"        uuid \u003d self.fake_node[\u0027uuid\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_4c56e507","line":42,"updated":"2014-09-18 20:47:57.000000000","message":"Same: expected vs. actual order. And all below.","commit_id":"f8a0719a0ee5e11e80de7ac59aac9efd5db078ab"}]}