)]}'
{"ironic/conductor/utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f384b1177bdf7f59bf512802b3a036d70c6e8cdc","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            curr_state \u003d task.driver.power.get_power_state(task)"},{"line_number":69,"context_line":"        except Exception as e:"},{"line_number":70,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":71,"context_line":"                node[\u0027last_error\u0027] \u003d ("},{"line_number":72,"context_line":"                    _(\"Failed to change power state to \u0027%(target)s\u0027. \""},{"line_number":73,"context_line":"                      \"Error: %(error)s\") % {"},{"line_number":74,"context_line":"                      \u0027target\u0027: new_state, \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_6bd2f335","line":71,"updated":"2014-10-09 22:26:18.000000000","message":"do you need this extra paren, or did you think it looks better with it, than bringing up  _(\"Failed...\" from the 2nd line?","commit_id":"0df2ffb8acf5530afeaf7153ca44d57e20ed7d71"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"52f5373eb111fb45cbafe085e17197af82b6317b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            curr_state \u003d task.driver.power.get_power_state(task)"},{"line_number":69,"context_line":"        except Exception as e:"},{"line_number":70,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":71,"context_line":"                node[\u0027last_error\u0027] \u003d ("},{"line_number":72,"context_line":"                    _(\"Failed to change power state to \u0027%(target)s\u0027. \""},{"line_number":73,"context_line":"                      \"Error: %(error)s\") % {"},{"line_number":74,"context_line":"                      \u0027target\u0027: new_state, \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_c67822fb","line":71,"in_reply_to":"baa201ad_6bd2f335","updated":"2014-10-10 15:13:48.000000000","message":"Bringing that line up exceeds the 80 character limit.","commit_id":"0df2ffb8acf5530afeaf7153ca44d57e20ed7d71"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e261a7e71c0393d9cd47e625c290d4e8af0a5ca2","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            task.driver.power.reboot(task)"},{"line_number":115,"context_line":"    except Exception as e:"},{"line_number":116,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":117,"context_line":"            node[\u0027last_error\u0027] \u003d ("},{"line_number":118,"context_line":"                _(\"Failed to change power state to \u0027%(target)s\u0027. \""},{"line_number":119,"context_line":"                  \"Error: %(error)s\") % {"},{"line_number":120,"context_line":"                    \u0027target\u0027: target_state, \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_ff113654","line":117,"updated":"2014-10-10 07:31:58.000000000","message":"Agree with Ruby, please do not use extra parentheses if possible.","commit_id":"0df2ffb8acf5530afeaf7153ca44d57e20ed7d71"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"52f5373eb111fb45cbafe085e17197af82b6317b","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            task.driver.power.reboot(task)"},{"line_number":115,"context_line":"    except Exception as e:"},{"line_number":116,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":117,"context_line":"            node[\u0027last_error\u0027] \u003d ("},{"line_number":118,"context_line":"                _(\"Failed to change power state to \u0027%(target)s\u0027. \""},{"line_number":119,"context_line":"                  \"Error: %(error)s\") % {"},{"line_number":120,"context_line":"                    \u0027target\u0027: target_state, \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_a6731e14","line":117,"in_reply_to":"baa201ad_ff113654","updated":"2014-10-10 15:13:48.000000000","message":"Same as above, bringing that line up exceeds the 80 character limit.","commit_id":"0df2ffb8acf5530afeaf7153ca44d57e20ed7d71"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"15bb4e92a8c25148575aee3e8e21edeaf329dc87","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            curr_state \u003d task.driver.power.get_power_state(task)"},{"line_number":69,"context_line":"        except Exception as e:"},{"line_number":70,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":71,"context_line":"                node[\u0027last_error\u0027] \u003d ("},{"line_number":72,"context_line":"                    _(\"Failed to change power state to \u0027%(target)s\u0027. \""},{"line_number":73,"context_line":"                      \"Error: %(error)s\") % {"},{"line_number":74,"context_line":"                      \u0027target\u0027: new_state, \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_c1c64c16","line":71,"updated":"2014-10-10 15:40:54.000000000","message":"hmm, we were probably not that clear:\n\n node[\u0027last_error\u0027] \u003d _(\n    \"Failed to change power state to \u0027%(target)s\u0027. \"\n     ....)","commit_id":"c2e7af025481de1e0106c96a1ff84d7f25a3fe67"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"153b87c5880548ef19497d60c3589cd68aeed0fe","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            curr_state \u003d task.driver.power.get_power_state(task)"},{"line_number":69,"context_line":"        except Exception as e:"},{"line_number":70,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":71,"context_line":"                node[\u0027last_error\u0027] \u003d ("},{"line_number":72,"context_line":"                    _(\"Failed to change power state to \u0027%(target)s\u0027. \""},{"line_number":73,"context_line":"                      \"Error: %(error)s\") % {"},{"line_number":74,"context_line":"                      \u0027target\u0027: new_state, \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_ac8cdc36","line":71,"in_reply_to":"baa201ad_c1c64c16","updated":"2014-10-10 17:57:45.000000000","message":"Ah, I see. Done.","commit_id":"c2e7af025481de1e0106c96a1ff84d7f25a3fe67"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"15bb4e92a8c25148575aee3e8e21edeaf329dc87","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            task.driver.power.reboot(task)"},{"line_number":115,"context_line":"    except Exception as e:"},{"line_number":116,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":117,"context_line":"            node[\u0027last_error\u0027] \u003d ("},{"line_number":118,"context_line":"                _(\"Failed to change power state to \u0027%(target)s\u0027. \""},{"line_number":119,"context_line":"                  \"Error: %(error)s\") % {"},{"line_number":120,"context_line":"                    \u0027target\u0027: target_state, \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_41da5cea","line":117,"updated":"2014-10-10 15:40:54.000000000","message":"ditto","commit_id":"c2e7af025481de1e0106c96a1ff84d7f25a3fe67"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"153b87c5880548ef19497d60c3589cd68aeed0fe","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            task.driver.power.reboot(task)"},{"line_number":115,"context_line":"    except Exception as e:"},{"line_number":116,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":117,"context_line":"            node[\u0027last_error\u0027] \u003d ("},{"line_number":118,"context_line":"                _(\"Failed to change power state to \u0027%(target)s\u0027. \""},{"line_number":119,"context_line":"                  \"Error: %(error)s\") % {"},{"line_number":120,"context_line":"                    \u0027target\u0027: target_state, \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_cc8120fd","line":117,"in_reply_to":"baa201ad_41da5cea","updated":"2014-10-10 17:57:45.000000000","message":"Done","commit_id":"c2e7af025481de1e0106c96a1ff84d7f25a3fe67"}],"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"0abbf91bc57bf4bb82d1295fbc5f5c23a74738a7","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        transit_channel \u003d None"},{"line_number":241,"context_line":"        transit_address \u003d None"},{"line_number":242,"context_line":"        target_channel \u003d None"},{"line_number":243,"context_line":"        target_address \u003d None"},{"line_number":244,"context_line":"    elif bridging_type in bridging_types:"},{"line_number":245,"context_line":"        # check if the particular bridging option is supported on host"},{"line_number":246,"context_line":"        if not _is_option_supported(\u0027%s_bridge\u0027 % bridging_type):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_3305b514","line":243,"updated":"2014-10-10 10:30:06.000000000","message":"Here also this can be used\n(local_address, transit_channel, transit_address, target_channel,\n target_address) \u003d (None,)*5","commit_id":"0df2ffb8acf5530afeaf7153ca44d57e20ed7d71"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"52f5373eb111fb45cbafe085e17197af82b6317b","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        transit_channel \u003d None"},{"line_number":241,"context_line":"        transit_address \u003d None"},{"line_number":242,"context_line":"        target_channel \u003d None"},{"line_number":243,"context_line":"        target_address \u003d None"},{"line_number":244,"context_line":"    elif bridging_type in bridging_types:"},{"line_number":245,"context_line":"        # check if the particular bridging option is supported on host"},{"line_number":246,"context_line":"        if not _is_option_supported(\u0027%s_bridge\u0027 % bridging_type):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_86e45aad","line":243,"in_reply_to":"baa201ad_3305b514","updated":"2014-10-10 15:13:48.000000000","message":"Done","commit_id":"0df2ffb8acf5530afeaf7153ca44d57e20ed7d71"}],"ironic/tests/conductor/test_conductor_utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f384b1177bdf7f59bf512802b3a036d70c6e8cdc","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        with mock.patch.object(self.driver.power,"},{"line_number":219,"context_line":"                               \u0027get_power_state\u0027) as get_power_state_mock:"},{"line_number":220,"context_line":"            (get_power_state_mock"},{"line_number":221,"context_line":"             .side_effect) \u003d exception.InvalidParameterValue("},{"line_number":222,"context_line":"                                 \u0027failed getting power state\u0027)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"            self.assertRaises(exception.InvalidParameterValue,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_eb94238e","line":221,"updated":"2014-10-09 22:26:18.000000000","message":"whoa!","commit_id":"0df2ffb8acf5530afeaf7153ca44d57e20ed7d71"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"52f5373eb111fb45cbafe085e17197af82b6317b","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        with mock.patch.object(self.driver.power,"},{"line_number":219,"context_line":"                               \u0027get_power_state\u0027) as get_power_state_mock:"},{"line_number":220,"context_line":"            (get_power_state_mock"},{"line_number":221,"context_line":"             .side_effect) \u003d exception.InvalidParameterValue("},{"line_number":222,"context_line":"                                 \u0027failed getting power state\u0027)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"            self.assertRaises(exception.InvalidParameterValue,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_46019238","line":221,"in_reply_to":"baa201ad_c2e659e8","updated":"2014-10-10 15:13:48.000000000","message":"Done","commit_id":"0df2ffb8acf5530afeaf7153ca44d57e20ed7d71"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f92d0486beb4999c903e7d1497e8e8be9f201cf0","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        with mock.patch.object(self.driver.power,"},{"line_number":219,"context_line":"                               \u0027get_power_state\u0027) as get_power_state_mock:"},{"line_number":220,"context_line":"            (get_power_state_mock"},{"line_number":221,"context_line":"             .side_effect) \u003d exception.InvalidParameterValue("},{"line_number":222,"context_line":"                                 \u0027failed getting power state\u0027)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"            self.assertRaises(exception.InvalidParameterValue,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_c2e659e8","line":221,"in_reply_to":"baa201ad_eb94238e","updated":"2014-10-10 08:52:51.000000000","message":"hah +1\n\n get_power_state_mock.side_effect \u003d (\n      exception.InvalidParameterValue(\u0027failed getting power state\u0027))\n\n?","commit_id":"0df2ffb8acf5530afeaf7153ca44d57e20ed7d71"}],"ironic/tests/conductor/utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f384b1177bdf7f59bf512802b3a036d70c6e8cdc","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    #                    with the real namespace."},{"line_number":46,"context_line":"    (driver_factory"},{"line_number":47,"context_line":"     .DriverFactory"},{"line_number":48,"context_line":"     ._extension_manager) \u003d dispatch.NameDispatchExtensionManager("},{"line_number":49,"context_line":"                                \u0027ironic.no-such-namespace\u0027,"},{"line_number":50,"context_line":"                                lambda x: True)"},{"line_number":51,"context_line":"    mock_ext_mgr \u003d driver_factory.DriverFactory()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_2be62b45","line":48,"updated":"2014-10-09 22:26:18.000000000","message":"I\u0027m not crazy about this (but don\u0027t have an alternative suggestion)","commit_id":"0df2ffb8acf5530afeaf7153ca44d57e20ed7d71"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee90d86c34fd2a31795225081bb75f47c2491705","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    #                    with the real namespace."},{"line_number":46,"context_line":"    (driver_factory"},{"line_number":47,"context_line":"     .DriverFactory"},{"line_number":48,"context_line":"     ._extension_manager) \u003d dispatch.NameDispatchExtensionManager("},{"line_number":49,"context_line":"                                \u0027ironic.no-such-namespace\u0027,"},{"line_number":50,"context_line":"                                lambda x: True)"},{"line_number":51,"context_line":"    mock_ext_mgr \u003d driver_factory.DriverFactory()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_bfa40e09","line":48,"in_reply_to":"baa201ad_2be62b45","updated":"2014-10-10 07:39:26.000000000","message":"Alternative:\n\n driver_factory.DriverFactory._extension_manager \u003d (\n     dispatch.NameDispatchExtensionManager(...))","commit_id":"0df2ffb8acf5530afeaf7153ca44d57e20ed7d71"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f92d0486beb4999c903e7d1497e8e8be9f201cf0","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    #                    with the real namespace."},{"line_number":46,"context_line":"    (driver_factory"},{"line_number":47,"context_line":"     .DriverFactory"},{"line_number":48,"context_line":"     ._extension_manager) \u003d dispatch.NameDispatchExtensionManager("},{"line_number":49,"context_line":"                                \u0027ironic.no-such-namespace\u0027,"},{"line_number":50,"context_line":"                                lambda x: True)"},{"line_number":51,"context_line":"    mock_ext_mgr \u003d driver_factory.DriverFactory()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_42f18994","line":48,"in_reply_to":"baa201ad_bfa40e09","updated":"2014-10-10 08:52:51.000000000","message":"+1 for alternative","commit_id":"0df2ffb8acf5530afeaf7153ca44d57e20ed7d71"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"52f5373eb111fb45cbafe085e17197af82b6317b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    #                    with the real namespace."},{"line_number":46,"context_line":"    (driver_factory"},{"line_number":47,"context_line":"     .DriverFactory"},{"line_number":48,"context_line":"     ._extension_manager) \u003d dispatch.NameDispatchExtensionManager("},{"line_number":49,"context_line":"                                \u0027ironic.no-such-namespace\u0027,"},{"line_number":50,"context_line":"                                lambda x: True)"},{"line_number":51,"context_line":"    mock_ext_mgr \u003d driver_factory.DriverFactory()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_a68f9ecb","line":48,"in_reply_to":"baa201ad_bfa40e09","updated":"2014-10-10 15:13:48.000000000","message":"Done","commit_id":"0df2ffb8acf5530afeaf7153ca44d57e20ed7d71"}],"ironic/tests/db/sqlalchemy/test_migrations.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f384b1177bdf7f59bf512802b3a036d70c6e8cdc","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        (script_directory"},{"line_number":233,"context_line":"         .from_config()"},{"line_number":234,"context_line":"         .walk_revisions"},{"line_number":235,"context_line":"         .return_value) \u003d self.versions"},{"line_number":236,"context_line":"        self.migration_api.version.return_value \u003d None"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        self._walk_versions(self.engine, self.config)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_6b04b3c6","line":235,"updated":"2014-10-09 22:26:18.000000000","message":"I\u0027m not liking this.","commit_id":"0df2ffb8acf5530afeaf7153ca44d57e20ed7d71"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee90d86c34fd2a31795225081bb75f47c2491705","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        (script_directory"},{"line_number":233,"context_line":"         .from_config()"},{"line_number":234,"context_line":"         .walk_revisions"},{"line_number":235,"context_line":"         .return_value) \u003d self.versions"},{"line_number":236,"context_line":"        self.migration_api.version.return_value \u003d None"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        self._walk_versions(self.engine, self.config)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_9f866a64","line":235,"in_reply_to":"baa201ad_6b04b3c6","updated":"2014-10-10 07:39:26.000000000","message":"agreed, please split like:\n\n something \u003d script_directory.from_config()\n something.walk_revisions.return_value \u003d self.versions","commit_id":"0df2ffb8acf5530afeaf7153ca44d57e20ed7d71"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"52f5373eb111fb45cbafe085e17197af82b6317b","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        (script_directory"},{"line_number":233,"context_line":"         .from_config()"},{"line_number":234,"context_line":"         .walk_revisions"},{"line_number":235,"context_line":"         .return_value) \u003d self.versions"},{"line_number":236,"context_line":"        self.migration_api.version.return_value \u003d None"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        self._walk_versions(self.engine, self.config)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_8680da8c","line":235,"in_reply_to":"baa201ad_9f866a64","updated":"2014-10-10 15:13:48.000000000","message":"Done","commit_id":"0df2ffb8acf5530afeaf7153ca44d57e20ed7d71"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee90d86c34fd2a31795225081bb75f47c2491705","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        (script_directory"},{"line_number":256,"context_line":"         .from_config()"},{"line_number":257,"context_line":"         .walk_revisions"},{"line_number":258,"context_line":"         .return_value) \u003d self.versions"},{"line_number":259,"context_line":"        self.migration_api.version.return_value \u003d None"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        self._walk_versions(self.engine, self.config, downgrade\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_bf7b2e7a","line":258,"updated":"2014-10-10 07:39:26.000000000","message":"ditto","commit_id":"0df2ffb8acf5530afeaf7153ca44d57e20ed7d71"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"52f5373eb111fb45cbafe085e17197af82b6317b","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        (script_directory"},{"line_number":256,"context_line":"         .from_config()"},{"line_number":257,"context_line":"         .walk_revisions"},{"line_number":258,"context_line":"         .return_value) \u003d self.versions"},{"line_number":259,"context_line":"        self.migration_api.version.return_value \u003d None"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        self._walk_versions(self.engine, self.config, downgrade\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_8657fa25","line":258,"in_reply_to":"baa201ad_bf7b2e7a","updated":"2014-10-10 15:13:48.000000000","message":"Done","commit_id":"0df2ffb8acf5530afeaf7153ca44d57e20ed7d71"}],"ironic/tests/db/sqlalchemy/test_types.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f384b1177bdf7f59bf512802b3a036d70c6e8cdc","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        cdr1 \u003d (sa_api"},{"line_number":59,"context_line":"                .model_query(models.Conductor)"},{"line_number":60,"context_line":"                .filter_by(id\u003dcdr1_id)"},{"line_number":61,"context_line":"                .one())"},{"line_number":62,"context_line":"        self.assertEqual([], cdr1.drivers)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        # Create conductor with drivers specified."}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_ab577bc9","line":61,"updated":"2014-10-09 22:26:18.000000000","message":"I find this so hard to read.\n\nWould using a temporary variable help? eg\nx \u003d sa_api.model_query(models.Conductor)\ncdr1 \u003d x.filter_by(...).one()","commit_id":"0df2ffb8acf5530afeaf7153ca44d57e20ed7d71"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee90d86c34fd2a31795225081bb75f47c2491705","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        cdr1 \u003d (sa_api"},{"line_number":59,"context_line":"                .model_query(models.Conductor)"},{"line_number":60,"context_line":"                .filter_by(id\u003dcdr1_id)"},{"line_number":61,"context_line":"                .one())"},{"line_number":62,"context_line":"        self.assertEqual([], cdr1.drivers)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        # Create conductor with drivers specified."}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_ff94d68d","line":61,"in_reply_to":"baa201ad_ab577bc9","updated":"2014-10-10 07:39:26.000000000","message":"I personally am ok with this one, but can be changed as well","commit_id":"0df2ffb8acf5530afeaf7153ca44d57e20ed7d71"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"52f5373eb111fb45cbafe085e17197af82b6317b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        cdr1 \u003d (sa_api"},{"line_number":59,"context_line":"                .model_query(models.Conductor)"},{"line_number":60,"context_line":"                .filter_by(id\u003dcdr1_id)"},{"line_number":61,"context_line":"                .one())"},{"line_number":62,"context_line":"        self.assertEqual([], cdr1.drivers)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        # Create conductor with drivers specified."}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_c1fe4c05","line":61,"in_reply_to":"baa201ad_ab577bc9","updated":"2014-10-10 15:13:48.000000000","message":"Surprising, I find this quite readable. However, I think a temp variable may not work well here since all of these methods affect the SQL that is generated. IMBW, though.","commit_id":"0df2ffb8acf5530afeaf7153ca44d57e20ed7d71"}],"ironic/tests/drivers/test_pxe.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"0abbf91bc57bf4bb82d1295fbc5f5c23a74738a7","unresolved":false,"context_lines":[{"line_number":662,"context_line":"                    key\u003d\u0027fake-56789\u0027)"},{"line_number":663,"context_line":"                # lock elevated w/o exception"},{"line_number":664,"context_line":"                self.assertEqual(1, _cont_deploy_mock.call_count,"},{"line_number":665,"context_line":"                            \"_cont_deploy was not called once.\")"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":""},{"line_number":668,"context_line":"@mock.patch.object(utils, \u0027unlink_without_raise\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_2ebd4e03","line":665,"updated":"2014-10-10 10:30:06.000000000","message":"should this remain _continue_deploy in the message? method name is not changed.","commit_id":"0df2ffb8acf5530afeaf7153ca44d57e20ed7d71"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"52f5373eb111fb45cbafe085e17197af82b6317b","unresolved":false,"context_lines":[{"line_number":662,"context_line":"                    key\u003d\u0027fake-56789\u0027)"},{"line_number":663,"context_line":"                # lock elevated w/o exception"},{"line_number":664,"context_line":"                self.assertEqual(1, _cont_deploy_mock.call_count,"},{"line_number":665,"context_line":"                            \"_cont_deploy was not called once.\")"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":""},{"line_number":668,"context_line":"@mock.patch.object(utils, \u0027unlink_without_raise\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_610f602f","line":665,"in_reply_to":"baa201ad_2ebd4e03","updated":"2014-10-10 15:13:48.000000000","message":"Ah yes, good catch.","commit_id":"0df2ffb8acf5530afeaf7153ca44d57e20ed7d71"}]}