)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"4d651c724b7cf519332098da964310eff7b5aa56","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support ipxe with Dnsmasq"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The workflow of ipxe in ironic now only support ISC dhcpd."},{"line_number":10,"context_line":"the cause is the option \u0027!175,bootfile-name\u0027 is not recognized"},{"line_number":11,"context_line":"by dnsmasq."},{"line_number":12,"context_line":"Add tag:!ipxe instead of !175 can correct this."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a8c0949_35ca9d6e","line":9,"updated":"2014-11-07 11:55:21.000000000","message":"nit: s/support/supports/","commit_id":"42f3d52ebbd06e2fb06bfb0fb9aa713cf93389a3"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"4d651c724b7cf519332098da964310eff7b5aa56","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support ipxe with Dnsmasq"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The workflow of ipxe in ironic now only support ISC dhcpd."},{"line_number":10,"context_line":"the cause is the option \u0027!175,bootfile-name\u0027 is not recognized"},{"line_number":11,"context_line":"by dnsmasq."},{"line_number":12,"context_line":"Add tag:!ipxe instead of !175 can correct this."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a8c0949_55c9e976","line":10,"updated":"2014-11-07 11:55:21.000000000","message":"nit: s/the/The/","commit_id":"42f3d52ebbd06e2fb06bfb0fb9aa713cf93389a3"}],"ironic/common/pxe_utils.py":[{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"4d651c724b7cf519332098da964310eff7b5aa56","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            # !175 \u003d\u003d non-iPXE."},{"line_number":246,"context_line":"            # http://ipxe.org/howto/dhcpd#ipxe-specific_options"},{"line_number":247,"context_line":"            dhcp_opts.append({\u0027opt_name\u0027: \u0027!175,bootfile-name\u0027,"},{"line_number":248,"context_line":"                              \u0027opt_value\u0027: CONF.pxe.pxe_bootfile_name})"},{"line_number":249,"context_line":"        # If the request comes from iPXE, direct it to boot from the"},{"line_number":250,"context_line":"        # iPXE script"},{"line_number":251,"context_line":"        dhcp_opts.append({\u0027opt_name\u0027: \u0027bootfile-name\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8c0949_6e737215","line":248,"updated":"2014-11-07 11:55:21.000000000","message":"The code is fine, but I think this might be better to de-duplicate this code:\n\nif dhcp_provider_name \u003d\u003d \u0027neutron\u0027:\n    prefix \u003d \u0027\u0027\nelse:\n    prefix \u003d \u0027tag:\u0027\ndhcp_opts.append({\u0027opt_name\u0027: prefix + \u0027!175,bootfile-name\u0027,\n                  \u0027opt_value\u0027: CONF.pxe.pxe_bootfile_name})","commit_id":"42f3d52ebbd06e2fb06bfb0fb9aa713cf93389a3"}]}
