)]}'
{"ironic/drivers/modules/agent.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2cdbee7862f1389b04fcf5a5e7fcb944f977bc38","unresolved":false,"context_lines":[{"line_number":526,"context_line":"        version \u003d kwargs.get(\u0027version\u0027)"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"        if version not in self.supported_payload_versions:"},{"line_number":529,"context_line":"            raise exception.InvalidParameterValue(_(\u0027Unknown lookup payload\u0027"},{"line_number":530,"context_line":"                                                    \u0027version: %s\u0027) % version)"},{"line_number":531,"context_line":"        interfaces \u003d self._get_interfaces(kwargs)"},{"line_number":532,"context_line":"        mac_addresses \u003d self._get_mac_addresses(interfaces)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_6642cb3f","line":529,"updated":"2014-11-13 09:57:25.000000000","message":"nit - space is missing between \u0027payload\u0027 and \u0027version\u0027","commit_id":"2d01336464e6af77546dbc1787d6092bb8caa676"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"13a19213430fd0314e426e4d2f7f48ffa17d79b4","unresolved":false,"context_lines":[{"line_number":528,"context_line":"        if version not in self.supported_payload_versions:"},{"line_number":529,"context_line":"            raise exception.InvalidParameterValue(_(\u0027Unknown lookup payload\u0027"},{"line_number":530,"context_line":"                                                    \u0027version: %s\u0027) % version)"},{"line_number":531,"context_line":"        interfaces \u003d self._get_interfaces(kwargs)"},{"line_number":532,"context_line":"        mac_addresses \u003d self._get_mac_addresses(interfaces)"},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"        node \u003d self._find_node_by_macs(context, mac_addresses)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_4b96b84d","line":531,"updated":"2014-11-13 09:42:25.000000000","message":"Was wondering if the idea here would be to expand kwargs, that\u0027s why _get_interfaces was expecting version and inventory as parameters because those are keys in kwargs, e.g:\n\n In [1]: kwargs \u003d {\u0027version\u0027: 1, \u0027inventory\u0027: \u0027test\u0027}\n\n In [2]: def _get_interfaces(version, inventory):\n    ...:     print version, inventory\n    ...:     \n\n In [3]: _get_interfaces(**kwargs)\n 1 test\n\n...\n\nThat said, if version is not used by that function and it\u0027s expecting a known parameter I think we should pass it directly, something like:\n\n interfaces \u003d self._get_interfaces(kwargs[\u0027inventory\u0027])","commit_id":"2d01336464e6af77546dbc1787d6092bb8caa676"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"13a19213430fd0314e426e4d2f7f48ffa17d79b4","unresolved":false,"context_lines":[{"line_number":553,"context_line":"            \u0027node\u0027: node"},{"line_number":554,"context_line":"        }"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"    def _get_interfaces(self, inventory):"},{"line_number":557,"context_line":"        interfaces \u003d []"},{"line_number":558,"context_line":"        try:"},{"line_number":559,"context_line":"            interfaces \u003d inventory[\u0027inventory\u0027][\u0027interfaces\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_2b87ac10","line":556,"updated":"2014-11-13 09:42:25.000000000","message":"This concerns me a bit because no tests was affected with this change, mind adding some tests to this function in this patch?","commit_id":"2d01336464e6af77546dbc1787d6092bb8caa676"}],"ironic/tests/drivers/test_agent.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"aad2ee783c9ce3850b25f9472c6f8e9668a07c89","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                          [fake_port1, fake_port2])"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.agent.AgentVendorInterface\u0027"},{"line_number":323,"context_line":"                \u0027._get_interfaces\u0027)"},{"line_number":324,"context_line":"    def test_get_interfaces(self, interface_mock):"},{"line_number":325,"context_line":"        fake_inventory \u003d {"},{"line_number":326,"context_line":"            \u0027interfaces\u0027: ["}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_773516d9","line":323,"updated":"2014-11-13 11:41:29.000000000","message":"Why do you mock it? Should be OK without mock.","commit_id":"4eeb14fe2e0e0e379edf0ad6a48b4002d329c53b"}]}