)]}'
{"ironic/__init__.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"643cf02a21049534e13d81067422e70d2750f079","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def _register_opts():"},{"line_number":30,"context_line":"    for g, o in opts._opt_lists:"},{"line_number":31,"context_line":"        CONF.register_opts(o, group\u003dg)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_109d1467","line":30,"updated":"2014-11-27 09:43:33.000000000","message":"optional: should we rename _opt_lists -\u003e opt_lists to make it public?","commit_id":"0ea19f434035fe8efd2638e87f3464c9c0a21fb2"}],"ironic/drivers/modules/snmp.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"643cf02a21049534e13d81067422e70d2750f079","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"CONF \u003d cfg.CONF"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"SNMP_V1 \u003d \u00271\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_906bc4f0","line":58,"updated":"2014-11-27 09:43:33.000000000","message":"Just a question, because there is a few similar cases. \n\nThis CONF variable used only once - in line 260. What is the sense to make it global for module?","commit_id":"0ea19f434035fe8efd2638e87f3464c9c0a21fb2"}],"ironic/opts.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"643cf02a21049534e13d81067422e70d2750f079","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from ironic.drivers.modules import pxe_opts"},{"line_number":30,"context_line":"from ironic.drivers.modules import seamicro_opts"},{"line_number":31,"context_line":"from ironic.drivers.modules import snmp_opts"},{"line_number":32,"context_line":"from ironic.drivers.modules import ssh_libvirt_opts"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def _get_my_ip():"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_e4128908","line":32,"updated":"2014-11-27 09:43:33.000000000","message":"please correct me, if I\u0027m wrong - if someone will add a new driver, he should declare all options into *_opts module and import it here?\n\nIf \u0027yes\u0027 - should this be documented somewhere? Or maybe there is a sense to load all ``*_opts`` from here without specifying them manually?","commit_id":"0ea19f434035fe8efd2638e87f3464c9c0a21fb2"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"643cf02a21049534e13d81067422e70d2750f079","unresolved":false,"context_lines":[{"line_number":372,"context_line":"]"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"def list_all_opts():"},{"line_number":376,"context_line":"    \"\"\"Return a list of oslo.config options available in Ironic."},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    Each element of the list is a tuple. The first element is the name of the"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_701bb880","line":375,"updated":"2014-11-27 09:43:33.000000000","message":"nit: in different openstack project and libraries this function called list_opts(), so I suggest to rename this as well","commit_id":"0ea19f434035fe8efd2638e87f3464c9c0a21fb2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"452f66cca5715e2789c4ca6bd89f07a80dbf0cf3","unresolved":false,"context_lines":[{"line_number":414,"context_line":"                           agent_opts._agent_client_opts])),"},{"line_number":415,"context_line":"    (\u0027ilo\u0027, _build_list([ilo_opts._ilo_opts,"},{"line_number":416,"context_line":"                         ilo_opts._ilo_power_opts])),"},{"line_number":417,"context_line":"]"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"def list_all_opts():"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_07c5005b","line":417,"updated":"2014-12-04 17:47:41.000000000","message":"I took a look at Lucas\u0027 version [1]. If we can\u0027t have some script that is smart enough to sniff through all the files and pull the configs out, then what about a mix of these two versions. This is because I like leaving the options in their respective files; it makes it easier to refer to them etc. Moving the options to this file or to separate *opt.py files (for files in drivers/modules/...) means there are two ways to add options which I also don\u0027t like.\n\nWhat do you think about adding some sort of get_options_info() to each of the files that have options, and here, making calls to all those get_options_info() methods. It would help, too, with getting the group names correct.\n\nEither way, people are going to have to remember to update this file when options for a new group are added (or moved to different files).\n\n\n[1] https://review.openstack.org/#/c/128005/","commit_id":"27ce62584d42d2d5af1af00f0c5665f4fcfb977d"}],"tox.ini":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eb1d19e94362f4007a670c3ae0d6ffe2892019fd","unresolved":false,"context_lines":[{"line_number":28,"context_line":"commands \u003d"},{"line_number":29,"context_line":"  python setup.py testr --coverage {posargs}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[testenv:genconfig]"},{"line_number":32,"context_line":"sitepackages \u003d False"},{"line_number":33,"context_line":"envdir \u003d {toxworkdir}/venv"},{"line_number":34,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":5,"id":"5a890539_71ea0710","line":31,"updated":"2014-12-04 17:05:02.000000000","message":"There\u0027s nothing in the commit that says that checkconfig is gone. It would be nice to still have this. Can\u0027t we just modify the check_uptodate.sh script (or add a different script) to do the check?","commit_id":"27ce62584d42d2d5af1af00f0c5665f4fcfb977d"}]}