)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8243e2dfafbaf8706cb94bc558b2bc2b06517149","unresolved":false,"context_lines":[{"line_number":10,"context_line":"ipminative defines \u0027net\u0027 as the name, so it does not match with pyghmi"},{"line_number":11,"context_line":"return value."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"In this patch, we redefine boot_devices.PXE value to \u0027net\u0027 which match"},{"line_number":14,"context_line":"pyghmi."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ic19597d2e577098a08e5ca2c5c6f0660200fc1cb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a890539_5f9dd158","line":13,"updated":"2014-11-28 08:46:40.000000000","message":"I think you mean \u0027network\u0027 instead of \u0027net\u0027","commit_id":"01ff281c2c1f8fe22cd14b70f4029b441afe0eab"}],"ironic/drivers/modules/ipminative.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8243e2dfafbaf8706cb94bc558b2bc2b06517149","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"_BOOT_DEVICES_MAP \u003d {"},{"line_number":73,"context_line":"    boot_devices.DISK: \u0027hd\u0027,"},{"line_number":74,"context_line":"    boot_devices.PXE: \u0027network\u0027,"},{"line_number":75,"context_line":"    boot_devices.CDROM: \u0027cdrom\u0027,"},{"line_number":76,"context_line":"    boot_devices.BIOS: \u0027setup\u0027,"},{"line_number":77,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_9f3ad932","line":74,"updated":"2014-11-28 08:46:40.000000000","message":"pyghmi is complicated since it define \u0027net\u0027, \u0027network\u0027 and \u0027pxe\u0027, I was wondering whether we should use the numerical value for this see[1]\n\n [1] https://github.com/stackforge/pyghmi/blob/master/pyghmi/ipmi/command.py#L25-L27","commit_id":"01ff281c2c1f8fe22cd14b70f4029b441afe0eab"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"71d2d56b80ecde0b453624a24b5d9fbc85e917ea","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"_BOOT_DEVICES_MAP \u003d {"},{"line_number":73,"context_line":"    boot_devices.DISK: \u0027hd\u0027,"},{"line_number":74,"context_line":"    boot_devices.PXE: \u0027network\u0027,"},{"line_number":75,"context_line":"    boot_devices.CDROM: \u0027cdrom\u0027,"},{"line_number":76,"context_line":"    boot_devices.BIOS: \u0027setup\u0027,"},{"line_number":77,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_1fc0a9df","line":74,"in_reply_to":"5a890539_9f3ad932","updated":"2014-11-28 08:55:06.000000000","message":"Yes, Lucas, I have checked these lins, pyghmi define mult-values for the input value when set device name, but for return value, it just parse the code 1 and map to \u0027network\u0027 as return value.","commit_id":"01ff281c2c1f8fe22cd14b70f4029b441afe0eab"}],"ironic/tests/drivers/test_ipminative.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6c54ea878aa715000eebb6679a3e8e44ffb1f9cc","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        with task_manager.acquire(self.context,"},{"line_number":299,"context_line":"                                  self.node.uuid) as task:"},{"line_number":300,"context_line":"            self.driver.management.set_boot_device(task, boot_devices.PXE)"},{"line_number":301,"context_line":"        # PXE is converted to \u0027net\u0027 internally by ipminative"},{"line_number":302,"context_line":"        ipmicmd.set_bootdev.assert_called_once_with(\u0027network\u0027, persist\u003dFalse)"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def test_set_boot_device_bad_device(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_30dc8b18","line":301,"updated":"2014-12-01 15:53:48.000000000","message":"don\u0027t know if we want to delete this comment or update it?","commit_id":"46d8ca6c6e0a093d0a3e0eca932116f77ddb7c17"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"bb98f9864c93f5cc96fe00108bd3fe856b32428c","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        with task_manager.acquire(self.context,"},{"line_number":299,"context_line":"                                  self.node.uuid) as task:"},{"line_number":300,"context_line":"            self.driver.management.set_boot_device(task, boot_devices.PXE)"},{"line_number":301,"context_line":"        # PXE is converted to \u0027net\u0027 internally by ipminative"},{"line_number":302,"context_line":"        ipmicmd.set_bootdev.assert_called_once_with(\u0027network\u0027, persist\u003dFalse)"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def test_set_boot_device_bad_device(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_d717ab52","line":301,"in_reply_to":"5a890539_30dc8b18","updated":"2014-12-02 02:19:32.000000000","message":"good catch, will fix.","commit_id":"46d8ca6c6e0a093d0a3e0eca932116f77ddb7c17"}]}