)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e539dc825701572baa6cf3552c42f22e48523621","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vladyslav Drok \u003cvdrok@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-12-05 13:57:28 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove \u0027glance://\u0027 prefix strip from image hrefs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"pxe_utils.get_deploy_kr_info and drivers.modules.pxe._get_image_info"},{"line_number":10,"context_line":"functions strip \u0027glance://\u0027 prefix from image references while it\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_367cbc20","line":7,"updated":"2014-12-08 16:35:09.000000000","message":"nit: \"Do not strip \u0027glance://\u0027 prefix from image hrefs\"","commit_id":"d312feee616a23ac0becee926d34b123133e07cd"}],"ironic/common/pxe_utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3c8020eaeeeaa3dbef05bf0563350fe8d09ef58d","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"def get_deploy_kr_info(node_uuid, driver_info):"},{"line_number":141,"context_line":"    \"\"\"Get uuid and tftp path for deploy kernel and ramdisk."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    Note: driver_info should be validated outside of this method."},{"line_number":144,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_4b48ba2d","line":141,"updated":"2014-12-08 22:27:13.000000000","message":"so this won\u0027t be true any more, because you aren\u0027t getting the \u0027uuid\u0027?","commit_id":"d312feee616a23ac0becee926d34b123133e07cd"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3c8020eaeeeaa3dbef05bf0563350fe8d09ef58d","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    :param ctx: context"},{"line_number":426,"context_line":"    :param cache: ImageCache instance to use for fetching"},{"line_number":427,"context_line":"    :param images_info: list of tuples (image uuid, destination path)"},{"line_number":428,"context_line":"    :param force_raw: boolean value, whether to convert the image to raw"},{"line_number":429,"context_line":"                      format"},{"line_number":430,"context_line":"    :raises: InstanceDeployFailure if unable to find enough disk space"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_c1872960","line":427,"updated":"2014-12-08 22:27:13.000000000","message":"not image uuid any more?","commit_id":"d312feee616a23ac0becee926d34b123133e07cd"}],"ironic/drivers/modules/image_cache.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"b3271e8130209031d2606d8e9cb0f78eea3492fc","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        # TODO(ghe): timeout and retry for downloads"},{"line_number":149,"context_line":"        # TODO(ghe): logging when image cannot be created"},{"line_number":150,"context_line":"        tmp_dir \u003d tempfile.mkdtemp(dir\u003dself.master_dir)"},{"line_number":151,"context_line":"        tmp_path \u003d os.path.join(tmp_dir, os.path.split(master_path)[1])"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        try:"},{"line_number":154,"context_line":"            _fetch(ctx, href, tmp_path, self._image_service, force_raw)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_a0e957b9","line":151,"updated":"2014-12-05 11:43:47.000000000","message":"Did you mean os.path.split(href) ?\n\nI would like to see it os.path.split(href)[-1] to confirm it works with both href and uuid.","commit_id":"a3b00fb2696003d3b3c76d3c66de1e2126e80f1d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"123ee0a28970fb899d9f4a07f5b1d37ac11a9b25","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        # TODO(ghe): timeout and retry for downloads"},{"line_number":149,"context_line":"        # TODO(ghe): logging when image cannot be created"},{"line_number":150,"context_line":"        tmp_dir \u003d tempfile.mkdtemp(dir\u003dself.master_dir)"},{"line_number":151,"context_line":"        tmp_path \u003d os.path.join(tmp_dir, os.path.split(master_path)[1])"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        try:"},{"line_number":154,"context_line":"            _fetch(ctx, href, tmp_path, self._image_service, force_raw)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_60c92f25","line":151,"in_reply_to":"5a890539_a0e957b9","updated":"2014-12-05 11:50:17.000000000","message":"These are actually the same - master_path is constructed on line 102 and on line 101 service_utils.parse_image_ref(href)[0] is actually doing the same as os.path.split(href)[-1] given the \u0027glance://uuid\u0027 format.\n\nBut I don\u0027t have strong preference so can change that if you want.","commit_id":"a3b00fb2696003d3b3c76d3c66de1e2126e80f1d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e539dc825701572baa6cf3552c42f22e48523621","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        # TODO(ghe): timeout and retry for downloads"},{"line_number":149,"context_line":"        # TODO(ghe): logging when image cannot be created"},{"line_number":150,"context_line":"        tmp_dir \u003d tempfile.mkdtemp(dir\u003dself.master_dir)"},{"line_number":151,"context_line":"        tmp_path \u003d os.path.join(tmp_dir, os.path.split(href)[1])"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        try:"},{"line_number":154,"context_line":"            _fetch(ctx, href, tmp_path, self._image_service, force_raw)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_36a3dc9f","line":151,"updated":"2014-12-08 16:35:09.000000000","message":"s/1/-1/ ?","commit_id":"d312feee616a23ac0becee926d34b123133e07cd"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"70c1cdb3abad6615fffc5723c0e1ee628315266f","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        # TODO(ghe): timeout and retry for downloads"},{"line_number":149,"context_line":"        # TODO(ghe): logging when image cannot be created"},{"line_number":150,"context_line":"        tmp_dir \u003d tempfile.mkdtemp(dir\u003dself.master_dir)"},{"line_number":151,"context_line":"        tmp_path \u003d os.path.join(tmp_dir, os.path.split(href)[1])"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        try:"},{"line_number":154,"context_line":"            _fetch(ctx, href, tmp_path, self._image_service, force_raw)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_f6d154ce","line":151,"in_reply_to":"3a961159_36a3dc9f","updated":"2014-12-08 16:38:45.000000000","message":"os.path.split always returns a tuple. Though may be changed to href.split(\u0027/\u0027)[-1] , is it more appropriate?","commit_id":"d312feee616a23ac0becee926d34b123133e07cd"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"e966d577b646e81ede9574613d355b785355fd63","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        # TODO(ghe): timeout and retry for downloads"},{"line_number":149,"context_line":"        # TODO(ghe): logging when image cannot be created"},{"line_number":150,"context_line":"        tmp_dir \u003d tempfile.mkdtemp(dir\u003dself.master_dir)"},{"line_number":151,"context_line":"        tmp_path \u003d os.path.join(tmp_dir, os.path.split(href)[1])"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        try:"},{"line_number":154,"context_line":"            _fetch(ctx, href, tmp_path, self._image_service, force_raw)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_39266f17","line":151,"in_reply_to":"3a961159_f6d154ce","updated":"2014-12-08 16:54:10.000000000","message":"I had same concern. But when I tested, I found os.path.split always returns  2 items \n\nEven when we pass os.path.split(\"uuid\"), it return [ \u0027\u0027, \u0027uuid\u0027 ] \n\n:)","commit_id":"d312feee616a23ac0becee926d34b123133e07cd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3b9f7ea5b17c56dace76fa26e4f14fc6ba981dec","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        # TODO(ghe): timeout and retry for downloads"},{"line_number":149,"context_line":"        # TODO(ghe): logging when image cannot be created"},{"line_number":150,"context_line":"        tmp_dir \u003d tempfile.mkdtemp(dir\u003dself.master_dir)"},{"line_number":151,"context_line":"        tmp_path \u003d os.path.join(tmp_dir, href.split(\u0027/\u0027)[-1])"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        try:"},{"line_number":154,"context_line":"            _fetch(ctx, href, tmp_path, self._image_service, force_raw)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_0961eca8","line":151,"updated":"2014-12-11 14:35:57.000000000","message":"This assumes that the uuid (or some unique identifier?) will always be the last part of an href. Which is a reasonable assumption I think, but I wonder where we can document that.","commit_id":"f629203721f31731881f6604967dfa6185a5f1f2"}]}