)]}'
{"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c3c1ce132a0a47c2924ff23dda898b3fd6c1ae75","unresolved":false,"context_lines":[{"line_number":167,"context_line":"def block_uuid(dev):"},{"line_number":168,"context_line":"    \"\"\"Get UUID of a block device.\"\"\""},{"line_number":169,"context_line":"    out, _err \u003d utils.execute(\u0027blkid\u0027, \u0027-s\u0027, \u0027UUID\u0027, \u0027-o\u0027, \u0027value\u0027, dev,"},{"line_number":170,"context_line":"                              run_as_root\u003dTrue,"},{"line_number":171,"context_line":"                              check_exit_code\u003d[0])"},{"line_number":172,"context_line":"    return out.strip()"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3a961159_dc0dfd41","line":170,"updated":"2015-01-14 14:02:15.000000000","message":"I think this function should log a real error and raise. Otherwise it\u0027s going to be hard to debug anyway. Also, do you have any ideas, why it doesn\u0027t raise? blkid fails but returns correct exit status?","commit_id":"cf3a04c11ebfaee8e077b6b3a301256fe67e6b38"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7419fca8071715233a7ca782a07fd3ae521e3cef","unresolved":false,"context_lines":[{"line_number":167,"context_line":"def block_uuid(dev):"},{"line_number":168,"context_line":"    \"\"\"Get UUID of a block device.\"\"\""},{"line_number":169,"context_line":"    out, _err \u003d utils.execute(\u0027blkid\u0027, \u0027-s\u0027, \u0027UUID\u0027, \u0027-o\u0027, \u0027value\u0027, dev,"},{"line_number":170,"context_line":"                              run_as_root\u003dTrue,"},{"line_number":171,"context_line":"                              check_exit_code\u003d[0])"},{"line_number":172,"context_line":"    return out.strip()"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"fa81d914_7797de90","line":170,"in_reply_to":"3a961159_47d37f5e","updated":"2015-01-29 13:05:41.000000000","message":"It seems that blkid doesn\u0027t actually fail to run the command, it executed and all but couldn\u0027t find the filesystem UUID.","commit_id":"cf3a04c11ebfaee8e077b6b3a301256fe67e6b38"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"88a5a07fde7f4ee30df24d442de9be0c151dc8d6","unresolved":false,"context_lines":[{"line_number":167,"context_line":"def block_uuid(dev):"},{"line_number":168,"context_line":"    \"\"\"Get UUID of a block device.\"\"\""},{"line_number":169,"context_line":"    out, _err \u003d utils.execute(\u0027blkid\u0027, \u0027-s\u0027, \u0027UUID\u0027, \u0027-o\u0027, \u0027value\u0027, dev,"},{"line_number":170,"context_line":"                              run_as_root\u003dTrue,"},{"line_number":171,"context_line":"                              check_exit_code\u003d[0])"},{"line_number":172,"context_line":"    return out.strip()"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3a961159_47d37f5e","line":170,"in_reply_to":"3a961159_dc0dfd41","updated":"2015-01-19 02:33:45.000000000","message":"I checked this \u0027blkid\u0027 command, it return normal code 0 and get empty uuid, not sure what happens.\n\nYes, we can raise the exception here in case the empty block uuid returning.","commit_id":"cf3a04c11ebfaee8e077b6b3a301256fe67e6b38"}],"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4f8ec0ada8860c7cd268ade18ff72ff57ec41040","unresolved":false,"context_lines":[{"line_number":522,"context_line":"        root_uuid \u003d iscsi_deploy.continue_deploy(task, **kwargs)"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"        if not root_uuid:"},{"line_number":525,"context_line":"            return"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"        try:"},{"line_number":528,"context_line":"            boot_iso \u003d _get_boot_iso(task, root_uuid)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a961159_89dfc3d5","side":"PARENT","line":525,"updated":"2015-01-05 11:38:52.000000000","message":"Can we add a test for the iLO driver as well?\n\nhttps://github.com/openstack/ironic/blob/master/ironic/tests/drivers/ilo/test_deploy.py#L322-L386","commit_id":"d74a5cd00c840c9c11f5ad3bd57cde64e64d18aa"}],"ironic/drivers/modules/iscsi_deploy.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"27aaa801f41468bc01ad5b998411ddd0fd4fc825","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    except Exception as e:"},{"line_number":317,"context_line":"        msg \u003d (_(\u0027Failed to continue iSCSI deployment. \u0027"},{"line_number":318,"context_line":"                 \u0027Error: %(error)s\u0027) %"},{"line_number":319,"context_line":"                  {\u0027instance\u0027: node.instance_uuid, \u0027error\u0027: e})"},{"line_number":320,"context_line":"        _fail_deploy(task, msg)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    root_uuid_or_disk_id \u003d uuid_dict_returned.get("}],"source_content_type":"text/x-python","patch_set":19,"id":"9a80dd14_28bcf0ba","line":319,"updated":"2015-03-19 11:21:13.000000000","message":"\u0027instance\u0027 is not used here","commit_id":"49af375ed17cd25331f89177b8ba6a6ac2e5644c"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"70f13b2b7f9b9485a7a377ad0bf72a50600eac70","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    except Exception as e:"},{"line_number":317,"context_line":"        msg \u003d (_(\u0027Failed to continue iSCSI deployment. \u0027"},{"line_number":318,"context_line":"                 \u0027Error: %(error)s\u0027) %"},{"line_number":319,"context_line":"                  {\u0027instance\u0027: node.instance_uuid, \u0027error\u0027: e})"},{"line_number":320,"context_line":"        _fail_deploy(task, msg)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    root_uuid_or_disk_id \u003d uuid_dict_returned.get("}],"source_content_type":"text/x-python","patch_set":19,"id":"9a80dd14_2b0b0ad7","line":319,"in_reply_to":"9a80dd14_28bcf0ba","updated":"2015-03-19 11:37:22.000000000","message":"Done","commit_id":"49af375ed17cd25331f89177b8ba6a6ac2e5644c"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"5d97ba8d66103566efcb98e6275a4380c9d0d46b","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        else:"},{"line_number":315,"context_line":"            uuid_dict_returned \u003d deploy_utils.deploy_partition_image(**params)"},{"line_number":316,"context_line":"    except Exception as e:"},{"line_number":317,"context_line":"        msg \u003d (_(\u0027Failed to continue iSCSI deployment on node %(node)s. \u0027"},{"line_number":318,"context_line":"                 \u0027Error: %(error)s\u0027) %"},{"line_number":319,"context_line":"                  {\u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":320,"context_line":"        _fail_deploy(task, msg)"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a80dd14_46471a1d","line":317,"updated":"2015-03-20 13:43:22.000000000","message":"This change to a translated string, while it is more informative, is being proposed after feature / string freeze, which is not acceptable (unless by exception). I don\u0027t think this change is necessary.","commit_id":"26c33c2aad5527f71431b669266ebfb7952bc9a0"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"945173f6c9b9a5f1c627eabf404babb921d8a0be","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        else:"},{"line_number":315,"context_line":"            uuid_dict_returned \u003d deploy_utils.deploy_partition_image(**params)"},{"line_number":316,"context_line":"    except Exception as e:"},{"line_number":317,"context_line":"        msg \u003d (_(\u0027Failed to continue iSCSI deployment on node %(node)s. \u0027"},{"line_number":318,"context_line":"                 \u0027Error: %(error)s\u0027) %"},{"line_number":319,"context_line":"                  {\u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":320,"context_line":"        _fail_deploy(task, msg)"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a80dd14_c6306aa0","line":317,"in_reply_to":"9a80dd14_46471a1d","updated":"2015-03-20 13:44:54.000000000","message":"Done","commit_id":"26c33c2aad5527f71431b669266ebfb7952bc9a0"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"5d97ba8d66103566efcb98e6275a4380c9d0d46b","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    root_uuid_or_disk_id \u003d uuid_dict_returned.get("},{"line_number":323,"context_line":"        \u0027root uuid\u0027, uuid_dict_returned.get(\u0027disk identifier\u0027))"},{"line_number":324,"context_line":"    if not root_uuid_or_disk_id:"},{"line_number":325,"context_line":"        msg \u003d (_(\"Couldn\u0027t determine the UUID of the root \""},{"line_number":326,"context_line":"                 \"partition or the disk identifier after deploying \""},{"line_number":327,"context_line":"                 \"node %s\") % node.uuid)"},{"line_number":328,"context_line":"        _fail_deploy(task, msg)"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a80dd14_66525edf","line":325,"updated":"2015-03-20 13:43:22.000000000","message":"on the other hand, this isn\u0027t a string change -- it\u0027s just moving the string about 50 lines. So this is fine.","commit_id":"26c33c2aad5527f71431b669266ebfb7952bc9a0"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"945173f6c9b9a5f1c627eabf404babb921d8a0be","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    root_uuid_or_disk_id \u003d uuid_dict_returned.get("},{"line_number":323,"context_line":"        \u0027root uuid\u0027, uuid_dict_returned.get(\u0027disk identifier\u0027))"},{"line_number":324,"context_line":"    if not root_uuid_or_disk_id:"},{"line_number":325,"context_line":"        msg \u003d (_(\"Couldn\u0027t determine the UUID of the root \""},{"line_number":326,"context_line":"                 \"partition or the disk identifier after deploying \""},{"line_number":327,"context_line":"                 \"node %s\") % node.uuid)"},{"line_number":328,"context_line":"        _fail_deploy(task, msg)"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a80dd14_e623ae55","line":325,"in_reply_to":"9a80dd14_66525edf","updated":"2015-03-20 13:44:54.000000000","message":"Done","commit_id":"26c33c2aad5527f71431b669266ebfb7952bc9a0"}],"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"cd105599527704d6778730325f8cd7fb43a41508","unresolved":false,"context_lines":[{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        if not root_uuid:"},{"line_number":471,"context_line":"            msg \u003d _(\u0027Failed to get root_uuid.\u0027)"},{"line_number":472,"context_line":"            LOG.error(_LE(\u0027Deploy failed for node %(nodes. \u0027"},{"line_number":473,"context_line":"                          \u0027Error: %(error)s\u0027),"},{"line_number":474,"context_line":"                      {\u0027instance\u0027: node.uuid, \u0027error\u0027: msg})"},{"line_number":475,"context_line":"            deploy_utils.set_failed_state(task, msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_a11de412","line":472,"updated":"2014-12-25 10:49:05.000000000","message":"Looks like \u0027)\u0027 missing.","commit_id":"5f90ca51be5a075fbd0ff66977c1deda69bc51b3"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"cd105599527704d6778730325f8cd7fb43a41508","unresolved":false,"context_lines":[{"line_number":471,"context_line":"            msg \u003d _(\u0027Failed to get root_uuid.\u0027)"},{"line_number":472,"context_line":"            LOG.error(_LE(\u0027Deploy failed for node %(nodes. \u0027"},{"line_number":473,"context_line":"                          \u0027Error: %(error)s\u0027),"},{"line_number":474,"context_line":"                      {\u0027instance\u0027: node.uuid, \u0027error\u0027: msg})"},{"line_number":475,"context_line":"            deploy_utils.set_failed_state(task, msg)"},{"line_number":476,"context_line":"            return"},{"line_number":477,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_6124dc60","line":474,"updated":"2014-12-25 10:49:05.000000000","message":"Mapping for \u0027instance\u0027 does not present in string.","commit_id":"5f90ca51be5a075fbd0ff66977c1deda69bc51b3"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8e6525241e40f2c631a1999e046afb35cea3928d","unresolved":false,"context_lines":[{"line_number":468,"context_line":"        root_uuid \u003d iscsi_deploy.continue_deploy(task, **kwargs)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        if not root_uuid:"},{"line_number":471,"context_line":"            msg \u003d _(\u0027Failed to get root_uuid.\u0027)"},{"line_number":472,"context_line":"            LOG.error(_LE(\u0027Deploy failed for node %(node)s. \u0027"},{"line_number":473,"context_line":"                          \u0027Error: %(error)s\u0027),"},{"line_number":474,"context_line":"                      {\u0027node\u0027: node.uuid, \u0027error\u0027: msg})"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a961159_f1e3e5a1","line":471,"updated":"2015-01-02 12:15:16.000000000","message":"When operators see this message on the logs I don\u0027t know if that will actually help them debugging the problem, \u0027root_uuid\u0027 is a local variable in this method scope and doesn\u0027t mean much outside it. Perhaps if we say something more explicit would be better, what about:\n\n\u0027Ironic couldn\u0027t determine the UUID of the image root filesystem to boot from.\u0027","commit_id":"b79b943d441c30dca38083a7579db3c8adcb6410"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"0a5ec3d9010151e406e7ccff7cab66dcc5dfaa72","unresolved":false,"context_lines":[{"line_number":530,"context_line":""},{"line_number":531,"context_line":"        root_uuid \u003d iscsi_deploy.continue_deploy(task, **kwargs)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        if not root_uuid:"},{"line_number":534,"context_line":"            return"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"        # save the node\u0027s root disk UUID so that another conductor could"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_27646de4","side":"PARENT","line":533,"updated":"2015-03-05 13:46:34.000000000","message":"Removing this piece of code is not correct right now as iscsi_deploy.continue_deploy can return still without a root_uuid in cases of error:\n\nhttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/iscsi_deploy.py#L269-L274\nhttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/iscsi_deploy.py#L282-L287\n\nEither we need to rethrow the exception back at these 2 above places or still keep this piece of code. I would prefer the former.","commit_id":"947edccabe526c7ad11f8006cdb3a54af7edbe14"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"893fec3127c5018c5fd9c6c310dc58d2d879f382","unresolved":false,"context_lines":[{"line_number":530,"context_line":""},{"line_number":531,"context_line":"        root_uuid \u003d iscsi_deploy.continue_deploy(task, **kwargs)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        if not root_uuid:"},{"line_number":534,"context_line":"            return"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"        # save the node\u0027s root disk UUID so that another conductor could"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_b1bdd26a","side":"PARENT","line":533,"in_reply_to":"9a80dd14_27646de4","updated":"2015-03-06 03:21:03.000000000","message":"Hi Ramakrishnan,\n\nThanks for your comments.\n\nI understand we add code logic into deploy_utils.work_on_disk() call as below, if can not get root_uuid, will raise InstanceDeployFailure exception:\n\n\n if not root_uuid:\t\n        raise exception.InstanceDeployFailure(\t\n            _(\"Can not get root device UUID\"))\n\n\nThis InstanceDeployFailure exception will be catched by continue_deploy() method in https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/iscsi_deploy.py#L282\n\nSo not sure if I understand your case, I think it can be handled by current patch, and will raise exception if root_uuid is empty.","commit_id":"947edccabe526c7ad11f8006cdb3a54af7edbe14"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"6b12136c85c8fd9f86cba0df4d66bdd5cd7faee5","unresolved":false,"context_lines":[{"line_number":530,"context_line":""},{"line_number":531,"context_line":"        root_uuid \u003d iscsi_deploy.continue_deploy(task, **kwargs)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        if not root_uuid:"},{"line_number":534,"context_line":"            return"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"        # save the node\u0027s root disk UUID so that another conductor could"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_f283c801","side":"PARENT","line":533,"in_reply_to":"9a80dd14_8ca9957d","updated":"2015-03-06 05:17:12.000000000","message":"Hi Ramesh,\n\nThanks for your comments, got your point, we should reraise the exception from continue_deploy() method call, and I will check more unittest issue and commit new patch to cover your comments, welcome your comments:)","commit_id":"947edccabe526c7ad11f8006cdb3a54af7edbe14"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"8e0e8f9c7f5456a99490d00bfa755fb4c1d43324","unresolved":false,"context_lines":[{"line_number":530,"context_line":""},{"line_number":531,"context_line":"        root_uuid \u003d iscsi_deploy.continue_deploy(task, **kwargs)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        if not root_uuid:"},{"line_number":534,"context_line":"            return"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"        # save the node\u0027s root disk UUID so that another conductor could"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_8ca9957d","side":"PARENT","line":533,"in_reply_to":"9a80dd14_b1bdd26a","updated":"2015-03-06 03:50:29.000000000","message":"Yeah that exactly was my point.  The InstanceDeployFailure exception will be catched by continue_deploy() in the place pointed by you but is not rethrown back.  In error case when we cannot find root_uuid, this causes the execution to return back to this method (because exception caught was not rethrown back) and continue downwards to rest of the code.  Same with the other place that I pointed out.","commit_id":"947edccabe526c7ad11f8006cdb3a54af7edbe14"}],"ironic/tests/drivers/test_pxe.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b389789a442595c8d915c73a225caf3be7c1536c","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        mock_image_cache.assert_called_once_with()"},{"line_number":643,"context_line":"        mock_image_cache.return_value.clean_up.assert_called_once_with()"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    @mock.patch.object(deploy_utils, \u0027notify_deploy_complete\u0027)"},{"line_number":646,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027InstanceImageCache\u0027)"},{"line_number":647,"context_line":"    def test_continue_deploy_root_uuid_fails(self, mock_image_cache,"},{"line_number":648,"context_line":"                                             notify_mock):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_12751afa","line":645,"updated":"2014-12-26 12:34:46.000000000","message":"Seems that you don\u0027t need any of these mocks - they are not called in tested code path.","commit_id":"de216d54f317ea8b3e95e54610d35ad013f06777"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b389789a442595c8d915c73a225caf3be7c1536c","unresolved":false,"context_lines":[{"line_number":654,"context_line":"            return None"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":657,"context_line":"                \u0027ironic.drivers.modules.deploy_utils.deploy\u0027,"},{"line_number":658,"context_line":"                fake_deploy))"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_7263be41","line":657,"updated":"2014-12-26 12:34:46.000000000","message":"While this one is needed, and it\u0027s better to rewrite it as mock with return_value\u003dNone","commit_id":"de216d54f317ea8b3e95e54610d35ad013f06777"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"028343d6efcd2f16bc04be826125d14f3adaacba","unresolved":false,"context_lines":[{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027InstanceImageCache\u0027)"},{"line_number":646,"context_line":"    @mock.patch.object(deploy_utils, \u0027deploy\u0027)"},{"line_number":647,"context_line":"    def test_continue_deploy_root_uuid_fails(self, mock_deploy, mock_image_cache):"},{"line_number":648,"context_line":"        self.node.power_state \u003d states.POWER_ON"},{"line_number":649,"context_line":"        self.node.provision_state \u003d states.DEPLOYWAIT"},{"line_number":650,"context_line":"        self.node.save()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_7653a4e2","line":647,"updated":"2014-12-29 04:20:15.000000000","message":"nit: s/test_continue/test__continue/","commit_id":"8e994294952adc4d0fb4873437701a3590d09a67"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"4bbb08be7e2c42d4e5d874980e510daf1cec16b5","unresolved":false,"context_lines":[{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027InstanceImageCache\u0027)"},{"line_number":646,"context_line":"    @mock.patch.object(deploy_utils, \u0027deploy\u0027)"},{"line_number":647,"context_line":"    def test_continue_deploy_root_uuid_fails(self, mock_deploy, mock_image_cache):"},{"line_number":648,"context_line":"        self.node.power_state \u003d states.POWER_ON"},{"line_number":649,"context_line":"        self.node.provision_state \u003d states.DEPLOYWAIT"},{"line_number":650,"context_line":"        self.node.save()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_968e50cf","line":647,"in_reply_to":"3a961159_7653a4e2","updated":"2014-12-29 05:20:05.000000000","message":"+1\n\nmake sense.","commit_id":"8e994294952adc4d0fb4873437701a3590d09a67"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c0f1d3b9f0a35dce0213375da8a76bb8fa7a8f3d","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        mock_image_cache.assert_called_once_with()"},{"line_number":643,"context_line":"        mock_image_cache.return_value.clean_up.assert_called_once_with()"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027InstanceImageCache\u0027)"},{"line_number":646,"context_line":"    @mock.patch.object(deploy_utils, \u0027deploy\u0027)"},{"line_number":647,"context_line":"    def test__continue_deploy_root_uuid_fails(self, mock_deploy, mock_image_cache):"},{"line_number":648,"context_line":"        self.node.power_state \u003d states.POWER_ON"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_a5c31056","line":645,"updated":"2014-12-29 11:31:18.000000000","message":"This mock is from test_continue_deploy_ramdisk_fails, please move it back.","commit_id":"040d52bd454befd238020e1bccf6209d84081683"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"f9b09f0a815d9017321777124d46b595c1079d55","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        mock_image_cache.assert_called_once_with()"},{"line_number":643,"context_line":"        mock_image_cache.return_value.clean_up.assert_called_once_with()"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027InstanceImageCache\u0027)"},{"line_number":646,"context_line":"    @mock.patch.object(deploy_utils, \u0027deploy\u0027)"},{"line_number":647,"context_line":"    def test__continue_deploy_root_uuid_fails(self, mock_deploy, mock_image_cache):"},{"line_number":648,"context_line":"        self.node.power_state \u003d states.POWER_ON"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_d149b0b8","line":645,"in_reply_to":"3a961159_a5c31056","updated":"2014-12-30 05:08:09.000000000","message":"This mock is required for this test, so restore the orig one into below function in next patch.","commit_id":"040d52bd454befd238020e1bccf6209d84081683"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c0f1d3b9f0a35dce0213375da8a76bb8fa7a8f3d","unresolved":false,"context_lines":[{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027InstanceImageCache\u0027)"},{"line_number":646,"context_line":"    @mock.patch.object(deploy_utils, \u0027deploy\u0027)"},{"line_number":647,"context_line":"    def test__continue_deploy_root_uuid_fails(self, mock_deploy, mock_image_cache):"},{"line_number":648,"context_line":"        self.node.power_state \u003d states.POWER_ON"},{"line_number":649,"context_line":"        self.node.provision_state \u003d states.DEPLOYWAIT"},{"line_number":650,"context_line":"        self.node.save()"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_05aa2485","line":647,"updated":"2014-12-29 11:31:18.000000000","message":"Line too long.","commit_id":"040d52bd454befd238020e1bccf6209d84081683"}]}
