)]}'
{"ironic/common/glance_service/base_image_service.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ae24ea2f1cce99bf82b71c30ebd71929e1f412ee","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                                                           reason\u003dstr(e))"},{"line_number":141,"context_line":"                LOG.exception(error_msg, {\u0027host\u0027: host,"},{"line_number":142,"context_line":"                                          \u0027port\u0027: port,"},{"line_number":143,"context_line":"                                          \u0027num_attempts\u0027: num_attempts,"},{"line_number":144,"context_line":"                                          \u0027attempt\u0027: attempt,"},{"line_number":145,"context_line":"                                          \u0027method\u0027: method,"},{"line_number":146,"context_line":"                                          \u0027extra\u0027: extra})"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_37f3960b","side":"PARENT","line":143,"updated":"2015-01-03 07:36:49.000000000","message":"We need to throw the error for the last attempt as well.  There is something wrong with the current code.  We don\u0027t have \u0027%(num_attempts)s\u0027 in error_msg.  Can we correct this ? \n\nI guess we could have error message logged like this:\n\n + Error contacting glance server \u0027localhost:xxxx\u0027 for \u0027show\u0027, attempt 1 of 3 failed.\n + Error contacting glance server \u0027localhost:xxxx\u0027 for \u0027show\u0027, attempt 2 of 3 failed.\n + Error contacting glance server \u0027localhost:xxxx\u0027 for \u0027show\u0027, attempt 3 of 3 failed.\n\nThat\u0027s more indicative to the viewer of logfile that there were 3 attempts and stopped trying after 3rd attempt.","commit_id":"d74a5cd00c840c9c11f5ad3bd57cde64e64d18aa"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ad0202f3dfe7dbe0c81140ae8c03ea0225b5258c","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                extra \u003d \"retrying\""},{"line_number":128,"context_line":"                error_msg \u003d _LE(\"Error contacting glance server \""},{"line_number":129,"context_line":"                                \"\u0027%(host)s:%(port)s\u0027 for \u0027%(method)s\u0027, attempt %(attempt)s of"},{"line_number":130,"context_line":"                                   %(num_attempts)s failed, \u0027%(extra)s\u0027.\")"},{"line_number":131,"context_line":"                LOG.exception(error_msg, {\u0027host\u0027: host,"},{"line_number":132,"context_line":"                                    \u0027port\u0027: port,"},{"line_number":133,"context_line":"                                    \u0027num_attempts\u0027: num_attempts,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_8bfed003","line":130,"updated":"2015-01-05 16:44:37.000000000","message":"It will output \"retrying\" to the log file even on the last attempt. It is misleading.  \n\nI suggest either we change extra to \"done retrying\" if attempt \u003d\u003d num_attempts or drop the extra altogether.","commit_id":"5178781977edf0f88c86c9003d5b330f953ee77d"}]}