)]}'
{"ironic/common/exception.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee474c7409209fbb1d3cd8484d5d2f3f862261c0","unresolved":false,"context_lines":[{"line_number":502,"context_line":""},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"class DracLifecycleJobNotFound(NotFound):"},{"line_number":505,"context_line":"    message \u003d _(\"Cannot find Lifecycle job %(job_id)s.\")"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"class FailedToGetSensorData(IronicException):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_887f9316","line":505,"updated":"2015-03-03 13:20:28.000000000","message":"nit: s/L/l/","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9136c6a4a5efa7af51d38d517cbf5465b79d8263","unresolved":false,"context_lines":[{"line_number":502,"context_line":""},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"class DracLifecycleJobNotFound(NotFound):"},{"line_number":505,"context_line":"    message \u003d _(\"Cannot find Lifecycle job %(job_id)s.\")"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"class FailedToGetSensorData(IronicException):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_7649fe8a","line":505,"in_reply_to":"ba7be1f8_887f9316","updated":"2015-03-04 11:25:28.000000000","message":"Done","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"}],"ironic/drivers/drac.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c9da0befacbacc227638bc2aa9f7705a65d5dfb3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                        \u0027create_virtual_disk\u0027: self.drac_vendor,"},{"line_number":45,"context_line":"                        \u0027delete_virtual_disk\u0027: self.drac_vendor,"},{"line_number":46,"context_line":"                        \u0027apply_pending_raid_config\u0027: self.drac_vendor,"},{"line_number":47,"context_line":"                        \u0027delete_pending_raid_config\u0027: self.drac_vendor,"},{"line_number":48,"context_line":"                        \u0027discover_raid_controllers\u0027: self.drac_vendor,"},{"line_number":49,"context_line":"                        \u0027discover_physical_disks\u0027: self.drac_vendor,"},{"line_number":50,"context_line":"                        \u0027discover_virtual_disks\u0027: self.drac_vendor,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_e1e710e1","line":47,"updated":"2015-01-08 14:48:45.000000000","message":"are some of these related to a generic RAID spec?","commit_id":"f29c15bbb34c00fa1e2d4ec07f788ce0443b45e3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"d7713bdccc8305fc3ea782f12f0fb0f7000fd8f6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                        \u0027create_virtual_disk\u0027: self.drac_vendor,"},{"line_number":45,"context_line":"                        \u0027delete_virtual_disk\u0027: self.drac_vendor,"},{"line_number":46,"context_line":"                        \u0027apply_pending_raid_config\u0027: self.drac_vendor,"},{"line_number":47,"context_line":"                        \u0027delete_pending_raid_config\u0027: self.drac_vendor,"},{"line_number":48,"context_line":"                        \u0027discover_raid_controllers\u0027: self.drac_vendor,"},{"line_number":49,"context_line":"                        \u0027discover_physical_disks\u0027: self.drac_vendor,"},{"line_number":50,"context_line":"                        \u0027discover_virtual_disks\u0027: self.drac_vendor,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_6d4aa3c6","line":47,"in_reply_to":"3a961159_e1e710e1","updated":"2015-01-23 15:27:08.000000000","message":"yeah, these are the low-level operations that will be used by the generic interface.","commit_id":"f29c15bbb34c00fa1e2d4ec07f788ce0443b45e3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee474c7409209fbb1d3cd8484d5d2f3f862261c0","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        columns \u003d [\u0027id\u0027, \u0027uuid\u0027, \u0027driver\u0027, \u0027driver_internal_info\u0027]"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        node_list \u003d manager.dbapi.get_nodeinfo_list(columns\u003dcolumns,"},{"line_number":90,"context_line":"                                                    filters\u003dfilters)"},{"line_number":91,"context_line":"        for (node_id, node_uuid, driver, driver_internal_info) in node_list:"},{"line_number":92,"context_line":"            if driver not in [\u0027fake_drac\u0027, \u0027pxe_drac\u0027]:"},{"line_number":93,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_08aac370","line":90,"updated":"2015-03-03 13:20:28.000000000","message":"nit: if you rebase on top of https://review.openstack.org/#/c/159100 you\u0027ll get a nice iter_nodes function, but as you wish","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9136c6a4a5efa7af51d38d517cbf5465b79d8263","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        columns \u003d [\u0027id\u0027, \u0027uuid\u0027, \u0027driver\u0027, \u0027driver_internal_info\u0027]"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        node_list \u003d manager.dbapi.get_nodeinfo_list(columns\u003dcolumns,"},{"line_number":90,"context_line":"                                                    filters\u003dfilters)"},{"line_number":91,"context_line":"        for (node_id, node_uuid, driver, driver_internal_info) in node_list:"},{"line_number":92,"context_line":"            if driver not in [\u0027fake_drac\u0027, \u0027pxe_drac\u0027]:"},{"line_number":93,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_61093a2c","line":90,"in_reply_to":"ba7be1f8_08aac370","updated":"2015-03-04 11:25:28.000000000","message":"nice! thanks for that!","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee474c7409209fbb1d3cd8484d5d2f3f862261c0","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                                                    filters\u003dfilters)"},{"line_number":91,"context_line":"        for (node_id, node_uuid, driver, driver_internal_info) in node_list:"},{"line_number":92,"context_line":"            if driver not in [\u0027fake_drac\u0027, \u0027pxe_drac\u0027]:"},{"line_number":93,"context_line":"                continue"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"            if (\u0027raid_config_job_ids\u0027 not in driver_internal_info or"},{"line_number":96,"context_line":"                len(driver_internal_info[\u0027raid_config_job_ids\u0027]) \u003d\u003d 0):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_a8b297e2","line":93,"updated":"2015-03-03 13:20:28.000000000","message":"not the best way to check it, even\n\n if \u0027drac\u0027 not in driver\n\nwould be a bit better.","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9136c6a4a5efa7af51d38d517cbf5465b79d8263","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                                                    filters\u003dfilters)"},{"line_number":91,"context_line":"        for (node_id, node_uuid, driver, driver_internal_info) in node_list:"},{"line_number":92,"context_line":"            if driver not in [\u0027fake_drac\u0027, \u0027pxe_drac\u0027]:"},{"line_number":93,"context_line":"                continue"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"            if (\u0027raid_config_job_ids\u0027 not in driver_internal_info or"},{"line_number":96,"context_line":"                len(driver_internal_info[\u0027raid_config_job_ids\u0027]) \u003d\u003d 0):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_413c3694","line":93,"in_reply_to":"ba7be1f8_a8b297e2","updated":"2015-03-04 11:25:28.000000000","message":"Done","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee474c7409209fbb1d3cd8484d5d2f3f862261c0","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                continue"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"            if (\u0027raid_config_job_ids\u0027 not in driver_internal_info or"},{"line_number":96,"context_line":"                len(driver_internal_info[\u0027raid_config_job_ids\u0027]) \u003d\u003d 0):"},{"line_number":97,"context_line":"                continue"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_e823af02","line":96,"updated":"2015-03-03 13:20:28.000000000","message":"s/len(driver_internal_info[\u0027raid_config_job_ids\u0027]) \u003d\u003d 0/not driver_internal_info[\u0027raid_config_job_ids\u0027]/","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9136c6a4a5efa7af51d38d517cbf5465b79d8263","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                continue"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"            if (\u0027raid_config_job_ids\u0027 not in driver_internal_info or"},{"line_number":96,"context_line":"                len(driver_internal_info[\u0027raid_config_job_ids\u0027]) \u003d\u003d 0):"},{"line_number":97,"context_line":"                continue"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_a1717279","line":96,"in_reply_to":"ba7be1f8_e823af02","updated":"2015-03-04 11:25:28.000000000","message":"Done","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee474c7409209fbb1d3cd8484d5d2f3f862261c0","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                node \u003d objects.Node.get_by_id(context, node_id)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"                if (node.maintenance or node.reservation is not None):"},{"line_number":106,"context_line":"                    continue"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"                with task_manager.acquire(context, node_id) as task:"},{"line_number":109,"context_line":"                    node \u003d task.node"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_68e33fd9","line":106,"updated":"2015-03-03 13:20:28.000000000","message":"I don\u0027t think this check is needed (and definitely not before acquiring the lock)","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9136c6a4a5efa7af51d38d517cbf5465b79d8263","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                node \u003d objects.Node.get_by_id(context, node_id)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"                if (node.maintenance or node.reservation is not None):"},{"line_number":106,"context_line":"                    continue"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"                with task_manager.acquire(context, node_id) as task:"},{"line_number":109,"context_line":"                    node \u003d task.node"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_01179eee","line":106,"in_reply_to":"ba7be1f8_68e33fd9","updated":"2015-03-04 11:25:28.000000000","message":"Done","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee474c7409209fbb1d3cd8484d5d2f3f862261c0","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                            node.save()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"                        elif config_job[\u0027state\u0027] \u003d\u003d \u0027Failed\u0027:"},{"line_number":131,"context_line":"                            node.maintenance \u003d True"},{"line_number":132,"context_line":"                            node.last_error \u003d config_job[\u0027message\u0027]"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"                            node.save()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_888073c0","line":131,"updated":"2015-03-03 13:20:28.000000000","message":"log message required","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9136c6a4a5efa7af51d38d517cbf5465b79d8263","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                            node.save()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"                        elif config_job[\u0027state\u0027] \u003d\u003d \u0027Failed\u0027:"},{"line_number":131,"context_line":"                            node.maintenance \u003d True"},{"line_number":132,"context_line":"                            node.last_error \u003d config_job[\u0027message\u0027]"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"                            node.save()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_01731e4e","line":131,"in_reply_to":"ba7be1f8_888073c0","updated":"2015-03-04 11:25:28.000000000","message":"Done","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":114,"name":"Victor Lowther","email":"victor.lowther@gmail.com","username":"victor-lowther"},"change_message_id":"83f858ff44852a0e3b959a3b615a651115ddcc69","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    @base.driver_periodic_task("},{"line_number":80,"context_line":"        spacing\u003dCONF.drac.query_raid_config_job_status_interval,"},{"line_number":81,"context_line":"        parallel\u003dFalse)"},{"line_number":82,"context_line":"    def _query_raid_config_job_status(self, manager, context):"},{"line_number":83,"context_line":"        \"\"\"Periodic task to check for update on running RAID config jobs.\"\"\""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        filters \u003d {\u0027reserved\u0027: False, \u0027maintenance\u0027: False}"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_ffd775bd","line":82,"updated":"2015-03-04 14:49:45.000000000","message":"It would be useful for the BIOS settings patch to refactor this into a generic \"is a job running\" function and a more specialized one that uses the first to see if the job is a RAID job.","commit_id":"3a98dcd57e74faa06ffc257c4bae3fda65892b0f"}],"ironic/drivers/modules/drac/client.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c9da0befacbacc227638bc2aa9f7705a65d5dfb3","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        :param resource_uri: URI of the resource."},{"line_number":95,"context_line":"        :param options: client options."},{"line_number":96,"context_line":"        :param method: name of the method to invoke."},{"line_number":97,"context_line":"        :raises: DracClientError on an error from pywsman library."},{"line_number":98,"context_line":"        :returns: an ElementTree object of the response received."},{"line_number":99,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_41d8e41d","line":96,"updated":"2015-01-08 14:48:45.000000000","message":":param xml:","commit_id":"f29c15bbb34c00fa1e2d4ec07f788ce0443b45e3"}],"ironic/drivers/modules/drac/raid.py":[{"author":{"_account_id":114,"name":"Victor Lowther","email":"victor.lowther@gmail.com","username":"victor-lowther"},"change_message_id":"c07a99b127b72400caca0ad9f1e1e4b5d97eb099","unresolved":false,"context_lines":[{"line_number":134,"context_line":"def create_virtual_disk(node, **kwargs):"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    parameters \u003d {}"},{"line_number":137,"context_line":"    parameters[\u0027phyisical_disks\u0027] \u003d []"},{"line_number":138,"context_line":"    parameters[\u0027virtual_disk_prop_names\u0027] \u003d []"},{"line_number":139,"context_line":"    parameters[\u0027virtual_disk_prop_values\u0027] \u003d []"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_7ea4b6a5","line":137,"updated":"2015-01-07 19:10:56.000000000","message":"phyisical -\u003e physical.","commit_id":"f29c15bbb34c00fa1e2d4ec07f788ce0443b45e3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"d7713bdccc8305fc3ea782f12f0fb0f7000fd8f6","unresolved":false,"context_lines":[{"line_number":134,"context_line":"def create_virtual_disk(node, **kwargs):"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    parameters \u003d {}"},{"line_number":137,"context_line":"    parameters[\u0027phyisical_disks\u0027] \u003d []"},{"line_number":138,"context_line":"    parameters[\u0027virtual_disk_prop_names\u0027] \u003d []"},{"line_number":139,"context_line":"    parameters[\u0027virtual_disk_prop_values\u0027] \u003d []"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_6d78e3f2","line":137,"in_reply_to":"3a961159_7ea4b6a5","updated":"2015-01-23 15:27:08.000000000","message":"Done","commit_id":"f29c15bbb34c00fa1e2d4ec07f788ce0443b45e3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c9da0befacbacc227638bc2aa9f7705a65d5dfb3","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    try:"},{"line_number":145,"context_line":"        parameters[\u0027raid_controller\u0027] \u003d str(kwargs[\u0027raid_controller\u0027])"},{"line_number":146,"context_line":"    except KeyError:"},{"line_number":147,"context_line":"        error_msgs.append(_(\"\u0027raid_controller\u0027 not supplied.\"))"},{"line_number":148,"context_line":"    except UnicodeEncodeError:"},{"line_number":149,"context_line":"        error_msgs.append(_(\"\u0027raid_controller\u0027 contains non-ASCII symbol.\"))"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_8113acb6","line":147,"updated":"2015-01-08 14:48:45.000000000","message":"s/not/is not/  (or was not)","commit_id":"f29c15bbb34c00fa1e2d4ec07f788ce0443b45e3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"d7713bdccc8305fc3ea782f12f0fb0f7000fd8f6","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    try:"},{"line_number":145,"context_line":"        parameters[\u0027raid_controller\u0027] \u003d str(kwargs[\u0027raid_controller\u0027])"},{"line_number":146,"context_line":"    except KeyError:"},{"line_number":147,"context_line":"        error_msgs.append(_(\"\u0027raid_controller\u0027 not supplied.\"))"},{"line_number":148,"context_line":"    except UnicodeEncodeError:"},{"line_number":149,"context_line":"        error_msgs.append(_(\"\u0027raid_controller\u0027 contains non-ASCII symbol.\"))"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_c8baa5bf","line":147,"in_reply_to":"3a961159_8113acb6","updated":"2015-01-23 15:27:08.000000000","message":"Done","commit_id":"f29c15bbb34c00fa1e2d4ec07f788ce0443b45e3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c9da0befacbacc227638bc2aa9f7705a65d5dfb3","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    except KeyError:"},{"line_number":147,"context_line":"        error_msgs.append(_(\"\u0027raid_controller\u0027 not supplied.\"))"},{"line_number":148,"context_line":"    except UnicodeEncodeError:"},{"line_number":149,"context_line":"        error_msgs.append(_(\"\u0027raid_controller\u0027 contains non-ASCII symbol.\"))"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    # Physical disks validation"},{"line_number":152,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_8c75a399","line":149,"updated":"2015-01-08 14:48:45.000000000","message":"I guess this pattern can be made a function (even somewhere in common):\n\n def get_str(args, key):\n    try:\n      result[key] \u003d str(args[key])\n    ...","commit_id":"f29c15bbb34c00fa1e2d4ec07f788ce0443b45e3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"d7713bdccc8305fc3ea782f12f0fb0f7000fd8f6","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    except KeyError:"},{"line_number":147,"context_line":"        error_msgs.append(_(\"\u0027raid_controller\u0027 not supplied.\"))"},{"line_number":148,"context_line":"    except UnicodeEncodeError:"},{"line_number":149,"context_line":"        error_msgs.append(_(\"\u0027raid_controller\u0027 contains non-ASCII symbol.\"))"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    # Physical disks validation"},{"line_number":152,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_d3d41649","line":149,"in_reply_to":"3a961159_8c75a399","updated":"2015-01-23 15:27:08.000000000","message":"OK, probably I will add it as a separate patch and rebase once it\u0027s accepted.","commit_id":"f29c15bbb34c00fa1e2d4ec07f788ce0443b45e3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c9da0befacbacc227638bc2aa9f7705a65d5dfb3","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        parameters[\u0027phyisical_disks\u0027] \u003d [str(disk) for disk in"},{"line_number":154,"context_line":"                                         kwargs[\u0027phyisical_disks\u0027]]"},{"line_number":155,"context_line":"    except KeyError:"},{"line_number":156,"context_line":"        error_msgs.append(_(\"\u0027phyisical_disks\u0027 not supplied.\"))"},{"line_number":157,"context_line":"    except UnicodeEncodeError:"},{"line_number":158,"context_line":"        error_msgs.append(_(\"\u0027phyisical_disks\u0027 contains non-ASCII symbol.\"))"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_c1093485","line":156,"updated":"2015-01-08 14:48:45.000000000","message":"s/not/is not/","commit_id":"f29c15bbb34c00fa1e2d4ec07f788ce0443b45e3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"d7713bdccc8305fc3ea782f12f0fb0f7000fd8f6","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        parameters[\u0027phyisical_disks\u0027] \u003d [str(disk) for disk in"},{"line_number":154,"context_line":"                                         kwargs[\u0027phyisical_disks\u0027]]"},{"line_number":155,"context_line":"    except KeyError:"},{"line_number":156,"context_line":"        error_msgs.append(_(\"\u0027phyisical_disks\u0027 not supplied.\"))"},{"line_number":157,"context_line":"    except UnicodeEncodeError:"},{"line_number":158,"context_line":"        error_msgs.append(_(\"\u0027phyisical_disks\u0027 contains non-ASCII symbol.\"))"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_e8b121e2","line":156,"in_reply_to":"3a961159_c1093485","updated":"2015-01-23 15:27:08.000000000","message":"Done","commit_id":"f29c15bbb34c00fa1e2d4ec07f788ce0443b45e3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c9da0befacbacc227638bc2aa9f7705a65d5dfb3","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        parameters[\u0027virtual_disk_prop_values\u0027].append("},{"line_number":163,"context_line":"            str(kwargs[\u0027size_in_mb\u0027]))"},{"line_number":164,"context_line":"        parameters[\u0027virtual_disk_prop_names\u0027].append(\u0027Size\u0027)"},{"line_number":165,"context_line":"        int(kwargs[\u0027size_in_mb\u0027])"},{"line_number":166,"context_line":"    except KeyError:"},{"line_number":167,"context_line":"        error_msgs.append(_(\"\u0027size_in_mb\u0027 not supplied.\"))"},{"line_number":168,"context_line":"    except UnicodeEncodeError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_414624c1","line":165,"updated":"2015-01-08 14:48:45.000000000","message":"I think we tend to call such properties without \"in\", like just \"size_mb\"","commit_id":"f29c15bbb34c00fa1e2d4ec07f788ce0443b45e3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"d7713bdccc8305fc3ea782f12f0fb0f7000fd8f6","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        parameters[\u0027virtual_disk_prop_values\u0027].append("},{"line_number":163,"context_line":"            str(kwargs[\u0027size_in_mb\u0027]))"},{"line_number":164,"context_line":"        parameters[\u0027virtual_disk_prop_names\u0027].append(\u0027Size\u0027)"},{"line_number":165,"context_line":"        int(kwargs[\u0027size_in_mb\u0027])"},{"line_number":166,"context_line":"    except KeyError:"},{"line_number":167,"context_line":"        error_msgs.append(_(\"\u0027size_in_mb\u0027 not supplied.\"))"},{"line_number":168,"context_line":"    except UnicodeEncodeError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_edd213d1","line":165,"in_reply_to":"3a961159_414624c1","updated":"2015-01-23 15:27:08.000000000","message":"Done","commit_id":"f29c15bbb34c00fa1e2d4ec07f788ce0443b45e3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c9da0befacbacc227638bc2aa9f7705a65d5dfb3","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        parameters[\u0027virtual_disk_prop_names\u0027].append(\u0027Size\u0027)"},{"line_number":165,"context_line":"        int(kwargs[\u0027size_in_mb\u0027])"},{"line_number":166,"context_line":"    except KeyError:"},{"line_number":167,"context_line":"        error_msgs.append(_(\"\u0027size_in_mb\u0027 not supplied.\"))"},{"line_number":168,"context_line":"    except UnicodeEncodeError:"},{"line_number":169,"context_line":"        error_msgs.append(_(\"\u0027size_in_mb\u0027 contains non-ASCII symbol.\"))"},{"line_number":170,"context_line":"    except ValueError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_e1355045","line":167,"updated":"2015-01-08 14:48:45.000000000","message":"s/not/is not/","commit_id":"f29c15bbb34c00fa1e2d4ec07f788ce0443b45e3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"d7713bdccc8305fc3ea782f12f0fb0f7000fd8f6","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        parameters[\u0027virtual_disk_prop_names\u0027].append(\u0027Size\u0027)"},{"line_number":165,"context_line":"        int(kwargs[\u0027size_in_mb\u0027])"},{"line_number":166,"context_line":"    except KeyError:"},{"line_number":167,"context_line":"        error_msgs.append(_(\"\u0027size_in_mb\u0027 not supplied.\"))"},{"line_number":168,"context_line":"    except UnicodeEncodeError:"},{"line_number":169,"context_line":"        error_msgs.append(_(\"\u0027size_in_mb\u0027 contains non-ASCII symbol.\"))"},{"line_number":170,"context_line":"    except ValueError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_08b58dcc","line":167,"in_reply_to":"3a961159_e1355045","updated":"2015-01-23 15:27:08.000000000","message":"Done","commit_id":"f29c15bbb34c00fa1e2d4ec07f788ce0443b45e3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c9da0befacbacc227638bc2aa9f7705a65d5dfb3","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        error_msgs.append(_(\"\u0027raid_level\u0027 contains non-ASCII symbol.\"))"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    # validating optional params"},{"line_number":184,"context_line":"    for param, prop_name in OPTIONAL_VIRTUAL_DISK_PROPS.iteritems():"},{"line_number":185,"context_line":"        if param in kwargs:"},{"line_number":186,"context_line":"            try:"},{"line_number":187,"context_line":"                parameters[\u0027virtual_disk_prop_values\u0027].append("}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_812c8c03","line":184,"updated":"2015-01-08 14:48:45.000000000","message":"s/iteritems/items/ for py3k compatibility","commit_id":"f29c15bbb34c00fa1e2d4ec07f788ce0443b45e3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"d7713bdccc8305fc3ea782f12f0fb0f7000fd8f6","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        error_msgs.append(_(\"\u0027raid_level\u0027 contains non-ASCII symbol.\"))"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    # validating optional params"},{"line_number":184,"context_line":"    for param, prop_name in OPTIONAL_VIRTUAL_DISK_PROPS.iteritems():"},{"line_number":185,"context_line":"        if param in kwargs:"},{"line_number":186,"context_line":"            try:"},{"line_number":187,"context_line":"                parameters[\u0027virtual_disk_prop_values\u0027].append("}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_6d9463e2","line":184,"in_reply_to":"3a961159_812c8c03","updated":"2015-01-23 15:27:08.000000000","message":"Done","commit_id":"f29c15bbb34c00fa1e2d4ec07f788ce0443b45e3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c9da0befacbacc227638bc2aa9f7705a65d5dfb3","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    # validating optional params"},{"line_number":184,"context_line":"    for param, prop_name in OPTIONAL_VIRTUAL_DISK_PROPS.iteritems():"},{"line_number":185,"context_line":"        if param in kwargs:"},{"line_number":186,"context_line":"            try:"},{"line_number":187,"context_line":"                parameters[\u0027virtual_disk_prop_values\u0027].append("},{"line_number":188,"context_line":"                    str(kwargs[param]))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_21d758c0","line":185,"updated":"2015-01-08 14:48:45.000000000","message":"nit: for readability it\u0027s better to reverse the condition:\n\n if param not in kwargs:\n   continue\n ...","commit_id":"f29c15bbb34c00fa1e2d4ec07f788ce0443b45e3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"d7713bdccc8305fc3ea782f12f0fb0f7000fd8f6","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    # validating optional params"},{"line_number":184,"context_line":"    for param, prop_name in OPTIONAL_VIRTUAL_DISK_PROPS.iteritems():"},{"line_number":185,"context_line":"        if param in kwargs:"},{"line_number":186,"context_line":"            try:"},{"line_number":187,"context_line":"                parameters[\u0027virtual_disk_prop_values\u0027].append("},{"line_number":188,"context_line":"                    str(kwargs[param]))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_6d59c359","line":185,"in_reply_to":"3a961159_21d758c0","updated":"2015-01-23 15:27:08.000000000","message":"Done","commit_id":"f29c15bbb34c00fa1e2d4ec07f788ce0443b45e3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c9da0befacbacc227638bc2aa9f7705a65d5dfb3","unresolved":false,"context_lines":[{"line_number":383,"context_line":"    options.add_selector(\"CreationClassName\", \"DCIM_RAIDService\")"},{"line_number":384,"context_line":"    options.add_selector(\"SystemName\", \"DCIM:ComputerSystem\")"},{"line_number":385,"context_line":"    options.add_selector(\"Name\", \"DCIM:RAIDService\")"},{"line_number":386,"context_line":"    options.add_property(\u0027Target\u0027, raid_controller)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    try:"},{"line_number":389,"context_line":"        root \u003d client.wsman_invoke(resource_uris.DCIM_RAIDService, options,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_2cabcfd6","line":386,"updated":"2015-01-08 14:48:45.000000000","message":"all this code from the beginning of the function is (nearly?) the same for all functions, consider moving it to a function","commit_id":"f29c15bbb34c00fa1e2d4ec07f788ce0443b45e3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"d7713bdccc8305fc3ea782f12f0fb0f7000fd8f6","unresolved":false,"context_lines":[{"line_number":383,"context_line":"    options.add_selector(\"CreationClassName\", \"DCIM_RAIDService\")"},{"line_number":384,"context_line":"    options.add_selector(\"SystemName\", \"DCIM:ComputerSystem\")"},{"line_number":385,"context_line":"    options.add_selector(\"Name\", \"DCIM:RAIDService\")"},{"line_number":386,"context_line":"    options.add_property(\u0027Target\u0027, raid_controller)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    try:"},{"line_number":389,"context_line":"        root \u003d client.wsman_invoke(resource_uris.DCIM_RAIDService, options,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_ed3cd3e4","line":386,"in_reply_to":"3a961159_2cabcfd6","updated":"2015-01-23 15:27:08.000000000","message":"Done in a separate patch.","commit_id":"f29c15bbb34c00fa1e2d4ec07f788ce0443b45e3"},{"author":{"_account_id":114,"name":"Victor Lowther","email":"victor.lowther@gmail.com","username":"victor-lowther"},"change_message_id":"d129f1898ef5d5cb0c0969fc54a800fd8215576b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"PHYISICAL_DISK_BUS_PROTOCOL \u003d {"},{"line_number":54,"context_line":"    \u00270\u0027: \u0027unkown\u0027,"},{"line_number":55,"context_line":"    \u00271\u0027: \u0027scsi\u0027,"},{"line_number":56,"context_line":"    \u00272\u0027: \u0027pata\u0027,"},{"line_number":57,"context_line":"    \u00273\u0027: \u0027fibre\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_aa89a4cb","line":54,"updated":"2015-03-03 15:55:24.000000000","message":"unknown","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9136c6a4a5efa7af51d38d517cbf5465b79d8263","unresolved":false,"context_lines":[{"line_number":51,"context_line":"}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"PHYISICAL_DISK_BUS_PROTOCOL \u003d {"},{"line_number":54,"context_line":"    \u00270\u0027: \u0027unkown\u0027,"},{"line_number":55,"context_line":"    \u00271\u0027: \u0027scsi\u0027,"},{"line_number":56,"context_line":"    \u00272\u0027: \u0027pata\u0027,"},{"line_number":57,"context_line":"    \u00273\u0027: \u0027fibre\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_a16c1238","line":54,"in_reply_to":"ba7be1f8_aa89a4cb","updated":"2015-03-04 11:25:28.000000000","message":"Done","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":114,"name":"Victor Lowther","email":"victor.lowther@gmail.com","username":"victor-lowther"},"change_message_id":"d129f1898ef5d5cb0c0969fc54a800fd8215576b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"DISK_PRIMARY_STATUS \u003d {"},{"line_number":64,"context_line":"    \u00270\u0027: \u0027unkown\u0027,"},{"line_number":65,"context_line":"    \u00271\u0027: \u0027ok\u0027,"},{"line_number":66,"context_line":"    \u00272\u0027: \u0027degraded\u0027,"},{"line_number":67,"context_line":"    \u00273\u0027: \u0027error\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_4ac2e8e9","line":64,"updated":"2015-03-03 15:55:24.000000000","message":"unknown","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9136c6a4a5efa7af51d38d517cbf5465b79d8263","unresolved":false,"context_lines":[{"line_number":61,"context_line":"}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"DISK_PRIMARY_STATUS \u003d {"},{"line_number":64,"context_line":"    \u00270\u0027: \u0027unkown\u0027,"},{"line_number":65,"context_line":"    \u00271\u0027: \u0027ok\u0027,"},{"line_number":66,"context_line":"    \u00272\u0027: \u0027degraded\u0027,"},{"line_number":67,"context_line":"    \u00273\u0027: \u0027error\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_c1690627","line":64,"in_reply_to":"ba7be1f8_4ac2e8e9","updated":"2015-03-04 11:25:28.000000000","message":"Done","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":114,"name":"Victor Lowther","email":"victor.lowther@gmail.com","username":"victor-lowther"},"change_message_id":"d129f1898ef5d5cb0c0969fc54a800fd8215576b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"DISK_RAID_STATUS \u003d {"},{"line_number":71,"context_line":"    \u00270\u0027: \u0027unkown\u0027,"},{"line_number":72,"context_line":"    \u00271\u0027: \u0027ready\u0027,"},{"line_number":73,"context_line":"    \u00272\u0027: \u0027online\u0027,"},{"line_number":74,"context_line":"    \u00273\u0027: \u0027foreign\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_8ab86076","line":71,"updated":"2015-03-03 15:55:24.000000000","message":"unknown","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9136c6a4a5efa7af51d38d517cbf5465b79d8263","unresolved":false,"context_lines":[{"line_number":68,"context_line":"}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"DISK_RAID_STATUS \u003d {"},{"line_number":71,"context_line":"    \u00270\u0027: \u0027unkown\u0027,"},{"line_number":72,"context_line":"    \u00271\u0027: \u0027ready\u0027,"},{"line_number":73,"context_line":"    \u00272\u0027: \u0027online\u0027,"},{"line_number":74,"context_line":"    \u00273\u0027: \u0027foreign\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_0174fefb","line":71,"in_reply_to":"ba7be1f8_8ab86076","updated":"2015-03-04 11:25:28.000000000","message":"Done","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":114,"name":"Victor Lowther","email":"victor.lowther@gmail.com","username":"victor-lowther"},"change_message_id":"d129f1898ef5d5cb0c0969fc54a800fd8215576b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        fqdd \u003d _get_raid_controller_attr(controller, \u0027FQDD\u0027)"},{"line_number":128,"context_line":"        model \u003d _get_raid_controller_attr(controller, \u0027ProductName\u0027)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    raid_controllers.append({"},{"line_number":131,"context_line":"        \u0027id\u0027: fqdd,"},{"line_number":132,"context_line":"        \u0027model\u0027: model"},{"line_number":133,"context_line":"    })"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_ea547c23","line":130,"updated":"2015-03-03 15:55:24.000000000","message":"bad indentation?","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9136c6a4a5efa7af51d38d517cbf5465b79d8263","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        fqdd \u003d _get_raid_controller_attr(controller, \u0027FQDD\u0027)"},{"line_number":128,"context_line":"        model \u003d _get_raid_controller_attr(controller, \u0027ProductName\u0027)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    raid_controllers.append({"},{"line_number":131,"context_line":"        \u0027id\u0027: fqdd,"},{"line_number":132,"context_line":"        \u0027model\u0027: model"},{"line_number":133,"context_line":"    })"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_41651644","line":130,"in_reply_to":"ba7be1f8_ea547c23","updated":"2015-03-04 11:25:28.000000000","message":"why?","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee474c7409209fbb1d3cd8484d5d2f3f862261c0","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        drac_raid_types \u003d _get_virtual_disk_attr(disk, \u0027RAIDTypes\u0027)"},{"line_number":185,"context_line":"        name \u003d _get_virtual_disk_attr(disk, \u0027Name\u0027)"},{"line_number":186,"context_line":"        drac_primary_status \u003d _get_virtual_disk_attr(disk, \u0027PrimaryStatus\u0027)"},{"line_number":187,"context_line":"        drac_raid_status \u003d _get_virtual_disk_attr(disk, \u0027RAIDStatus\u0027)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        virtual_disks.append({"},{"line_number":190,"context_line":"            \u0027controller\u0027: controller,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_689b3f18","line":187,"updated":"2015-03-03 13:20:28.000000000","message":"the same code appears below but with s/_get_virtual_disk_attr/_get_physical_disk_attr/ maybe move it into function accepting `disk` and `func` and returning a dict?","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9136c6a4a5efa7af51d38d517cbf5465b79d8263","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        drac_raid_types \u003d _get_virtual_disk_attr(disk, \u0027RAIDTypes\u0027)"},{"line_number":185,"context_line":"        name \u003d _get_virtual_disk_attr(disk, \u0027Name\u0027)"},{"line_number":186,"context_line":"        drac_primary_status \u003d _get_virtual_disk_attr(disk, \u0027PrimaryStatus\u0027)"},{"line_number":187,"context_line":"        drac_raid_status \u003d _get_virtual_disk_attr(disk, \u0027RAIDStatus\u0027)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        virtual_disks.append({"},{"line_number":190,"context_line":"            \u0027controller\u0027: controller,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_137e0faf","line":187,"in_reply_to":"ba7be1f8_689b3f18","updated":"2015-03-04 11:25:28.000000000","message":"While the code is definitely not the same because physical and virtual disk have different attributes, I can refactor it creating the function you suggested.","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee474c7409209fbb1d3cd8484d5d2f3f862261c0","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    except KeyError:"},{"line_number":323,"context_line":"        error_msgs.append(_(\"\u0027raid_controller\u0027 is not supplied.\"))"},{"line_number":324,"context_line":"    except UnicodeEncodeError:"},{"line_number":325,"context_line":"        error_msgs.append(_(\"\u0027raid_controller\u0027 contains non-ASCII symbol.\"))"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    # Physical disks validation"},{"line_number":328,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_68c25fea","line":325,"updated":"2015-03-03 13:20:28.000000000","message":"maybe move this try..except.. snippet to a function too? it\u0027s repeated pretty often","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9136c6a4a5efa7af51d38d517cbf5465b79d8263","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    except KeyError:"},{"line_number":323,"context_line":"        error_msgs.append(_(\"\u0027raid_controller\u0027 is not supplied.\"))"},{"line_number":324,"context_line":"    except UnicodeEncodeError:"},{"line_number":325,"context_line":"        error_msgs.append(_(\"\u0027raid_controller\u0027 contains non-ASCII symbol.\"))"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    # Physical disks validation"},{"line_number":328,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_f305fb14","line":325,"in_reply_to":"ba7be1f8_68c25fea","updated":"2015-03-04 11:25:28.000000000","message":"sorry, you already suggested it. doing it right now...","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee474c7409209fbb1d3cd8484d5d2f3f862261c0","unresolved":false,"context_lines":[{"line_number":680,"context_line":"    filtered_disks \u003d []"},{"line_number":681,"context_line":"    for disk in logical_disks:"},{"line_number":682,"context_line":"        if (include_root_volume and \u0027is_root_volume\u0027 in disk and"},{"line_number":683,"context_line":"            disk[\u0027is_root_volume\u0027]):"},{"line_number":684,"context_line":"            filtered_disks.append(disk)"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        if (include_nonroot_volumes and (\u0027is_root_volume\u0027 not in disk or"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_c877cbd2","line":683,"updated":"2015-03-03 13:20:28.000000000","message":"nit:\n\n if include_root_volume and disk.get(\u0027is_root_volume\u0027)","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9136c6a4a5efa7af51d38d517cbf5465b79d8263","unresolved":false,"context_lines":[{"line_number":680,"context_line":"    filtered_disks \u003d []"},{"line_number":681,"context_line":"    for disk in logical_disks:"},{"line_number":682,"context_line":"        if (include_root_volume and \u0027is_root_volume\u0027 in disk and"},{"line_number":683,"context_line":"            disk[\u0027is_root_volume\u0027]):"},{"line_number":684,"context_line":"            filtered_disks.append(disk)"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        if (include_nonroot_volumes and (\u0027is_root_volume\u0027 not in disk or"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_a995d489","line":683,"in_reply_to":"ba7be1f8_c877cbd2","updated":"2015-03-04 11:25:28.000000000","message":"Done","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee474c7409209fbb1d3cd8484d5d2f3f862261c0","unresolved":false,"context_lines":[{"line_number":684,"context_line":"            filtered_disks.append(disk)"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        if (include_nonroot_volumes and (\u0027is_root_volume\u0027 not in disk or"},{"line_number":687,"context_line":"            not disk[\u0027is_root_volume\u0027])):"},{"line_number":688,"context_line":"            filtered_disks.append(disk)"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"    return filtered_disks"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_88415365","line":687,"updated":"2015-03-03 13:20:28.000000000","message":"nit:\n\n if include_nonroot_volume and not disk.get(\u0027is_root_volume\u0027)","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9136c6a4a5efa7af51d38d517cbf5465b79d8263","unresolved":false,"context_lines":[{"line_number":684,"context_line":"            filtered_disks.append(disk)"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        if (include_nonroot_volumes and (\u0027is_root_volume\u0027 not in disk or"},{"line_number":687,"context_line":"            not disk[\u0027is_root_volume\u0027])):"},{"line_number":688,"context_line":"            filtered_disks.append(disk)"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"    return filtered_disks"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_e98fcc73","line":687,"in_reply_to":"ba7be1f8_88415365","updated":"2015-03-04 11:25:28.000000000","message":"Done","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee474c7409209fbb1d3cd8484d5d2f3f862261c0","unresolved":false,"context_lines":[{"line_number":693,"context_line":"def _add_missing_options(logical_disks):"},{"line_number":694,"context_line":"    for disk in logical_disks:"},{"line_number":695,"context_line":"        if \u0027size_mb\u0027 not in disk:"},{"line_number":696,"context_line":"            disk[\u0027size_mb\u0027] \u003d disk[\u0027size_gb\u0027] * 2 ** 10"},{"line_number":697,"context_line":"            disk.pop(\u0027size_gb\u0027)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        if \u0027span_depth\u0027 not in disk:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_6837bfff","line":696,"updated":"2015-03-03 13:20:28.000000000","message":"nit: 2**10 \u003d\u003d 1024 :)","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9136c6a4a5efa7af51d38d517cbf5465b79d8263","unresolved":false,"context_lines":[{"line_number":693,"context_line":"def _add_missing_options(logical_disks):"},{"line_number":694,"context_line":"    for disk in logical_disks:"},{"line_number":695,"context_line":"        if \u0027size_mb\u0027 not in disk:"},{"line_number":696,"context_line":"            disk[\u0027size_mb\u0027] \u003d disk[\u0027size_gb\u0027] * 2 ** 10"},{"line_number":697,"context_line":"            disk.pop(\u0027size_gb\u0027)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        if \u0027span_depth\u0027 not in disk:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_c9c68849","line":696,"in_reply_to":"ba7be1f8_6837bfff","updated":"2015-03-04 11:25:28.000000000","message":"yeah, I know! :-)","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":114,"name":"Victor Lowther","email":"victor.lowther@gmail.com","username":"victor-lowther"},"change_message_id":"d129f1898ef5d5cb0c0969fc54a800fd8215576b","unresolved":false,"context_lines":[{"line_number":697,"context_line":"            disk.pop(\u0027size_gb\u0027)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        if \u0027span_depth\u0027 not in disk:"},{"line_number":700,"context_line":"            disk[\u0027span_depth\u0027] \u003d 1"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"        if \u0027span_length\u0027 not in disk:"},{"line_number":703,"context_line":"            disk[\u0027span_length\u0027] \u003d len(disk[\u0027physical_disks\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_80591f37","line":700,"updated":"2015-03-03 15:55:24.000000000","message":"Not for [156]+0.  span_depth must be \u003e 1 for them.","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":114,"name":"Victor Lowther","email":"victor.lowther@gmail.com","username":"victor-lowther"},"change_message_id":"523e4cd6663ade94b263685baf6a07182ef586af","unresolved":false,"context_lines":[{"line_number":697,"context_line":"            disk.pop(\u0027size_gb\u0027)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        if \u0027span_depth\u0027 not in disk:"},{"line_number":700,"context_line":"            disk[\u0027span_depth\u0027] \u003d 1"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"        if \u0027span_length\u0027 not in disk:"},{"line_number":703,"context_line":"            disk[\u0027span_length\u0027] \u003d len(disk[\u0027physical_disks\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_20615339","line":700,"in_reply_to":"ba7be1f8_80591f37","updated":"2015-03-03 16:02:04.000000000","message":"Specifically, the span logic I used in Crowbar is at https://github.com/opencrowbar/hardware/blob/develop/raid/crowbar_engine/barclamp_raid/app/models/barclamp_raid/driver.rb#L121","commit_id":"9fb08045d8fea75f886664ba8dd1536d8fc5c31b"},{"author":{"_account_id":114,"name":"Victor Lowther","email":"victor.lowther@gmail.com","username":"victor-lowther"},"change_message_id":"83f858ff44852a0e3b959a3b615a651115ddcc69","unresolved":false,"context_lines":[{"line_number":682,"context_line":""},{"line_number":683,"context_line":"        if \u0027span_length\u0027 not in disk:"},{"line_number":684,"context_line":"            disk[\u0027span_length\u0027] \u003d len(disk[\u0027physical_disks\u0027])"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        disk[\u0027raid_controller\u0027] \u003d \u0027RAID.Integrated.1-1\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_a241660d","line":685,"updated":"2015-03-04 14:49:45.000000000","message":"The span_depth and span_length logic here is still busted for RAID 1+0, 5+0, and 6+0.  https://github.com/opencrowbar/hardware/blob/develop/raid/crowbar_engine/barclamp_raid/app/models/barclamp_raid/driver.rb#L121 has the proper logic.","commit_id":"3a98dcd57e74faa06ffc257c4bae3fda65892b0f"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"2d49e3d60670a35d31318fbbc58795927dedcdab","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        :disk_type:"},{"line_number":212,"context_line":"            Disk type of the physical disk, one of \u0027hdd\u0027 or \u0027ssd\u0027."},{"line_number":213,"context_line":"        :interface_type:"},{"line_number":214,"context_line":"            Interface type of the physical disk, one of \u0027unkown\u0027, \u0027scsi\u0027,"},{"line_number":215,"context_line":"            \u0027pata\u0027, \u0027fibre\u0027, \u0027usb\u0027, \u0027sata\u0027, or \u0027sas\u0027."},{"line_number":216,"context_line":"        :size_gb:"},{"line_number":217,"context_line":"            Size of the physical disk in gigabytes."}],"source_content_type":"text/x-python","patch_set":7,"id":"bab921fb_31417b0c","line":214,"updated":"2015-04-23 14:50:08.000000000","message":"s/unkown/unknown/","commit_id":"8b1587a78903a773ade0ad17b0b0e5331e86c254"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"f0623394167cb1b73626922df47470bcebe1d0df","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        :disk_type:"},{"line_number":212,"context_line":"            Disk type of the physical disk, one of \u0027hdd\u0027 or \u0027ssd\u0027."},{"line_number":213,"context_line":"        :interface_type:"},{"line_number":214,"context_line":"            Interface type of the physical disk, one of \u0027unkown\u0027, \u0027scsi\u0027,"},{"line_number":215,"context_line":"            \u0027pata\u0027, \u0027fibre\u0027, \u0027usb\u0027, \u0027sata\u0027, or \u0027sas\u0027."},{"line_number":216,"context_line":"        :size_gb:"},{"line_number":217,"context_line":"            Size of the physical disk in gigabytes."}],"source_content_type":"text/x-python","patch_set":7,"id":"9abe1de1_ecd46f48","line":214,"in_reply_to":"bab921fb_31417b0c","updated":"2015-04-27 11:21:53.000000000","message":"Done","commit_id":"8b1587a78903a773ade0ad17b0b0e5331e86c254"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"2d49e3d60670a35d31318fbbc58795927dedcdab","unresolved":false,"context_lines":[{"line_number":286,"context_line":"    \"\"\"Creates a single virtual disk on a RAID controller."},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    The created virtual disk will be in pending state. The DRAC card will do"},{"line_number":289,"context_line":"    the actual configuration once the the changes are applied on the RAID. This"},{"line_number":290,"context_line":"    can be done by calling the apply_pending_config method."},{"line_number":291,"context_line":"    :param node: an ironic node object."},{"line_number":292,"context_line":"    :param kwargs: a dictionary holding the virtual disk attributes:"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab921fb_d148ff2f","line":289,"updated":"2015-04-23 14:50:08.000000000","message":"s/the the/the/","commit_id":"8b1587a78903a773ade0ad17b0b0e5331e86c254"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"f0623394167cb1b73626922df47470bcebe1d0df","unresolved":false,"context_lines":[{"line_number":286,"context_line":"    \"\"\"Creates a single virtual disk on a RAID controller."},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    The created virtual disk will be in pending state. The DRAC card will do"},{"line_number":289,"context_line":"    the actual configuration once the the changes are applied on the RAID. This"},{"line_number":290,"context_line":"    can be done by calling the apply_pending_config method."},{"line_number":291,"context_line":"    :param node: an ironic node object."},{"line_number":292,"context_line":"    :param kwargs: a dictionary holding the virtual disk attributes:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abe1de1_4c559bc4","line":289,"in_reply_to":"bab921fb_d148ff2f","updated":"2015-04-27 11:21:53.000000000","message":"Done","commit_id":"8b1587a78903a773ade0ad17b0b0e5331e86c254"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"2d49e3d60670a35d31318fbbc58795927dedcdab","unresolved":false,"context_lines":[{"line_number":391,"context_line":"    \"\"\"Deletes a single virtual disk on a RAID controller."},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    The deleted virtual disk will be in pending state. The DRAC card will do"},{"line_number":394,"context_line":"    the actual configuration once the the changes are applied on the RAID. This"},{"line_number":395,"context_line":"    can be done by calling the ``apply_pending_config`` method."},{"line_number":396,"context_line":"    :param node: an ironic node object."},{"line_number":397,"context_line":"    :param kwargs: a dictionary holding the virtual disk attributes:"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab921fb_715ed3ea","line":394,"updated":"2015-04-23 14:50:08.000000000","message":"s/the the/the/","commit_id":"8b1587a78903a773ade0ad17b0b0e5331e86c254"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"f0623394167cb1b73626922df47470bcebe1d0df","unresolved":false,"context_lines":[{"line_number":391,"context_line":"    \"\"\"Deletes a single virtual disk on a RAID controller."},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    The deleted virtual disk will be in pending state. The DRAC card will do"},{"line_number":394,"context_line":"    the actual configuration once the the changes are applied on the RAID. This"},{"line_number":395,"context_line":"    can be done by calling the ``apply_pending_config`` method."},{"line_number":396,"context_line":"    :param node: an ironic node object."},{"line_number":397,"context_line":"    :param kwargs: a dictionary holding the virtual disk attributes:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abe1de1_0c5e83e9","line":394,"in_reply_to":"bab921fb_715ed3ea","updated":"2015-04-27 11:21:53.000000000","message":"Done","commit_id":"8b1587a78903a773ade0ad17b0b0e5331e86c254"}],"ironic/drivers/modules/drac/vendor_passthru.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c9da0befacbacc227638bc2aa9f7705a65d5dfb3","unresolved":false,"context_lines":[{"line_number":34,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# NOTE(ifarkas): The listing of lifecylce jobs shouldn\u0027t be supported by the"},{"line_number":38,"context_line":"#                vendor_passthru interface. The reason for this is that Ironic"},{"line_number":39,"context_line":"#                doesn\u0027t support periodic tasks for the drivers which is"},{"line_number":40,"context_line":"#                required for applying the RAID configuration. The DRAC card"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_4cb65b3f","line":37,"updated":"2015-01-08 14:48:45.000000000","message":"nit: s/lifecylce/lifecycle/","commit_id":"f29c15bbb34c00fa1e2d4ec07f788ce0443b45e3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"d7713bdccc8305fc3ea782f12f0fb0f7000fd8f6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# NOTE(ifarkas): The listing of lifecylce jobs shouldn\u0027t be supported by the"},{"line_number":38,"context_line":"#                vendor_passthru interface. The reason for this is that Ironic"},{"line_number":39,"context_line":"#                doesn\u0027t support periodic tasks for the drivers which is"},{"line_number":40,"context_line":"#                required for applying the RAID configuration. The DRAC card"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_ed13f363","line":37,"in_reply_to":"3a961159_4cb65b3f","updated":"2015-01-23 15:27:08.000000000","message":"Done","commit_id":"f29c15bbb34c00fa1e2d4ec07f788ce0443b45e3"}]}
