)]}'
{"ironic/api/hooks.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e1063ed5380e62c3adff4102738d1d882e3ec1d6","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            \u0027domain_name\u0027: headers.get(\u0027X-User-Domain-Name\u0027),"},{"line_number":75,"context_line":"            \u0027auth_token\u0027: headers.get(\u0027X-Auth-Token\u0027),"},{"line_number":76,"context_line":"            \u0027roles\u0027: headers.get(\u0027X-Roles\u0027, \u0027\u0027).split(\u0027,\u0027),"},{"line_number":77,"context_line":"        }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        is_admin \u003d policy.enforce(\u0027admin_api\u0027, creds, creds)"},{"line_number":80,"context_line":"        is_public_api \u003d state.request.environ.get(\u0027is_public_api\u0027, False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_7bb012dc","line":77,"updated":"2015-01-09 11:44:40.000000000","message":"much cleaner :)","commit_id":"2d84e03a87f8a0be96299d5c5f64b16ac2f570e3"}],"ironic/tests/api/test_hooks.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e1063ed5380e62c3adff4102738d1d882e3ec1d6","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"class TestContextHook(base.FunctionalTest):"},{"line_number":169,"context_line":"    @mock.patch.object(context, \u0027RequestContext\u0027)"},{"line_number":170,"context_line":"    def test_context_hook_not_admin(self, mock_ctx):"},{"line_number":171,"context_line":"        headers \u003d fake_headers(admin\u003dFalse)"},{"line_number":172,"context_line":"        reqstate \u003d FakeRequestState(headers\u003dheaders)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_bb6d1a9b","line":169,"updated":"2015-01-09 11:44:40.000000000","message":"Nit: since you\u0027re mocking context.RequestContext in all method of this class, \nyou could add this mock at the TestContextHook class level, e.g:\n \n @mock.patch.object(context, \u0027RequestContext\u0027)\n class TestContextHook(base.FunctionalTest):\n\n     def test_context_hook_not_admin(self, mock_ctx):\n         ...","commit_id":"2d84e03a87f8a0be96299d5c5f64b16ac2f570e3"}]}
