)]}'
{"ironic/common/images.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"36c92bde9df7035a7e3f5557decc5257803a7db2","unresolved":false,"context_lines":[{"line_number":314,"context_line":"    \"\"\""},{"line_number":315,"context_line":"    glance_service \u003d service.Service(version\u003d1, context\u003dcontext)"},{"line_number":316,"context_line":"    iproperties \u003d glance_service.show(image_uuid)[\u0027properties\u0027]"},{"line_number":317,"context_line":"    return [iproperties.get(p) for p in properties]"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"def get_glance_image_property(context, image_uuid, property):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_b244581a","line":317,"updated":"2015-01-09 14:55:05.000000000","message":"why not just return all properties as a dict? this filtering makes little sense to me.","commit_id":"a4ace6c6818bd129269604667fc1f0a31d9123a9"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"4bd7e5d275fc3c61637f91aff9c05c2910b3d43c","unresolved":false,"context_lines":[{"line_number":314,"context_line":"    \"\"\""},{"line_number":315,"context_line":"    glance_service \u003d service.Service(version\u003d1, context\u003dcontext)"},{"line_number":316,"context_line":"    iproperties \u003d glance_service.show(image_uuid)[\u0027properties\u0027]"},{"line_number":317,"context_line":"    return [iproperties.get(p) for p in properties]"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"def get_glance_image_property(context, image_uuid, property):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_d29ba471","line":317,"in_reply_to":"3a961159_b244581a","updated":"2015-01-09 15:01:57.000000000","message":"I think it\u0027s nice that the calling code has to be explicit about which values it\u0027s interested in. Helps for clarity, but I\u0027m not that attached to it.\n\nIt would be nicer to return these as a dict, though, so I\u0027ll do that and see what people think about the filtering.","commit_id":"a4ace6c6818bd129269604667fc1f0a31d9123a9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3d8ebfbf4782e798859378c88032776d66ce7a3d","unresolved":false,"context_lines":[{"line_number":303,"context_line":"    return data.virtual_size"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"def get_glance_image_properties(context, image_uuid, properties):"},{"line_number":307,"context_line":"    \"\"\"Returns the values of several properties of a glance image"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    :param context: context"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_4a48bb2e","line":306,"updated":"2015-01-12 11:25:27.000000000","message":"a nit: what about making properties optional and defaulting to all properties?","commit_id":"9415037e7f35d38dca7573ba3935d7584e35917c"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"495ed440866f03236e1c84386da517fbcea10754","unresolved":false,"context_lines":[{"line_number":303,"context_line":"    return data.virtual_size"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"def get_glance_image_properties(context, image_uuid, properties):"},{"line_number":307,"context_line":"    \"\"\"Returns the values of several properties of a glance image"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    :param context: context"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_eb796683","line":306,"in_reply_to":"3a961159_4a48bb2e","updated":"2015-01-12 14:10:01.000000000","message":"Done","commit_id":"9415037e7f35d38dca7573ba3935d7584e35917c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3d8ebfbf4782e798859378c88032776d66ce7a3d","unresolved":false,"context_lines":[{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    requested_properties \u003d {}"},{"line_number":319,"context_line":"    for p in properties:"},{"line_number":320,"context_line":"        requested_properties[p] \u003d iproperties.get(p)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    return requested_properties"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_6a6c979e","line":320,"updated":"2015-01-12 11:25:27.000000000","message":"also a nit:\n\n return {p: iproperties.get(p) for p in properties}","commit_id":"9415037e7f35d38dca7573ba3935d7584e35917c"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"495ed440866f03236e1c84386da517fbcea10754","unresolved":false,"context_lines":[{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    requested_properties \u003d {}"},{"line_number":319,"context_line":"    for p in properties:"},{"line_number":320,"context_line":"        requested_properties[p] \u003d iproperties.get(p)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    return requested_properties"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_6bb65640","line":320,"in_reply_to":"3a961159_6a6c979e","updated":"2015-01-12 14:10:01.000000000","message":"Done","commit_id":"9415037e7f35d38dca7573ba3935d7584e35917c"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"c750f698083273e9fc91384b4d54c8a81b8d58d2","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    return requested_properties"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"def get_glance_image_property(context, image_uuid, property):"},{"line_number":326,"context_line":"    \"\"\"Returns the value of a glance image property."},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    :param context: context"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_c47e746a","line":325,"updated":"2015-01-10 03:37:03.000000000","message":"Is this function worth putting now ? All the places that we use get_glance_image_propert* now request atleast 2 properties.  Since we are changing all the current invocations, I guess any new consumer of this method always use get_glance_image_properties with just one property in the properties list.  I suggest it may be removed.","commit_id":"9415037e7f35d38dca7573ba3935d7584e35917c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3d8ebfbf4782e798859378c88032776d66ce7a3d","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    return requested_properties"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"def get_glance_image_property(context, image_uuid, property):"},{"line_number":326,"context_line":"    \"\"\"Returns the value of a glance image property."},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    :param context: context"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_ca34abae","line":325,"in_reply_to":"3a961159_c47e746a","updated":"2015-01-12 11:25:27.000000000","message":"+1 for removing","commit_id":"9415037e7f35d38dca7573ba3935d7584e35917c"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"495ed440866f03236e1c84386da517fbcea10754","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    return requested_properties"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"def get_glance_image_property(context, image_uuid, property):"},{"line_number":326,"context_line":"    \"\"\"Returns the value of a glance image property."},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    :param context: context"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_769c846b","line":325,"in_reply_to":"3a961159_c47e746a","updated":"2015-01-12 14:10:01.000000000","message":"Yes, thanks. If nobody uses it then it\u0027s just dead code isn\u0027t it?","commit_id":"9415037e7f35d38dca7573ba3935d7584e35917c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"995a05d1e6c913f7d961550d50144589c1ae92ad","unresolved":false,"context_lines":[{"line_number":303,"context_line":"    return data.virtual_size"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"def get_glance_image_properties(context, image_uuid, properties\u003d\"all\"):"},{"line_number":307,"context_line":"    \"\"\"Returns the values of several properties of a glance image"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    :param context: context"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a930d6b_fad33901","line":306,"updated":"2015-01-27 15:09:19.000000000","message":"nit: None is a bit more common default","commit_id":"d0446f1abbf0374da8059359fd985c52c95c4233"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"2c8115960a47383d2e6ef6c72efb4fe41d20ffbc","unresolved":false,"context_lines":[{"line_number":303,"context_line":"    return data.virtual_size"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"def get_glance_image_properties(context, image_uuid, properties\u003d\"all\"):"},{"line_number":307,"context_line":"    \"\"\"Returns the values of several properties of a glance image"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    :param context: context"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a930d6b_602eb7fc","line":306,"in_reply_to":"1a930d6b_fad33901","updated":"2015-01-27 17:27:04.000000000","message":"Yes it is, but I didn\u0027t like to use it because \u0027None\u0027 actually the opposite of the effect that is caused if you use the default. So I used \u0027all\u0027 as a sentinel instead. I\u0027d prefer to leave it like this.","commit_id":"d0446f1abbf0374da8059359fd985c52c95c4233"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"995a05d1e6c913f7d961550d50144589c1ae92ad","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    :param context: context"},{"line_number":310,"context_line":"    :param image_uuid: the UUID of the image in glance"},{"line_number":311,"context_line":"    :param properties: the properties whose values are required."},{"line_number":312,"context_line":"    :returns: a dict of the values of the properties"},{"line_number":313,"context_line":"               a property not on the glance metadata will have a value of None."},{"line_number":314,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a930d6b_ba0b717b","line":311,"updated":"2015-01-27 15:09:19.000000000","message":"default value should be described","commit_id":"d0446f1abbf0374da8059359fd985c52c95c4233"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"2c8115960a47383d2e6ef6c72efb4fe41d20ffbc","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    :param context: context"},{"line_number":310,"context_line":"    :param image_uuid: the UUID of the image in glance"},{"line_number":311,"context_line":"    :param properties: the properties whose values are required."},{"line_number":312,"context_line":"    :returns: a dict of the values of the properties"},{"line_number":313,"context_line":"               a property not on the glance metadata will have a value of None."},{"line_number":314,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a930d6b_40ec5bbb","line":311,"in_reply_to":"1a930d6b_ba0b717b","updated":"2015-01-27 17:27:04.000000000","message":"Done","commit_id":"d0446f1abbf0374da8059359fd985c52c95c4233"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ec015df0d4184302d3c42154b7d75241edafbf3a","unresolved":false,"context_lines":[{"line_number":312,"context_line":"    :returns: a dict of the values of the properties"},{"line_number":313,"context_line":"              a property not on the glance metadata will have a value of None."},{"line_number":314,"context_line":"              This argument is optional, if not specified all properties will"},{"line_number":315,"context_line":"              be returned."},{"line_number":316,"context_line":"    \"\"\""},{"line_number":317,"context_line":"    glance_service \u003d service.Service(version\u003d1, context\u003dcontext)"},{"line_number":318,"context_line":"    iproperties \u003d glance_service.show(image_uuid)[\u0027properties\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa81d914_5e7c1573","line":315,"updated":"2015-01-27 20:07:28.000000000","message":"Seems you updated a wrong description.","commit_id":"a65043ae19be14d36c4a3869894f384cc66471da"}],"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"c750f698083273e9fc91384b4d54c8a81b8d58d2","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    deploy_info \u003d _parse_deploy_info(task.node)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    image_uuid \u003d deploy_info[\u0027image_source\u0027]"},{"line_number":94,"context_line":"    boot_iso_uuid, kernel_uuid, ramdisk_uuid \u003d ("},{"line_number":95,"context_line":"        images.get_glance_image_properties(task.context,"},{"line_number":96,"context_line":"            image_uuid, [\u0027boot_iso\u0027, \u0027kernel_id\u0027, \u0027ramdisk_id\u0027]))"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_248d787d","line":94,"updated":"2015-01-10 03:37:03.000000000","message":"I guess we return a dictionary, not a tuple. This is wrong I guess.","commit_id":"9415037e7f35d38dca7573ba3935d7584e35917c"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"495ed440866f03236e1c84386da517fbcea10754","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    deploy_info \u003d _parse_deploy_info(task.node)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    image_uuid \u003d deploy_info[\u0027image_source\u0027]"},{"line_number":94,"context_line":"    boot_iso_uuid, kernel_uuid, ramdisk_uuid \u003d ("},{"line_number":95,"context_line":"        images.get_glance_image_properties(task.context,"},{"line_number":96,"context_line":"            image_uuid, [\u0027boot_iso\u0027, \u0027kernel_id\u0027, \u0027ramdisk_id\u0027]))"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_7673a44e","line":94,"in_reply_to":"3a961159_248d787d","updated":"2015-01-12 14:10:01.000000000","message":"I tried both ways - the function returning a dict or a list. List seems a bit nicer (that\u0027s what you pass in, after all), but I could see it either way.  I\u0027ll change it to a dict and see what people say.","commit_id":"9415037e7f35d38dca7573ba3935d7584e35917c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"8b093c0cdc7ab03385fb476cb163275ffe703b66","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    deploy_info \u003d _parse_deploy_info(task.node)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    image_uuid \u003d deploy_info[\u0027image_source\u0027]"},{"line_number":94,"context_line":"    boot_iso_uuid, kernel_uuid, ramdisk_uuid \u003d ("},{"line_number":95,"context_line":"        images.get_glance_image_properties(task.context,"},{"line_number":96,"context_line":"            image_uuid, [\u0027boot_iso\u0027, \u0027kernel_id\u0027, \u0027ramdisk_id\u0027]))"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_c187adb3","line":94,"updated":"2015-01-26 14:09:55.000000000","message":"get_glance_image_properties() returns a dict property:value. But here only keys extracted:\n \u003e\u003e\u003e boot_iso_uuid, kernel_uuid, ramdisk_uuid \u003d {\u0027boot_iso_uuid\u0027: \u0027a\u0027,   \u0027kernel_uuid\u0027: \u0027b\u0027, \u0027ramdisk_uuid\u0027: \u0027c\u0027} \n\u003e\u003e\u003e boot_iso_uuid, kernel_uuid, ramdisk_uuid\n(\u0027kernel_uuid\u0027, \u0027boot_iso_uuid\u0027, \u0027ramdisk_uuid\u0027)","commit_id":"83da074360ded02f49ea50d09e8511b5ebe929eb"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"c0cbbcf1afeed9f32ed5520f07aa41e07af24cf6","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    deploy_info \u003d _parse_deploy_info(task.node)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    image_uuid \u003d deploy_info[\u0027image_source\u0027]"},{"line_number":94,"context_line":"    boot_iso_uuid, kernel_uuid, ramdisk_uuid \u003d ("},{"line_number":95,"context_line":"        images.get_glance_image_properties(task.context,"},{"line_number":96,"context_line":"            image_uuid, [\u0027boot_iso\u0027, \u0027kernel_id\u0027, \u0027ramdisk_id\u0027]))"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_9c5b48f5","line":94,"in_reply_to":"1a930d6b_c187adb3","updated":"2015-01-26 14:17:49.000000000","message":"Thanks Yuriy. Will fix asap.","commit_id":"83da074360ded02f49ea50d09e8511b5ebe929eb"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b0249fa2e03abf2b5a03d150bde1f5985a3d80cb","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    LOG.debug(\"Trying to get a boot ISO to boot the baremetal node\")"},{"line_number":91,"context_line":"    deploy_info \u003d _parse_deploy_info(task.node)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    image_uuid \u003d deploy_info[\u0027image_source\u0027]"},{"line_number":94,"context_line":"    glance_properties \u003d ("},{"line_number":95,"context_line":"        images.get_glance_image_properties(task.context,"},{"line_number":96,"context_line":"            image_uuid, [\u0027boot_iso\u0027, \u0027kernel_id\u0027, \u0027ramdisk_id\u0027]))"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a930d6b_116d5504","line":93,"updated":"2015-01-27 12:15:12.000000000","message":"I\u0027d prefer it was left as image_href as now it can be already not just uuid but glance://uuid","commit_id":"d0446f1abbf0374da8059359fd985c52c95c4233"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"995a05d1e6c913f7d961550d50144589c1ae92ad","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    LOG.debug(\"Trying to get a boot ISO to boot the baremetal node\")"},{"line_number":91,"context_line":"    deploy_info \u003d _parse_deploy_info(task.node)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    image_uuid \u003d deploy_info[\u0027image_source\u0027]"},{"line_number":94,"context_line":"    glance_properties \u003d ("},{"line_number":95,"context_line":"        images.get_glance_image_properties(task.context,"},{"line_number":96,"context_line":"            image_uuid, [\u0027boot_iso\u0027, \u0027kernel_id\u0027, \u0027ramdisk_id\u0027]))"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a930d6b_fa2899e3","line":93,"in_reply_to":"1a930d6b_116d5504","updated":"2015-01-27 15:09:19.000000000","message":"+1","commit_id":"d0446f1abbf0374da8059359fd985c52c95c4233"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"2c8115960a47383d2e6ef6c72efb4fe41d20ffbc","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    LOG.debug(\"Trying to get a boot ISO to boot the baremetal node\")"},{"line_number":91,"context_line":"    deploy_info \u003d _parse_deploy_info(task.node)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    image_uuid \u003d deploy_info[\u0027image_source\u0027]"},{"line_number":94,"context_line":"    glance_properties \u003d ("},{"line_number":95,"context_line":"        images.get_glance_image_properties(task.context,"},{"line_number":96,"context_line":"            image_uuid, [\u0027boot_iso\u0027, \u0027kernel_id\u0027, \u0027ramdisk_id\u0027]))"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a930d6b_60631742","line":93,"in_reply_to":"1a930d6b_fa2899e3","updated":"2015-01-27 17:27:04.000000000","message":"Done","commit_id":"d0446f1abbf0374da8059359fd985c52c95c4233"}],"ironic/tests/drivers/ilo/test_deploy.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b0249fa2e03abf2b5a03d150bde1f5985a3d80cb","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        tempfile_mock.return_value \u003d mock_file_handle"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        deploy_info_mock.return_value \u003d {\u0027image_source\u0027: \u0027image-uuid\u0027}"},{"line_number":125,"context_line":"        image_props_mock.side_effect \u003d [{\u0027boot_iso\u0027: None,"},{"line_number":126,"context_line":"                                         \u0027kernel_id\u0027: \u0027kernel_uuid\u0027,"},{"line_number":127,"context_line":"                                         \u0027ramdisk_id\u0027: \u0027ramdisk_uuid\u0027}]"},{"line_number":128,"context_line":"        boot_object_name_mock.return_value \u003d \u0027abcdef\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a930d6b_71ae992f","line":125,"updated":"2015-01-27 12:15:12.000000000","message":"Why not use return_value?","commit_id":"d0446f1abbf0374da8059359fd985c52c95c4233"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"2c8115960a47383d2e6ef6c72efb4fe41d20ffbc","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        tempfile_mock.return_value \u003d mock_file_handle"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        deploy_info_mock.return_value \u003d {\u0027image_source\u0027: \u0027image-uuid\u0027}"},{"line_number":125,"context_line":"        image_props_mock.side_effect \u003d [{\u0027boot_iso\u0027: None,"},{"line_number":126,"context_line":"                                         \u0027kernel_id\u0027: \u0027kernel_uuid\u0027,"},{"line_number":127,"context_line":"                                         \u0027ramdisk_id\u0027: \u0027ramdisk_uuid\u0027}]"},{"line_number":128,"context_line":"        boot_object_name_mock.return_value \u003d \u0027abcdef\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a930d6b_809ba316","line":125,"in_reply_to":"1a930d6b_71ae992f","updated":"2015-01-27 17:27:04.000000000","message":"I was just copying the way it was in the test before. I did notice that this test was different but didn\u0027t want to change it in this patch. I\u0027ll see if it\u0027s just a one-line change I\u0027ll do it but otherwise I\u0027d prefer to leave that to a separate patch.","commit_id":"d0446f1abbf0374da8059359fd985c52c95c4233"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"c88859ceac0b92ffe96d990182cda49052ade6b2","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            boot_iso_actual \u003d ilo_deploy._get_boot_iso(task, \u0027root-uuid\u0027)"},{"line_number":134,"context_line":"            deploy_info_mock.assert_called_once_with(task.node)"},{"line_number":135,"context_line":"            image_props_mock.assert_any_call(task.context, \u0027image-uuid\u0027,"},{"line_number":136,"context_line":"                [\u0027boot_iso\u0027, \u0027kernel_id\u0027, \u0027ramdisk_id\u0027])"},{"line_number":137,"context_line":"            boot_object_name_mock.assert_called_once_with(task.node)"},{"line_number":138,"context_line":"            create_boot_iso_mock.assert_called_once_with(task.context,"},{"line_number":139,"context_line":"                    \u0027tmpfile\u0027, \u0027kernel_uuid\u0027, \u0027ramdisk_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa81d914_b8aa7bd2","line":136,"updated":"2015-01-28 02:04:27.000000000","message":"This should be assert_called_once_with to ensure it was only called once (since that\u0027s the point of this patch).\n\nI\u0027ve submitted a follow-up patch to fix this so we can keep moving on this review: if you happen to fix it yourself, ping me and I\u0027ll abandon it.","commit_id":"d18a8cadbcdb4c0a0513b060e00a1753a34d5087"}],"ironic/tests/test_images.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"65b99344bee93220ccce137c562edbf5cc7cbb99","unresolved":false,"context_lines":[{"line_number":473,"context_line":"                          \u0027p3\u0027: None}, ret_val)"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    @mock.patch.object(image_service, \u0027Service\u0027)"},{"line_number":476,"context_line":"    def test_get_glance_image_properties(self, image_service_mock):"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        prop_dict \u003d {\u0027properties\u0027: {\u0027p1\u0027: \u0027v1\u0027,"},{"line_number":479,"context_line":"                                    \u0027p2\u0027: \u0027v2\u0027}}"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_7996b340","line":476,"updated":"2015-01-26 12:03:40.000000000","message":"Duplicate method name, causing pep8 error","commit_id":"b053bd87d9748f04008b843389c69fe13c4616bd"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"4494785248bbd6f886c074e59e474d29b7a10a41","unresolved":false,"context_lines":[{"line_number":473,"context_line":"                          \u0027p3\u0027: None}, ret_val)"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    @mock.patch.object(image_service, \u0027Service\u0027)"},{"line_number":476,"context_line":"    def test_get_glance_image_properties(self, image_service_mock):"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        prop_dict \u003d {\u0027properties\u0027: {\u0027p1\u0027: \u0027v1\u0027,"},{"line_number":479,"context_line":"                                    \u0027p2\u0027: \u0027v2\u0027}}"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_48512235","line":476,"in_reply_to":"1a930d6b_7996b340","updated":"2015-01-26 13:08:07.000000000","message":"Poor quality rebasing by me, sorry. We don\u0027t need to change this method any more anyway - it was from the previous version of the parent patch.  Fixed.","commit_id":"b053bd87d9748f04008b843389c69fe13c4616bd"}]}