)]}'
{"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":1249,"context_line":"#swift_max_retries\u003d2"},{"line_number":1250,"context_line":""},{"line_number":1251,"context_line":""},{"line_number":1252,"context_line":"[vbox]"},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"#"},{"line_number":1255,"context_line":"# Options defined in ironic.drivers.modules.vbox"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a961159_12d7daef","line":1252,"updated":"2015-01-19 21:34:19.000000000","message":"is vbox an accepted abbreviation for VirtualBox? Maybe we should spell it out \u0027virtualbox\u0027?","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"068a8d4b597993e63744b3ec0da7756355e32f36","unresolved":false,"context_lines":[{"line_number":1249,"context_line":"#swift_max_retries\u003d2"},{"line_number":1250,"context_line":""},{"line_number":1251,"context_line":""},{"line_number":1252,"context_line":"[vbox]"},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"#"},{"line_number":1255,"context_line":"# Options defined in ironic.drivers.modules.vbox"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a961159_a5b23047","line":1252,"in_reply_to":"3a961159_12d7daef","updated":"2015-01-20 10:55:40.000000000","message":"Hmm personally I\u0027m good with \"vbox\", that\u0027s how I always referred to VirtualBox. But if it\u0027s causing confusion we should yes write it as  virtualbox","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":1249,"context_line":"#swift_max_retries\u003d2"},{"line_number":1250,"context_line":""},{"line_number":1251,"context_line":""},{"line_number":1252,"context_line":"[vbox]"},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"#"},{"line_number":1255,"context_line":"# Options defined in ironic.drivers.modules.vbox"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a961159_222e2c43","line":1252,"in_reply_to":"3a961159_a5b23047","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":1255,"context_line":"# Options defined in ironic.drivers.modules.vbox"},{"line_number":1256,"context_line":"#"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"# Port on which vbox web service is listening. (integer value)"},{"line_number":1259,"context_line":"#vbox_port\u003d18083"},{"line_number":1260,"context_line":""},{"line_number":1261,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a961159_72057e78","line":1258,"updated":"2015-01-19 21:34:19.000000000","message":"should we spell out Virtualbox here?","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":1255,"context_line":"# Options defined in ironic.drivers.modules.vbox"},{"line_number":1256,"context_line":"#"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"# Port on which vbox web service is listening. (integer value)"},{"line_number":1259,"context_line":"#vbox_port\u003d18083"},{"line_number":1260,"context_line":""},{"line_number":1261,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a961159_42233858","line":1258,"in_reply_to":"3a961159_72057e78","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"#"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"# Port on which vbox web service is listening. (integer value)"},{"line_number":1259,"context_line":"#vbox_port\u003d18083"},{"line_number":1260,"context_line":""},{"line_number":1261,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a961159_d2f472d2","line":1259,"updated":"2015-01-19 21:34:19.000000000","message":"I\u0027d prefer if it was just \u0027port\u0027","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"#"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"# Port on which vbox web service is listening. (integer value)"},{"line_number":1259,"context_line":"#vbox_port\u003d18083"},{"line_number":1260,"context_line":""},{"line_number":1261,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a961159_62283434","line":1259,"in_reply_to":"3a961159_a544f047","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"068a8d4b597993e63744b3ec0da7756355e32f36","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"#"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"# Port on which vbox web service is listening. (integer value)"},{"line_number":1259,"context_line":"#vbox_port\u003d18083"},{"line_number":1260,"context_line":""},{"line_number":1261,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a961159_a544f047","line":1259,"in_reply_to":"3a961159_d2f472d2","updated":"2015-01-20 10:55:40.000000000","message":"+1","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"}],"ironic/common/exception.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":493,"context_line":"                \"File system %(fs)s is not supported.\")"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"class VboxOperationError(IronicException):"},{"line_number":497,"context_line":"    message \u003d _(\"VirtualBox Operation \u0027%(operation)s\u0027 failed, \""},{"line_number":498,"context_line":"                \"error: %(error)s\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_4d5c6781","line":496,"updated":"2015-01-19 21:34:19.000000000","message":"please make sure that you are consistent, \u0027Vbox\u0027 or \u0027VBox\u0027 throughout.","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"e5efab595257041b02562c01180b707118fdbbdf","unresolved":false,"context_lines":[{"line_number":493,"context_line":"                \"File system %(fs)s is not supported.\")"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"class VboxOperationError(IronicException):"},{"line_number":497,"context_line":"    message \u003d _(\"VirtualBox Operation \u0027%(operation)s\u0027 failed, \""},{"line_number":498,"context_line":"                \"error: %(error)s\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_d2ee2622","line":496,"in_reply_to":"1a930d6b_3cdbc61c","updated":"2015-01-21 16:06:11.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":493,"context_line":"                \"File system %(fs)s is not supported.\")"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"class VboxOperationError(IronicException):"},{"line_number":497,"context_line":"    message \u003d _(\"VirtualBox Operation \u0027%(operation)s\u0027 failed, \""},{"line_number":498,"context_line":"                \"error: %(error)s\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_e21344ff","line":496,"in_reply_to":"3a961159_4d5c6781","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c1dfc412a665e0b0cb6b0dd93665b2bb4006bcae","unresolved":false,"context_lines":[{"line_number":493,"context_line":"                \"File system %(fs)s is not supported.\")"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"class VboxOperationError(IronicException):"},{"line_number":497,"context_line":"    message \u003d _(\"VirtualBox Operation \u0027%(operation)s\u0027 failed, \""},{"line_number":498,"context_line":"                \"error: %(error)s\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_3cdbc61c","line":496,"in_reply_to":"3a961159_e21344ff","updated":"2015-01-21 13:50:48.000000000","message":"nit: it seems to me that we use *Failed postfix more often than *Error","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":494,"context_line":""},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"class VboxOperationError(IronicException):"},{"line_number":497,"context_line":"    message \u003d _(\"VirtualBox Operation \u0027%(operation)s\u0027 failed, \""},{"line_number":498,"context_line":"                \"error: %(error)s\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_921caa68","line":497,"updated":"2015-01-19 21:34:19.000000000","message":"s/Operation/operation/\n\nI\u0027d also prefer that this ends a sentence. Ie, s/failed,/s/failed./","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":494,"context_line":""},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"class VboxOperationError(IronicException):"},{"line_number":497,"context_line":"    message \u003d _(\"VirtualBox Operation \u0027%(operation)s\u0027 failed, \""},{"line_number":498,"context_line":"                \"error: %(error)s\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_42da584c","line":497,"in_reply_to":"3a961159_921caa68","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"}],"ironic/drivers/agent.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                    reason\u003d_(\"Unable to import pyremotevbox library\"))"},{"line_number":104,"context_line":"        self.power \u003d vbox.VBoxPower()"},{"line_number":105,"context_line":"        self.management \u003d vbox.VBoxManagement()"},{"line_number":106,"context_line":"        self.deploy \u003d agent.AgentDeploy()"},{"line_number":107,"context_line":"        self.vendor \u003d agent.AgentVendorInterface()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_523322c4","line":106,"updated":"2015-01-19 21:34:19.000000000","message":"I\u0027d prefer if you moved this one line up, after .power and before .management, since that\u0027s the ordering used for the rest of the drivers here. (Might as well be consistent, makes it easier to compare.)","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                    reason\u003d_(\"Unable to import pyremotevbox library\"))"},{"line_number":104,"context_line":"        self.power \u003d vbox.VBoxPower()"},{"line_number":105,"context_line":"        self.management \u003d vbox.VBoxManagement()"},{"line_number":106,"context_line":"        self.deploy \u003d agent.AgentDeploy()"},{"line_number":107,"context_line":"        self.vendor \u003d agent.AgentVendorInterface()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_82e36005","line":106,"in_reply_to":"3a961159_523322c4","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"}],"ironic/drivers/fake.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    \"\"\"Fake VirtualBox driver.\"\"\""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def __init__(self):"},{"line_number":181,"context_line":"        self.power \u003d vbox.VBoxPower()"},{"line_number":182,"context_line":"        self.deploy \u003d fake.FakeDeploy()"},{"line_number":183,"context_line":"        self.management \u003d vbox.VBoxManagement()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_722d7e45","line":181,"updated":"2015-01-19 21:34:19.000000000","message":"shouldn\u0027t we check for pyremotevbox library?","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    \"\"\"Fake VirtualBox driver.\"\"\""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def __init__(self):"},{"line_number":181,"context_line":"        self.power \u003d vbox.VBoxPower()"},{"line_number":182,"context_line":"        self.deploy \u003d fake.FakeDeploy()"},{"line_number":183,"context_line":"        self.management \u003d vbox.VBoxManagement()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_22bc6cdb","line":181,"in_reply_to":"3a961159_0555c4c1","updated":"2015-01-20 14:50:10.000000000","message":"All the tests use fake_vbox driver.  If we were to check for pyremotevbox library, we wouldn\u0027t be able to run unit tests without pyremotevbox library.","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6a4a302e4a37c07fd18cdf126cca644fea797e0d","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    \"\"\"Fake VirtualBox driver.\"\"\""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def __init__(self):"},{"line_number":181,"context_line":"        self.power \u003d vbox.VBoxPower()"},{"line_number":182,"context_line":"        self.deploy \u003d fake.FakeDeploy()"},{"line_number":183,"context_line":"        self.management \u003d vbox.VBoxManagement()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_48b19900","line":181,"in_reply_to":"3a961159_22bc6cdb","updated":"2015-01-20 15:21:12.000000000","message":"The tests will work. Take a look at [1]; you set things up there so it adds the library (with mocks) :-)\n\n[1] https://github.com/openstack/ironic/blob/master/ironic/tests/drivers/third_party_driver_mocks.py","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"e5efab595257041b02562c01180b707118fdbbdf","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    \"\"\"Fake VirtualBox driver.\"\"\""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def __init__(self):"},{"line_number":181,"context_line":"        self.power \u003d vbox.VBoxPower()"},{"line_number":182,"context_line":"        self.deploy \u003d fake.FakeDeploy()"},{"line_number":183,"context_line":"        self.management \u003d vbox.VBoxManagement()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_f2a5e204","line":181,"in_reply_to":"3a961159_48b19900","updated":"2015-01-21 16:06:11.000000000","message":"Thanks for the info.  I didn\u0027t know this. Got it only after I saw the comment on unit test.","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"068a8d4b597993e63744b3ec0da7756355e32f36","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    \"\"\"Fake VirtualBox driver.\"\"\""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def __init__(self):"},{"line_number":181,"context_line":"        self.power \u003d vbox.VBoxPower()"},{"line_number":182,"context_line":"        self.deploy \u003d fake.FakeDeploy()"},{"line_number":183,"context_line":"        self.management \u003d vbox.VBoxManagement()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_0555c4c1","line":181,"in_reply_to":"3a961159_722d7e45","updated":"2015-01-20 10:55:40.000000000","message":"+1 \n\n if not importutils.try_import(\u0027pyremotebox\u0027):\n     raise exception.DriverLoadError(\n                 driver\u003dself.__class__.__name__, \n                 reason\u003d_(\u0027Unable to import pyremotebox library\u0027))","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"}],"ironic/drivers/modules/vbox.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"855caacb1c8467424ded2e4610f4902d6d7c96d2","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    \u0027vbox_username\u0027: _(\"Username for the Virtualbox Host. \""},{"line_number":72,"context_line":"                       \"Default value is \u0027\u0027. Optional.\"),"},{"line_number":73,"context_line":"    \u0027vbox_password\u0027: _(\"Password for Virtualbox Host user. \""},{"line_number":74,"context_line":"                       \"Default value is \u0027\u0027. Optional.\"),"},{"line_number":75,"context_line":"}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES.copy()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_25a2c04b","line":74,"updated":"2015-01-12 12:07:53.000000000","message":"I wonder whether the port should be a config or a property (defaulting to 18083)\n\nSince we already have host as a property I think it would make sense to make port another property. I\u0027m also thinking about the conductor take over, in case we have 2 conductors and each one has a diff vbox_port configured, the take over wouldn\u0027t work.","commit_id":"71356f14b20292b37339f381ab60466d7e250b6b"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"39f4801608a18a8b9bc28c298bd80dcca79c5aa2","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    \u0027vbox_username\u0027: _(\"Username for the Virtualbox Host. \""},{"line_number":72,"context_line":"                       \"Default value is \u0027\u0027. Optional.\"),"},{"line_number":73,"context_line":"    \u0027vbox_password\u0027: _(\"Password for Virtualbox Host user. \""},{"line_number":74,"context_line":"                       \"Default value is \u0027\u0027. Optional.\"),"},{"line_number":75,"context_line":"}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES.copy()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_4b1a7a19","line":74,"in_reply_to":"3a961159_25a2c04b","updated":"2015-01-12 14:25:36.000000000","message":"Done","commit_id":"71356f14b20292b37339f381ab60466d7e250b6b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"855caacb1c8467424ded2e4610f4902d6d7c96d2","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            _run_vbox_method(task.node, \u0027set_power_state\u0027, \u0027start\u0027)"},{"line_number":201,"context_line":"        elif target_state \u003d\u003d states.REBOOT:"},{"line_number":202,"context_line":"            _run_vbox_method(task.node, \u0027set_power_state\u0027, \u0027stop\u0027)"},{"line_number":203,"context_line":"            _run_vbox_method(task.node, \u0027set_power_state\u0027, \u0027start\u0027)"},{"line_number":204,"context_line":"        else:"},{"line_number":205,"context_line":"            msg \u003d _(\"\u0027set_power_state\u0027 called with invalid power \""},{"line_number":206,"context_line":"                    \"state \u0027%s\u0027\") % target_state"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_45ceec5c","line":203,"updated":"2015-01-12 12:07:53.000000000","message":"nit: self.reboot(task) ?","commit_id":"71356f14b20292b37339f381ab60466d7e250b6b"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"39f4801608a18a8b9bc28c298bd80dcca79c5aa2","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            _run_vbox_method(task.node, \u0027set_power_state\u0027, \u0027start\u0027)"},{"line_number":201,"context_line":"        elif target_state \u003d\u003d states.REBOOT:"},{"line_number":202,"context_line":"            _run_vbox_method(task.node, \u0027set_power_state\u0027, \u0027stop\u0027)"},{"line_number":203,"context_line":"            _run_vbox_method(task.node, \u0027set_power_state\u0027, \u0027start\u0027)"},{"line_number":204,"context_line":"        else:"},{"line_number":205,"context_line":"            msg \u003d _(\"\u0027set_power_state\u0027 called with invalid power \""},{"line_number":206,"context_line":"                    \"state \u0027%s\u0027\") % target_state"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_8b1462ea","line":203,"in_reply_to":"3a961159_45ceec5c","updated":"2015-01-12 14:25:36.000000000","message":"Done","commit_id":"71356f14b20292b37339f381ab60466d7e250b6b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"855caacb1c8467424ded2e4610f4902d6d7c96d2","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            _run_vbox_method(task.node, \u0027set_boot_device\u0027,"},{"line_number":294,"context_line":"                             \u0027set_boot_device\u0027, vbox_boot_device)"},{"line_number":295,"context_line":"        except pyremotevbox_exc.VmInWrongPowerState as exc:"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"            # NOTE(rameshg87): We cannot change the boot device when the vm"},{"line_number":298,"context_line":"            # is powered on. This is a VirtualBox limitation. We just log"},{"line_number":299,"context_line":"            # the error silently and return because throwing error will cause"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_6583e8a9","line":296,"updated":"2015-01-12 12:07:53.000000000","message":"nit: useless empty line","commit_id":"71356f14b20292b37339f381ab60466d7e250b6b"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"39f4801608a18a8b9bc28c298bd80dcca79c5aa2","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            _run_vbox_method(task.node, \u0027set_boot_device\u0027,"},{"line_number":294,"context_line":"                             \u0027set_boot_device\u0027, vbox_boot_device)"},{"line_number":295,"context_line":"        except pyremotevbox_exc.VmInWrongPowerState as exc:"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"            # NOTE(rameshg87): We cannot change the boot device when the vm"},{"line_number":298,"context_line":"            # is powered on. This is a VirtualBox limitation. We just log"},{"line_number":299,"context_line":"            # the error silently and return because throwing error will cause"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_ebda464a","line":296,"in_reply_to":"3a961159_6583e8a9","updated":"2015-01-12 14:25:36.000000000","message":"Done","commit_id":"71356f14b20292b37339f381ab60466d7e250b6b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"068a8d4b597993e63744b3ec0da7756355e32f36","unresolved":false,"context_lines":[{"line_number":43,"context_line":"VBOX_TO_IRONIC_DEVICE_MAPPING \u003d {v: k"},{"line_number":44,"context_line":"                       for k, v in IRONIC_TO_VBOX_DEVICE_MAPPING.items()}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"IRONIC_TO_VBOX_POWER_MAPPING \u003d {"},{"line_number":47,"context_line":"                                states.POWER_OFF: \u0027PoweredOff\u0027,"},{"line_number":48,"context_line":"                                states.POWER_ON: \u0027Running\u0027,"},{"line_number":49,"context_line":"                                states.ERROR: \u0027Error\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_25a1e046","line":46,"updated":"2015-01-20 10:55:40.000000000","message":"Seems that IRONIC_TO_VBOX_POWER_MAPPING, is only used to build VBOX_TO_IRONIC_POWER_MAPPING. Wouldn\u0027t it be easier to make VBOX_TO_IRONIC_POWER_MAPPING directly from the states?\n\nIn the future if we need the inverse, we can create by inverting the key and value of VBOX_TO_IRONIC_POWER_MAPPING.\n\ne.g\n\n VBOX_TO_IRONIC_POWER_MAPPING  \u003d {\n     \u0027PowerOff\u0027: states.POWER_OFF,\n     \u0027Running\u0027: states.POWER_ON,\n     ...","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":43,"context_line":"VBOX_TO_IRONIC_DEVICE_MAPPING \u003d {v: k"},{"line_number":44,"context_line":"                       for k, v in IRONIC_TO_VBOX_DEVICE_MAPPING.items()}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"IRONIC_TO_VBOX_POWER_MAPPING \u003d {"},{"line_number":47,"context_line":"                                states.POWER_OFF: \u0027PoweredOff\u0027,"},{"line_number":48,"context_line":"                                states.POWER_ON: \u0027Running\u0027,"},{"line_number":49,"context_line":"                                states.ERROR: \u0027Error\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_c272c849","line":46,"in_reply_to":"3a961159_25a1e046","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":51,"context_line":"VBOX_TO_IRONIC_POWER_MAPPING \u003d {v: k"},{"line_number":52,"context_line":"                       for k, v in IRONIC_TO_VBOX_POWER_MAPPING.items()}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"opts \u003d ["},{"line_number":56,"context_line":"    cfg.IntOpt(\u0027vbox_port\u0027,"},{"line_number":57,"context_line":"               default\u003d18083,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_d2ab921d","line":54,"updated":"2015-01-19 21:34:19.000000000","message":"I\u0027m not sure we need another blank line here?","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":51,"context_line":"VBOX_TO_IRONIC_POWER_MAPPING \u003d {v: k"},{"line_number":52,"context_line":"                       for k, v in IRONIC_TO_VBOX_POWER_MAPPING.items()}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"opts \u003d ["},{"line_number":56,"context_line":"    cfg.IntOpt(\u0027vbox_port\u0027,"},{"line_number":57,"context_line":"               default\u003d18083,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_e26fc45e","line":54,"in_reply_to":"3a961159_d2ab921d","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"REQUIRED_PROPERTIES \u003d {"},{"line_number":66,"context_line":"    \u0027vbox_vmname\u0027: _(\"Name of the VM in VirtualBox. Required.\"),"},{"line_number":67,"context_line":"    \u0027vbox_host\u0027: _(\"IP address or hostname of the VirtualBox Host. Required\")"},{"line_number":68,"context_line":"}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"OPTIONAL_PROPERTIES \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_b2136664","line":67,"updated":"2015-01-19 21:34:19.000000000","message":"s/Host/host/. Or should it be \u0027Host\u0027? I see you have done that for the optional properties too.\n\ns/Required/Required./","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"REQUIRED_PROPERTIES \u003d {"},{"line_number":66,"context_line":"    \u0027vbox_vmname\u0027: _(\"Name of the VM in VirtualBox. Required.\"),"},{"line_number":67,"context_line":"    \u0027vbox_host\u0027: _(\"IP address or hostname of the VirtualBox Host. Required\")"},{"line_number":68,"context_line":"}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"OPTIONAL_PROPERTIES \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_02b3f0ec","line":67,"in_reply_to":"3a961159_b2136664","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":68,"context_line":"}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"OPTIONAL_PROPERTIES \u003d {"},{"line_number":71,"context_line":"    \u0027vbox_username\u0027: _(\"Username for the Virtualbox Host. \""},{"line_number":72,"context_line":"                       \"Default value is \u0027\u0027. Optional.\"),"},{"line_number":73,"context_line":"    \u0027vbox_password\u0027: _(\"Password for Virtualbox Host user. \""},{"line_number":74,"context_line":"                       \"Default value is \u0027\u0027. Optional.\"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_ed3273f2","line":71,"updated":"2015-01-19 21:34:19.000000000","message":"s/Virtualbox/VirtualBox/\n\nditto for the strings below (and everywhere else you have \u0027Virtualbox\u0027).","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":68,"context_line":"}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"OPTIONAL_PROPERTIES \u003d {"},{"line_number":71,"context_line":"    \u0027vbox_username\u0027: _(\"Username for the Virtualbox Host. \""},{"line_number":72,"context_line":"                       \"Default value is \u0027\u0027. Optional.\"),"},{"line_number":73,"context_line":"    \u0027vbox_password\u0027: _(\"Password for Virtualbox Host user. \""},{"line_number":74,"context_line":"                       \"Default value is \u0027\u0027. Optional.\"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_82c60049","line":71,"in_reply_to":"3a961159_ed3273f2","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    \u0027vbox_password\u0027: _(\"Password for Virtualbox Host user. \""},{"line_number":74,"context_line":"                       \"Default value is \u0027\u0027. Optional.\"),"},{"line_number":75,"context_line":"    \u0027vbox_port\u0027: _(\"Port on which vbox web service is listening. \""},{"line_number":76,"context_line":"                   \"Default value is 18083. Optional.\"),"},{"line_number":77,"context_line":"}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES.copy()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_0d47bf4d","line":76,"updated":"2015-01-19 21:34:19.000000000","message":"Is that the default value or does it default to the corresponding config value?","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6a4a302e4a37c07fd18cdf126cca644fea797e0d","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    \u0027vbox_password\u0027: _(\"Password for Virtualbox Host user. \""},{"line_number":74,"context_line":"                       \"Default value is \u0027\u0027. Optional.\"),"},{"line_number":75,"context_line":"    \u0027vbox_port\u0027: _(\"Port on which vbox web service is listening. \""},{"line_number":76,"context_line":"                   \"Default value is 18083. Optional.\"),"},{"line_number":77,"context_line":"}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES.copy()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_a88e7d30","line":76,"in_reply_to":"3a961159_022850ed","updated":"2015-01-20 15:21:12.000000000","message":"The string should probably be updated to reflect that.","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    \u0027vbox_password\u0027: _(\"Password for Virtualbox Host user. \""},{"line_number":74,"context_line":"                       \"Default value is \u0027\u0027. Optional.\"),"},{"line_number":75,"context_line":"    \u0027vbox_port\u0027: _(\"Port on which vbox web service is listening. \""},{"line_number":76,"context_line":"                   \"Default value is 18083. Optional.\"),"},{"line_number":77,"context_line":"}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES.copy()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_022850ed","line":76,"in_reply_to":"3a961159_0d47bf4d","updated":"2015-01-20 14:50:10.000000000","message":"Defaults to the corresponding config value\u0027s default.","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"e5efab595257041b02562c01180b707118fdbbdf","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    \u0027vbox_password\u0027: _(\"Password for Virtualbox Host user. \""},{"line_number":74,"context_line":"                       \"Default value is \u0027\u0027. Optional.\"),"},{"line_number":75,"context_line":"    \u0027vbox_port\u0027: _(\"Port on which vbox web service is listening. \""},{"line_number":76,"context_line":"                   \"Default value is 18083. Optional.\"),"},{"line_number":77,"context_line":"}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES.copy()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_92bbbe0d","line":76,"in_reply_to":"3a961159_a88e7d30","updated":"2015-01-21 16:06:11.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"def parse_driver_info(node):"},{"line_number":84,"context_line":"    \"\"\"Gets the driver specific Node deployment info."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    This method validates whether the \u0027driver_info\u0027 property of the"},{"line_number":87,"context_line":"    supplied node contains the required information for this driver."}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_cd63f7dc","line":84,"updated":"2015-01-19 21:34:19.000000000","message":"deployment?","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"def parse_driver_info(node):"},{"line_number":84,"context_line":"    \"\"\"Gets the driver specific Node deployment info."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    This method validates whether the \u0027driver_info\u0027 property of the"},{"line_number":87,"context_line":"    supplied node contains the required information for this driver."}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_4232585f","line":84,"in_reply_to":"3a961159_cd63f7dc","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4b80be9fc40d150154a5b7f443c3fe8967584a01","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    :returns: a dict containing information from driver_info"},{"line_number":91,"context_line":"        and default values."},{"line_number":92,"context_line":"    :raises: MissingParameterValue if some required parameters are missing."},{"line_number":93,"context_line":"    :raises: InvalidParameterValue on invalid inputs."},{"line_number":94,"context_line":"    \"\"\""},{"line_number":95,"context_line":"    info \u003d node.driver_info"},{"line_number":96,"context_line":"    d_info \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_25d64f54","line":93,"updated":"2015-01-19 22:23:06.000000000","message":"this is bugging me. Maybe it is a nit, but I\u0027m worried that this will be copy/pasted forever.\n\n\u0027invalid inputs\u0027 doesn\u0027t really say much when \u0027node\u0027 is the only argument to this method. Maybe you can grep through the code and find a description that makes more sense.","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    :returns: a dict containing information from driver_info"},{"line_number":91,"context_line":"        and default values."},{"line_number":92,"context_line":"    :raises: MissingParameterValue if some required parameters are missing."},{"line_number":93,"context_line":"    :raises: InvalidParameterValue on invalid inputs."},{"line_number":94,"context_line":"    \"\"\""},{"line_number":95,"context_line":"    info \u003d node.driver_info"},{"line_number":96,"context_line":"    d_info \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_020f708c","line":93,"in_reply_to":"3a961159_25d64f54","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        except KeyError:"},{"line_number":103,"context_line":"            error_msgs.append(_(\"\u0027%s\u0027 not supplied to VBoxDriver.\") % param)"},{"line_number":104,"context_line":"    if error_msgs:"},{"line_number":105,"context_line":"        msg \u003d (_(\"The following parameters were mising while parsing \""},{"line_number":106,"context_line":"                 \"driver_info:\\n%s\") % \"\\n\".join(error_msgs))"},{"line_number":107,"context_line":"        raise exception.MissingParameterValue(msg)"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_2db71b23","line":105,"updated":"2015-01-19 21:34:19.000000000","message":"typo: mising\n\nI\u0027m not sure that \u0027parsing\u0027 is something to mention to the user since there really isn\u0027t any parsing going on here.","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        except KeyError:"},{"line_number":103,"context_line":"            error_msgs.append(_(\"\u0027%s\u0027 not supplied to VBoxDriver.\") % param)"},{"line_number":104,"context_line":"    if error_msgs:"},{"line_number":105,"context_line":"        msg \u003d (_(\"The following parameters were mising while parsing \""},{"line_number":106,"context_line":"                 \"driver_info:\\n%s\") % \"\\n\".join(error_msgs))"},{"line_number":107,"context_line":"        raise exception.MissingParameterValue(msg)"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_82228000","line":105,"in_reply_to":"3a961159_2db71b23","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    if error_msgs:"},{"line_number":105,"context_line":"        msg \u003d (_(\"The following parameters were mising while parsing \""},{"line_number":106,"context_line":"                 \"driver_info:\\n%s\") % \"\\n\".join(error_msgs))"},{"line_number":107,"context_line":"        raise exception.MissingParameterValue(msg)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    for param in OPTIONAL_PROPERTIES:"},{"line_number":110,"context_line":"        if param in info:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_adb5cbee","line":107,"updated":"2015-01-19 21:34:19.000000000","message":"If you have more than one missing parameter, this message is going to look ugly. \u0027...A not supplied to VBoxDriver. B not supplied to VBoxDriver.\u0027","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    if error_msgs:"},{"line_number":105,"context_line":"        msg \u003d (_(\"The following parameters were mising while parsing \""},{"line_number":106,"context_line":"                 \"driver_info:\\n%s\") % \"\\n\".join(error_msgs))"},{"line_number":107,"context_line":"        raise exception.MissingParameterValue(msg)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    for param in OPTIONAL_PROPERTIES:"},{"line_number":110,"context_line":"        if param in info:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_620e748e","line":107,"in_reply_to":"3a961159_adb5cbee","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4b80be9fc40d150154a5b7f443c3fe8967584a01","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    for param in OPTIONAL_PROPERTIES:"},{"line_number":110,"context_line":"        if param in info:"},{"line_number":111,"context_line":"            d_info[param[5:]] \u003d info[param]"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    try:"},{"line_number":114,"context_line":"        d_info[\u0027port\u0027] \u003d int(d_info[\u0027port\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_a5d15f58","line":111,"updated":"2015-01-19 22:23:06.000000000","message":"I\u0027m not fond of param[5:] being repeated twice; it seems error prone.","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    for param in OPTIONAL_PROPERTIES:"},{"line_number":110,"context_line":"        if param in info:"},{"line_number":111,"context_line":"            d_info[param[5:]] \u003d info[param]"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    try:"},{"line_number":114,"context_line":"        d_info[\u0027port\u0027] \u003d int(d_info[\u0027port\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_a21f7cb7","line":111,"in_reply_to":"3a961159_a5d15f58","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"068a8d4b597993e63744b3ec0da7756355e32f36","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            d_info[param[5:]] \u003d info[param]"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    try:"},{"line_number":114,"context_line":"        d_info[\u0027port\u0027] \u003d int(d_info[\u0027port\u0027])"},{"line_number":115,"context_line":"    except KeyError:"},{"line_number":116,"context_line":"        d_info[\u0027port\u0027] \u003d CONF.vbox.vbox_port"},{"line_number":117,"context_line":"    except ValueError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_45cd0c5e","line":114,"updated":"2015-01-20 10:55:40.000000000","message":"try:\n     d_info[\u0027port\u0027] \u003d int(d_info.get(\u0027port\u0027, CONF.vbox.vbox_port))\nexcept ValueError:\n     raise InvalidParameter ...","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            d_info[param[5:]] \u003d info[param]"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    try:"},{"line_number":114,"context_line":"        d_info[\u0027port\u0027] \u003d int(d_info[\u0027port\u0027])"},{"line_number":115,"context_line":"    except KeyError:"},{"line_number":116,"context_line":"        d_info[\u0027port\u0027] \u003d CONF.vbox.vbox_port"},{"line_number":117,"context_line":"    except ValueError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_428098bf","line":114,"in_reply_to":"3a961159_45cd0c5e","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    \"\"\"Runs a method of pyremotevbox.vbox.VirtualMachine"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    This method runs a method from pyremotevbox.vbox.VirtualMachine"},{"line_number":129,"context_line":"    when the method to be invoked and the argument to be passed to"},{"line_number":130,"context_line":"    the method are provided."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    :param node: an Ironic node object."}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_0d733f17","line":129,"updated":"2015-01-19 21:34:19.000000000","message":"nit: could be more than one argument, right?","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    \"\"\"Runs a method of pyremotevbox.vbox.VirtualMachine"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    This method runs a method from pyremotevbox.vbox.VirtualMachine"},{"line_number":129,"context_line":"    when the method to be invoked and the argument to be passed to"},{"line_number":130,"context_line":"    the method are provided."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    :param node: an Ironic node object."}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_c273a814","line":129,"in_reply_to":"3a961159_0d733f17","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    :param call_kwargs: The kwargs to be passed to the method."},{"line_number":139,"context_line":"    :returns: The value returned by \u0027vm_object_method\u0027"},{"line_number":140,"context_line":"    :raises: VboxOperationError, if execution of method failed."},{"line_number":141,"context_line":"    :raises: InvalidParameterValue, if invalid method was passed."},{"line_number":142,"context_line":"    \"\"\""},{"line_number":143,"context_line":"    driver_info \u003d parse_driver_info(node)"},{"line_number":144,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_2da63bac","line":141,"updated":"2015-01-19 21:34:19.000000000","message":"You are using \u0027method\u0027 in for three different things in this docstring. I suggest deleting the first method from \u0027This \u003cmethod\u003e runs a method\u0027, to get rid of one confusion.\n\nAnd since you have two different methods as parameters, the descriptions here should be clear enough to know which method you\u0027re referring to.","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    :param call_kwargs: The kwargs to be passed to the method."},{"line_number":139,"context_line":"    :returns: The value returned by \u0027vm_object_method\u0027"},{"line_number":140,"context_line":"    :raises: VboxOperationError, if execution of method failed."},{"line_number":141,"context_line":"    :raises: InvalidParameterValue, if invalid method was passed."},{"line_number":142,"context_line":"    \"\"\""},{"line_number":143,"context_line":"    driver_info \u003d parse_driver_info(node)"},{"line_number":144,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_625cb47e","line":141,"in_reply_to":"3a961159_2da63bac","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                                           error\u003dexc)"},{"line_number":156,"context_line":"    except AttributeError:"},{"line_number":157,"context_line":"        raise exception.InvalidParameterValue(_(\"Invalid method \u0027%s\u0027 passed \""},{"line_number":158,"context_line":"            \"to \u0027_run_vbox_method\u0027\") % vm_object_method)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"class VBoxPower(base.PowerInterface):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_ad36ab4f","line":158,"updated":"2015-01-19 21:34:19.000000000","message":"I\u0027m not fond of this coding style. You\u0027re assuming here (I hope) that the only way to get this exception is via the getattr() call above. In that case, why not just put a try/except there, or just test for it there. This way seems error prone if someone adds some code to the try/except above that might also raise an AttributeError. Eg, what if the func() call raises that?","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                                           error\u003dexc)"},{"line_number":156,"context_line":"    except AttributeError:"},{"line_number":157,"context_line":"        raise exception.InvalidParameterValue(_(\"Invalid method \u0027%s\u0027 passed \""},{"line_number":158,"context_line":"            \"to \u0027_run_vbox_method\u0027\") % vm_object_method)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"class VBoxPower(base.PowerInterface):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_22c9cc25","line":158,"in_reply_to":"3a961159_ad36ab4f","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"068a8d4b597993e63744b3ec0da7756355e32f36","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                                           error\u003dexc)"},{"line_number":156,"context_line":"    except AttributeError:"},{"line_number":157,"context_line":"        raise exception.InvalidParameterValue(_(\"Invalid method \u0027%s\u0027 passed \""},{"line_number":158,"context_line":"            \"to \u0027_run_vbox_method\u0027\") % vm_object_method)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"class VBoxPower(base.PowerInterface):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_45226c03","line":158,"in_reply_to":"3a961159_ad36ab4f","updated":"2015-01-20 10:55:40.000000000","message":"Yeah, it seems clearner if we separate the try...except blocks for specific exceptions","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        :param task: a task from TaskManager."},{"line_number":262,"context_line":"        :returns: a dictionary containing:"},{"line_number":263,"context_line":"            \u0027boot_device\u0027: one of the ironic.common.boot_devices"},{"line_number":264,"context_line":"            \u0027persistent\u0027: True if boot device is persistent, False otherwise"},{"line_number":265,"context_line":"        :raises: MissingParameterValue if required parameters are missing."},{"line_number":266,"context_line":"        :raises: InvalidParameterValue on invalid inputs."}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_98e3ebd7","line":263,"updated":"2015-01-19 21:34:19.000000000","message":"or None","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        :param task: a task from TaskManager."},{"line_number":262,"context_line":"        :returns: a dictionary containing:"},{"line_number":263,"context_line":"            \u0027boot_device\u0027: one of the ironic.common.boot_devices"},{"line_number":264,"context_line":"            \u0027persistent\u0027: True if boot device is persistent, False otherwise"},{"line_number":265,"context_line":"        :raises: MissingParameterValue if required parameters are missing."},{"line_number":266,"context_line":"        :raises: InvalidParameterValue on invalid inputs."}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_a2d4dcbb","line":263,"in_reply_to":"3a961159_98e3ebd7","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        :param task: a task from TaskManager."},{"line_number":262,"context_line":"        :returns: a dictionary containing:"},{"line_number":263,"context_line":"            \u0027boot_device\u0027: one of the ironic.common.boot_devices"},{"line_number":264,"context_line":"            \u0027persistent\u0027: True if boot device is persistent, False otherwise"},{"line_number":265,"context_line":"        :raises: MissingParameterValue if required parameters are missing."},{"line_number":266,"context_line":"        :raises: InvalidParameterValue on invalid inputs."},{"line_number":267,"context_line":"        :raises: VboxOperationError, if error encountered from VirtualBox"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_78a2bfae","line":264,"updated":"2015-01-19 21:34:19.000000000","message":"you might want to check the output from sphinx (when generating documentation) to see if there are warnings; I\u0027m not sure that this is acceptable format.","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        :param task: a task from TaskManager."},{"line_number":262,"context_line":"        :returns: a dictionary containing:"},{"line_number":263,"context_line":"            \u0027boot_device\u0027: one of the ironic.common.boot_devices"},{"line_number":264,"context_line":"            \u0027persistent\u0027: True if boot device is persistent, False otherwise"},{"line_number":265,"context_line":"        :raises: MissingParameterValue if required parameters are missing."},{"line_number":266,"context_line":"        :raises: InvalidParameterValue on invalid inputs."},{"line_number":267,"context_line":"        :raises: VboxOperationError, if error encountered from VirtualBox"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_02ebf07b","line":264,"in_reply_to":"3a961159_78a2bfae","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                                         \u0027get_boot_device\u0027)"},{"line_number":273,"context_line":"        try:"},{"line_number":274,"context_line":"            # NOTE(rameshg87): VirtualBox has only persistent boot devices."},{"line_number":275,"context_line":"            persistent \u003d True"},{"line_number":276,"context_line":"            ironic_boot_dev \u003d VBOX_TO_IRONIC_DEVICE_MAPPING[vbox_boot_dev]"},{"line_number":277,"context_line":"        except KeyError:"},{"line_number":278,"context_line":"            ironic_boot_dev \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_38983775","line":275,"updated":"2015-01-19 21:34:19.000000000","message":"I don\u0027t see why this needs to be in the try/except block","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                                         \u0027get_boot_device\u0027)"},{"line_number":273,"context_line":"        try:"},{"line_number":274,"context_line":"            # NOTE(rameshg87): VirtualBox has only persistent boot devices."},{"line_number":275,"context_line":"            persistent \u003d True"},{"line_number":276,"context_line":"            ironic_boot_dev \u003d VBOX_TO_IRONIC_DEVICE_MAPPING[vbox_boot_dev]"},{"line_number":277,"context_line":"        except KeyError:"},{"line_number":278,"context_line":"            ironic_boot_dev \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_a205bc16","line":275,"in_reply_to":"3a961159_38983775","updated":"2015-01-20 14:50:10.000000000","message":"VirtualBox can be configured to boot from some other device (like floppy) that is not supported by Ironic. Even though this is rare possibility, just wanted to take care of this.  If that is the case, then this would raise KeyError.","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"e5efab595257041b02562c01180b707118fdbbdf","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                                         \u0027get_boot_device\u0027)"},{"line_number":273,"context_line":"        try:"},{"line_number":274,"context_line":"            # NOTE(rameshg87): VirtualBox has only persistent boot devices."},{"line_number":275,"context_line":"            persistent \u003d True"},{"line_number":276,"context_line":"            ironic_boot_dev \u003d VBOX_TO_IRONIC_DEVICE_MAPPING[vbox_boot_dev]"},{"line_number":277,"context_line":"        except KeyError:"},{"line_number":278,"context_line":"            ironic_boot_dev \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_d26386af","line":275,"in_reply_to":"3a961159_487fd917","updated":"2015-01-21 16:06:11.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6a4a302e4a37c07fd18cdf126cca644fea797e0d","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                                         \u0027get_boot_device\u0027)"},{"line_number":273,"context_line":"        try:"},{"line_number":274,"context_line":"            # NOTE(rameshg87): VirtualBox has only persistent boot devices."},{"line_number":275,"context_line":"            persistent \u003d True"},{"line_number":276,"context_line":"            ironic_boot_dev \u003d VBOX_TO_IRONIC_DEVICE_MAPPING[vbox_boot_dev]"},{"line_number":277,"context_line":"        except KeyError:"},{"line_number":278,"context_line":"            ironic_boot_dev \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_487fd917","line":275,"in_reply_to":"3a961159_a205bc16","updated":"2015-01-20 15:21:12.000000000","message":"how does \u0027persistent \u003d True\u0027 raise a KeyError?\n\nI wasn\u0027t saying don\u0027t do it, I meant I didn\u0027t see a need for it to be inside the try. You could do that before the try.","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"068a8d4b597993e63744b3ec0da7756355e32f36","unresolved":false,"context_lines":[{"line_number":276,"context_line":"            ironic_boot_dev \u003d VBOX_TO_IRONIC_DEVICE_MAPPING[vbox_boot_dev]"},{"line_number":277,"context_line":"        except KeyError:"},{"line_number":278,"context_line":"            ironic_boot_dev \u003d None"},{"line_number":279,"context_line":"            persistent \u003d None"},{"line_number":280,"context_line":"            msg \u003d _LE(\"VirtualBox returned unknown boot device \u0027%(device)s\u0027 \""},{"line_number":281,"context_line":"                      \"for node %(node)s\")"},{"line_number":282,"context_line":"            LOG.error(msg % {\u0027device\u0027: vbox_boot_dev, \u0027node\u0027: task.node.uuid})"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_b74ee36c","line":279,"updated":"2015-01-20 10:55:40.000000000","message":"Yeah try...except doesn\u0027t seems to be needed.\n\n persistent \u003d True\n ironic_boot_dev \u003d  VBOX_TO_IRONIC_DEVICE_MAPPING.get(vbox_boot_dev)\n if not ironic_boot_dev:\n     persistent \u003d None\n     LOG.error(_LE(...), {...})\n\n return {\u0027boot_device\u0027: ...}","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":276,"context_line":"            ironic_boot_dev \u003d VBOX_TO_IRONIC_DEVICE_MAPPING[vbox_boot_dev]"},{"line_number":277,"context_line":"        except KeyError:"},{"line_number":278,"context_line":"            ironic_boot_dev \u003d None"},{"line_number":279,"context_line":"            persistent \u003d None"},{"line_number":280,"context_line":"            msg \u003d _LE(\"VirtualBox returned unknown boot device \u0027%(device)s\u0027 \""},{"line_number":281,"context_line":"                      \"for node %(node)s\")"},{"line_number":282,"context_line":"            LOG.error(msg % {\u0027device\u0027: vbox_boot_dev, \u0027node\u0027: task.node.uuid})"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_85360ae7","line":279,"in_reply_to":"3a961159_b74ee36c","updated":"2015-01-20 14:50:10.000000000","message":"It can raise KeyError if VirtualBox is configured to boot from some other device that we don\u0027t support in Ironic. Just wanted to take care of this.","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"068a8d4b597993e63744b3ec0da7756355e32f36","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            persistent \u003d None"},{"line_number":280,"context_line":"            msg \u003d _LE(\"VirtualBox returned unknown boot device \u0027%(device)s\u0027 \""},{"line_number":281,"context_line":"                      \"for node %(node)s\")"},{"line_number":282,"context_line":"            LOG.error(msg % {\u0027device\u0027: vbox_boot_dev, \u0027node\u0027: task.node.uuid})"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        return {\u0027boot_device\u0027: ironic_boot_dev, \u0027persistent\u0027: persistent}"},{"line_number":285,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_376113d5","line":282,"updated":"2015-01-20 10:55:40.000000000","message":"nit: LOG interpolation:\n\n LOG.error(msg, {\u0027device\u0027})","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            persistent \u003d None"},{"line_number":280,"context_line":"            msg \u003d _LE(\"VirtualBox returned unknown boot device \u0027%(device)s\u0027 \""},{"line_number":281,"context_line":"                      \"for node %(node)s\")"},{"line_number":282,"context_line":"            LOG.error(msg % {\u0027device\u0027: vbox_boot_dev, \u0027node\u0027: task.node.uuid})"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        return {\u0027boot_device\u0027: ironic_boot_dev, \u0027persistent\u0027: persistent}"},{"line_number":285,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_85d9aa86","line":282,"in_reply_to":"3a961159_376113d5","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        :param task: a task from TaskManager."},{"line_number":291,"context_line":"        :param device: ironic.common.boot_devices"},{"line_number":292,"context_line":"        :param persistent: True if boot device is persistent, False otherwise"},{"line_number":293,"context_line":"        :raises: MissingParameterValue if required parameters are missing."},{"line_number":294,"context_line":"        :raises: InvalidParameterValue on invalid inputs."},{"line_number":295,"context_line":"        :raises: VboxOperationError, if error encountered from VirtualBox"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_18d7fbef","line":292,"updated":"2015-01-19 21:34:19.000000000","message":"You ignore this, right? Maybe document it.","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        :param task: a task from TaskManager."},{"line_number":291,"context_line":"        :param device: ironic.common.boot_devices"},{"line_number":292,"context_line":"        :param persistent: True if boot device is persistent, False otherwise"},{"line_number":293,"context_line":"        :raises: MissingParameterValue if required parameters are missing."},{"line_number":294,"context_line":"        :raises: InvalidParameterValue on invalid inputs."},{"line_number":295,"context_line":"        :raises: VboxOperationError, if error encountered from VirtualBox"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_c28f28cc","line":292,"in_reply_to":"3a961159_18d7fbef","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        :param device: ironic.common.boot_devices"},{"line_number":292,"context_line":"        :param persistent: True if boot device is persistent, False otherwise"},{"line_number":293,"context_line":"        :raises: MissingParameterValue if required parameters are missing."},{"line_number":294,"context_line":"        :raises: InvalidParameterValue on invalid inputs."},{"line_number":295,"context_line":"        :raises: VboxOperationError, if error encountered from VirtualBox"},{"line_number":296,"context_line":"            operation."},{"line_number":297,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_f8c94f52","line":294,"updated":"2015-01-19 21:34:19.000000000","message":"or if device is invalid.","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        :param device: ironic.common.boot_devices"},{"line_number":292,"context_line":"        :param persistent: True if boot device is persistent, False otherwise"},{"line_number":293,"context_line":"        :raises: MissingParameterValue if required parameters are missing."},{"line_number":294,"context_line":"        :raises: InvalidParameterValue on invalid inputs."},{"line_number":295,"context_line":"        :raises: VboxOperationError, if error encountered from VirtualBox"},{"line_number":296,"context_line":"            operation."},{"line_number":297,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_e28c24da","line":294,"in_reply_to":"3a961159_f8c94f52","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        try:"},{"line_number":306,"context_line":"            _run_vbox_method(task.node, \u0027set_boot_device\u0027,"},{"line_number":307,"context_line":"                             \u0027set_boot_device\u0027, vbox_boot_device)"},{"line_number":308,"context_line":"        except pyremotevbox_exc.VmInWrongPowerState as exc:"},{"line_number":309,"context_line":"            # NOTE(rameshg87): We cannot change the boot device when the vm"},{"line_number":310,"context_line":"            # is powered on. This is a VirtualBox limitation. We just log"},{"line_number":311,"context_line":"            # the error silently and return because throwing error will cause"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_78139fb7","line":308,"updated":"2015-01-19 21:34:19.000000000","message":"so this exception doesn\u0027t inherit from pyremotevbox_exc.PyRemoteVBoxException?\n\nIf not, you should update the description for _run_vbox_method(), to indicate that this can be raised.","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        try:"},{"line_number":306,"context_line":"            _run_vbox_method(task.node, \u0027set_boot_device\u0027,"},{"line_number":307,"context_line":"                             \u0027set_boot_device\u0027, vbox_boot_device)"},{"line_number":308,"context_line":"        except pyremotevbox_exc.VmInWrongPowerState as exc:"},{"line_number":309,"context_line":"            # NOTE(rameshg87): We cannot change the boot device when the vm"},{"line_number":310,"context_line":"            # is powered on. This is a VirtualBox limitation. We just log"},{"line_number":311,"context_line":"            # the error silently and return because throwing error will cause"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_62b83476","line":308,"in_reply_to":"3a961159_78139fb7","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"}],"ironic/drivers/modules/virtualbox.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c6e93049e62d636b9c194b8192d1ee67e11093b9","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            missing in the node\u0027s driver_info."},{"line_number":232,"context_line":"        :raises: InvalidParameterValue, if some parameter(s) have invalid"},{"line_number":233,"context_line":"            value(s) in the node\u0027s driver_info."},{"line_number":234,"context_line":"        :raises: InvalidParameterValue if an invalid power state was specified."},{"line_number":235,"context_line":"        :raises: VirtualBoxOperationFailed, if error encountered from"},{"line_number":236,"context_line":"            VirtualBox operation."},{"line_number":237,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a930d6b_e2539914","line":234,"updated":"2015-01-27 13:32:30.000000000","message":"nit - can be joined with previous InvalidParameterValue block.","commit_id":"7a83bd3b00d5665c459f44a79342c224264e7c5b"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f35de3cfd9cabb5fef2460d85962fad4e2d3f833","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            missing in the node\u0027s driver_info."},{"line_number":232,"context_line":"        :raises: InvalidParameterValue, if some parameter(s) have invalid"},{"line_number":233,"context_line":"            value(s) in the node\u0027s driver_info."},{"line_number":234,"context_line":"        :raises: InvalidParameterValue if an invalid power state was specified."},{"line_number":235,"context_line":"        :raises: VirtualBoxOperationFailed, if error encountered from"},{"line_number":236,"context_line":"            VirtualBox operation."},{"line_number":237,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa81d914_1759108e","line":234,"in_reply_to":"1a930d6b_e2539914","updated":"2015-01-30 14:10:08.000000000","message":"Done","commit_id":"7a83bd3b00d5665c459f44a79342c224264e7c5b"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"2b54267152e631dc6ef0a2b769bcc500b37975b7","unresolved":false,"context_lines":[{"line_number":42,"context_line":"VIRTUALBOX_TO_IRONIC_POWER_MAPPING \u003d {"},{"line_number":43,"context_line":"                                \u0027PoweredOff\u0027: states.POWER_OFF,"},{"line_number":44,"context_line":"                                \u0027Running\u0027: states.POWER_ON,"},{"line_number":45,"context_line":"                                \u0027Error\u0027: states.ERROR"},{"line_number":46,"context_line":"                               }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"opts \u003d ["}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_25ad259d","line":45,"updated":"2015-02-03 15:50:04.000000000","message":"nit: add trailing comma","commit_id":"0818cb762780115bd9973642e92fcb144811e52d"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"3f79a1a0adf34de7b3bda1817b1bc53e4b145065","unresolved":false,"context_lines":[{"line_number":42,"context_line":"VIRTUALBOX_TO_IRONIC_POWER_MAPPING \u003d {"},{"line_number":43,"context_line":"                                \u0027PoweredOff\u0027: states.POWER_OFF,"},{"line_number":44,"context_line":"                                \u0027Running\u0027: states.POWER_ON,"},{"line_number":45,"context_line":"                                \u0027Error\u0027: states.ERROR"},{"line_number":46,"context_line":"                               }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"opts \u003d ["}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_5fca6a1b","line":45,"in_reply_to":"da86d52c_25ad259d","updated":"2015-02-06 06:11:47.000000000","message":"Will fix if I throw in another patch set. Otherwise will fix it with doc update.","commit_id":"0818cb762780115bd9973642e92fcb144811e52d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"2b54267152e631dc6ef0a2b769bcc500b37975b7","unresolved":false,"context_lines":[{"line_number":58,"context_line":"REQUIRED_PROPERTIES \u003d {"},{"line_number":59,"context_line":"    \u0027virtualbox_vmname\u0027: _(\"Name of the VM in VirtualBox. Required.\"),"},{"line_number":60,"context_line":"    \u0027virtualbox_host\u0027: _(\"IP address or hostname of the VirtualBox host. \""},{"line_number":61,"context_line":"                         \"Required.\")"},{"line_number":62,"context_line":"}"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"OPTIONAL_PROPERTIES \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_2584450b","line":61,"updated":"2015-02-03 15:50:04.000000000","message":"nit: add trailing comma","commit_id":"0818cb762780115bd9973642e92fcb144811e52d"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"3f79a1a0adf34de7b3bda1817b1bc53e4b145065","unresolved":false,"context_lines":[{"line_number":58,"context_line":"REQUIRED_PROPERTIES \u003d {"},{"line_number":59,"context_line":"    \u0027virtualbox_vmname\u0027: _(\"Name of the VM in VirtualBox. Required.\"),"},{"line_number":60,"context_line":"    \u0027virtualbox_host\u0027: _(\"IP address or hostname of the VirtualBox host. \""},{"line_number":61,"context_line":"                         \"Required.\")"},{"line_number":62,"context_line":"}"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"OPTIONAL_PROPERTIES \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_7fcd6e30","line":61,"in_reply_to":"da86d52c_2584450b","updated":"2015-02-06 06:11:47.000000000","message":"Will fix if I throw in another patch set. Otherwise will fix it with doc update.","commit_id":"0818cb762780115bd9973642e92fcb144811e52d"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9edc3e97df57f9e6124627cda94c84da7412e02f","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        :raises: VirtualBoxOperationFailed, if error encountered from"},{"line_number":259,"context_line":"            VirtualBox operation."},{"line_number":260,"context_line":"        \"\"\""},{"line_number":261,"context_line":"        _run_virtualbox_method(task.node, \u0027reboot\u0027, \u0027stop\u0027)"},{"line_number":262,"context_line":"        _run_virtualbox_method(task.node, \u0027reboot\u0027, \u0027start\u0027)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_58f2409b","line":261,"updated":"2015-02-02 13:04:22.000000000","message":"Is it possible or necessary to test the VM is really power off before we start it?","commit_id":"0818cb762780115bd9973642e92fcb144811e52d"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"3f79a1a0adf34de7b3bda1817b1bc53e4b145065","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        :raises: VirtualBoxOperationFailed, if error encountered from"},{"line_number":259,"context_line":"            VirtualBox operation."},{"line_number":260,"context_line":"        \"\"\""},{"line_number":261,"context_line":"        _run_virtualbox_method(task.node, \u0027reboot\u0027, \u0027stop\u0027)"},{"line_number":262,"context_line":"        _run_virtualbox_method(task.node, \u0027reboot\u0027, \u0027start\u0027)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_3f4856b2","line":261,"in_reply_to":"da86d52c_58f2409b","updated":"2015-02-06 06:11:47.000000000","message":"The pyremotevbox module will do this:\n\nhttps://github.com/rameshg87/pyremotevbox/blob/master/pyremotevbox/vbox.py#L353-L354\n\nhttps://github.com/rameshg87/pyremotevbox/blob/master/pyremotevbox/vbox.py#L379-L380","commit_id":"0818cb762780115bd9973642e92fcb144811e52d"}],"ironic/drivers/pxe.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"384ef138a0d64e1a92496a10b8e239f6ec87722e","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        self.power \u003d irmc_power.IRMCPower()"},{"line_number":209,"context_line":"        self.console \u003d ipmitool.IPMIShellinaboxConsole()"},{"line_number":210,"context_line":"        self.deploy \u003d pxe.PXEDeploy()"},{"line_number":211,"context_line":"        self.management \u003d ipmitool.IPMIManagement()"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"class PXEAndVirtualBoxDriver(base.BaseDriver):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_af507d5f","line":211,"updated":"2015-01-30 20:59:00.000000000","message":"You stole the self.vendor from this driver, need to put it back :)","commit_id":"9b3c6f6299a9316a5f5af5ac8d5060629bf24a87"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"da0eb24ac8156116bdb6c7a84b792af7cedf3f91","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        self.power \u003d irmc_power.IRMCPower()"},{"line_number":209,"context_line":"        self.console \u003d ipmitool.IPMIShellinaboxConsole()"},{"line_number":210,"context_line":"        self.deploy \u003d pxe.PXEDeploy()"},{"line_number":211,"context_line":"        self.management \u003d ipmitool.IPMIManagement()"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"class PXEAndVirtualBoxDriver(base.BaseDriver):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_08eedaec","line":211,"in_reply_to":"da86d52c_af507d5f","updated":"2015-02-02 10:26:52.000000000","message":"Oh. Will put it back right away. :)","commit_id":"9b3c6f6299a9316a5f5af5ac8d5060629bf24a87"}],"ironic/tests/drivers/test_vbox.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"855caacb1c8467424ded2e4610f4902d6d7c96d2","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        self.assertIsNotNone(info.get(\u0027host\u0027))"},{"line_number":52,"context_line":"        self.assertIsNotNone(info.get(\u0027username\u0027))"},{"line_number":53,"context_line":"        self.assertIsNotNone(info.get(\u0027password\u0027))"},{"line_number":54,"context_line":"        self.assertIsNotNone(info.get(\u0027port\u0027))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_parse_driver_info_missing_vmname(self):"},{"line_number":57,"context_line":"        del self.node.driver_info[\u0027vbox_vmname\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_a52eb08a","line":54,"updated":"2015-01-12 12:07:53.000000000","message":"self.assertEqual ? It would be nice to ensure that the expected values are being returned.","commit_id":"71356f14b20292b37339f381ab60466d7e250b6b"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"39f4801608a18a8b9bc28c298bd80dcca79c5aa2","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        self.assertIsNotNone(info.get(\u0027host\u0027))"},{"line_number":52,"context_line":"        self.assertIsNotNone(info.get(\u0027username\u0027))"},{"line_number":53,"context_line":"        self.assertIsNotNone(info.get(\u0027password\u0027))"},{"line_number":54,"context_line":"        self.assertIsNotNone(info.get(\u0027port\u0027))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_parse_driver_info_missing_vmname(self):"},{"line_number":57,"context_line":"        del self.node.driver_info[\u0027vbox_vmname\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_2be44e0d","line":54,"in_reply_to":"3a961159_a52eb08a","updated":"2015-01-12 14:25:36.000000000","message":"Done","commit_id":"71356f14b20292b37339f381ab60466d7e250b6b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"855caacb1c8467424ded2e4610f4902d6d7c96d2","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @mock.patch.object(vbox, \u0027pyremotevbox_vbox\u0027)"},{"line_number":67,"context_line":"    def test__run_vbox_method(self, vbox_mock):"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        host_mock \u003d mock.MagicMock()"},{"line_number":70,"context_line":"        func_mock \u003d mock.MagicMock()"},{"line_number":71,"context_line":"        vm_object_mock \u003d mock.MagicMock(foo\u003dfunc_mock)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_c571fcac","line":68,"updated":"2015-01-12 12:07:53.000000000","message":"nit: remove empty line (same for many other methods in this file)","commit_id":"71356f14b20292b37339f381ab60466d7e250b6b"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"39f4801608a18a8b9bc28c298bd80dcca79c5aa2","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @mock.patch.object(vbox, \u0027pyremotevbox_vbox\u0027)"},{"line_number":67,"context_line":"    def test__run_vbox_method(self, vbox_mock):"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        host_mock \u003d mock.MagicMock()"},{"line_number":70,"context_line":"        func_mock \u003d mock.MagicMock()"},{"line_number":71,"context_line":"        vm_object_mock \u003d mock.MagicMock(foo\u003dfunc_mock)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_4be19afb","line":68,"in_reply_to":"3a961159_c571fcac","updated":"2015-01-12 14:25:36.000000000","message":"Done","commit_id":"71356f14b20292b37339f381ab60466d7e250b6b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"855caacb1c8467424ded2e4610f4902d6d7c96d2","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                                                    \u0027some-ironic-method\u0027,"},{"line_number":78,"context_line":"                                                    \u0027foo\u0027,"},{"line_number":79,"context_line":"                                                    \u0027args\u0027,"},{"line_number":80,"context_line":"                                                    kwarg\u003d\u0027kwarg\u0027)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        vbox_mock.VirtualBoxHost.assert_called_once_with(vmname\u003d\u0027baremetal1\u0027,"},{"line_number":83,"context_line":"                                                         host\u003d\u002710.0.2.2\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_65a928dd","line":80,"updated":"2015-01-12 12:07:53.000000000","message":"nit: indentation","commit_id":"71356f14b20292b37339f381ab60466d7e250b6b"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"39f4801608a18a8b9bc28c298bd80dcca79c5aa2","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                                                    \u0027some-ironic-method\u0027,"},{"line_number":78,"context_line":"                                                    \u0027foo\u0027,"},{"line_number":79,"context_line":"                                                    \u0027args\u0027,"},{"line_number":80,"context_line":"                                                    kwarg\u003d\u0027kwarg\u0027)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        vbox_mock.VirtualBoxHost.assert_called_once_with(vmname\u003d\u0027baremetal1\u0027,"},{"line_number":83,"context_line":"                                                         host\u003d\u002710.0.2.2\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_6bee56ef","line":80,"in_reply_to":"3a961159_65a928dd","updated":"2015-01-12 14:25:36.000000000","message":"Done","commit_id":"71356f14b20292b37339f381ab60466d7e250b6b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"855caacb1c8467424ded2e4610f4902d6d7c96d2","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        vbox_exc_mock.PyRemoteVBoxException \u003d Exception"},{"line_number":96,"context_line":"        exc \u003d Exception()"},{"line_number":97,"context_line":"        vbox_mock.VirtualBoxHost.side_effect \u003d exc"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        self.assertRaises(exception.VboxOperationError, vbox._run_vbox_method,"},{"line_number":100,"context_line":"                          self.node, \u0027some-ironic-method\u0027, \u0027foo\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_25f640fa","line":97,"updated":"2015-01-12 12:07:53.000000000","message":"exc is used only once, so no need to create a new variable\n\nvbox_mock.VirtualBoxHost.side_effect \u003d Exception()","commit_id":"71356f14b20292b37339f381ab60466d7e250b6b"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"39f4801608a18a8b9bc28c298bd80dcca79c5aa2","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        vbox_exc_mock.PyRemoteVBoxException \u003d Exception"},{"line_number":96,"context_line":"        exc \u003d Exception()"},{"line_number":97,"context_line":"        vbox_mock.VirtualBoxHost.side_effect \u003d exc"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        self.assertRaises(exception.VboxOperationError, vbox._run_vbox_method,"},{"line_number":100,"context_line":"                          self.node, \u0027some-ironic-method\u0027, \u0027foo\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_8beb82db","line":97,"in_reply_to":"3a961159_25f640fa","updated":"2015-01-12 14:25:36.000000000","message":"Done","commit_id":"71356f14b20292b37339f381ab60466d7e250b6b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"855caacb1c8467424ded2e4610f4902d6d7c96d2","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    def test__run_vbox_method_find_vm_fails(self, vbox_mock, vbox_exc_mock):"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        vbox_exc_mock.PyRemoteVBoxException \u003d Exception"},{"line_number":108,"context_line":"        exc \u003d Exception()"},{"line_number":109,"context_line":"        host_mock \u003d mock.MagicMock()"},{"line_number":110,"context_line":"        vbox_mock.VirtualBoxHost.return_value \u003d host_mock"},{"line_number":111,"context_line":"        host_mock.find_vm.side_effect \u003d exc"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_e5d2785a","line":108,"updated":"2015-01-12 12:07:53.000000000","message":"ditto re exc no need to create a variable","commit_id":"71356f14b20292b37339f381ab60466d7e250b6b"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"39f4801608a18a8b9bc28c298bd80dcca79c5aa2","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    def test__run_vbox_method_find_vm_fails(self, vbox_mock, vbox_exc_mock):"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        vbox_exc_mock.PyRemoteVBoxException \u003d Exception"},{"line_number":108,"context_line":"        exc \u003d Exception()"},{"line_number":109,"context_line":"        host_mock \u003d mock.MagicMock()"},{"line_number":110,"context_line":"        vbox_mock.VirtualBoxHost.return_value \u003d host_mock"},{"line_number":111,"context_line":"        host_mock.find_vm.side_effect \u003d exc"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_ab859e0b","line":108,"in_reply_to":"3a961159_e5d2785a","updated":"2015-01-12 14:25:36.000000000","message":"Done","commit_id":"71356f14b20292b37339f381ab60466d7e250b6b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"855caacb1c8467424ded2e4610f4902d6d7c96d2","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        self.assertRaises(exception.VboxOperationError, vbox._run_vbox_method,"},{"line_number":114,"context_line":"                          self.node, \u0027foo\u0027, \u0027some-ironic-method\u0027,"},{"line_number":115,"context_line":"                          \u0027args\u0027, kwarg\u003d\u0027kwarg\u0027)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @mock.patch.object(vbox, \u0027pyremotevbox_exc\u0027)"},{"line_number":118,"context_line":"    @mock.patch.object(vbox, \u0027pyremotevbox_vbox\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_a5c23051","line":115,"updated":"2015-01-12 12:07:53.000000000","message":"host_mock.find_vm.assert_called_once_with(\u0027baremetal1\u0027) ?","commit_id":"71356f14b20292b37339f381ab60466d7e250b6b"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"39f4801608a18a8b9bc28c298bd80dcca79c5aa2","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        self.assertRaises(exception.VboxOperationError, vbox._run_vbox_method,"},{"line_number":114,"context_line":"                          self.node, \u0027foo\u0027, \u0027some-ironic-method\u0027,"},{"line_number":115,"context_line":"                          \u0027args\u0027, kwarg\u003d\u0027kwarg\u0027)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @mock.patch.object(vbox, \u0027pyremotevbox_exc\u0027)"},{"line_number":118,"context_line":"    @mock.patch.object(vbox, \u0027pyremotevbox_vbox\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_eb7fa615","line":115,"in_reply_to":"3a961159_a5c23051","updated":"2015-01-12 14:25:36.000000000","message":"Done","commit_id":"71356f14b20292b37339f381ab60466d7e250b6b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"855caacb1c8467424ded2e4610f4902d6d7c96d2","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        host_mock \u003d mock.MagicMock()"},{"line_number":124,"context_line":"        func_mock \u003d mock.MagicMock()"},{"line_number":125,"context_line":"        vbox_mock.VirtualBoxHost.return_value \u003d host_mock"},{"line_number":126,"context_line":"        host_mock.find_vm.side_effect \u003d exc"},{"line_number":127,"context_line":"        func_mock.side_effect \u003d exc"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self.assertRaises(exception.VboxOperationError, vbox._run_vbox_method,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_8517f4ed","line":126,"updated":"2015-01-12 12:07:53.000000000","message":"it\u0027s testing that func raises an exception righ? So no need to make host_mock raise an Exception?\n\nIt\u0027s confusing whether it\u0027s find_vm() or func() being tested here","commit_id":"71356f14b20292b37339f381ab60466d7e250b6b"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"39f4801608a18a8b9bc28c298bd80dcca79c5aa2","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        host_mock \u003d mock.MagicMock()"},{"line_number":124,"context_line":"        func_mock \u003d mock.MagicMock()"},{"line_number":125,"context_line":"        vbox_mock.VirtualBoxHost.return_value \u003d host_mock"},{"line_number":126,"context_line":"        host_mock.find_vm.side_effect \u003d exc"},{"line_number":127,"context_line":"        func_mock.side_effect \u003d exc"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self.assertRaises(exception.VboxOperationError, vbox._run_vbox_method,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_cb658a1e","line":126,"in_reply_to":"3a961159_8517f4ed","updated":"2015-01-12 14:25:36.000000000","message":"Done. Ah it\u0027s a mistake. Will fix, thanks.","commit_id":"71356f14b20292b37339f381ab60466d7e250b6b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"855caacb1c8467424ded2e4610f4902d6d7c96d2","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self.assertRaises(exception.VboxOperationError, vbox._run_vbox_method,"},{"line_number":130,"context_line":"                          self.node, \u0027foo\u0027, \u0027some-ironic-method\u0027,"},{"line_number":131,"context_line":"                          \u0027args\u0027, kwarg\u003d\u0027kwarg\u0027)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @mock.patch.object(vbox, \u0027pyremotevbox_exc\u0027)"},{"line_number":134,"context_line":"    @mock.patch.object(vbox, \u0027pyremotevbox_vbox\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_c59e5c69","line":131,"updated":"2015-01-12 12:07:53.000000000","message":"host_mock.find_vm.assert_called_once_with(\u0027baremetal1\u0027) ?","commit_id":"71356f14b20292b37339f381ab60466d7e250b6b"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"39f4801608a18a8b9bc28c298bd80dcca79c5aa2","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self.assertRaises(exception.VboxOperationError, vbox._run_vbox_method,"},{"line_number":130,"context_line":"                          self.node, \u0027foo\u0027, \u0027some-ironic-method\u0027,"},{"line_number":131,"context_line":"                          \u0027args\u0027, kwarg\u003d\u0027kwarg\u0027)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @mock.patch.object(vbox, \u0027pyremotevbox_exc\u0027)"},{"line_number":134,"context_line":"    @mock.patch.object(vbox, \u0027pyremotevbox_vbox\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_6b7e56b1","line":131,"in_reply_to":"3a961159_c59e5c69","updated":"2015-01-12 14:25:36.000000000","message":"Done","commit_id":"71356f14b20292b37339f381ab60466d7e250b6b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        info \u003d vbox.parse_driver_info(self.node)"},{"line_number":74,"context_line":"        self.assertEqual(18083, info[\u0027port\u0027])"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @mock.patch.object(vbox, \u0027pyremotevbox_vbox\u0027)"},{"line_number":77,"context_line":"    def test__run_vbox_method(self, vbox_mock):"},{"line_number":78,"context_line":"        host_mock \u003d mock.MagicMock()"},{"line_number":79,"context_line":"        func_mock \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_92566a5d","line":76,"updated":"2015-01-19 21:34:19.000000000","message":"The idea is to have these unit tests run with the pyremotevbox library if it is available, and to use mocks if it is not available. Please take a look at [1] to see how we\u0027ve done it for other third-party libraries.\n\n[1] https://github.com/openstack/ironic/blob/master/ironic/tests/drivers/third_party_driver_mocks.py","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        info \u003d vbox.parse_driver_info(self.node)"},{"line_number":74,"context_line":"        self.assertEqual(18083, info[\u0027port\u0027])"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @mock.patch.object(vbox, \u0027pyremotevbox_vbox\u0027)"},{"line_number":77,"context_line":"    def test__run_vbox_method(self, vbox_mock):"},{"line_number":78,"context_line":"        host_mock \u003d mock.MagicMock()"},{"line_number":79,"context_line":"        func_mock \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_a5a866da","line":76,"in_reply_to":"3a961159_92566a5d","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"}],"ironic/tests/drivers/test_virtualbox.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c6e93049e62d636b9c194b8192d1ee67e11093b9","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                                          port\u003d12345)"},{"line_number":164,"context_line":"        host_object_mock.find_vm.assert_called_once_with(\u0027baremetal1\u0027)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"class VirtualBoxPowerTestCase(db_base.DbTestCase):"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a930d6b_1da804da","line":166,"updated":"2015-01-27 13:32:30.000000000","message":"nit - there is no test for _run_virtualbox_method if raising pyremotevbox.exception.VmInWrongPowerState","commit_id":"7a83bd3b00d5665c459f44a79342c224264e7c5b"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f35de3cfd9cabb5fef2460d85962fad4e2d3f833","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                                          port\u003d12345)"},{"line_number":164,"context_line":"        host_object_mock.find_vm.assert_called_once_with(\u0027baremetal1\u0027)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"class VirtualBoxPowerTestCase(db_base.DbTestCase):"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa81d914_179e7007","line":166,"in_reply_to":"1a930d6b_13ae3598","updated":"2015-01-30 14:10:08.000000000","message":"Done","commit_id":"7a83bd3b00d5665c459f44a79342c224264e7c5b"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"dc0393584e5910e7f81117b88f0b2dc8ff12ea4f","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                                          port\u003d12345)"},{"line_number":164,"context_line":"        host_object_mock.find_vm.assert_called_once_with(\u0027baremetal1\u0027)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"class VirtualBoxPowerTestCase(db_base.DbTestCase):"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a930d6b_13ae3598","line":166,"in_reply_to":"1a930d6b_1da804da","updated":"2015-01-27 14:16:54.000000000","message":"++. It would be good to have a test for that to make sure the driver operates we expect it to.","commit_id":"7a83bd3b00d5665c459f44a79342c224264e7c5b"}],"setup.cfg":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1178303bda0f71a214780f8ed0908fd49e464046","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    pxe_ipmitool \u003d ironic.drivers.pxe:PXEAndIPMIToolDriver"},{"line_number":56,"context_line":"    pxe_ipminative \u003d ironic.drivers.pxe:PXEAndIPMINativeDriver"},{"line_number":57,"context_line":"    pxe_ssh \u003d ironic.drivers.pxe:PXEAndSSHDriver"},{"line_number":58,"context_line":"    pxe_vbox \u003d ironic.drivers.pxe:PXEAndVboxDriver"},{"line_number":59,"context_line":"    pxe_seamicro \u003d ironic.drivers.pxe:PXEAndSeaMicroDriver"},{"line_number":60,"context_line":"    pxe_iboot \u003d ironic.drivers.pxe:PXEAndIBootDriver"},{"line_number":61,"context_line":"    pxe_ilo \u003d ironic.drivers.pxe:PXEAndIloDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"3a961159_92a74abc","line":58,"updated":"2015-01-19 21:34:19.000000000","message":"It is Vbox here and for fake* driver, but VBox for agent one. I think they should be consistent.","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94ad965d11aa546ab97096c0308e4bf33cd27c80","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    pxe_ipmitool \u003d ironic.drivers.pxe:PXEAndIPMIToolDriver"},{"line_number":56,"context_line":"    pxe_ipminative \u003d ironic.drivers.pxe:PXEAndIPMINativeDriver"},{"line_number":57,"context_line":"    pxe_ssh \u003d ironic.drivers.pxe:PXEAndSSHDriver"},{"line_number":58,"context_line":"    pxe_vbox \u003d ironic.drivers.pxe:PXEAndVboxDriver"},{"line_number":59,"context_line":"    pxe_seamicro \u003d ironic.drivers.pxe:PXEAndSeaMicroDriver"},{"line_number":60,"context_line":"    pxe_iboot \u003d ironic.drivers.pxe:PXEAndIBootDriver"},{"line_number":61,"context_line":"    pxe_ilo \u003d ironic.drivers.pxe:PXEAndIloDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"3a961159_657e7e6c","line":58,"in_reply_to":"3a961159_92a74abc","updated":"2015-01-20 14:50:10.000000000","message":"Done","commit_id":"5394316fd3a105589327c56e01affd9c1dc45852"}]}
