)]}'
{"ironic/drivers/irmc.py":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"0c0745a2d63b2b32380f74dd6b36a9a266b84d76","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ironic.drivers.modules import pxe"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class PXEiRMCDriver(base.BaseDriver):"},{"line_number":25,"context_line":"    \"\"\"iRMC driver using PXE for deploy.\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_1af25ae3","line":24,"updated":"2015-01-13 09:34:56.000000000","message":"This file has been removed in the dependent patch https://review.openstack.org/#/c/144901/.\n\nI should have use git merge instead of git rebase?","commit_id":"859ac6e10b811612d9b7b609169e16b9ca34e095"}],"ironic/drivers/modules/irmc/common.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"70dd14b03dda5421f39756ff52ffba4afaf2eef5","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               help\u003d\u0027Timeout (in seconds) for iRMC operations\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027sensor_method\u0027,"},{"line_number":39,"context_line":"               default\u003d\u0027ipmitool\u0027,"},{"line_number":40,"context_line":"               help\u003d\"Sensor Data retrieval method either \""},{"line_number":41,"context_line":"               + \"\u0027ipmitool\u0027 or \u0027scci\u0027\"),"},{"line_number":42,"context_line":"]"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_dc72c2e4","line":40,"updated":"2015-01-21 14:09:30.000000000","message":"same nit as with auth_method help.","commit_id":"4ba891110fcc997380fcd8b0e17f30d84b6d5d1e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"543d75e406f19213cd5ec5bf2c7fa4995ef27c72","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    cfg.StrOpt(\u0027sensor_method\u0027,"},{"line_number":39,"context_line":"               default\u003d\u0027ipmitool\u0027,"},{"line_number":40,"context_line":"               help\u003d\"Sensor Data retrieval method either \""},{"line_number":41,"context_line":"               + \"\u0027ipmitool\u0027 or \u0027scci\u0027\"),"},{"line_number":42,"context_line":"]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_dc8802ea","line":41,"updated":"2015-01-21 15:01:51.000000000","message":"Please change to \u0027\"ipmitool\" or \"scci\"\u0027 for consistency.","commit_id":"4ba891110fcc997380fcd8b0e17f30d84b6d5d1e"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"cec3b68b84d79dbde6693769da049fa4dc7079b5","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    cfg.StrOpt(\u0027sensor_method\u0027,"},{"line_number":39,"context_line":"               default\u003d\u0027ipmitool\u0027,"},{"line_number":40,"context_line":"               help\u003d\"Sensor Data retrieval method either \""},{"line_number":41,"context_line":"               + \"\u0027ipmitool\u0027 or \u0027scci\u0027\"),"},{"line_number":42,"context_line":"]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_030a0b8a","line":41,"in_reply_to":"1a930d6b_dc8802ea","updated":"2015-01-22 09:38:57.000000000","message":"I\u0027ll fix that.","commit_id":"4ba891110fcc997380fcd8b0e17f30d84b6d5d1e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"543d75e406f19213cd5ec5bf2c7fa4995ef27c72","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    if not isinstance(d_info[\u0027irmc_client_timeout\u0027], int):"},{"line_number":106,"context_line":"        error_msgs.append("},{"line_number":107,"context_line":"            _(\"\u0027%s\u0027 is not integer type.\") % \u0027irmc_client_timeout\u0027)"},{"line_number":108,"context_line":"    if d_info[\u0027irmc_sensor_method\u0027] not in (\u0027ipmitool\u0027, \u0027scci\u0027):"},{"line_number":109,"context_line":"        error_msgs.append("},{"line_number":110,"context_line":"            _(\"\u0027%s\u0027 has unsupported value.\") % \u0027irmc_sensor_method\u0027)"},{"line_number":111,"context_line":"    if error_msgs:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_bc9fb602","line":108,"updated":"2015-01-21 15:01:51.000000000","message":"Maybe add .lower() as l99?","commit_id":"4ba891110fcc997380fcd8b0e17f30d84b6d5d1e"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"cec3b68b84d79dbde6693769da049fa4dc7079b5","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    if not isinstance(d_info[\u0027irmc_client_timeout\u0027], int):"},{"line_number":106,"context_line":"        error_msgs.append("},{"line_number":107,"context_line":"            _(\"\u0027%s\u0027 is not integer type.\") % \u0027irmc_client_timeout\u0027)"},{"line_number":108,"context_line":"    if d_info[\u0027irmc_sensor_method\u0027] not in (\u0027ipmitool\u0027, \u0027scci\u0027):"},{"line_number":109,"context_line":"        error_msgs.append("},{"line_number":110,"context_line":"            _(\"\u0027%s\u0027 has unsupported value.\") % \u0027irmc_sensor_method\u0027)"},{"line_number":111,"context_line":"    if error_msgs:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_23e8e7b3","line":108,"in_reply_to":"1a930d6b_bc9fb602","updated":"2015-01-22 09:38:57.000000000","message":"I\u0027ll fix that.","commit_id":"4ba891110fcc997380fcd8b0e17f30d84b6d5d1e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"86fb3bf8dffea08cecb392c77b57b66814d3ee5c","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    \"\"\""},{"line_number":172,"context_line":"    driver_info \u003d parse_driver_info(node)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    report \u003d scci.get_report("},{"line_number":175,"context_line":"        driver_info[\u0027irmc_address\u0027],"},{"line_number":176,"context_line":"        driver_info[\u0027irmc_username\u0027],"},{"line_number":177,"context_line":"        driver_info[\u0027irmc_password\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_8f81ba91","line":174,"updated":"2015-01-22 11:40:19.000000000","message":"nit: report variable will be just used to return, so you can return directly\n \n return scci.get_report(\n                driver_info[...],\n                ...","commit_id":"4ba891110fcc997380fcd8b0e17f30d84b6d5d1e"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"077129bea2ccf68ff1c937b23c6d697cade69dca","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    \"\"\""},{"line_number":172,"context_line":"    driver_info \u003d parse_driver_info(node)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    report \u003d scci.get_report("},{"line_number":175,"context_line":"        driver_info[\u0027irmc_address\u0027],"},{"line_number":176,"context_line":"        driver_info[\u0027irmc_username\u0027],"},{"line_number":177,"context_line":"        driver_info[\u0027irmc_password\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_2c560ad3","line":174,"in_reply_to":"1a930d6b_8f81ba91","updated":"2015-01-22 14:32:23.000000000","message":"I\u0027ll fix that.","commit_id":"4ba891110fcc997380fcd8b0e17f30d84b6d5d1e"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"372fc677285f41ffa6315f5851f48dfa506f317e","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    task.node.driver_info \u003d info"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"def get_irmc_report(node):"},{"line_number":162,"context_line":"    \"\"\"Gets iRMC SCCI report."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    Given an ironic node object, this method gives back a iRMC SCCI client"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_d7df780b","line":161,"updated":"2015-01-30 13:45:59.000000000","message":"This seems like it doesn\u0027t have any unit tests.","commit_id":"f445a0d5896b57bbcdc24c90e496cb1679437537"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"f93effe702ef3a32209f369bf88f00e45c4f63bd","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    task.node.driver_info \u003d info"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"def get_irmc_report(node):"},{"line_number":162,"context_line":"    \"\"\"Gets iRMC SCCI report."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    Given an ironic node object, this method gives back a iRMC SCCI client"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_a21ba071","line":161,"in_reply_to":"fa81d914_d7df780b","updated":"2015-01-30 14:52:45.000000000","message":"I\u0027ll add that.","commit_id":"f445a0d5896b57bbcdc24c90e496cb1679437537"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c7f0410804954d5344d2c3ea7687340deab8ec29","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                             \"The default value is 60. Optional.\"),"},{"line_number":63,"context_line":"    \u0027irmc_sensor_method\u0027: _(\"Sensor Data retrieval method; either \""},{"line_number":64,"context_line":"                            \"\u0027ipmitool\u0027 or \u0027scci\u0027. Optional.\")"},{"line_number":65,"context_line":"}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES.copy()"},{"line_number":68,"context_line":"COMMON_PROPERTIES.update(OPTIONAL_PROPERTIES)"}],"source_content_type":"text/x-python","patch_set":18,"id":"da86d52c_71e0f0cc","line":65,"updated":"2015-02-09 17:30:14.000000000","message":"why do you need to support ipmitool here?\n\nalso please make sure you work is aligned with https://review.openstack.org/#/c/130074","commit_id":"3b4e6dd38f6e8c1a4465b9f409c7c7efd6f34a7a"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"83b2f3483f59892f3fa5b9e76f4b083395f4e6c9","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                             \"The default value is 60. Optional.\"),"},{"line_number":63,"context_line":"    \u0027irmc_sensor_method\u0027: _(\"Sensor Data retrieval method; either \""},{"line_number":64,"context_line":"                            \"\u0027ipmitool\u0027 or \u0027scci\u0027. Optional.\")"},{"line_number":65,"context_line":"}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES.copy()"},{"line_number":68,"context_line":"COMMON_PROPERTIES.update(OPTIONAL_PROPERTIES)"}],"source_content_type":"text/x-python","patch_set":18,"id":"da86d52c_e5bced6e","line":65,"in_reply_to":"da86d52c_71e0f0cc","updated":"2015-02-10 13:54:27.000000000","message":"The reason is exactly to align with the 130074.\nSupporting ipmitool is the reflection of the spec review comment which suggests to keep compatible behavior.","commit_id":"3b4e6dd38f6e8c1a4465b9f409c7c7efd6f34a7a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7ca46c7b45c8f40f2d81248acbd575054f5ecac1","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    cfg.StrOpt(\u0027sensor_method\u0027,"},{"line_number":39,"context_line":"               default\u003d\u0027ipmitool\u0027,"},{"line_number":40,"context_line":"               help\u003d\u0027Sensor Data retrieval method either \u0027 +"},{"line_number":41,"context_line":"               \u0027\"ipmitool\" or \"scci\"\u0027),"},{"line_number":42,"context_line":"]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_90942c8c","line":41,"updated":"2015-02-11 08:21:00.000000000","message":"would be nice to mention the default here (also why is ipmitool the default?)","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"710aa7dfc42851186c4774eba41da717c1b37416","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    cfg.StrOpt(\u0027sensor_method\u0027,"},{"line_number":39,"context_line":"               default\u003d\u0027ipmitool\u0027,"},{"line_number":40,"context_line":"               help\u003d\u0027Sensor Data retrieval method either \u0027 +"},{"line_number":41,"context_line":"               \u0027\"ipmitool\" or \"scci\"\u0027),"},{"line_number":42,"context_line":"]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_0a029209","line":41,"in_reply_to":"da86d52c_173d722b","updated":"2015-02-12 09:22:28.000000000","message":"I\u0027ll fix that.","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a546fcac1f35f3972d3cd911ccf1d2ebee27921","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    cfg.StrOpt(\u0027sensor_method\u0027,"},{"line_number":39,"context_line":"               default\u003d\u0027ipmitool\u0027,"},{"line_number":40,"context_line":"               help\u003d\u0027Sensor Data retrieval method either \u0027 +"},{"line_number":41,"context_line":"               \u0027\"ipmitool\" or \"scci\"\u0027),"},{"line_number":42,"context_line":"]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_173d722b","line":41,"in_reply_to":"da86d52c_90942c8c","updated":"2015-02-11 23:05:05.000000000","message":"We don\u0027t typically mention the default -- that should be apparent if you are looking at this file, or looking at ironic.conf.sample.\n\nHow about \u0027Sensor data retrieval method, either ...\u0027","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a546fcac1f35f3972d3cd911ccf1d2ebee27921","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                          \"\u0027digest\u0027. Optional.\"),"},{"line_number":61,"context_line":"    \u0027irmc_client_timeout\u0027: _(\"Timeout (in seconds) for iRMC operations. \""},{"line_number":62,"context_line":"                             \"The default value is 60. Optional.\"),"},{"line_number":63,"context_line":"    \u0027irmc_sensor_method\u0027: _(\"Sensor Data retrieval method; either \""},{"line_number":64,"context_line":"                            \"\u0027ipmitool\u0027 or \u0027scci\u0027. Optional.\")"},{"line_number":65,"context_line":"}"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_f7545e55","line":63,"updated":"2015-02-11 23:05:05.000000000","message":"s/Data/data/","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"710aa7dfc42851186c4774eba41da717c1b37416","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                          \"\u0027digest\u0027. Optional.\"),"},{"line_number":61,"context_line":"    \u0027irmc_client_timeout\u0027: _(\"Timeout (in seconds) for iRMC operations. \""},{"line_number":62,"context_line":"                             \"The default value is 60. Optional.\"),"},{"line_number":63,"context_line":"    \u0027irmc_sensor_method\u0027: _(\"Sensor Data retrieval method; either \""},{"line_number":64,"context_line":"                            \"\u0027ipmitool\u0027 or \u0027scci\u0027. Optional.\")"},{"line_number":65,"context_line":"}"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_0a77f2a0","line":63,"in_reply_to":"da86d52c_f7545e55","updated":"2015-02-12 09:22:28.000000000","message":"I\u0027ll fix that.","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a546fcac1f35f3972d3cd911ccf1d2ebee27921","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    \u0027irmc_client_timeout\u0027: _(\"Timeout (in seconds) for iRMC operations. \""},{"line_number":62,"context_line":"                             \"The default value is 60. Optional.\"),"},{"line_number":63,"context_line":"    \u0027irmc_sensor_method\u0027: _(\"Sensor Data retrieval method; either \""},{"line_number":64,"context_line":"                            \"\u0027ipmitool\u0027 or \u0027scci\u0027. Optional.\")"},{"line_number":65,"context_line":"}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES.copy()"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_374b56b2","line":64,"updated":"2015-02-11 23:05:05.000000000","message":"Should mention the default value.","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"710aa7dfc42851186c4774eba41da717c1b37416","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    \u0027irmc_client_timeout\u0027: _(\"Timeout (in seconds) for iRMC operations. \""},{"line_number":62,"context_line":"                             \"The default value is 60. Optional.\"),"},{"line_number":63,"context_line":"    \u0027irmc_sensor_method\u0027: _(\"Sensor Data retrieval method; either \""},{"line_number":64,"context_line":"                            \"\u0027ipmitool\u0027 or \u0027scci\u0027. Optional.\")"},{"line_number":65,"context_line":"}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES.copy()"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_4a6d6acb","line":64,"in_reply_to":"da86d52c_374b56b2","updated":"2015-02-12 09:22:28.000000000","message":"I\u0027ll fix that.","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a546fcac1f35f3972d3cd911ccf1d2ebee27921","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    \"\"\"Gets iRMC SCCI report."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    Given an ironic node object, this method gives back a iRMC SCCI client"},{"line_number":165,"context_line":"    to do operations on the iRMC."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    :param node: An ironic node object."},{"line_number":168,"context_line":"    :returns: A xml.etree.ElementTree object."}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_d2df6838","line":165,"updated":"2015-02-11 23:05:05.000000000","message":"I don\u0027t understand this. It looks like you\u0027re returning an ElementTree object. I don\u0027t see any iRMC SCCI client being returned?","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"710aa7dfc42851186c4774eba41da717c1b37416","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    \"\"\"Gets iRMC SCCI report."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    Given an ironic node object, this method gives back a iRMC SCCI client"},{"line_number":165,"context_line":"    to do operations on the iRMC."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    :param node: An ironic node object."},{"line_number":168,"context_line":"    :returns: A xml.etree.ElementTree object."}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_8adf6268","line":165,"in_reply_to":"da86d52c_d2df6838","updated":"2015-02-12 09:22:28.000000000","message":"I\u0027ll fix the docstring.","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a546fcac1f35f3972d3cd911ccf1d2ebee27921","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    :raises: MissingParameterValue if some mandatory information"},{"line_number":171,"context_line":"        is missing on the node."},{"line_number":172,"context_line":"    :raises: SCCIInvalidInputError if required parameters are invalid."},{"line_number":173,"context_line":"    :raises: SCCIClientError if SCCI failed."},{"line_number":174,"context_line":"    \"\"\""},{"line_number":175,"context_line":"    driver_info \u003d parse_driver_info(node)"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_8c1eb06e","line":173,"updated":"2015-02-11 23:05:05.000000000","message":"These two aren\u0027t ironic exceptions, are they? If not, maybe prefix them with something.","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"710aa7dfc42851186c4774eba41da717c1b37416","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    :raises: MissingParameterValue if some mandatory information"},{"line_number":171,"context_line":"        is missing on the node."},{"line_number":172,"context_line":"    :raises: SCCIInvalidInputError if required parameters are invalid."},{"line_number":173,"context_line":"    :raises: SCCIClientError if SCCI failed."},{"line_number":174,"context_line":"    \"\"\""},{"line_number":175,"context_line":"    driver_info \u003d parse_driver_info(node)"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_4ac9eaaa","line":173,"in_reply_to":"da86d52c_8c1eb06e","updated":"2015-02-12 09:22:28.000000000","message":"I\u0027ll add the prefix.","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"319fbf9c6c612c22f76b9ebc6493208953792d88","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               help\u003d\u0027Timeout (in seconds) for iRMC operations\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027sensor_method\u0027,"},{"line_number":39,"context_line":"               default\u003d\u0027ipmitool\u0027,"},{"line_number":40,"context_line":"               help\u003d\u0027Sensor data retrieval method either, \u0027 +"},{"line_number":41,"context_line":"               \u0027\"ipmitool\" or \"scci\"\u0027),"},{"line_number":42,"context_line":"]"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_a997c7ea","line":40,"updated":"2015-02-12 15:15:38.000000000","message":"the comma should be after \u0027method\u0027, not \u0027either\u0027 :-(","commit_id":"bb8ffc6b2fb0f4e8ce1dd03b019e9c47277816c4"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"edaba2ceabd2e519146498fe3eeea6249019b390","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               help\u003d\u0027Timeout (in seconds) for iRMC operations\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027sensor_method\u0027,"},{"line_number":39,"context_line":"               default\u003d\u0027ipmitool\u0027,"},{"line_number":40,"context_line":"               help\u003d\u0027Sensor data retrieval method either, \u0027 +"},{"line_number":41,"context_line":"               \u0027\"ipmitool\" or \"scci\"\u0027),"},{"line_number":42,"context_line":"]"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_b110f600","line":40,"in_reply_to":"da86d52c_a997c7ea","updated":"2015-02-13 00:14:15.000000000","message":"I\u0027ll fix that :P","commit_id":"bb8ffc6b2fb0f4e8ce1dd03b019e9c47277816c4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"319fbf9c6c612c22f76b9ebc6493208953792d88","unresolved":false,"context_lines":[{"line_number":162,"context_line":"def get_irmc_report(node):"},{"line_number":163,"context_line":"    \"\"\"Gets iRMC SCCI report."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    Given an ironic node object, this method gives back a iRMC SCCI report."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    :param node: An ironic node object."},{"line_number":168,"context_line":"    :returns: A xml.etree.ElementTree object."}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_697f8fab","line":165,"updated":"2015-02-12 15:15:38.000000000","message":"I was wondering, what is a SCCI report? What kind of information is in this report?","commit_id":"bb8ffc6b2fb0f4e8ce1dd03b019e9c47277816c4"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"edaba2ceabd2e519146498fe3eeea6249019b390","unresolved":false,"context_lines":[{"line_number":162,"context_line":"def get_irmc_report(node):"},{"line_number":163,"context_line":"    \"\"\"Gets iRMC SCCI report."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    Given an ironic node object, this method gives back a iRMC SCCI report."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    :param node: An ironic node object."},{"line_number":168,"context_line":"    :returns: A xml.etree.ElementTree object."}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_71303e56","line":165,"in_reply_to":"da86d52c_697f8fab","updated":"2015-02-13 00:14:15.000000000","message":"It is a XML report. The following is the summary section of the report. \u003cContent\u003e shows what are inside.\n\n\n \u003cSummary\u003e\n  \u003cCreated\u003e\n   \u003cIsAdmin\u003etrue\u003c/IsAdmin\u003e\n   \u003cDate\u003e2014/12/15 18:46:20\u003c/Date\u003e\n   \u003cBuildDuration\u003e14\u003c/BuildDuration\u003e\n   \u003cCompany\u003eFUJITSU\u003c/Company\u003e\n   \u003cComputer\u003eiRMC38058D\u003c/Computer\u003e\n   \u003cOS\u003eiRMC S4 7.65F SDR: 3.71   ID 0356  RX300S8\u003c/OS\u003e\n   \u003cDomain\u003e\u003c/Domain\u003e\n   \u003cHostIPv4Address\u003e10.124.196.159\u003c/HostIPv4Address\u003e\n   \u003cHostIPv6Address\u003efe80::921b:eff:fe38:58d\u003c/HostIPv6Address\u003e\n  \u003c/Created\u003e\n  \u003cErrors Count\u003d\"1\"\u003e\n   \u003cSystemEventlog\u003e\n    \u003cMessage\u003e4 important error(s) in system event log (SEL)!\u003c/Message\u003e\n   \u003c/SystemEventlog\u003e\n  \u003c/Errors\u003e\n  \u003cWarnings Count\u003d\"2\"\u003e\n   \u003cSystemEventlog\u003e\n    \u003cMessage\u003e1 important warning(s) in system event log SEL\u003c/Message\u003e\n   \u003c/SystemEventlog\u003e\n   \u003cInternalEventlog\u003e\n    \u003cMessage\u003e2 important warning(s) in internal event log IEL\u003c/Message\u003e\n   \u003c/InternalEventlog\u003e\n  \u003c/Warnings\u003e\n  \u003cContent\u003e\n   \u003cItem Name\u003d\"System/BIOS\"\u003e\u003c/Item\u003e\n   \u003cItem Name\u003d\"System/Processor\"\u003e\u003c/Item\u003e\n   \u003cItem Name\u003d\"System/Memory\"\u003e\u003c/Item\u003e\n   \u003cItem Name\u003d\"System/Fans\"\u003e\u003c/Item\u003e\n   \u003cItem Name\u003d\"System/Temperatures\"\u003e\u003c/Item\u003e\n   \u003cItem Name\u003d\"System/PowerSupplies\"\u003e\u003c/Item\u003e\n   \u003cItem Name\u003d\"System/Voltages\"\u003e\u003c/Item\u003e\n   \u003cItem Name\u003d\"System/IDPROMS\"\u003e\u003c/Item\u003e\n   \u003cItem Name\u003d\"System/SensorDataRecords\"\u003e\u003c/Item\u003e\n   \u003cItem Name\u003d\"System/PCIDevices\"\u003e\u003c/Item\u003e\n   \u003cItem Name\u003d\"System/SystemEventlog\"\u003e\u003c/Item\u003e\n   \u003cItem Name\u003d\"System/InternalEventlog\"\u003e\u003c/Item\u003e\n   \u003cItem Name\u003d\"System/BootStatus\"\u003e\u003c/Item\u003e\n   \u003cItem Name\u003d\"System/ManagementControllers\"\u003e\u003c/Item\u003e\n   \u003cItem Name\u003d\"Software/ServerView/ServerViewRaid\"\u003e\u003c/Item\u003e\n  \u003c/Content\u003e\n \u003c/Summary\u003e","commit_id":"bb8ffc6b2fb0f4e8ce1dd03b019e9c47277816c4"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1ce068f80404fec3d2a076e927ced791ce18bd09","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            _(\"\u0027%s\u0027 is not integer type.\") % \u0027irmc_client_timeout\u0027)"},{"line_number":110,"context_line":"    if d_info[\u0027irmc_sensor_method\u0027].lower() not in (\u0027ipmitool\u0027, \u0027scci\u0027):"},{"line_number":111,"context_line":"        error_msgs.append("},{"line_number":112,"context_line":"            _(\"\u0027%s\u0027 has unsupported value.\") % \u0027irmc_sensor_method\u0027)"},{"line_number":113,"context_line":"    if error_msgs:"},{"line_number":114,"context_line":"        msg \u003d (_(\"The following type errors were encountered while parsing \""},{"line_number":115,"context_line":"                 \"driver_info:\\n%s\") % \"\\n\".join(error_msgs))"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_c8a42ba8","line":112,"updated":"2015-02-25 02:16:56.000000000","message":"nit: if it\u0027s a constant to be substituted, then we don\u0027t need to use %. we can build the string directly.  Ditto for all above.","commit_id":"0a5ed24c1e0bf3e1aa87a0d3f911963126526c79"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"3b79e899db8c8cc8408cc159a9e36dfb097d9be6","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            _(\"\u0027%s\u0027 is not integer type.\") % \u0027irmc_client_timeout\u0027)"},{"line_number":110,"context_line":"    if d_info[\u0027irmc_sensor_method\u0027].lower() not in (\u0027ipmitool\u0027, \u0027scci\u0027):"},{"line_number":111,"context_line":"        error_msgs.append("},{"line_number":112,"context_line":"            _(\"\u0027%s\u0027 has unsupported value.\") % \u0027irmc_sensor_method\u0027)"},{"line_number":113,"context_line":"    if error_msgs:"},{"line_number":114,"context_line":"        msg \u003d (_(\"The following type errors were encountered while parsing \""},{"line_number":115,"context_line":"                 \"driver_info:\\n%s\") % \"\\n\".join(error_msgs))"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_23ede8b7","line":112,"in_reply_to":"ba7be1f8_c8a42ba8","updated":"2015-02-25 07:04:42.000000000","message":"I\u0027ll fix that.","commit_id":"0a5ed24c1e0bf3e1aa87a0d3f911963126526c79"}],"ironic/drivers/modules/irmc/management.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"f5081bffcbf2d55254b5e9855cccbbfc8cd7ccbe","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                      {"},{"line_number":53,"context_line":"                        \u0027Sensor Type 1\u0027: {"},{"line_number":54,"context_line":"                          \u0027Sensor ID 1\u0027: {"},{"line_number":55,"context_line":"                            \u0027key\u0027: \u0027key value1\u0027,"},{"line_number":56,"context_line":"                            \u0027entity\u0027: \u0027entity value1\u0027,"},{"line_number":57,"context_line":"                            \u0027sensor\u0027: \u0027sensor value1\u0027"},{"line_number":58,"context_line":"                          },"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_594ee239","line":55,"updated":"2015-01-20 02:14:04.000000000","message":"based on the sensor data format defined in base class [1],  the \u0027Sensor Reading\u0027 which is under \u0027Sensor ID xxx\u0027 section, it is required for Ceilometer, \u0027Sensor Reading\u0027 is the sensor current value, and we have the logic [2] [3] in ipmitool and ipminative driver, if \u0027Sensor Reading\u0027 is None, should ignore current sensor data.  So can you add the same logic to \u0027filter\u0027 the sensor data?\n\n\n[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/base.py#L582\n[2] https://github.com/openstack/ironic/blob/6110667212404fc1302ce471605c2ffec51317f7/ironic/drivers/modules/ipminative.py#L275\n[3] https://github.com/openstack/ironic/blob/686f2ebaece43dc0d03e958693bb290a4c865491/ironic/drivers/modules/ipmitool.py#L537","commit_id":"bdc0d175aee6a44af3403adea70bff8f2f94796c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"7bfc1e7c80c68934e7a9dff40634ea906f6711c5","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                      {"},{"line_number":53,"context_line":"                        \u0027Sensor Type 1\u0027: {"},{"line_number":54,"context_line":"                          \u0027Sensor ID 1\u0027: {"},{"line_number":55,"context_line":"                            \u0027key\u0027: \u0027key value1\u0027,"},{"line_number":56,"context_line":"                            \u0027entity\u0027: \u0027entity value1\u0027,"},{"line_number":57,"context_line":"                            \u0027sensor\u0027: \u0027sensor value1\u0027"},{"line_number":58,"context_line":"                          },"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_e87a45b9","line":55,"in_reply_to":"3a961159_594ee239","updated":"2015-01-21 05:01:03.000000000","message":"I\u0027ll fix that.\nIt seems \u0027Sensor ID\u0027 is also mandatory as well as \u0027Sensor Reading\u0027\n\n62                 sensor_reading \u003d sensor_data[\u0027Sensor Reading\u0027] \n\n63                 sensor_id \u003d sensor_data[\u0027Sensor ID\u0027]","commit_id":"bdc0d175aee6a44af3403adea70bff8f2f94796c"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"f5081bffcbf2d55254b5e9855cccbbfc8cd7ccbe","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        sensors_data.setdefault(sensor_type, {})[sensor_id] \u003d decoded_data"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    # print(sensors_data)"},{"line_number":120,"context_line":"    return sensors_data"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_f9aa2ed2","line":119,"updated":"2015-01-20 02:14:04.000000000","message":"Understand this is used for testing when coding, so can you remove it?","commit_id":"bdc0d175aee6a44af3403adea70bff8f2f94796c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"7bfc1e7c80c68934e7a9dff40634ea906f6711c5","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        sensors_data.setdefault(sensor_type, {})[sensor_id] \u003d decoded_data"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    # print(sensors_data)"},{"line_number":120,"context_line":"    return sensors_data"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_a8575d26","line":119,"in_reply_to":"3a961159_f9aa2ed2","updated":"2015-01-21 05:01:03.000000000","message":"I\u0027ll remove it.","commit_id":"bdc0d175aee6a44af3403adea70bff8f2f94796c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"70dd14b03dda5421f39756ff52ffba4afaf2eef5","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                            \u0027sensor\u0027: \u0027sensor value4\u0027"},{"line_number":75,"context_line":"                          }"},{"line_number":76,"context_line":"                        }"},{"line_number":77,"context_line":"                      }"},{"line_number":78,"context_line":"    \"\"\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_3f1d7867","line":77,"updated":"2015-01-21 14:09:30.000000000","message":"If you want this to be seen in generated docs you should add it to some \"public method\", i.e. without underscore in the beginning.","commit_id":"4ba891110fcc997380fcd8b0e17f30d84b6d5d1e"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"cec3b68b84d79dbde6693769da049fa4dc7079b5","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                            \u0027sensor\u0027: \u0027sensor value4\u0027"},{"line_number":75,"context_line":"                          }"},{"line_number":76,"context_line":"                        }"},{"line_number":77,"context_line":"                      }"},{"line_number":78,"context_line":"    \"\"\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_83235b04","line":77,"in_reply_to":"1a930d6b_3f1d7867","updated":"2015-01-22 09:38:57.000000000","message":"Okay, I\u0027ll move this inline doc to the following public method. \n\ndef get_sensors_data(self, task):\t198","commit_id":"4ba891110fcc997380fcd8b0e17f30d84b6d5d1e"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"1e591717e9e95317a1d69b09a68df318ea525d73","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            (sensor_type_number is None) or"},{"line_number":100,"context_line":"            (entity_name is None) or"},{"line_number":101,"context_line":"            (entity_id is None)):"},{"line_number":102,"context_line":"            continue"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        sensor_type \u003d (\u0027%s (%s)\u0027 %"},{"line_number":105,"context_line":"                       (sensor_type_name.text, sensor_type_number.text))"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_63685df6","line":102,"updated":"2015-01-21 07:09:01.000000000","message":"Equivalent with \u0027None in \u0027:\n\n    if None in (sensor_type_name, sensor_type_number, entity_name, entity_id):\n        continue","commit_id":"4ba891110fcc997380fcd8b0e17f30d84b6d5d1e"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"cec3b68b84d79dbde6693769da049fa4dc7079b5","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            (sensor_type_number is None) or"},{"line_number":100,"context_line":"            (entity_name is None) or"},{"line_number":101,"context_line":"            (entity_id is None)):"},{"line_number":102,"context_line":"            continue"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        sensor_type \u003d (\u0027%s (%s)\u0027 %"},{"line_number":105,"context_line":"                       (sensor_type_name.text, sensor_type_number.text))"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_e3797ffd","line":102,"in_reply_to":"1a930d6b_63685df6","updated":"2015-01-22 09:38:57.000000000","message":"I\u0027ll fix that.","commit_id":"4ba891110fcc997380fcd8b0e17f30d84b6d5d1e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"543d75e406f19213cd5ec5bf2c7fa4995ef27c72","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            reading_units.text is None) else reading_units.text"},{"line_number":113,"context_line":"        reading_value_text \u003d \"None\" if ("},{"line_number":114,"context_line":"            reading_value.text is None) else reading_value.text"},{"line_number":115,"context_line":"        sensor_reading \u003d \u0027%s %s\u0027 % (reading_value_text, reading_units_text)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        sensors_data.setdefault(sensor_type, {})[sensor_id] \u003d {"},{"line_number":118,"context_line":"              \u0027Sensor Reading\u0027: sensor_reading,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_758f2124","line":115,"updated":"2015-01-21 15:01:51.000000000","message":"Looks like lines 113-114 not needed\n \u003e\u003e\u003e \u0027%s %s\u0027 % (None, None)\n \u0027None None\u0027\n \u003e\u003e\u003e","commit_id":"4ba891110fcc997380fcd8b0e17f30d84b6d5d1e"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"cec3b68b84d79dbde6693769da049fa4dc7079b5","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            reading_units.text is None) else reading_units.text"},{"line_number":113,"context_line":"        reading_value_text \u003d \"None\" if ("},{"line_number":114,"context_line":"            reading_value.text is None) else reading_value.text"},{"line_number":115,"context_line":"        sensor_reading \u003d \u0027%s %s\u0027 % (reading_value_text, reading_units_text)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        sensors_data.setdefault(sensor_type, {})[sensor_id] \u003d {"},{"line_number":118,"context_line":"              \u0027Sensor Reading\u0027: sensor_reading,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_1e217e9f","line":115,"in_reply_to":"1a930d6b_758f2124","updated":"2015-01-22 09:38:57.000000000","message":"If reading_units.text and reading_value.text are not None respectively,\nsensor_reading is not \u0027None None\u0027, but like \u0027600 RPM\u0027,\nthe line 324 in \nhttps://review.openstack.org/#/c/146803/3/ironic/tests/drivers/irmc/test_management.py\n\nDid I understand your comment correctly?","commit_id":"4ba891110fcc997380fcd8b0e17f30d84b6d5d1e"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"1e591717e9e95317a1d69b09a68df318ea525d73","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        If Convert SCCI Sensors Data XML report to the dict format."},{"line_number":202,"context_line":"        :param task: a TaskManager instance."},{"line_number":203,"context_line":"        :raises: FailedToGetSensorData when getting the sensor data fails."},{"line_number":204,"context_line":"        :raises: FailedToParseSensorData when parsing sensor data fails."},{"line_number":205,"context_line":"        :returns: returns a dict of sensor data group by sensor type."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_c30bd129","line":204,"updated":"2015-01-21 07:09:01.000000000","message":":raises: InvalidParameterValue when getting invalid irmc_sensor_method.","commit_id":"4ba891110fcc997380fcd8b0e17f30d84b6d5d1e"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"cec3b68b84d79dbde6693769da049fa4dc7079b5","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        If Convert SCCI Sensors Data XML report to the dict format."},{"line_number":202,"context_line":"        :param task: a TaskManager instance."},{"line_number":203,"context_line":"        :raises: FailedToGetSensorData when getting the sensor data fails."},{"line_number":204,"context_line":"        :raises: FailedToParseSensorData when parsing sensor data fails."},{"line_number":205,"context_line":"        :returns: returns a dict of sensor data group by sensor type."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_5e96a695","line":204,"in_reply_to":"1a930d6b_c30bd129","updated":"2015-01-22 09:38:57.000000000","message":"I\u0027ll fix that.","commit_id":"4ba891110fcc997380fcd8b0e17f30d84b6d5d1e"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"372fc677285f41ffa6315f5851f48dfa506f317e","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        self.validate(task)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        if driver_utils.get_node_capability(task.node, \u0027boot_mode\u0027) \u003d\u003d \u0027uefi\u0027:"},{"line_number":142,"context_line":"            if device not in self.get_supported_boot_devices():"},{"line_number":143,"context_line":"                raise exception.InvalidParameterValue(_("},{"line_number":144,"context_line":"                    \"Invalid boot device %s specified.\") % device)"},{"line_number":145,"context_line":"            timeout_disable \u003d \"0x00 0x08 0x03 0x08\""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_b7712446","line":142,"updated":"2015-01-30 13:45:59.000000000","message":"Shouldn\u0027t we pull this above the first if condition ?","commit_id":"f445a0d5896b57bbcdc24c90e496cb1679437537"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"f93effe702ef3a32209f369bf88f00e45c4f63bd","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        self.validate(task)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        if driver_utils.get_node_capability(task.node, \u0027boot_mode\u0027) \u003d\u003d \u0027uefi\u0027:"},{"line_number":142,"context_line":"            if device not in self.get_supported_boot_devices():"},{"line_number":143,"context_line":"                raise exception.InvalidParameterValue(_("},{"line_number":144,"context_line":"                    \"Invalid boot device %s specified.\") % device)"},{"line_number":145,"context_line":"            timeout_disable \u003d \"0x00 0x08 0x03 0x08\""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_c2bfb4a8","line":142,"in_reply_to":"fa81d914_b7712446","updated":"2015-01-30 14:52:45.000000000","message":"I intentionally put the condition here to prevent us from doing the same check twice in case of BIOS boot mode.\n\nBecause this check is also done in the super(ipmitool.IPMIManagement, self).set_boot_device() as well.","commit_id":"f445a0d5896b57bbcdc24c90e496cb1679437537"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"cd920387f7c7db0173ab42142769522ee2db5876","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        self.validate(task)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        if driver_utils.get_node_capability(task.node, \u0027boot_mode\u0027) \u003d\u003d \u0027uefi\u0027:"},{"line_number":142,"context_line":"            if device not in self.get_supported_boot_devices():"},{"line_number":143,"context_line":"                raise exception.InvalidParameterValue(_("},{"line_number":144,"context_line":"                    \"Invalid boot device %s specified.\") % device)"},{"line_number":145,"context_line":"            timeout_disable \u003d \"0x00 0x08 0x03 0x08\""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_fd329d5d","line":142,"in_reply_to":"fa81d914_c2bfb4a8","updated":"2015-01-30 15:07:05.000000000","message":"Okay. Makes sense.","commit_id":"f445a0d5896b57bbcdc24c90e496cb1679437537"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"372fc677285f41ffa6315f5851f48dfa506f317e","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            timeout_disable \u003d \"0x00 0x08 0x03 0x08\""},{"line_number":146,"context_line":"            ipmitool._send_raw(task, timeout_disable)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"            # note(naohirot): As of imimtool version 1.8.13,"},{"line_number":149,"context_line":"            # in case of chassis command, the efiboot option doesn\u0027t"},{"line_number":150,"context_line":"            # get set with persistent at the same time."},{"line_number":151,"context_line":"            # $ ipmitool chassis bootdev pxe options\u003defiboot,persistent"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_37861414","line":148,"updated":"2015-01-30 13:45:59.000000000","message":"nit: ipmitool","commit_id":"f445a0d5896b57bbcdc24c90e496cb1679437537"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"f93effe702ef3a32209f369bf88f00e45c4f63bd","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            timeout_disable \u003d \"0x00 0x08 0x03 0x08\""},{"line_number":146,"context_line":"            ipmitool._send_raw(task, timeout_disable)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"            # note(naohirot): As of imimtool version 1.8.13,"},{"line_number":149,"context_line":"            # in case of chassis command, the efiboot option doesn\u0027t"},{"line_number":150,"context_line":"            # get set with persistent at the same time."},{"line_number":151,"context_line":"            # $ ipmitool chassis bootdev pxe options\u003defiboot,persistent"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_624d283e","line":148,"in_reply_to":"fa81d914_37861414","updated":"2015-01-30 14:52:45.000000000","message":"I\u0027ll fix that.","commit_id":"f445a0d5896b57bbcdc24c90e496cb1679437537"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"4e2aeeaae09c0593a0d1bed9316b12ba4a1c3352","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"scci \u003d importutils.try_import(\u0027scciclient.irmc.scci\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"CONF \u003d cfg.CONF"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"da86d52c_9920154b","line":32,"updated":"2015-02-03 04:50:33.000000000","message":"not using CONF anywhere?","commit_id":"847c60ceffe6e6a7b630eca3b9cfdb18ce8e35a0"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"5475ca8ef11dc695ffa9709de6f9b087ffefa450","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"scci \u003d importutils.try_import(\u0027scciclient.irmc.scci\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"CONF \u003d cfg.CONF"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"da86d52c_343570f7","line":32,"in_reply_to":"da86d52c_9920154b","updated":"2015-02-03 06:20:07.000000000","message":"I\u0027ll remove it.","commit_id":"847c60ceffe6e6a7b630eca3b9cfdb18ce8e35a0"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"4e2aeeaae09c0593a0d1bed9316b12ba4a1c3352","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        return irmc_common.COMMON_PROPERTIES"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def validate(self, task):"},{"line_number":106,"context_line":"        \"\"\"Validate the driver-specific Node power info."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        This method validates whether the \u0027driver_info\u0027 property of the"},{"line_number":109,"context_line":"        supplied node contains the required information for this driver to"}],"source_content_type":"text/x-python","patch_set":13,"id":"da86d52c_39be49d5","line":106,"updated":"2015-02-03 04:50:33.000000000","message":"power Info?","commit_id":"847c60ceffe6e6a7b630eca3b9cfdb18ce8e35a0"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"5475ca8ef11dc695ffa9709de6f9b087ffefa450","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        return irmc_common.COMMON_PROPERTIES"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def validate(self, task):"},{"line_number":106,"context_line":"        \"\"\"Validate the driver-specific Node power info."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        This method validates whether the \u0027driver_info\u0027 property of the"},{"line_number":109,"context_line":"        supplied node contains the required information for this driver to"}],"source_content_type":"text/x-python","patch_set":13,"id":"da86d52c_b42080b1","line":106,"in_reply_to":"da86d52c_39be49d5","updated":"2015-02-03 06:20:07.000000000","message":"I\u0027ll fix that.","commit_id":"847c60ceffe6e6a7b630eca3b9cfdb18ce8e35a0"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"4e2aeeaae09c0593a0d1bed9316b12ba4a1c3352","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        This method validates whether the \u0027driver_info\u0027 property of the"},{"line_number":109,"context_line":"        supplied node contains the required information for this driver to"},{"line_number":110,"context_line":"        manage the power state of the node. If invalid, raises an exception;"},{"line_number":111,"context_line":"        otherwise, returns None."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        :param task: a TaskManager instance containing the node to act on."}],"source_content_type":"text/x-python","patch_set":13,"id":"da86d52c_f9ecb1f5","line":110,"updated":"2015-02-03 04:50:33.000000000","message":"why is it specific to power state ?","commit_id":"847c60ceffe6e6a7b630eca3b9cfdb18ce8e35a0"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"5475ca8ef11dc695ffa9709de6f9b087ffefa450","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        This method validates whether the \u0027driver_info\u0027 property of the"},{"line_number":109,"context_line":"        supplied node contains the required information for this driver to"},{"line_number":110,"context_line":"        manage the power state of the node. If invalid, raises an exception;"},{"line_number":111,"context_line":"        otherwise, returns None."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        :param task: a TaskManager instance containing the node to act on."}],"source_content_type":"text/x-python","patch_set":13,"id":"da86d52c_48008401","line":110,"in_reply_to":"da86d52c_f9ecb1f5","updated":"2015-02-03 06:20:07.000000000","message":"I\u0027ll fix that.","commit_id":"847c60ceffe6e6a7b630eca3b9cfdb18ce8e35a0"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"4e2aeeaae09c0593a0d1bed9316b12ba4a1c3352","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        :raises: IPMIFailure on an error from ipmitool."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        \"\"\""},{"line_number":139,"context_line":"        self.validate(task)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        if driver_utils.get_node_capability(task.node, \u0027boot_mode\u0027) \u003d\u003d \u0027uefi\u0027:"},{"line_number":142,"context_line":"            if device not in self.get_supported_boot_devices():"}],"source_content_type":"text/x-python","patch_set":13,"id":"da86d52c_d99fed5d","line":139,"updated":"2015-02-03 04:50:33.000000000","message":"is it again required to validate? conductor will call validate before delegating to driver specific right ? https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L1236","commit_id":"847c60ceffe6e6a7b630eca3b9cfdb18ce8e35a0"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"5475ca8ef11dc695ffa9709de6f9b087ffefa450","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        :raises: IPMIFailure on an error from ipmitool."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        \"\"\""},{"line_number":139,"context_line":"        self.validate(task)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        if driver_utils.get_node_capability(task.node, \u0027boot_mode\u0027) \u003d\u003d \u0027uefi\u0027:"},{"line_number":142,"context_line":"            if device not in self.get_supported_boot_devices():"}],"source_content_type":"text/x-python","patch_set":13,"id":"da86d52c_a824a0af","line":139,"in_reply_to":"da86d52c_d99fed5d","updated":"2015-02-03 06:20:07.000000000","message":"I\u0027ll remove it.","commit_id":"847c60ceffe6e6a7b630eca3b9cfdb18ce8e35a0"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"4e2aeeaae09c0593a0d1bed9316b12ba4a1c3352","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            return super(IRMCManagement, self).get_sensors_data(task)"},{"line_number":213,"context_line":"        else:"},{"line_number":214,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":215,"context_line":"                \"Invalid irmc_sensor_method %s specified.\") %"},{"line_number":216,"context_line":"                                                  sensor_method)"}],"source_content_type":"text/x-python","patch_set":13,"id":"da86d52c_b99eb952","line":215,"updated":"2015-02-03 04:50:33.000000000","message":"Its already verified in parse_driver_info (validate ) , not required again?","commit_id":"847c60ceffe6e6a7b630eca3b9cfdb18ce8e35a0"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"5475ca8ef11dc695ffa9709de6f9b087ffefa450","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            return super(IRMCManagement, self).get_sensors_data(task)"},{"line_number":213,"context_line":"        else:"},{"line_number":214,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":215,"context_line":"                \"Invalid irmc_sensor_method %s specified.\") %"},{"line_number":216,"context_line":"                                                  sensor_method)"}],"source_content_type":"text/x-python","patch_set":13,"id":"da86d52c_e83cd8c1","line":215,"in_reply_to":"da86d52c_b99eb952","updated":"2015-02-03 06:20:07.000000000","message":"I\u0027ll remove it.","commit_id":"847c60ceffe6e6a7b630eca3b9cfdb18ce8e35a0"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"c0f50999b6eafd615322d0fbaa675f134d65badc","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ironic.common.i18n import _"},{"line_number":22,"context_line":"from ironic.common.i18n import _LE"},{"line_number":23,"context_line":"from ironic.conductor import task_manager"},{"line_number":24,"context_line":"import ironic.drivers.modules.ipmitool as ipmitool"},{"line_number":25,"context_line":"from ironic.drivers.modules.irmc import common as irmc_common"},{"line_number":26,"context_line":"from ironic.drivers import utils as driver_utils"},{"line_number":27,"context_line":"from ironic.openstack.common import log as logging"}],"source_content_type":"text/x-python","patch_set":14,"id":"da86d52c_4d088e91","line":24,"updated":"2015-02-03 10:40:26.000000000","message":"from ironic.drivers.modules import ipmitool ( as is not required ) .. may be you can change for consistency in next patch :)","commit_id":"bf3f0ae3cfd5a49bdc78284c709a045f6efaa765"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"450846c955ccf7a923688e62bd5b6c3011908d8f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ironic.common.i18n import _"},{"line_number":22,"context_line":"from ironic.common.i18n import _LE"},{"line_number":23,"context_line":"from ironic.conductor import task_manager"},{"line_number":24,"context_line":"import ironic.drivers.modules.ipmitool as ipmitool"},{"line_number":25,"context_line":"from ironic.drivers.modules.irmc import common as irmc_common"},{"line_number":26,"context_line":"from ironic.drivers import utils as driver_utils"},{"line_number":27,"context_line":"from ironic.openstack.common import log as logging"}],"source_content_type":"text/x-python","patch_set":14,"id":"da86d52c_f313e4b5","line":24,"in_reply_to":"da86d52c_4d088e91","updated":"2015-02-03 11:51:05.000000000","message":"This is necessary to call ipmitool._send_raw() at the line 139.","commit_id":"bf3f0ae3cfd5a49bdc78284c709a045f6efaa765"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"5d75859e8ad866d573ed5fbcb1fff6a6831a401d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ironic.common.i18n import _"},{"line_number":22,"context_line":"from ironic.common.i18n import _LE"},{"line_number":23,"context_line":"from ironic.conductor import task_manager"},{"line_number":24,"context_line":"import ironic.drivers.modules.ipmitool as ipmitool"},{"line_number":25,"context_line":"from ironic.drivers.modules.irmc import common as irmc_common"},{"line_number":26,"context_line":"from ironic.drivers import utils as driver_utils"},{"line_number":27,"context_line":"from ironic.openstack.common import log as logging"}],"source_content_type":"text/x-python","patch_set":14,"id":"da86d52c_5b249ec4","line":24,"in_reply_to":"da86d52c_d80b348c","updated":"2015-02-04 06:10:17.000000000","message":"Anusha,\n\nThe from form like \"from ironic.drivers.modules import ipmitool\" doesn\u0027t allow us to call  a function which starts with underscore such as _send_raw().\nBut the import form allows us.\nThat\u0027s why I changed it to \"\timport ironic.drivers.modules.ipmitool as ipmitool\"\n\nThanks. :)\n\nNaohiro","commit_id":"bf3f0ae3cfd5a49bdc78284c709a045f6efaa765"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"8fd0a3e150332eadde63d6ca18c14fec6084e2b0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ironic.common.i18n import _"},{"line_number":22,"context_line":"from ironic.common.i18n import _LE"},{"line_number":23,"context_line":"from ironic.conductor import task_manager"},{"line_number":24,"context_line":"import ironic.drivers.modules.ipmitool as ipmitool"},{"line_number":25,"context_line":"from ironic.drivers.modules.irmc import common as irmc_common"},{"line_number":26,"context_line":"from ironic.drivers import utils as driver_utils"},{"line_number":27,"context_line":"from ironic.openstack.common import log as logging"}],"source_content_type":"text/x-python","patch_set":14,"id":"da86d52c_d80b348c","line":24,"in_reply_to":"da86d52c_f313e4b5","updated":"2015-02-04 03:54:11.000000000","message":"no.. I meant change the above import to ,\"from ironic.drivers.modules import ipmitool\" , for consistency, its fine if you dont want to :)","commit_id":"bf3f0ae3cfd5a49bdc78284c709a045f6efaa765"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"beac4a7d7d092dbc169ba05f45532e08e36bf9df","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                     boot_devices.DISK: \u00270x08\u0027,"},{"line_number":35,"context_line":"                     boot_devices.CDROM: \u00270x14\u0027,"},{"line_number":36,"context_line":"                     boot_devices.BIOS: \u00270x18\u0027,"},{"line_number":37,"context_line":"                     boot_devices.SAFE: \u00270x0c\u0027}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _get_sensors_data(task):"}],"source_content_type":"text/x-python","patch_set":16,"id":"da86d52c_fe17c042","line":37,"updated":"2015-02-05 14:20:20.000000000","message":"nit: Add trailing comma and put bracket on next line.\n\n   boot_devices.SAFE: \u00270x0c\u0027,\n ]","commit_id":"89ed8afe0dec46e262ae703e213716f74ce15c63"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"b3f91dc29d8532b87491f7ab9e1499811dd8cb1e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                     boot_devices.DISK: \u00270x08\u0027,"},{"line_number":35,"context_line":"                     boot_devices.CDROM: \u00270x14\u0027,"},{"line_number":36,"context_line":"                     boot_devices.BIOS: \u00270x18\u0027,"},{"line_number":37,"context_line":"                     boot_devices.SAFE: \u00270x0c\u0027}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _get_sensors_data(task):"}],"source_content_type":"text/x-python","patch_set":16,"id":"da86d52c_b2956234","line":37,"in_reply_to":"da86d52c_fe17c042","updated":"2015-02-06 02:44:32.000000000","message":"I\u0027ll fix that.","commit_id":"89ed8afe0dec46e262ae703e213716f74ce15c63"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"beac4a7d7d092dbc169ba05f45532e08e36bf9df","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    except Exception as e:"},{"line_number":55,"context_line":"        LOG.error(_LE(\"SCCI get sensor data failed for node %(node_id)s \""},{"line_number":56,"context_line":"                  \"with the following error: %(error)s\"),"},{"line_number":57,"context_line":"              {\u0027node_id\u0027: task.node.uuid, \u0027error\u0027: e})"},{"line_number":58,"context_line":"        raise exception.FailedToGetSensorData("},{"line_number":59,"context_line":"                    node\u003dtask.node.uuid, error\u003de)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"da86d52c_4312b562","line":57,"updated":"2015-02-05 14:20:20.000000000","message":"nit: indentation","commit_id":"89ed8afe0dec46e262ae703e213716f74ce15c63"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"b3f91dc29d8532b87491f7ab9e1499811dd8cb1e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    except Exception as e:"},{"line_number":55,"context_line":"        LOG.error(_LE(\"SCCI get sensor data failed for node %(node_id)s \""},{"line_number":56,"context_line":"                  \"with the following error: %(error)s\"),"},{"line_number":57,"context_line":"              {\u0027node_id\u0027: task.node.uuid, \u0027error\u0027: e})"},{"line_number":58,"context_line":"        raise exception.FailedToGetSensorData("},{"line_number":59,"context_line":"                    node\u003dtask.node.uuid, error\u003de)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"da86d52c_d298166c","line":57,"in_reply_to":"da86d52c_4312b562","updated":"2015-02-06 02:44:32.000000000","message":"I\u0027ll fix that.","commit_id":"89ed8afe0dec46e262ae703e213716f74ce15c63"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"beac4a7d7d092dbc169ba05f45532e08e36bf9df","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        sensors_data.setdefault(sensor_type, {})[sensor_id] \u003d {"},{"line_number":86,"context_line":"              \u0027Sensor Reading\u0027: sensor_reading,"},{"line_number":87,"context_line":"              \u0027Sensor ID\u0027: sensor_id,"},{"line_number":88,"context_line":"              \u0027Units\u0027: reading_units_text}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    return sensors_data"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"da86d52c_7e5af02a","line":88,"updated":"2015-02-05 14:20:20.000000000","message":"nit: add trailing command and put brace on next line","commit_id":"89ed8afe0dec46e262ae703e213716f74ce15c63"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"b3f91dc29d8532b87491f7ab9e1499811dd8cb1e","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        sensors_data.setdefault(sensor_type, {})[sensor_id] \u003d {"},{"line_number":86,"context_line":"              \u0027Sensor Reading\u0027: sensor_reading,"},{"line_number":87,"context_line":"              \u0027Sensor ID\u0027: sensor_id,"},{"line_number":88,"context_line":"              \u0027Units\u0027: reading_units_text}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    return sensors_data"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"da86d52c_f29b5a63","line":88,"in_reply_to":"da86d52c_7e5af02a","updated":"2015-02-06 02:44:32.000000000","message":"I\u0027ll fix that.","commit_id":"89ed8afe0dec46e262ae703e213716f74ce15c63"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"beac4a7d7d092dbc169ba05f45532e08e36bf9df","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        if sensor_method \u003d\u003d \u0027scci\u0027:"},{"line_number":204,"context_line":"            return _get_sensors_data(task)"},{"line_number":205,"context_line":"        elif sensor_method \u003d\u003d \u0027ipmitool\u0027:"},{"line_number":206,"context_line":"            return super(IRMCManagement, self).get_sensors_data(task)"}],"source_content_type":"text/x-python","patch_set":16,"id":"da86d52c_03cb5d1f","line":206,"updated":"2015-02-05 14:20:20.000000000","message":"Should there be something like this??\n\n else:\n    raise someException(\u0027unknown sensor_method\u0027)","commit_id":"89ed8afe0dec46e262ae703e213716f74ce15c63"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"b3f91dc29d8532b87491f7ab9e1499811dd8cb1e","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        if sensor_method \u003d\u003d \u0027scci\u0027:"},{"line_number":204,"context_line":"            return _get_sensors_data(task)"},{"line_number":205,"context_line":"        elif sensor_method \u003d\u003d \u0027ipmitool\u0027:"},{"line_number":206,"context_line":"            return super(IRMCManagement, self).get_sensors_data(task)"}],"source_content_type":"text/x-python","patch_set":16,"id":"da86d52c_f2b27ae3","line":206,"in_reply_to":"da86d52c_03cb5d1f","updated":"2015-02-06 02:44:32.000000000","message":"I agree with you in terms of protective programming.\nThe original code was written in the way you suggested.\nplease look at the patch set #13\n\nhttps://review.openstack.org/#/c/146803/13..16/ironic/drivers/modules/irmc/management.py","commit_id":"89ed8afe0dec46e262ae703e213716f74ce15c63"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"72227caa53c9359ca3b5df33fad8cc272ddcb1e3","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        if sensor_method \u003d\u003d \u0027scci\u0027:"},{"line_number":204,"context_line":"            return _get_sensors_data(task)"},{"line_number":205,"context_line":"        elif sensor_method \u003d\u003d \u0027ipmitool\u0027:"},{"line_number":206,"context_line":"            return super(IRMCManagement, self).get_sensors_data(task)"}],"source_content_type":"text/x-python","patch_set":16,"id":"da86d52c_264853cb","line":206,"in_reply_to":"da86d52c_f2b27ae3","updated":"2015-02-06 03:37:38.000000000","message":"I agree with you too :)","commit_id":"89ed8afe0dec46e262ae703e213716f74ce15c63"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c7f0410804954d5344d2c3ea7687340deab8ec29","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"_BOOTPARAM5_DATA2 \u003d {boot_devices.PXE: \u00270x04\u0027,"},{"line_number":34,"context_line":"                     boot_devices.DISK: \u00270x08\u0027,"},{"line_number":35,"context_line":"                     boot_devices.CDROM: \u00270x14\u0027,"},{"line_number":36,"context_line":"                     boot_devices.BIOS: \u00270x18\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"da86d52c_d1f7dc8a","line":33,"updated":"2015-02-09 17:30:14.000000000","message":"can we have a better name for this variable? people tend to use BOOT_DEVICE_MAPPING or kind of","commit_id":"3b4e6dd38f6e8c1a4465b9f409c7c7efd6f34a7a"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"cd4781c695ec3dbca6fbe32c8cacb78d7602b46c","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"_BOOTPARAM5_DATA2 \u003d {boot_devices.PXE: \u00270x04\u0027,"},{"line_number":34,"context_line":"                     boot_devices.DISK: \u00270x08\u0027,"},{"line_number":35,"context_line":"                     boot_devices.CDROM: \u00270x14\u0027,"},{"line_number":36,"context_line":"                     boot_devices.BIOS: \u00270x18\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"da86d52c_bbb93617","line":33,"in_reply_to":"da86d52c_d1f7dc8a","updated":"2015-02-10 14:10:56.000000000","message":"It means \"Boot Option Parameters #5 Data2\" which is defined in Set/Get System Boot Options Command , IPMI spec v2.0.\n\nI\u0027ll add the comment.","commit_id":"3b4e6dd38f6e8c1a4465b9f409c7c7efd6f34a7a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c7f0410804954d5344d2c3ea7687340deab8ec29","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        reading_units_text \u003d \"None\" if ("},{"line_number":81,"context_line":"            reading_units.text is None) else reading_units.text"},{"line_number":82,"context_line":"        reading_value_text \u003d \"None\" if ("},{"line_number":83,"context_line":"            reading_value.text is None) else reading_value.text"},{"line_number":84,"context_line":"        sensor_reading \u003d \u0027%s %s\u0027 % (reading_value_text, reading_units_text)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        sensors_data.setdefault(sensor_type, {})[sensor_id] \u003d {"}],"source_content_type":"text/x-python","patch_set":18,"id":"da86d52c_314918b8","line":83,"updated":"2015-02-09 17:30:14.000000000","message":"you can use just str(reading_value.text), str(None) is \"None\"","commit_id":"3b4e6dd38f6e8c1a4465b9f409c7c7efd6f34a7a"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"83b2f3483f59892f3fa5b9e76f4b083395f4e6c9","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        reading_units_text \u003d \"None\" if ("},{"line_number":81,"context_line":"            reading_units.text is None) else reading_units.text"},{"line_number":82,"context_line":"        reading_value_text \u003d \"None\" if ("},{"line_number":83,"context_line":"            reading_value.text is None) else reading_value.text"},{"line_number":84,"context_line":"        sensor_reading \u003d \u0027%s %s\u0027 % (reading_value_text, reading_units_text)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        sensors_data.setdefault(sensor_type, {})[sensor_id] \u003d {"}],"source_content_type":"text/x-python","patch_set":18,"id":"da86d52c_c02fd786","line":83,"in_reply_to":"da86d52c_314918b8","updated":"2015-02-10 13:54:27.000000000","message":"I\u0027ll fix that.","commit_id":"3b4e6dd38f6e8c1a4465b9f409c7c7efd6f34a7a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c7f0410804954d5344d2c3ea7687340deab8ec29","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        if sensor_method \u003d\u003d \u0027scci\u0027:"},{"line_number":206,"context_line":"            return _get_sensors_data(task)"},{"line_number":207,"context_line":"        elif sensor_method \u003d\u003d \u0027ipmitool\u0027:"},{"line_number":208,"context_line":"            return super(IRMCManagement, self).get_sensors_data(task)"},{"line_number":209,"context_line":"        else:"},{"line_number":210,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":211,"context_line":"                \"Invalid irmc_sensor_method %s specified.\") %"}],"source_content_type":"text/x-python","patch_set":18,"id":"da86d52c_b1a26849","line":208,"updated":"2015-02-09 17:30:14.000000000","message":"as this is the only reason why we need inheriting from IPMI management, I suggest supporting only scci.. otherwise you need to sets of credentials","commit_id":"3b4e6dd38f6e8c1a4465b9f409c7c7efd6f34a7a"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"83b2f3483f59892f3fa5b9e76f4b083395f4e6c9","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        if sensor_method \u003d\u003d \u0027scci\u0027:"},{"line_number":206,"context_line":"            return _get_sensors_data(task)"},{"line_number":207,"context_line":"        elif sensor_method \u003d\u003d \u0027ipmitool\u0027:"},{"line_number":208,"context_line":"            return super(IRMCManagement, self).get_sensors_data(task)"},{"line_number":209,"context_line":"        else:"},{"line_number":210,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":211,"context_line":"                \"Invalid irmc_sensor_method %s specified.\") %"}],"source_content_type":"text/x-python","patch_set":18,"id":"da86d52c_c0e2772e","line":208,"in_reply_to":"da86d52c_b1a26849","updated":"2015-02-10 13:54:27.000000000","message":"This is not the only reason to inherit from IPMI management.\nImplementing set_boot_device() is also required the inheritance.","commit_id":"3b4e6dd38f6e8c1a4465b9f409c7c7efd6f34a7a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a546fcac1f35f3972d3cd911ccf1d2ebee27921","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    \"\"\"Get sensors data method."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    Convert Sensors Data in SCCI report from XML to the dict format."},{"line_number":47,"context_line":"    :param task: A TaskManager instance."},{"line_number":48,"context_line":"    :raises: FailedToGetSensorData when getting the sensor data fails."},{"line_number":49,"context_line":"    :returns: Returns a consistent formatted dict of sensor data grouped"},{"line_number":50,"context_line":"              by sensor type, which can be processed by Ceilometer."}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_9266d04f","line":47,"updated":"2015-02-11 23:05:05.000000000","message":"We usually add a blank line to separate the description from the parameters.\n\nI think this description could be clearer. I\u0027m guessing it gets sensor data from the task\u0027s node via SCCI?","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"710aa7dfc42851186c4774eba41da717c1b37416","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    \"\"\"Get sensors data method."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    Convert Sensors Data in SCCI report from XML to the dict format."},{"line_number":47,"context_line":"    :param task: A TaskManager instance."},{"line_number":48,"context_line":"    :raises: FailedToGetSensorData when getting the sensor data fails."},{"line_number":49,"context_line":"    :returns: Returns a consistent formatted dict of sensor data grouped"},{"line_number":50,"context_line":"              by sensor type, which can be processed by Ceilometer."}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_8ad04220","line":47,"in_reply_to":"da86d52c_9266d04f","updated":"2015-02-12 09:22:28.000000000","message":"Yes, I\u0027ll fix both.","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a546fcac1f35f3972d3cd911ccf1d2ebee27921","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        reading_units \u003d sdr.find(\u0027./Data/Decoded/Sensor/BaseUnitName\u0027)"},{"line_number":84,"context_line":"        reading_units_text \u003d \"None\" if ("},{"line_number":85,"context_line":"            reading_units is None) else str(reading_units.text)"},{"line_number":86,"context_line":"        sensor_reading \u003d \u0027%s %s\u0027 % (reading_value_text, reading_units_text)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        sensors_data.setdefault(sensor_type, {})[sensor_id] \u003d {"},{"line_number":89,"context_line":"            \u0027Sensor Reading\u0027: sensor_reading,"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_cfcc1abe","line":86,"updated":"2015-02-11 23:05:05.000000000","message":"You\u0027re fine with this being \u0027None None\u0027?","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"710aa7dfc42851186c4774eba41da717c1b37416","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        reading_units \u003d sdr.find(\u0027./Data/Decoded/Sensor/BaseUnitName\u0027)"},{"line_number":84,"context_line":"        reading_units_text \u003d \"None\" if ("},{"line_number":85,"context_line":"            reading_units is None) else str(reading_units.text)"},{"line_number":86,"context_line":"        sensor_reading \u003d \u0027%s %s\u0027 % (reading_value_text, reading_units_text)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        sensors_data.setdefault(sensor_type, {})[sensor_id] \u003d {"},{"line_number":89,"context_line":"            \u0027Sensor Reading\u0027: sensor_reading,"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_4aaf2a7d","line":86,"in_reply_to":"da86d52c_cfcc1abe","updated":"2015-02-12 09:22:28.000000000","message":"Yes, SCCI would return None in some case, so None should be recorded to indicate that data was missed during certain time period.","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a546fcac1f35f3972d3cd911ccf1d2ebee27921","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            timeout_disable \u003d \"0x00 0x08 0x03 0x08\""},{"line_number":143,"context_line":"            ipmitool.send_raw(task, timeout_disable)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"            # note(naohirot): As of ipmitool version 1.8.13,"},{"line_number":146,"context_line":"            # in case of chassis command, the efiboot option doesn\u0027t"},{"line_number":147,"context_line":"            # get set with persistent at the same time."},{"line_number":148,"context_line":"            # $ ipmitool chassis bootdev pxe options\u003defiboot,persistent"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_e26d7533","line":145,"updated":"2015-02-11 23:05:05.000000000","message":"what if someone is using ipmitool version \u003c 1.8.13. Will this work still?","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"710aa7dfc42851186c4774eba41da717c1b37416","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            timeout_disable \u003d \"0x00 0x08 0x03 0x08\""},{"line_number":143,"context_line":"            ipmitool.send_raw(task, timeout_disable)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"            # note(naohirot): As of ipmitool version 1.8.13,"},{"line_number":146,"context_line":"            # in case of chassis command, the efiboot option doesn\u0027t"},{"line_number":147,"context_line":"            # get set with persistent at the same time."},{"line_number":148,"context_line":"            # $ ipmitool chassis bootdev pxe options\u003defiboot,persistent"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_8a8be2c1","line":145,"in_reply_to":"da86d52c_e26d7533","updated":"2015-02-12 09:22:28.000000000","message":"Yes, because ipmi raw command is the bare minimum function of IPMI.","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a546fcac1f35f3972d3cd911ccf1d2ebee27921","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        \"\"\"Get sensors data method."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        Convert Sensors Data in SCCI report from XML to the dict format."},{"line_number":170,"context_line":"        :param task: A TaskManager instance."},{"line_number":171,"context_line":"        :raises: FailedToGetSensorData when getting the sensor data fails."},{"line_number":172,"context_line":"        :raises: FailedToParseSensorData when parsing sensor data fails."},{"line_number":173,"context_line":"        :raises: InvalidParameterValue if required parameters are invalid."}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_227eadaf","line":170,"updated":"2015-02-11 23:05:05.000000000","message":"similar comments to the above _get_sensors_data()","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"710aa7dfc42851186c4774eba41da717c1b37416","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        \"\"\"Get sensors data method."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        Convert Sensors Data in SCCI report from XML to the dict format."},{"line_number":170,"context_line":"        :param task: A TaskManager instance."},{"line_number":171,"context_line":"        :raises: FailedToGetSensorData when getting the sensor data fails."},{"line_number":172,"context_line":"        :raises: FailedToParseSensorData when parsing sensor data fails."},{"line_number":173,"context_line":"        :raises: InvalidParameterValue if required parameters are invalid."}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_caa87a22","line":170,"in_reply_to":"da86d52c_227eadaf","updated":"2015-02-12 09:22:28.000000000","message":"I\u0027ll fix that.","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a546fcac1f35f3972d3cd911ccf1d2ebee27921","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                      }"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        \"\"\""},{"line_number":206,"context_line":"        sensor_method \u003d task.node.driver_info[\u0027irmc_sensor_method\u0027]"},{"line_number":207,"context_line":"        if sensor_method \u003d\u003d \u0027scci\u0027:"},{"line_number":208,"context_line":"            return _get_sensors_data(task)"},{"line_number":209,"context_line":"        elif sensor_method \u003d\u003d \u0027ipmitool\u0027:"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_222cedab","line":206,"updated":"2015-02-11 23:05:05.000000000","message":"I thought that was optional. Did you add code that makes sure it exists in driver_info? I must have missed it.","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"710aa7dfc42851186c4774eba41da717c1b37416","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                      }"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        \"\"\""},{"line_number":206,"context_line":"        sensor_method \u003d task.node.driver_info[\u0027irmc_sensor_method\u0027]"},{"line_number":207,"context_line":"        if sensor_method \u003d\u003d \u0027scci\u0027:"},{"line_number":208,"context_line":"            return _get_sensors_data(task)"},{"line_number":209,"context_line":"        elif sensor_method \u003d\u003d \u0027ipmitool\u0027:"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_2da130f8","line":206,"in_reply_to":"da86d52c_222cedab","updated":"2015-02-12 09:22:28.000000000","message":"Yes, irmc_common.parse_driver_info(node) makes sure that it exists.","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"e868213aab1fd57518e435aa6f6d466b1b1de580","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                      }"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        \"\"\""},{"line_number":206,"context_line":"        sensor_method \u003d task.node.driver_info[\u0027irmc_sensor_method\u0027]"},{"line_number":207,"context_line":"        if sensor_method \u003d\u003d \u0027scci\u0027:"},{"line_number":208,"context_line":"            return _get_sensors_data(task)"},{"line_number":209,"context_line":"        elif sensor_method \u003d\u003d \u0027ipmitool\u0027:"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_3f392da4","line":206,"in_reply_to":"da86d52c_244dbe3e","updated":"2015-02-13 01:01:44.000000000","message":"Ruby\n\nI think the following line create the key, irmc_sensor_method\u0027.\n\nopt \u003d {param: info.get(param, CONF.irmc.get(param[len(\u0027irmc_\u0027):]))\t96\n\nIf there isn\u0027t the key, the following line causes exception.\n\nif d_info[\u0027irmc_sensor_method\u0027].lower() not in (\u0027ipmitool\u0027, \u0027scci\u0027):\t110\n\nAnd I confirmed that the following test case worked by adding the last line:\n\nclass IRMCValidateParametersTestCase(db_base.DbTestCase):\n\n    def setUp(self):\n        super(IRMCValidateParametersTestCase, self).setUp()\n        self.node \u003d obj_utils.create_test_node(\n            self.context,\n            driver\u003d\u0027fake_irmc\u0027,\n            driver_info\u003ddb_utils.get_test_irmc_info())\n\n    def test_parse_driver_info(self):\n        info \u003d irmc_common.parse_driver_info(self.node)\n\n        self.assertIsNotNone(info.get(\u0027irmc_address\u0027))\n        self.assertIsNotNone(info.get(\u0027irmc_username\u0027))\n        self.assertIsNotNone(info.get(\u0027irmc_password\u0027))\n        self.assertIsNotNone(info.get(\u0027irmc_client_timeout\u0027))\n        self.assertIsNotNone(info.get(\u0027irmc_port\u0027))\n        self.assertIsNotNone(info.get(\u0027irmc_auth_method\u0027))\n        self.assertIsNotNone(info.get(\u0027irmc_sensor_method\u0027))\n        self.assertEqual(\u0027ipmitool\u0027, info.get(\u0027irmc_sensor_method\u0027))\n\nThanks.\nNaohiro","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6c6dcc0c157ffe875de46c386ee7ebaac0cc711e","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                      }"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        \"\"\""},{"line_number":206,"context_line":"        sensor_method \u003d task.node.driver_info[\u0027irmc_sensor_method\u0027]"},{"line_number":207,"context_line":"        if sensor_method \u003d\u003d \u0027scci\u0027:"},{"line_number":208,"context_line":"            return _get_sensors_data(task)"},{"line_number":209,"context_line":"        elif sensor_method \u003d\u003d \u0027ipmitool\u0027:"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_244dbe3e","line":206,"in_reply_to":"da86d52c_2da130f8","updated":"2015-02-12 15:15:48.000000000","message":"irmc_common.parse_driver_info(node) makes sure that the dictionary returned from info\u003d irmc_common.parse_driver_info(node) has a \u0027irmc_sensor_method\u0027 key. It doesn\u0027t ensure that node.driver_info[\u0027irmc_sensor_method\u0027] exists because that is optional.\n\nFrom looking at irmc_common.parse_driver_info(), I see that if driver_info does NOT have \u0027irmc_sensor_method\u0027 specified, then that value is taken from the config value \u0027sensor_method\u0027. But this value is NOT placed in driver_info. So how can you guarantee that task.node.driver_info has a \u0027irmc_sensor_method\u0027 key?\n\nWhat am I missing?","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"867c85dc08565de9a764f3e89f5b93dc63da834f","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                      }"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        \"\"\""},{"line_number":206,"context_line":"        sensor_method \u003d task.node.driver_info[\u0027irmc_sensor_method\u0027]"},{"line_number":207,"context_line":"        if sensor_method \u003d\u003d \u0027scci\u0027:"},{"line_number":208,"context_line":"            return _get_sensors_data(task)"},{"line_number":209,"context_line":"        elif sensor_method \u003d\u003d \u0027ipmitool\u0027:"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_a53c2ce2","line":206,"in_reply_to":"da86d52c_3f392da4","updated":"2015-02-13 02:36:26.000000000","message":"Ruby,\n\nI understood your point.\nI fixed like this:\n        d_info \u003d irmc_common.parse_driver_info(task.node)\n        sensor_method \u003d d_info[\u0027irmc_sensor_method\u0027]\n\nThanks for your insightful review.\n\nNaohiro","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a546fcac1f35f3972d3cd911ccf1d2ebee27921","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        else:"},{"line_number":212,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":213,"context_line":"                \"Invalid irmc_sensor_method %s specified.\") %"},{"line_number":214,"context_line":"                                                  sensor_method)"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_452e4b8d","line":214,"updated":"2015-02-11 23:05:05.000000000","message":"I think you might want to :\n   info \u003d irmc_common.parse_driver_info(task.node)\n  sensor_method \u003d info[\u0027irmc_sensor_method\u0027]\n\nThen you\u0027ll know that the value is valid.","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"710aa7dfc42851186c4774eba41da717c1b37416","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        else:"},{"line_number":212,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":213,"context_line":"                \"Invalid irmc_sensor_method %s specified.\") %"},{"line_number":214,"context_line":"                                                  sensor_method)"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_ad928054","line":214,"in_reply_to":"da86d52c_452e4b8d","updated":"2015-02-12 09:22:28.000000000","message":"Yes, I understood your point.\n\nBut I intentionally didn\u0027t put the code,\nbecause the manager calls validate() before get_sensors_data() at \nhttps://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L1210\n\nAlso if I put the validate(), I have to remove \"else\" part again. please look at the comments.\n\nhttps://review.openstack.org/#/c/146803/13..19/ironic/drivers/modules/irmc/management.py\n\nhttps://review.openstack.org/#/c/146803/16..19/ironic/drivers/modules/irmc/management.py","commit_id":"e3e5d6f0ef78d8e04c61633adbcb1e1de23bf39a"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1ce068f80404fec3d2a076e927ced791ce18bd09","unresolved":false,"context_lines":[{"line_number":14,"context_line":"iRMC Management Driver"},{"line_number":15,"context_line":"\"\"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo.utils import importutils"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from ironic.common import boot_devices"},{"line_number":20,"context_line":"from ironic.common import exception"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_68bdffb6","line":17,"updated":"2015-02-25 02:16:56.000000000","message":"We changed everything to oslo_utils recently.","commit_id":"0a5ed24c1e0bf3e1aa87a0d3f911963126526c79"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"3b79e899db8c8cc8408cc159a9e36dfb097d9be6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"iRMC Management Driver"},{"line_number":15,"context_line":"\"\"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo.utils import importutils"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from ironic.common import boot_devices"},{"line_number":20,"context_line":"from ironic.common import exception"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_830a1477","line":17,"in_reply_to":"ba7be1f8_68bdffb6","updated":"2015-02-25 07:04:42.000000000","message":"I\u0027ll fix that.","commit_id":"0a5ed24c1e0bf3e1aa87a0d3f911963126526c79"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b56f39c4457c5bc618e7870da367965c51f6227a","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        # d_info[\u0027irmc_sensor_method\u0027] is either \u0027scci\u0027 or \u0027ipmitool\u0027."},{"line_number":212,"context_line":"        d_info \u003d irmc_common.parse_driver_info(task.node)"},{"line_number":213,"context_line":"        sensor_method \u003d d_info[\u0027irmc_sensor_method\u0027]"},{"line_number":214,"context_line":"        if sensor_method \u003d\u003d \u0027scci\u0027:"},{"line_number":215,"context_line":"            return _get_sensors_data(task)"},{"line_number":216,"context_line":"        elif sensor_method \u003d\u003d \u0027ipmitool\u0027:"},{"line_number":217,"context_line":"            return super(IRMCManagement, self).get_sensors_data(task)"}],"source_content_type":"text/x-python","patch_set":23,"id":"ba7be1f8_0bc26852","line":214,"updated":"2015-02-26 17:07:36.000000000","message":"If all your code is assuming that these values are lower-cased, you should change common.parse_driver_info() so that they are lower-cased.","commit_id":"49ca371a5b1c62bee00eaaa196d8e8fa49e7b9cd"}],"ironic/tests/drivers/irmc/test_common.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1ce068f80404fec3d2a076e927ced791ce18bd09","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.assertIsNotNone(info.get(\u0027irmc_port\u0027))"},{"line_number":50,"context_line":"        self.assertIsNotNone(info.get(\u0027irmc_auth_method\u0027))"},{"line_number":51,"context_line":"        self.assertIsNotNone(info.get(\u0027irmc_sensor_method\u0027))"},{"line_number":52,"context_line":"        self.assertEqual(\u0027ipmitool\u0027, info.get(\u0027irmc_sensor_method\u0027))"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_parse_driver_info_missing_address(self):"},{"line_number":55,"context_line":"        del self.node.driver_info[\u0027irmc_address\u0027]"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_a8b9b77a","line":52,"updated":"2015-02-25 02:16:56.000000000","message":"May be just add a test case where it validates scci as a valid irmc_sensor_method.","commit_id":"0a5ed24c1e0bf3e1aa87a0d3f911963126526c79"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"3b79e899db8c8cc8408cc159a9e36dfb097d9be6","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.assertIsNotNone(info.get(\u0027irmc_port\u0027))"},{"line_number":50,"context_line":"        self.assertIsNotNone(info.get(\u0027irmc_auth_method\u0027))"},{"line_number":51,"context_line":"        self.assertIsNotNone(info.get(\u0027irmc_sensor_method\u0027))"},{"line_number":52,"context_line":"        self.assertEqual(\u0027ipmitool\u0027, info.get(\u0027irmc_sensor_method\u0027))"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_parse_driver_info_missing_address(self):"},{"line_number":55,"context_line":"        del self.node.driver_info[\u0027irmc_address\u0027]"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_71b7a3f5","line":52,"in_reply_to":"ba7be1f8_a8b9b77a","updated":"2015-02-25 07:04:42.000000000","message":"I\u0027ll fix that.","commit_id":"0a5ed24c1e0bf3e1aa87a0d3f911963126526c79"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"7d10f64170d42c0448136f2c4c3b872beb6244f8","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.assertEqual(\u0027basic\u0027, info.get(\u0027irmc_auth_method\u0027))"},{"line_number":58,"context_line":"        self.assertEqual(443, info.get(\u0027irmc_port\u0027))"},{"line_number":59,"context_line":"        self.assertEqual(60, info.get(\u0027irmc_client_timeout\u0027))"},{"line_number":60,"context_line":"        self.assertEqual(\u0027ipmitool\u0027, info.get(\u0027irmc_sensor_method\u0027))"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test_parse_driver_info_missing_address(self):"},{"line_number":63,"context_line":"        del self.node.driver_info[\u0027irmc_address\u0027]"}],"source_content_type":"text/x-python","patch_set":23,"id":"ba7be1f8_4f1f5a6c","line":60,"updated":"2015-02-25 08:30:42.000000000","message":"Since by default it is ipmitool, better it would have been scci.","commit_id":"49ca371a5b1c62bee00eaaa196d8e8fa49e7b9cd"}],"ironic/tests/drivers/irmc/test_management.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"f5081bffcbf2d55254b5e9855cccbbfc8cd7ccbe","unresolved":false,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        self.assertEqual(len(sensor_dict), 2)"},{"line_number":320,"context_line":"        sensor_type1 \u003d sensor_dict[\u0027Temperature (1)\u0027]"},{"line_number":321,"context_line":"        self.assertEqual(len(sensor_type1), 2)"},{"line_number":322,"context_line":"        sensor_type2 \u003d sensor_dict[\u0027Fan (4)\u0027]"},{"line_number":323,"context_line":"        self.assertEqual(len(sensor_type2), 2)"},{"line_number":324,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_d9ff3265","line":321,"updated":"2015-01-20 02:14:04.000000000","message":"Not sure why we assert the leng of the sensor_type1 here?\nAnd the first argument for assertEqual is the *expected* value, it will be more clear if we follow the argument order.","commit_id":"bdc0d175aee6a44af3403adea70bff8f2f94796c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"7bfc1e7c80c68934e7a9dff40634ea906f6711c5","unresolved":false,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        self.assertEqual(len(sensor_dict), 2)"},{"line_number":320,"context_line":"        sensor_type1 \u003d sensor_dict[\u0027Temperature (1)\u0027]"},{"line_number":321,"context_line":"        self.assertEqual(len(sensor_type1), 2)"},{"line_number":322,"context_line":"        sensor_type2 \u003d sensor_dict[\u0027Fan (4)\u0027]"},{"line_number":323,"context_line":"        self.assertEqual(len(sensor_type2), 2)"},{"line_number":324,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_96bd5e06","line":321,"in_reply_to":"3a961159_d9ff3265","updated":"2015-01-21 05:01:03.000000000","message":"I\u0027ll fix that.","commit_id":"bdc0d175aee6a44af3403adea70bff8f2f94796c"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"f5081bffcbf2d55254b5e9855cccbbfc8cd7ccbe","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        sensor_id3 \u003d sensor_type2[\u0027FAN1 SYS (29)\u0027]"},{"line_number":331,"context_line":"        self.assertEqual(len(sensor_id3), 2)"},{"line_number":332,"context_line":"        sensor_id4 \u003d sensor_type2[\u0027FAN2 SYS (29)\u0027]"},{"line_number":333,"context_line":"        self.assertEqual(len(sensor_id4), 2)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    @mock.patch.object(irmc_management, \u0027scci\u0027)"},{"line_number":336,"context_line":"    @mock.patch.object(irmc_common, \u0027get_irmc_report\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_3972f64a","line":333,"updated":"2015-01-20 02:14:04.000000000","message":"I think it is more clear that we define an expected sensors_data which is returned from self.driver.management.get_sensors_data(task), and run one single line to verify the result:\n\n\n  fake_sensors_data \u003d {\n\n  \u0027Temperature (1)\u0027 : { \n                  \u0027Sensor ID 1\u0027 : { \u0027Sensor Reading\u0027 : ’current value 1\u0027 , \u0027Key 2\u0027 : \u0027value 2\u0027  }, \n                  \u0027Sensor ID 2\u0027 : { \u0027Sensor Reading\u0027 : ’current value 2 \u0027 , \u0027Key 2\u0027 : \u0027value 2\u0027 }\n                               },\n \n  \u0027Fan (4)\u0027 : { \n                  \u0027Sensor ID 1\u0027 : { \u0027Sensor Reading\u0027 : ’current value 1\u0027 , \u0027Key 2\u0027 : \u0027value 2\u0027  }, \n                  \u0027Sensor ID 2\u0027 : { \u0027Sensor Reading\u0027 : ’current value 2 \u0027 , \u0027Key 2\u0027 : \u0027value 2\u0027 }\n                               }\n                            }\n\n  self.assertEqual(fake_sensors_data, sensor_dict)","commit_id":"bdc0d175aee6a44af3403adea70bff8f2f94796c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"7bfc1e7c80c68934e7a9dff40634ea906f6711c5","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        sensor_id3 \u003d sensor_type2[\u0027FAN1 SYS (29)\u0027]"},{"line_number":331,"context_line":"        self.assertEqual(len(sensor_id3), 2)"},{"line_number":332,"context_line":"        sensor_id4 \u003d sensor_type2[\u0027FAN2 SYS (29)\u0027]"},{"line_number":333,"context_line":"        self.assertEqual(len(sensor_id4), 2)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    @mock.patch.object(irmc_management, \u0027scci\u0027)"},{"line_number":336,"context_line":"    @mock.patch.object(irmc_common, \u0027get_irmc_report\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_363e6a8c","line":333,"in_reply_to":"3a961159_3972f64a","updated":"2015-01-21 05:01:03.000000000","message":"I\u0027ll fix that.","commit_id":"bdc0d175aee6a44af3403adea70bff8f2f94796c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"86fb3bf8dffea08cecb392c77b57b66814d3ee5c","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                                                   persistent\u003dTrue)"},{"line_number":281,"context_line":"            _send_raw_mock.assert_has_calls(["},{"line_number":282,"context_line":"                mock.call(task, \"0x00 0x08 0x03 0x08\"),"},{"line_number":283,"context_line":"                mock.call(task, \"0x00 0x08 0x05 0xe0 0x0c 0x00 0x00 0x00\")])"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    @mock.patch.object(irmc_management.ipmitool, \"_send_raw\", autospec\u003dTrue)"},{"line_number":286,"context_line":"    def test_management_interface_set_boot_device_uefi_ng1(self,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_63990a1f","line":283,"updated":"2015-01-22 11:40:19.000000000","message":"All this methods set_boot_device_uefi_ok{1, 2, 3, ..., 10} looks pretty much same and we could then share some code between so it\u0027s easier to keep tests updated when needed. What about:\n\n    @mock.patch.object(irmc_management.ipmitool, \"_send_raw\", autospec\u003dTrue)\n    def _test_management_interface_set_boot_device_uefi_ok(self, params,\n                                                           expected_raw_code,\n                                                           send_raw_mock):\n        send_raw_mock.return_value \u003d [None, None]\n\n        with task_manager.acquire(self.context, self.node.uuid) as task:\n            task.node.properties[\u0027capabilities\u0027] \u003d \u0027\u0027\n            driver_utils.add_node_capability(task, \u0027boot_mode\u0027, \u0027uefi\u0027)\n            self.driver.management.set_boot_device(task, **params)\n            send_raw_mock.assert_has_calls([\n                mock.call(task, \"0x00 0x08 0x03 0x08\"),\n                mock.call(task, expected_raw_code)])\n\n    def test_management_interface_set_boot_device_uefi_ok_pxe(self):\n        params \u003d {\u0027device\u0027: boot_devices.PXE, \u0027persistent\u0027: False}\n        self._test_management_interface_set_boot_device_uefi_ok(params,\n            \"0x00 0x08 0x05 0xa0 0x04 0x00 0x00 0x00\")\n\n        params[\u0027persistent\u0027] \u003d True\n        self._test_management_interface_set_boot_device_uefi_ok(params,\n            \"0x00 0x08 0x05 0xe0 0x04 0x00 0x00 0x00\")\n\n    def test_management_interface_set_boot_device_uefi_ok_disk(self):\n        ...\n\n\n    def test_management_interface_set_boot_device_uefi_ok_cdrom(self):\n        ...\n\n     and so on...","commit_id":"4ba891110fcc997380fcd8b0e17f30d84b6d5d1e"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"077129bea2ccf68ff1c937b23c6d697cade69dca","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                                                   persistent\u003dTrue)"},{"line_number":281,"context_line":"            _send_raw_mock.assert_has_calls(["},{"line_number":282,"context_line":"                mock.call(task, \"0x00 0x08 0x03 0x08\"),"},{"line_number":283,"context_line":"                mock.call(task, \"0x00 0x08 0x05 0xe0 0x0c 0x00 0x00 0x00\")])"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    @mock.patch.object(irmc_management.ipmitool, \"_send_raw\", autospec\u003dTrue)"},{"line_number":286,"context_line":"    def test_management_interface_set_boot_device_uefi_ng1(self,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_0cd94e83","line":283,"in_reply_to":"1a930d6b_63990a1f","updated":"2015-01-22 14:32:23.000000000","message":"I\u0027ll fix that.","commit_id":"4ba891110fcc997380fcd8b0e17f30d84b6d5d1e"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"372fc677285f41ffa6315f5851f48dfa506f317e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    def test_validate(self, mock_drvinfo):"},{"line_number":63,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":64,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":65,"context_line":"            task.driver.power.validate(task)"},{"line_number":66,"context_line":"            mock_drvinfo.assert_called_once_with(task.node)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @mock.patch.object(irmc_common, \u0027parse_driver_info\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_57fb88c0","line":65,"updated":"2015-01-30 13:45:59.000000000","message":"task.driver.management.validate().","commit_id":"f445a0d5896b57bbcdc24c90e496cb1679437537"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"f93effe702ef3a32209f369bf88f00e45c4f63bd","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    def test_validate(self, mock_drvinfo):"},{"line_number":63,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":64,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":65,"context_line":"            task.driver.power.validate(task)"},{"line_number":66,"context_line":"            mock_drvinfo.assert_called_once_with(task.node)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @mock.patch.object(irmc_common, \u0027parse_driver_info\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_c2edf4b8","line":65,"in_reply_to":"fa81d914_57fb88c0","updated":"2015-01-30 14:52:45.000000000","message":"I\u0027ll fix that.","commit_id":"f445a0d5896b57bbcdc24c90e496cb1679437537"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"372fc677285f41ffa6315f5851f48dfa506f317e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":73,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":74,"context_line":"            self.assertRaises(exception.InvalidParameterValue,"},{"line_number":75,"context_line":"                              task.driver.power.validate,"},{"line_number":76,"context_line":"                              task)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_management_interface_get_supported_boot_devices(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_77f88cc3","line":75,"updated":"2015-01-30 13:45:59.000000000","message":"task.driver.management.validate()","commit_id":"f445a0d5896b57bbcdc24c90e496cb1679437537"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"f93effe702ef3a32209f369bf88f00e45c4f63bd","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":73,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":74,"context_line":"            self.assertRaises(exception.InvalidParameterValue,"},{"line_number":75,"context_line":"                              task.driver.power.validate,"},{"line_number":76,"context_line":"                              task)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_management_interface_get_supported_boot_devices(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_42390440","line":75,"in_reply_to":"fa81d914_77f88cc3","updated":"2015-01-30 14:52:45.000000000","message":"I\u0027ll fix that.","commit_id":"f445a0d5896b57bbcdc24c90e496cb1679437537"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"372fc677285f41ffa6315f5851f48dfa506f317e","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        set_boot_device_mock \u003d ipmi_management_mock.return_value"},{"line_number":91,"context_line":"        set_boot_device_mock.return_value \u003d None"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        def super_mock(*args, **kwargs):"},{"line_number":94,"context_line":"            if args and issubclass(irmc_management.IRMCManagement, args[0]):"},{"line_number":95,"context_line":"                return ipmi_management_mock"},{"line_number":96,"context_line":"            return __builtin__.original_super(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_f7a8fc8e","line":93,"updated":"2015-01-30 13:45:59.000000000","message":"I think we could simplify it if we just added this above:\n\n  @mock.patch.object(ipmitool.IPMIManagement, \u0027set_boot_device\u0027)","commit_id":"f445a0d5896b57bbcdc24c90e496cb1679437537"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"4749f929d01b2e68b036704396c737599248ac67","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        set_boot_device_mock \u003d ipmi_management_mock.return_value"},{"line_number":91,"context_line":"        set_boot_device_mock.return_value \u003d None"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        def super_mock(*args, **kwargs):"},{"line_number":94,"context_line":"            if args and issubclass(irmc_management.IRMCManagement, args[0]):"},{"line_number":95,"context_line":"                return ipmi_management_mock"},{"line_number":96,"context_line":"            return __builtin__.original_super(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_a388ffc5","line":93,"in_reply_to":"fa81d914_9df0c192","updated":"2015-01-30 17:05:18.000000000","message":"Ramakrishnan,\n\nI found my bug in management.py\n\n -        super(ipmitool.IPMIManagement, self).validate(task)\n +        super(IRMCManagement, self).validate(task)\n\n -            super(ipmitool.IPMIManagement, self).set_boot_device(\n +            super(IRMCManagement, self).set_boot_device(\n                 task, device, persistent)\n\n -            return super(ipmitool.IPMIManagement, self).get_sensors_data(task)\n +            return super(IRMCManagement, self).get_sensors_data(task)\n\n\nThank you very much :)\n\nNaohiro","commit_id":"f445a0d5896b57bbcdc24c90e496cb1679437537"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"f93effe702ef3a32209f369bf88f00e45c4f63bd","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        set_boot_device_mock \u003d ipmi_management_mock.return_value"},{"line_number":91,"context_line":"        set_boot_device_mock.return_value \u003d None"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        def super_mock(*args, **kwargs):"},{"line_number":94,"context_line":"            if args and issubclass(irmc_management.IRMCManagement, args[0]):"},{"line_number":95,"context_line":"                return ipmi_management_mock"},{"line_number":96,"context_line":"            return __builtin__.original_super(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_fd2d3d96","line":93,"in_reply_to":"fa81d914_f7a8fc8e","updated":"2015-01-30 14:52:45.000000000","message":"I tried, but I couldn\u0027t make it.\nIs this the way you advised?\n\n\n    #@testtools.skip(\"mocking super() in this way doesn\u0027t work\")\n    @mock.patch.object(ipmitool.IPMIManagement, \u0027set_boot_device\u0027)\n    def test_management_interface_set_boot_device(self, set_boot_device_mock):\n        with task_manager.acquire(self.context, self.node.uuid) as task:\n            self.driver.management.set_boot_device(task, boot_devices.PXE)\n            set_boot_device_mock.assert_called_once_with(\n                task,\n                boot_devices.PXE,\n                False)\n\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nFAIL: ironic.tests.drivers.irmc.test_management.IRMCManagementTestCase.test_management_interface_set_boot_device\n----------------------------------------------------------------------\nEmpty attachments:\n  pythonlogging:\u0027\u0027\n\nTraceback (most recent call last):\n  File \"/home/naohirot/work/src/ironic/.tox/py27/local/lib/python2.7/site-packages/mock.py\", line 1201, in patched\n    return func(*args, **keywargs)\n  File \"ironic/tests/drivers/irmc/test_management.py\", line 95, in test_management_interface_set_boot_device\n    False)\n  File \"/home/naohirot/work/src/ironic/.tox/py27/local/lib/python2.7/site-packages/mock.py\", line 845, in assert_called_once_with\n    raise AssertionError(msg)\nAssertionError: Expected to be called once. Called 0 times.\n\nRan 18 tests in 0.422s","commit_id":"f445a0d5896b57bbcdc24c90e496cb1679437537"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"cd920387f7c7db0173ab42142769522ee2db5876","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        set_boot_device_mock \u003d ipmi_management_mock.return_value"},{"line_number":91,"context_line":"        set_boot_device_mock.return_value \u003d None"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        def super_mock(*args, **kwargs):"},{"line_number":94,"context_line":"            if args and issubclass(irmc_management.IRMCManagement, args[0]):"},{"line_number":95,"context_line":"                return ipmi_management_mock"},{"line_number":96,"context_line":"            return __builtin__.original_super(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_9df0c192","line":93,"in_reply_to":"fa81d914_fd2d3d96","updated":"2015-01-30 15:07:05.000000000","message":"It is a lot simplified if we do it that way. I have an example for you:\n\nWe inherit in PxeIloDeploy, the code is here:\nhttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/deploy.py#L407-L424\n\nAnd its test is here:\nhttps://github.com/openstack/ironic/blob/master/ironic/tests/drivers/ilo/test_deploy.py#L452-L464","commit_id":"f445a0d5896b57bbcdc24c90e496cb1679437537"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"372fc677285f41ffa6315f5851f48dfa506f317e","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        set_boot_device_mock \u003d ipmi_management_mock.return_value"},{"line_number":115,"context_line":"        set_boot_device_mock.return_value \u003d None"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        def super_mock(*args, **kwargs):"},{"line_number":118,"context_line":"            if args and issubclass(irmc_management.IRMCManagement, args[0]):"},{"line_number":119,"context_line":"                return ipmi_management_mock"},{"line_number":120,"context_line":"            return __builtin__.original_super(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_37aff495","line":117,"updated":"2015-01-30 13:45:59.000000000","message":"Ditto about mocking the method on superclass.","commit_id":"f445a0d5896b57bbcdc24c90e496cb1679437537"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"f93effe702ef3a32209f369bf88f00e45c4f63bd","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        set_boot_device_mock \u003d ipmi_management_mock.return_value"},{"line_number":115,"context_line":"        set_boot_device_mock.return_value \u003d None"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        def super_mock(*args, **kwargs):"},{"line_number":118,"context_line":"            if args and issubclass(irmc_management.IRMCManagement, args[0]):"},{"line_number":119,"context_line":"                return ipmi_management_mock"},{"line_number":120,"context_line":"            return __builtin__.original_super(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_5d3c89c8","line":117,"in_reply_to":"fa81d914_37aff495","updated":"2015-01-30 14:52:45.000000000","message":"Same as above.","commit_id":"f445a0d5896b57bbcdc24c90e496cb1679437537"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"372fc677285f41ffa6315f5851f48dfa506f317e","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                return ipmi_management_mock"},{"line_number":296,"context_line":"            return __builtin__.original_super(*args, **kwargs)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        __builtin__.original_super \u003d super"},{"line_number":299,"context_line":"        __builtin__.super \u003d super_mock"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_77a24c9a","line":298,"updated":"2015-01-30 13:45:59.000000000","message":"Ditto about mocking superclass method.","commit_id":"f445a0d5896b57bbcdc24c90e496cb1679437537"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"f93effe702ef3a32209f369bf88f00e45c4f63bd","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                return ipmi_management_mock"},{"line_number":296,"context_line":"            return __builtin__.original_super(*args, **kwargs)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        __builtin__.original_super \u003d super"},{"line_number":299,"context_line":"        __builtin__.super \u003d super_mock"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_1d569106","line":298,"in_reply_to":"fa81d914_77a24c9a","updated":"2015-01-30 14:52:45.000000000","message":"Same as above.","commit_id":"f445a0d5896b57bbcdc24c90e496cb1679437537"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"c0f50999b6eafd615322d0fbaa675f134d65badc","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from ironic.tests.objects import utils as obj_utils"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"INFO_DICT \u003d db_utils.get_test_irmc_info()"},{"line_number":38,"context_line":"CONF \u003d cfg.CONF"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class IRMCManagementTestCase(db_base.DbTestCase):"}],"source_content_type":"text/x-python","patch_set":14,"id":"da86d52c_6db1d2e0","line":38,"updated":"2015-02-03 10:40:26.000000000","message":"Not used.","commit_id":"bf3f0ae3cfd5a49bdc78284c709a045f6efaa765"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"450846c955ccf7a923688e62bd5b6c3011908d8f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from ironic.tests.objects import utils as obj_utils"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"INFO_DICT \u003d db_utils.get_test_irmc_info()"},{"line_number":38,"context_line":"CONF \u003d cfg.CONF"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class IRMCManagementTestCase(db_base.DbTestCase):"}],"source_content_type":"text/x-python","patch_set":14,"id":"da86d52c_d6c08e2c","line":38,"in_reply_to":"da86d52c_6db1d2e0","updated":"2015-02-03 11:51:05.000000000","message":"I\u0027ll remove it.","commit_id":"bf3f0ae3cfd5a49bdc78284c709a045f6efaa765"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"c0f50999b6eafd615322d0fbaa675f134d65badc","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            set_boot_device_mock):"},{"line_number":103,"context_line":"        \"\"\"bios mode specified.\"\"\""},{"line_number":104,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":105,"context_line":"            task.node.properties[\u0027capabilities\u0027] \u003d \u0027\u0027"},{"line_number":106,"context_line":"            driver_utils.add_node_capability(task, \u0027boot_mode\u0027, \u0027bios\u0027)"},{"line_number":107,"context_line":"            task.driver.management.set_boot_device(task, boot_devices.PXE)"},{"line_number":108,"context_line":"            set_boot_device_mock.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":14,"id":"da86d52c_8d48c688","line":105,"updated":"2015-02-03 10:40:26.000000000","message":"no need to define it prior i guess. add node capability will take care of it .. if its not there","commit_id":"bf3f0ae3cfd5a49bdc78284c709a045f6efaa765"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"450846c955ccf7a923688e62bd5b6c3011908d8f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            set_boot_device_mock):"},{"line_number":103,"context_line":"        \"\"\"bios mode specified.\"\"\""},{"line_number":104,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":105,"context_line":"            task.node.properties[\u0027capabilities\u0027] \u003d \u0027\u0027"},{"line_number":106,"context_line":"            driver_utils.add_node_capability(task, \u0027boot_mode\u0027, \u0027bios\u0027)"},{"line_number":107,"context_line":"            task.driver.management.set_boot_device(task, boot_devices.PXE)"},{"line_number":108,"context_line":"            set_boot_device_mock.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":14,"id":"da86d52c_565d7ee8","line":105,"in_reply_to":"da86d52c_8d48c688","updated":"2015-02-03 11:51:05.000000000","message":"I\u0027ll remove it.","commit_id":"bf3f0ae3cfd5a49bdc78284c709a045f6efaa765"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"c0f50999b6eafd615322d0fbaa675f134d65badc","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                boot_devices.PXE,"},{"line_number":111,"context_line":"                False)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @mock.patch.object(irmc_management.ipmitool, \"_send_raw\", autospec\u003dTrue)"},{"line_number":114,"context_line":"    def _test_management_interface_set_boot_device_uefi_ok(self, params,"},{"line_number":115,"context_line":"                                                           expected_raw_code,"},{"line_number":116,"context_line":"                                                           send_raw_mock):"}],"source_content_type":"text/x-python","patch_set":14,"id":"da86d52c_4d5c0d26","line":113,"updated":"2015-02-03 10:40:26.000000000","message":"is it not just ipmitool ? what does irmc_management.ipmitool specify?","commit_id":"bf3f0ae3cfd5a49bdc78284c709a045f6efaa765"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"450846c955ccf7a923688e62bd5b6c3011908d8f","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                boot_devices.PXE,"},{"line_number":111,"context_line":"                False)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @mock.patch.object(irmc_management.ipmitool, \"_send_raw\", autospec\u003dTrue)"},{"line_number":114,"context_line":"    def _test_management_interface_set_boot_device_uefi_ok(self, params,"},{"line_number":115,"context_line":"                                                           expected_raw_code,"},{"line_number":116,"context_line":"                                                           send_raw_mock):"}],"source_content_type":"text/x-python","patch_set":14,"id":"da86d52c_f6b752d6","line":113,"in_reply_to":"da86d52c_4d5c0d26","updated":"2015-02-03 11:51:05.000000000","message":"irmc_management.ipmitool is the instance of ipmi in ironic.drivers.modules.irmc.management module.\n\nyou can find the detail explanation in here:\nhttp://www.voidspace.org.uk/python/mock/patch.html#where-to-patch","commit_id":"bf3f0ae3cfd5a49bdc78284c709a045f6efaa765"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"c0f50999b6eafd615322d0fbaa675f134d65badc","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        _send_raw_mock.return_value \u003d [None, None]"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":189,"context_line":"            task.node.properties[\u0027capabilities\u0027] \u003d \u0027\u0027"},{"line_number":190,"context_line":"            driver_utils.add_node_capability(task, \u0027boot_mode\u0027, \u0027uefi\u0027)"},{"line_number":191,"context_line":"            e \u003d self.assertRaises(exception.InvalidParameterValue,"},{"line_number":192,"context_line":"                                  self.driver.management.set_boot_device,"}],"source_content_type":"text/x-python","patch_set":14,"id":"da86d52c_8d160654","line":189,"updated":"2015-02-03 10:40:26.000000000","message":"ditto","commit_id":"bf3f0ae3cfd5a49bdc78284c709a045f6efaa765"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"450846c955ccf7a923688e62bd5b6c3011908d8f","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        _send_raw_mock.return_value \u003d [None, None]"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":189,"context_line":"            task.node.properties[\u0027capabilities\u0027] \u003d \u0027\u0027"},{"line_number":190,"context_line":"            driver_utils.add_node_capability(task, \u0027boot_mode\u0027, \u0027uefi\u0027)"},{"line_number":191,"context_line":"            e \u003d self.assertRaises(exception.InvalidParameterValue,"},{"line_number":192,"context_line":"                                  self.driver.management.set_boot_device,"}],"source_content_type":"text/x-python","patch_set":14,"id":"da86d52c_56b57ecb","line":189,"in_reply_to":"da86d52c_8d160654","updated":"2015-02-03 11:51:05.000000000","message":"I\u0027ll remove it.","commit_id":"bf3f0ae3cfd5a49bdc78284c709a045f6efaa765"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"319fbf9c6c612c22f76b9ebc6493208953792d88","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                  self.driver.management.set_boot_device,"},{"line_number":189,"context_line":"                                  task,"},{"line_number":190,"context_line":"                                  \"unknown\")"},{"line_number":191,"context_line":"        self.assertEqual(\"Invalid boot device unknown specified.\", str(e))"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    @mock.patch.object(irmc_management, \u0027scci\u0027)"},{"line_number":194,"context_line":"    @mock.patch.object(irmc_common, \u0027get_irmc_report\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_bb654cb0","line":191,"updated":"2015-02-12 15:15:38.000000000","message":"I think we don\u0027t compare strings because the string might not be in English; it could be translated. I suppose you could look for \u0027unknown\u0027 in the string; that won\u0027t be translated. I am also fine not having this line at all. We don\u0027t typically check the error messages in the tests.","commit_id":"bb8ffc6b2fb0f4e8ce1dd03b019e9c47277816c4"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"edaba2ceabd2e519146498fe3eeea6249019b390","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                  self.driver.management.set_boot_device,"},{"line_number":189,"context_line":"                                  task,"},{"line_number":190,"context_line":"                                  \"unknown\")"},{"line_number":191,"context_line":"        self.assertEqual(\"Invalid boot device unknown specified.\", str(e))"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    @mock.patch.object(irmc_management, \u0027scci\u0027)"},{"line_number":194,"context_line":"    @mock.patch.object(irmc_common, \u0027get_irmc_report\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_31708607","line":191,"in_reply_to":"da86d52c_bb654cb0","updated":"2015-02-13 00:14:15.000000000","message":"Okay, I\u0027ll remove it.","commit_id":"bb8ffc6b2fb0f4e8ce1dd03b019e9c47277816c4"}]}
