)]}'
{"ironic/common/states.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"7acd63954a8c9b8abad1dfac6b6abdfd623d17a6","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"# An errored instance can be rebuilt"},{"line_number":194,"context_line":"# ironic/conductor/manager.py:do_node_deploy()"},{"line_number":195,"context_line":"machine.add_transition(ERROR, DEPLOYING, \u0027rebuild\u0027)"},{"line_number":196,"context_line":"# or deleted"},{"line_number":197,"context_line":"# ironic/conductor/manager.py:do_node_tear_down()"},{"line_number":198,"context_line":"machine.add_transition(ERROR, DELETING, \u0027delete\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_92c91c7d","line":195,"updated":"2015-01-19 10:47:06.000000000","message":"On failure during deploy, we reach to DEPLOYFAIL.  Then \u0027rebuild\u0027 takes us to DEPLOYING.  After this change we might never goto ERROR from DEPLOYING. So this line may be removed I think.","commit_id":"d239273e9648c43283e35f21a57fb32a36b2c0a3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"efe609f8d95dbbcc316b8d874309ea766193b544","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"# An errored instance can be rebuilt"},{"line_number":194,"context_line":"# ironic/conductor/manager.py:do_node_deploy()"},{"line_number":195,"context_line":"machine.add_transition(ERROR, DEPLOYING, \u0027rebuild\u0027)"},{"line_number":196,"context_line":"# or deleted"},{"line_number":197,"context_line":"# ironic/conductor/manager.py:do_node_tear_down()"},{"line_number":198,"context_line":"machine.add_transition(ERROR, DELETING, \u0027delete\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_fe1e9fbb","line":195,"in_reply_to":"3a961159_92c91c7d","updated":"2015-01-19 17:53:36.000000000","message":"Hmm. A node could DELETING -\u003e ERROR. In this case, do we want to prevent ERROR -\u003e (via rebuild) -\u003e DEPLOYING? I think (but haven\u0027t tested/confirmed) that our code allows for this; unless we delete this transition. (and/or maybe depends on why it went to ERROR in the first place.)\n\nI looked at our juno version [1], and it explicitly allows for ERROR -\u003e rebuild. I think if we want to remove this, it should be associated with a bug. The intent of this patch was to remove transitions that our code didn\u0027t exercise/support. \n\n[1] https://github.com/openstack/ironic/blob/stable/juno/ironic/conductor/manager.py#L494","commit_id":"d239273e9648c43283e35f21a57fb32a36b2c0a3"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"56d48e2d75d052c8759f06373b9c04f75719d740","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"# An errored instance can be rebuilt"},{"line_number":194,"context_line":"# ironic/conductor/manager.py:do_node_deploy()"},{"line_number":195,"context_line":"machine.add_transition(ERROR, DEPLOYING, \u0027rebuild\u0027)"},{"line_number":196,"context_line":"# or deleted"},{"line_number":197,"context_line":"# ironic/conductor/manager.py:do_node_tear_down()"},{"line_number":198,"context_line":"machine.add_transition(ERROR, DELETING, \u0027delete\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_3f0f2f31","line":195,"in_reply_to":"3a961159_fe1e9fbb","updated":"2015-01-20 09:34:21.000000000","message":"Yeah, but DELETING -\u003e ERROR ---- (via rebuild) -----\u003e DEPLOYING, I am wondering why would someone do that.  \n\nThe only thing I can think of is - If someone actually planned to delete an instance, and when it errored they changed their mind for a rebuild. :) But I don\u0027t know if it\u0027s a valid case after all. I am okay with filing a bug and removing this.","commit_id":"d239273e9648c43283e35f21a57fb32a36b2c0a3"}]}