)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40da442d903dc1493a68baf6dd985d7c0b4e3ab0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nisha Agarwal \u003cagarwalnisha1980@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-16 06:06:49 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add states required for node-introspection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements : blueprint ironic-node-properties-discovery"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_4d6824ba","line":7,"updated":"2015-01-16 14:06:36.000000000","message":"looks like people call it \u0027inspection\u0027 now","commit_id":"efa50c5b5ab6e4ac47df8ef5f0f1eaa4745f6e42"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ccdf3c0a814bfa25f9f5432d39a9d24da4f78a58","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nisha Agarwal \u003cagarwalnisha1980@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-16 06:06:49 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add states required for node-introspection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements : blueprint ironic-node-properties-discovery"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a930d6b_8fdd2373","line":7,"in_reply_to":"3a961159_4d6824ba","updated":"2015-01-22 20:09:19.000000000","message":"ok","commit_id":"efa50c5b5ab6e4ac47df8ef5f0f1eaa4745f6e42"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"525fc4b0bccbe4b29a1ae62c77f25b5012349864","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add states required for node-inspection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements : blueprint ironic-node-properties-discovery"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Adds states INSPECTING, INSPECTED, INSPECTFAIL,"},{"line_number":12,"context_line":"MANAGEABLE as required by Inspection."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"da86d52c_c4c1584f","line":9,"updated":"2015-02-12 03:14:11.000000000","message":"This is the first time I\u0027ve seen an \u0027Implements\u0027 line occurring before the description. I have no idea whether it matters or not, although [1] mentions putting it at the very end.\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"fd1c7662552dd43de0d4d39a86294b917fe6763d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"1f68115015f01850968b9b1502ff23a74241e839","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add states required for node-inspection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements : blueprint ironic-node-properties-discovery"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Adds states INSPECTING, INSPECTED, INSPECTFAIL,"},{"line_number":12,"context_line":"MANAGEABLE as required by Inspection."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"da86d52c_07a7f2bd","line":9,"in_reply_to":"da86d52c_c4c1584f","updated":"2015-02-12 03:54:10.000000000","message":"ok i will correct in all the patches then. :)","commit_id":"fd1c7662552dd43de0d4d39a86294b917fe6763d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"525fc4b0bccbe4b29a1ae62c77f25b5012349864","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Implements : blueprint ironic-node-properties-discovery"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Adds states INSPECTING, INSPECTED, INSPECTFAIL,"},{"line_number":12,"context_line":"MANAGEABLE as required by Inspection."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If62173d30785ff19c1d10256788190f8d8c519e3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"da86d52c_841da011","line":12,"updated":"2015-02-12 03:14:11.000000000","message":"MANAGEABLE is already there?","commit_id":"fd1c7662552dd43de0d4d39a86294b917fe6763d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"1f68115015f01850968b9b1502ff23a74241e839","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Implements : blueprint ironic-node-properties-discovery"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Adds states INSPECTING, INSPECTED, INSPECTFAIL,"},{"line_number":12,"context_line":"MANAGEABLE as required by Inspection."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If62173d30785ff19c1d10256788190f8d8c519e3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"da86d52c_87cbe270","line":12,"in_reply_to":"da86d52c_841da011","updated":"2015-02-12 03:54:10.000000000","message":"ohk i will remove. Earlier i was adding till Deva\u0027s patch didnt land :)","commit_id":"fd1c7662552dd43de0d4d39a86294b917fe6763d"}],"ironic/common/states.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40da442d903dc1493a68baf6dd985d7c0b4e3ab0","unresolved":false,"context_lines":[{"line_number":158,"context_line":"# TODO(deva): change NOSTATE to AVAILABLE here"},{"line_number":159,"context_line":"machine.add_state(DELETING, target\u003dNOSTATE, **watchers)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"machine.add_state(MANAGEABLE, target\u003dAVAILABLE, **watchers)"},{"line_number":162,"context_line":"machine.add_state(INSPECTED, target\u003dMANAGEABLE, **watchers)"},{"line_number":163,"context_line":"machine.add_state(INSPECTING, target\u003dINSPECTED, **watchers)"},{"line_number":164,"context_line":"machine.add_state(INSPECTFAIL, **watchers)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_8db5ac33","line":161,"updated":"2015-01-16 14:06:36.000000000","message":"IIRC manageable is a stable state","commit_id":"efa50c5b5ab6e4ac47df8ef5f0f1eaa4745f6e42"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ccdf3c0a814bfa25f9f5432d39a9d24da4f78a58","unresolved":false,"context_lines":[{"line_number":158,"context_line":"# TODO(deva): change NOSTATE to AVAILABLE here"},{"line_number":159,"context_line":"machine.add_state(DELETING, target\u003dNOSTATE, **watchers)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"machine.add_state(MANAGEABLE, target\u003dAVAILABLE, **watchers)"},{"line_number":162,"context_line":"machine.add_state(INSPECTED, target\u003dMANAGEABLE, **watchers)"},{"line_number":163,"context_line":"machine.add_state(INSPECTING, target\u003dINSPECTED, **watchers)"},{"line_number":164,"context_line":"machine.add_state(INSPECTFAIL, **watchers)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_ac617fa9","line":161,"in_reply_to":"3a961159_8db5ac33","updated":"2015-01-22 20:09:19.000000000","message":"Yes but it transitions to AVAILABLE state as per state machine model for deploy to start....","commit_id":"efa50c5b5ab6e4ac47df8ef5f0f1eaa4745f6e42"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40da442d903dc1493a68baf6dd985d7c0b4e3ab0","unresolved":false,"context_lines":[{"line_number":207,"context_line":"machine.add_transition(DEPLOYING, ERROR, \u0027error\u0027)"},{"line_number":208,"context_line":"machine.add_transition(ACTIVE, ERROR, \u0027error\u0027)"},{"line_number":209,"context_line":"machine.add_transition(DELETING, ERROR, \u0027error\u0027)"},{"line_number":210,"context_line":"machine.add_transition(INSPECTING, ERROR, \u0027error\u0027)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"# An errored instance can be rebuilt"},{"line_number":213,"context_line":"# ironic/conductor/manager.py:do_node_deploy()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_4d966495","line":210,"updated":"2015-01-16 14:06:36.000000000","message":"s/ERROR/INSPECTFAIL/ ?","commit_id":"efa50c5b5ab6e4ac47df8ef5f0f1eaa4745f6e42"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ccdf3c0a814bfa25f9f5432d39a9d24da4f78a58","unresolved":false,"context_lines":[{"line_number":207,"context_line":"machine.add_transition(DEPLOYING, ERROR, \u0027error\u0027)"},{"line_number":208,"context_line":"machine.add_transition(ACTIVE, ERROR, \u0027error\u0027)"},{"line_number":209,"context_line":"machine.add_transition(DELETING, ERROR, \u0027error\u0027)"},{"line_number":210,"context_line":"machine.add_transition(INSPECTING, ERROR, \u0027error\u0027)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"# An errored instance can be rebuilt"},{"line_number":213,"context_line":"# ironic/conductor/manager.py:do_node_deploy()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_8c3763af","line":210,"in_reply_to":"3a961159_4d966495","updated":"2015-01-22 20:09:19.000000000","message":"I added similar to what we have above....i think it should be same as others. Not very sure though....","commit_id":"efa50c5b5ab6e4ac47df8ef5f0f1eaa4745f6e42"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b89e98c6746aeb706ab092037794e95756faad33","unresolved":false,"context_lines":[{"line_number":135,"context_line":"machine.add_state(ACTIVE, **watchers)"},{"line_number":136,"context_line":"machine.add_state(ERROR, **watchers)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# Add deploy* states"},{"line_number":139,"context_line":"# NOTE(deva): Juno shows a target_provision_state of DEPLOYDONE"},{"line_number":140,"context_line":"#             this is changed in Kilo to ACTIVE"},{"line_number":141,"context_line":"machine.add_state(DEPLOYING, target\u003dACTIVE, **watchers)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_5f8af2bf","side":"PARENT","line":138,"updated":"2015-01-23 11:43:50.000000000","message":"why was this comment deleted?","commit_id":"78a72f5c3b77bfbc940f759a1b52d244033d4657"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b89e98c6746aeb706ab092037794e95756faad33","unresolved":false,"context_lines":[{"line_number":154,"context_line":"# TODO(deva): change NOSTATE to AVAILABLE here"},{"line_number":155,"context_line":"machine.add_state(DELETING, target\u003dNOSTATE, **watchers)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"machine.add_state(MANAGEABLE, **watchers)"},{"line_number":158,"context_line":"machine.add_state(INSPECTED, target\u003dMANAGEABLE, **watchers)"},{"line_number":159,"context_line":"machine.add_state(INSPECTING, target\u003dINSPECTED, **watchers)"},{"line_number":160,"context_line":"machine.add_state(INSPECTFAIL, **watchers)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_3fbb6673","line":157,"updated":"2015-01-23 11:43:50.000000000","message":"I suggest using NOSTATE here and below for now, until migration to ENROLL, MANAGEABLE and AVAILABLE is done","commit_id":"9e62ca4227f4bcf5076f4ee55492311bf208bfbf"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"543e44851da43accff778e72d871abfbac62663b","unresolved":false,"context_lines":[{"line_number":155,"context_line":"machine.add_state(DELETING, target\u003dNOSTATE, **watchers)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"machine.add_state(MANAGEABLE, **watchers)"},{"line_number":158,"context_line":"machine.add_state(INSPECTED, target\u003dMANAGEABLE, **watchers)"},{"line_number":159,"context_line":"machine.add_state(INSPECTING, target\u003dINSPECTED, **watchers)"},{"line_number":160,"context_line":"machine.add_state(INSPECTFAIL, **watchers)"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_b925880a","line":158,"updated":"2015-01-26 00:06:56.000000000","message":"the INSPECTED state is not reachable by any of the transitions you added.","commit_id":"3696186c0ce4d1ae94cbed4101aa97d0a599d90d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"c7150a92ef79ab5bd15bdae9c281ea42103af599","unresolved":false,"context_lines":[{"line_number":155,"context_line":"machine.add_state(DELETING, target\u003dNOSTATE, **watchers)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"machine.add_state(MANAGEABLE, **watchers)"},{"line_number":158,"context_line":"machine.add_state(INSPECTED, target\u003dMANAGEABLE, **watchers)"},{"line_number":159,"context_line":"machine.add_state(INSPECTING, target\u003dINSPECTED, **watchers)"},{"line_number":160,"context_line":"machine.add_state(INSPECTFAIL, **watchers)"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa81d914_52b6b6dd","line":158,"in_reply_to":"1a930d6b_b925880a","updated":"2015-01-28 05:12:01.000000000","message":"ok will add it.","commit_id":"3696186c0ce4d1ae94cbed4101aa97d0a599d90d"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"543e44851da43accff778e72d871abfbac62663b","unresolved":false,"context_lines":[{"line_number":209,"context_line":"machine.add_transition(ERROR, DELETING, \u0027delete\u0027)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"machine.add_transition(MANAGEABLE, INSPECTING, \u0027inspect\u0027)"},{"line_number":212,"context_line":"machine.add_transition(INSPECTING, MANAGEABLE, \u0027done\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_d91ed4ba","line":212,"updated":"2015-01-26 00:06:56.000000000","message":"missing a transition for INSPECTFAIL here\n\nAlso, you probably want INSPECTING to transition to INSPECTED, and that should transition to MANAGEABLE","commit_id":"3696186c0ce4d1ae94cbed4101aa97d0a599d90d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"c7150a92ef79ab5bd15bdae9c281ea42103af599","unresolved":false,"context_lines":[{"line_number":209,"context_line":"machine.add_transition(ERROR, DELETING, \u0027delete\u0027)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"machine.add_transition(MANAGEABLE, INSPECTING, \u0027inspect\u0027)"},{"line_number":212,"context_line":"machine.add_transition(INSPECTING, MANAGEABLE, \u0027done\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa81d914_72bbbac4","line":212,"in_reply_to":"1a930d6b_d91ed4ba","updated":"2015-01-28 05:12:01.000000000","message":"Ok. I was actually confused how INSPECTED will be reached as it is an intermediate state","commit_id":"3696186c0ce4d1ae94cbed4101aa97d0a599d90d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cc3292407cf3bcb157058f2f5bf28385e1b29113","unresolved":false,"context_lines":[{"line_number":135,"context_line":"machine.add_state(ACTIVE, **watchers)"},{"line_number":136,"context_line":"machine.add_state(ERROR, **watchers)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# Add deploy* states"},{"line_number":139,"context_line":"# NOTE(deva): Juno shows a target_provision_state of DEPLOYDONE"},{"line_number":140,"context_line":"#             this is changed in Kilo to ACTIVE"},{"line_number":141,"context_line":"machine.add_state(DEPLOYING, target\u003dACTIVE, **watchers)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa81d914_071e7b63","side":"PARENT","line":138,"updated":"2015-01-29 08:42:22.000000000","message":"why is this line deleted?","commit_id":"00d58f904256a861ed3f8fc6e18ace3156ccb8fb"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"978df9d9237925812f4deba17e20d30604e489bf","unresolved":false,"context_lines":[{"line_number":135,"context_line":"machine.add_state(ACTIVE, **watchers)"},{"line_number":136,"context_line":"machine.add_state(ERROR, **watchers)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# Add deploy* states"},{"line_number":139,"context_line":"# NOTE(deva): Juno shows a target_provision_state of DEPLOYDONE"},{"line_number":140,"context_line":"#             this is changed in Kilo to ACTIVE"},{"line_number":141,"context_line":"machine.add_state(DEPLOYING, target\u003dACTIVE, **watchers)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa81d914_75888fc5","side":"PARENT","line":138,"in_reply_to":"fa81d914_071e7b63","updated":"2015-01-30 08:19:39.000000000","message":"i think it got deleted by mistake while rebasing... :( will add it again.","commit_id":"00d58f904256a861ed3f8fc6e18ace3156ccb8fb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cc3292407cf3bcb157058f2f5bf28385e1b29113","unresolved":false,"context_lines":[{"line_number":155,"context_line":"machine.add_state(DELETING, target\u003dNOSTATE, **watchers)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"# Adding states for inspection."},{"line_number":158,"context_line":"machine.add_state(MANAGEABLE, **watchers)"},{"line_number":159,"context_line":"machine.add_state(INSPECTED, target\u003dMANAGEABLE, **watchers)"},{"line_number":160,"context_line":"machine.add_state(INSPECTING, target\u003dINSPECTED, **watchers)"},{"line_number":161,"context_line":"machine.add_state(INSPECTFAIL, **watchers)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa81d914_d506d01f","line":158,"updated":"2015-01-29 08:42:22.000000000","message":"I guess you should rebase on https://review.openstack.org/#/c/150073/ to get MANAGEABLE state","commit_id":"cdd5c8bf3daffa1045d6988928900ce43560f7d4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"978df9d9237925812f4deba17e20d30604e489bf","unresolved":false,"context_lines":[{"line_number":155,"context_line":"machine.add_state(DELETING, target\u003dNOSTATE, **watchers)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"# Adding states for inspection."},{"line_number":158,"context_line":"machine.add_state(MANAGEABLE, **watchers)"},{"line_number":159,"context_line":"machine.add_state(INSPECTED, target\u003dMANAGEABLE, **watchers)"},{"line_number":160,"context_line":"machine.add_state(INSPECTING, target\u003dINSPECTED, **watchers)"},{"line_number":161,"context_line":"machine.add_state(INSPECTFAIL, **watchers)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa81d914_959183f3","line":158,"in_reply_to":"fa81d914_d506d01f","updated":"2015-01-30 08:19:39.000000000","message":"ok.","commit_id":"cdd5c8bf3daffa1045d6988928900ce43560f7d4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2e8105eda4a933d5b613b000755af686c2caad13","unresolved":false,"context_lines":[{"line_number":219,"context_line":"# Add inspect* states."},{"line_number":220,"context_line":"machine.add_state(INSPECTED, target\u003dMANAGEABLE, **watchers)"},{"line_number":221,"context_line":"machine.add_state(INSPECTING, target\u003dINSPECTED, **watchers)"},{"line_number":222,"context_line":"machine.add_state(INSPECTFAIL, **watchers)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"# A deployment may fail"},{"line_number":225,"context_line":"machine.add_transition(DEPLOYING, DEPLOYFAIL, \u0027fail\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"da86d52c_db51890f","line":222,"updated":"2015-02-03 16:02:42.000000000","message":"Seems that we cannot move anywhere from INSPECTFAIL state? Is that correct behavior?","commit_id":"a26f91f3d90d22da400592ac3c8d8c228395dc00"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"525fc4b0bccbe4b29a1ae62c77f25b5012349864","unresolved":false,"context_lines":[{"line_number":133,"context_line":"provision_state via the REST API."},{"line_number":134,"context_line":"\"\"\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"INSPECTING \u003d \u0027inspecting\u0027"},{"line_number":138,"context_line":"\"\"\" Node is under inspection."},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_04bc50ba","line":136,"updated":"2015-02-12 03:14:11.000000000","message":"wondering why the extra blank line","commit_id":"fd1c7662552dd43de0d4d39a86294b917fe6763d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"822d8a722b06bddc9a10f49f416379d87faae05d","unresolved":false,"context_lines":[{"line_number":133,"context_line":"provision_state via the REST API."},{"line_number":134,"context_line":"\"\"\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"INSPECTING \u003d \u0027inspecting\u0027"},{"line_number":138,"context_line":"\"\"\" Node is under inspection."},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_07d9b256","line":136,"in_reply_to":"da86d52c_04bc50ba","updated":"2015-02-12 03:52:19.000000000","message":"will remove.","commit_id":"fd1c7662552dd43de0d4d39a86294b917fe6763d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"525fc4b0bccbe4b29a1ae62c77f25b5012349864","unresolved":false,"context_lines":[{"line_number":142,"context_line":"\"\"\""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"INSPECTED \u003d \u0027inspected\u0027"},{"line_number":145,"context_line":"\"\"\" Node is successfully inspected."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"This is the transitory value of provision_state and never represented in"},{"line_number":148,"context_line":"target_provision_state."}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_e4df3c0b","line":145,"updated":"2015-02-12 03:14:11.000000000","message":"nit s/is/was/","commit_id":"fd1c7662552dd43de0d4d39a86294b917fe6763d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"822d8a722b06bddc9a10f49f416379d87faae05d","unresolved":false,"context_lines":[{"line_number":142,"context_line":"\"\"\""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"INSPECTED \u003d \u0027inspected\u0027"},{"line_number":145,"context_line":"\"\"\" Node is successfully inspected."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"This is the transitory value of provision_state and never represented in"},{"line_number":148,"context_line":"target_provision_state."}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_a718e61e","line":145,"in_reply_to":"da86d52c_e4df3c0b","updated":"2015-02-12 03:52:19.000000000","message":"ok :)","commit_id":"fd1c7662552dd43de0d4d39a86294b917fe6763d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"525fc4b0bccbe4b29a1ae62c77f25b5012349864","unresolved":false,"context_lines":[{"line_number":144,"context_line":"INSPECTED \u003d \u0027inspected\u0027"},{"line_number":145,"context_line":"\"\"\" Node is successfully inspected."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"This is the transitory value of provision_state and never represented in"},{"line_number":148,"context_line":"target_provision_state."},{"line_number":149,"context_line":"\"\"\""},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_64d34c04","line":147,"updated":"2015-02-12 03:14:11.000000000","message":"nit: s/the/a/","commit_id":"fd1c7662552dd43de0d4d39a86294b917fe6763d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"822d8a722b06bddc9a10f49f416379d87faae05d","unresolved":false,"context_lines":[{"line_number":144,"context_line":"INSPECTED \u003d \u0027inspected\u0027"},{"line_number":145,"context_line":"\"\"\" Node is successfully inspected."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"This is the transitory value of provision_state and never represented in"},{"line_number":148,"context_line":"target_provision_state."},{"line_number":149,"context_line":"\"\"\""},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_871da211","line":147,"in_reply_to":"da86d52c_64d34c04","updated":"2015-02-12 03:52:19.000000000","message":"OK","commit_id":"fd1c7662552dd43de0d4d39a86294b917fe6763d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"525fc4b0bccbe4b29a1ae62c77f25b5012349864","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"# Add inspect* states."},{"line_number":217,"context_line":"machine.add_state(INSPECTED, target\u003dMANAGEABLE, **watchers)"},{"line_number":218,"context_line":"machine.add_state(INSPECTING, target\u003dINSPECTED, **watchers)"},{"line_number":219,"context_line":"machine.add_state(INSPECTFAIL, **watchers)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"# A deployment may fail"}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_440e488d","line":218,"updated":"2015-02-12 03:14:11.000000000","message":"this is a small nit. I\u0027d actually prefer to see INSPECTING before INSPECTED, since I think of INSPECTING -\u003e INSPECTED -\u003e MANAGEABLE","commit_id":"fd1c7662552dd43de0d4d39a86294b917fe6763d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"822d8a722b06bddc9a10f49f416379d87faae05d","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"# Add inspect* states."},{"line_number":217,"context_line":"machine.add_state(INSPECTED, target\u003dMANAGEABLE, **watchers)"},{"line_number":218,"context_line":"machine.add_state(INSPECTING, target\u003dINSPECTED, **watchers)"},{"line_number":219,"context_line":"machine.add_state(INSPECTFAIL, **watchers)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"# A deployment may fail"}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_c74eba37","line":218,"in_reply_to":"da86d52c_440e488d","updated":"2015-02-12 03:52:19.000000000","message":"ok","commit_id":"fd1c7662552dd43de0d4d39a86294b917fe6763d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"525fc4b0bccbe4b29a1ae62c77f25b5012349864","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"# Added transitions for inspection."},{"line_number":270,"context_line":"machine.add_transition(MANAGEABLE, INSPECTING, \u0027inspect\u0027)"},{"line_number":271,"context_line":"machine.add_transition(INSPECTING, INSPECTED, \u0027inspect\u0027)"},{"line_number":272,"context_line":"machine.add_transition(INSPECTING, INSPECTFAIL, \u0027fail\u0027)"},{"line_number":273,"context_line":"machine.add_transition(INSPECTED, MANAGEABLE, \u0027done\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_e4c9fc26","line":271,"updated":"2015-02-12 03:14:11.000000000","message":"I\u0027m not sure about this one. I\u0027d prefer \u0027done\u0027 to \u0027inspect\u0027, since \u0027inspect\u0027 indicates that you want to inspect, but I would think you would want to go to inspected when you\u0027re done inspecting.","commit_id":"fd1c7662552dd43de0d4d39a86294b917fe6763d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"822d8a722b06bddc9a10f49f416379d87faae05d","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"# Added transitions for inspection."},{"line_number":270,"context_line":"machine.add_transition(MANAGEABLE, INSPECTING, \u0027inspect\u0027)"},{"line_number":271,"context_line":"machine.add_transition(INSPECTING, INSPECTED, \u0027inspect\u0027)"},{"line_number":272,"context_line":"machine.add_transition(INSPECTING, INSPECTFAIL, \u0027fail\u0027)"},{"line_number":273,"context_line":"machine.add_transition(INSPECTED, MANAGEABLE, \u0027done\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_47280a33","line":271,"in_reply_to":"da86d52c_e4c9fc26","updated":"2015-02-12 03:52:19.000000000","message":"May be we can use different verb here. I just tried to follow our state machine model :). Suggestions are welcome for this. If verb changes here, it will change in inspection code also.\n\n\u0027done\u0027 is supposed to be executed when transiting from INSPECTED -\u003e MANAGEABLE\n\nWe also agree dto use \u0027ED states as no-op states which i am not sure how to implement. But as part of this transition i update the field \u0027last_inspected\u0027 in the inspection code.","commit_id":"fd1c7662552dd43de0d4d39a86294b917fe6763d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"822cef693c708858e81f4ff8428cda9799ba926e","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"# Add inspect* states."},{"line_number":217,"context_line":"machine.add_state(INSPECTED, target\u003dMANAGEABLE, **watchers)"},{"line_number":218,"context_line":"machine.add_state(INSPECTING, target\u003dINSPECTED, **watchers)"},{"line_number":219,"context_line":"machine.add_state(INSPECTFAIL, target\u003dMANAGEABLE, **watchers)"},{"line_number":220,"context_line":"machine.add_state(INSPECTFAIL, target\u003dINSPECTING, **watchers)"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"da86d52c_2a1f5b5c","line":218,"updated":"2015-02-12 04:33:46.000000000","message":"Cannot swap above two lines as state model then complains that INSPECTED state doesnt exist.","commit_id":"e5fc8bbd8a5c63e263148651d8cf88c494c4bbf1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fc0748d372fde166a4d8d958b29e0ebc1e031ffb","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"# Add inspect* states."},{"line_number":217,"context_line":"machine.add_state(INSPECTED, target\u003dMANAGEABLE, **watchers)"},{"line_number":218,"context_line":"machine.add_state(INSPECTING, target\u003dINSPECTED, **watchers)"},{"line_number":219,"context_line":"machine.add_state(INSPECTFAIL, target\u003dMANAGEABLE, **watchers)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"# A deployment may fail"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_a907c7c8","line":218,"updated":"2015-02-12 14:18:08.000000000","message":"I was thinking about this. Should check with Devananda, but I think his intent was for target to be the end state, ie, I think this should be MANAGEABLE.","commit_id":"90dba53de4c4d7a29b924e0a297be9016c81dbcd"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"a6c3f845212ff697ba02932b377a8293f470ec76","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"# Add inspect* states."},{"line_number":217,"context_line":"machine.add_state(INSPECTED, target\u003dMANAGEABLE, **watchers)"},{"line_number":218,"context_line":"machine.add_state(INSPECTING, target\u003dINSPECTED, **watchers)"},{"line_number":219,"context_line":"machine.add_state(INSPECTFAIL, target\u003dMANAGEABLE, **watchers)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"# A deployment may fail"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_fcaa2870","line":218,"in_reply_to":"da86d52c_a907c7c8","updated":"2015-02-13 14:36:08.000000000","message":"Agree, and we can likely remove the INSPECTED state.","commit_id":"90dba53de4c4d7a29b924e0a297be9016c81dbcd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ba474102e5e39389607c8b937f7e81b49888af94","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"# Add inspect* states."},{"line_number":217,"context_line":"machine.add_state(INSPECTED, target\u003dMANAGEABLE, **watchers)"},{"line_number":218,"context_line":"machine.add_state(INSPECTING, target\u003dINSPECTED, **watchers)"},{"line_number":219,"context_line":"machine.add_state(INSPECTFAIL, target\u003dMANAGEABLE, **watchers)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"# A deployment may fail"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_70aaafd3","line":218,"in_reply_to":"da86d52c_fcaa2870","updated":"2015-02-16 06:47:35.000000000","message":"i have added the target as MANAGEABLE in patch set 20.","commit_id":"90dba53de4c4d7a29b924e0a297be9016c81dbcd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fc0748d372fde166a4d8d958b29e0ebc1e031ffb","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"# Added transitions for inspection."},{"line_number":270,"context_line":"machine.add_transition(MANAGEABLE, INSPECTING, \u0027inspect\u0027)"},{"line_number":271,"context_line":"machine.add_transition(INSPECTING, INSPECTED, \u0027inspect\u0027)"},{"line_number":272,"context_line":"machine.add_transition(INSPECTING, INSPECTFAIL, \u0027fail\u0027)"},{"line_number":273,"context_line":"machine.add_transition(INSPECTED, MANAGEABLE, \u0027done\u0027)"},{"line_number":274,"context_line":"machine.add_transition(INSPECTFAIL, MANAGEABLE, \u0027manage\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_69bcef06","line":271,"updated":"2015-02-12 14:18:08.000000000","message":"We need to resolve this. I don\u0027t see \u0027done\u0027 mentioned in the new state machine spec, nor does that spec mention how to transition from *ING -\u003e *ED -\u003e EndState, or what happens in a *FAIL state.\n\nIt makes sense to me that \u0027done\u0027 would indicate go to the next state, regardless if it was a *ED-\u003eendstate or *ING-\u003e*ED.\n\nUsing the same verb that gets a node into *ING, to also transition *ING -\u003e *ED doesn\u0027t make sense to me.","commit_id":"90dba53de4c4d7a29b924e0a297be9016c81dbcd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bee7c87bcc53c2d47548ecc74b5046aba3ed14ad","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"# Added transitions for inspection."},{"line_number":270,"context_line":"machine.add_transition(MANAGEABLE, INSPECTING, \u0027inspect\u0027)"},{"line_number":271,"context_line":"machine.add_transition(INSPECTING, INSPECTED, \u0027inspect\u0027)"},{"line_number":272,"context_line":"machine.add_transition(INSPECTING, INSPECTFAIL, \u0027fail\u0027)"},{"line_number":273,"context_line":"machine.add_transition(INSPECTED, MANAGEABLE, \u0027done\u0027)"},{"line_number":274,"context_line":"machine.add_transition(INSPECTFAIL, MANAGEABLE, \u0027manage\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_14c32239","line":271,"in_reply_to":"da86d52c_30f757f7","updated":"2015-02-16 10:02:46.000000000","message":"\u003e let me know how is last_inspected updated in in-band implementation\n\nyou should not care about it, in-band inspection driver will do it itself","commit_id":"90dba53de4c4d7a29b924e0a297be9016c81dbcd"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"a6c3f845212ff697ba02932b377a8293f470ec76","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"# Added transitions for inspection."},{"line_number":270,"context_line":"machine.add_transition(MANAGEABLE, INSPECTING, \u0027inspect\u0027)"},{"line_number":271,"context_line":"machine.add_transition(INSPECTING, INSPECTED, \u0027inspect\u0027)"},{"line_number":272,"context_line":"machine.add_transition(INSPECTING, INSPECTFAIL, \u0027fail\u0027)"},{"line_number":273,"context_line":"machine.add_transition(INSPECTED, MANAGEABLE, \u0027done\u0027)"},{"line_number":274,"context_line":"machine.add_transition(INSPECTFAIL, MANAGEABLE, \u0027manage\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_9cb76cf5","line":271,"in_reply_to":"da86d52c_69bcef06","updated":"2015-02-13 14:36:08.000000000","message":"I think \u0027done\u0027 should cause a transition from INSPECTING to MANADEABLE","commit_id":"90dba53de4c4d7a29b924e0a297be9016c81dbcd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ba474102e5e39389607c8b937f7e81b49888af94","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"# Added transitions for inspection."},{"line_number":270,"context_line":"machine.add_transition(MANAGEABLE, INSPECTING, \u0027inspect\u0027)"},{"line_number":271,"context_line":"machine.add_transition(INSPECTING, INSPECTED, \u0027inspect\u0027)"},{"line_number":272,"context_line":"machine.add_transition(INSPECTING, INSPECTFAIL, \u0027fail\u0027)"},{"line_number":273,"context_line":"machine.add_transition(INSPECTED, MANAGEABLE, \u0027done\u0027)"},{"line_number":274,"context_line":"machine.add_transition(INSPECTFAIL, MANAGEABLE, \u0027manage\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_30f757f7","line":271,"in_reply_to":"da86d52c_9cb76cf5","updated":"2015-02-16 06:47:35.000000000","message":"From INSPECTING -\u003e INSPECTED, we discover the properties and update the field last_inspected.\n\nAfter that we move the state from INSPECTED to MANAGEABLE with \u0027done\u0027.\n\nI am fine to use another verb like \u0027resume\u0027 for INSPECTING -\u003e INSPECTED.\n\nDmitry, let me know how is last_inspected updated in in-band implementation. Any suggestions are welcomed. :)","commit_id":"90dba53de4c4d7a29b924e0a297be9016c81dbcd"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"a6c3f845212ff697ba02932b377a8293f470ec76","unresolved":false,"context_lines":[{"line_number":272,"context_line":"machine.add_transition(INSPECTING, INSPECTFAIL, \u0027fail\u0027)"},{"line_number":273,"context_line":"machine.add_transition(INSPECTED, MANAGEABLE, \u0027done\u0027)"},{"line_number":274,"context_line":"machine.add_transition(INSPECTFAIL, MANAGEABLE, \u0027manage\u0027)"},{"line_number":275,"context_line":"machine.add_transition(INSPECTFAIL, INSPECTING, \u0027inspect\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_7c97183b","line":275,"updated":"2015-02-13 14:36:08.000000000","message":"I like what we\u0027ve done above this code, with a comment per transition as to why the transition is there. Can we also do this here?","commit_id":"90dba53de4c4d7a29b924e0a297be9016c81dbcd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ba474102e5e39389607c8b937f7e81b49888af94","unresolved":false,"context_lines":[{"line_number":272,"context_line":"machine.add_transition(INSPECTING, INSPECTFAIL, \u0027fail\u0027)"},{"line_number":273,"context_line":"machine.add_transition(INSPECTED, MANAGEABLE, \u0027done\u0027)"},{"line_number":274,"context_line":"machine.add_transition(INSPECTFAIL, MANAGEABLE, \u0027manage\u0027)"},{"line_number":275,"context_line":"machine.add_transition(INSPECTFAIL, INSPECTING, \u0027inspect\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_50dbeb7c","line":275,"in_reply_to":"da86d52c_7c97183b","updated":"2015-02-16 06:47:35.000000000","message":"done with patch set 20.","commit_id":"90dba53de4c4d7a29b924e0a297be9016c81dbcd"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"e532a0e9626fdf3eac3c7fa87d55a9910a9a9339","unresolved":false,"context_lines":[{"line_number":142,"context_line":"\"\"\""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"INSPECTED \u003d \u0027inspected\u0027"},{"line_number":145,"context_line":"\"\"\" Node was successfully inspected."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"This is a transitory value of provision_state and never represented in"},{"line_number":148,"context_line":"target_provision_state."}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_86e9361c","line":145,"updated":"2015-02-18 17:51:20.000000000","message":"I believe we are trying to avoid the ED states. see comments on rev 8 of https://review.openstack.org/#/c/153444","commit_id":"b21812d4b231b502d047509d7f49185fb6c7444f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"def8cabe532a120f8464f93e76f9ebed84f63473","unresolved":false,"context_lines":[{"line_number":142,"context_line":"\"\"\""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"INSPECTED \u003d \u0027inspected\u0027"},{"line_number":145,"context_line":"\"\"\" Node was successfully inspected."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"This is a transitory value of provision_state and never represented in"},{"line_number":148,"context_line":"target_provision_state."}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_c0cb09a2","line":145,"in_reply_to":"da86d52c_694253ac","updated":"2015-02-18 22:05:44.000000000","message":"Recently when i had asked Deva on IRC about it:\n\n this is from the IRC meeting which happened this Monday\n\u003cjroll\u003e devanand_: you said earlier to burn all of the *ED states?\n\u003cdevanand_\u003e jroll: defer, not burn ...","commit_id":"b21812d4b231b502d047509d7f49185fb6c7444f"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b1eca638b56b744779841c51d54a12402796c94f","unresolved":false,"context_lines":[{"line_number":142,"context_line":"\"\"\""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"INSPECTED \u003d \u0027inspected\u0027"},{"line_number":145,"context_line":"\"\"\" Node was successfully inspected."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"This is a transitory value of provision_state and never represented in"},{"line_number":148,"context_line":"target_provision_state."}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_694253ac","line":145,"in_reply_to":"da86d52c_86e9361c","updated":"2015-02-18 18:18:49.000000000","message":"I agree and I think Deva also agreed the other day (we need to get better at moving things from irc to gerrit)","commit_id":"b21812d4b231b502d047509d7f49185fb6c7444f"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"e532a0e9626fdf3eac3c7fa87d55a9910a9a9339","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"# Add inspect* states."},{"line_number":217,"context_line":"machine.add_state(INSPECTING, target\u003dMANAGEABLE, **watchers)"},{"line_number":218,"context_line":"machine.add_state(INSPECTED, target\u003dMANAGEABLE, **watchers)"},{"line_number":219,"context_line":"machine.add_state(INSPECTFAIL, target\u003dMANAGEABLE, **watchers)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"# A deployment may fail"}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_b18cdbd8","line":218,"updated":"2015-02-18 17:51:20.000000000","message":"I believe we are trying to avoid the ED states.","commit_id":"b21812d4b231b502d047509d7f49185fb6c7444f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"def8cabe532a120f8464f93e76f9ebed84f63473","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"# Add inspect* states."},{"line_number":217,"context_line":"machine.add_state(INSPECTING, target\u003dMANAGEABLE, **watchers)"},{"line_number":218,"context_line":"machine.add_state(INSPECTED, target\u003dMANAGEABLE, **watchers)"},{"line_number":219,"context_line":"machine.add_state(INSPECTFAIL, target\u003dMANAGEABLE, **watchers)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"# A deployment may fail"}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_05ce135a","line":218,"in_reply_to":"da86d52c_b18cdbd8","updated":"2015-02-18 22:05:44.000000000","message":"Chris, I am not sure. As i understood the state needs to be there but it can be a no-op state.","commit_id":"b21812d4b231b502d047509d7f49185fb6c7444f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"092ea362fb50e4861833dcfe77724f0dac4e4e1c","unresolved":false,"context_lines":[{"line_number":270,"context_line":"# Initiate inspection."},{"line_number":271,"context_line":"machine.add_transition(MANAGEABLE, INSPECTING, \u0027inspect\u0027)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"# ironic/conductor/manager.py:inspect_hardware()."},{"line_number":274,"context_line":"machine.add_transition(INSPECTING, INSPECTED, \u0027inspect\u0027)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"# Inspection may fail."}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_4223d804","line":273,"updated":"2015-02-17 20:13:15.000000000","message":"Hmm. I don\u0027t know. That code doesn\u0027t exist yet. I assume it will exist so I guess it is fine to have it here...","commit_id":"b21812d4b231b502d047509d7f49185fb6c7444f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ed769d6332fbb929097317871dcece31ef0d1624","unresolved":false,"context_lines":[{"line_number":270,"context_line":"# Initiate inspection."},{"line_number":271,"context_line":"machine.add_transition(MANAGEABLE, INSPECTING, \u0027inspect\u0027)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"# ironic/conductor/manager.py:inspect_hardware()."},{"line_number":274,"context_line":"machine.add_transition(INSPECTING, INSPECTED, \u0027inspect\u0027)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"# Inspection may fail."}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_96b50434","line":273,"in_reply_to":"da86d52c_4223d804","updated":"2015-02-18 06:01:53.000000000","message":"It is there in its dependent patch.\nhttps://review.openstack.org/#/c/149823/16/ironic/conductor/manager.py Line number 1777.","commit_id":"b21812d4b231b502d047509d7f49185fb6c7444f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"092ea362fb50e4861833dcfe77724f0dac4e4e1c","unresolved":false,"context_lines":[{"line_number":271,"context_line":"machine.add_transition(MANAGEABLE, INSPECTING, \u0027inspect\u0027)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"# ironic/conductor/manager.py:inspect_hardware()."},{"line_number":274,"context_line":"machine.add_transition(INSPECTING, INSPECTED, \u0027inspect\u0027)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"# Inspection may fail."},{"line_number":277,"context_line":"machine.add_transition(INSPECTING, INSPECTFAIL, \u0027fail\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_7f7a37bb","line":274,"updated":"2015-02-17 20:13:15.000000000","message":"I still don\u0027t think \u0027inspect\u0027 should cause INSPECTING -\u003e INSPECTED.\n\n\u0027inspect\u0027 is an action, and it could mean if INSPECTING, stay INSPECTING. If you\u0027re in INSPECTING, and someone says \u0027inspect\u0027, I don\u0027t see how anyone would think that means \u0027finish inspecting\u0027.\n\nTo be clear about this, now that I\u0027ve written the above. I think it is wrong to have \u0027inspect\u0027 cause INSPECTING -\u003e INSPECTED.\n\nI am fine with using \u0027done\u0027 for INSPECTING -\u003e INSPECTED and INSPECTED-\u003eMANAGEABLE because \u0027done\u0027 to me means I\u0027m done INSPECTING.","commit_id":"b21812d4b231b502d047509d7f49185fb6c7444f"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b1eca638b56b744779841c51d54a12402796c94f","unresolved":false,"context_lines":[{"line_number":271,"context_line":"machine.add_transition(MANAGEABLE, INSPECTING, \u0027inspect\u0027)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"# ironic/conductor/manager.py:inspect_hardware()."},{"line_number":274,"context_line":"machine.add_transition(INSPECTING, INSPECTED, \u0027inspect\u0027)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"# Inspection may fail."},{"line_number":277,"context_line":"machine.add_transition(INSPECTING, INSPECTFAIL, \u0027fail\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_8904e77e","line":274,"in_reply_to":"da86d52c_3b6fe1fd","updated":"2015-02-18 18:18:49.000000000","message":"+1","commit_id":"b21812d4b231b502d047509d7f49185fb6c7444f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ed769d6332fbb929097317871dcece31ef0d1624","unresolved":false,"context_lines":[{"line_number":271,"context_line":"machine.add_transition(MANAGEABLE, INSPECTING, \u0027inspect\u0027)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"# ironic/conductor/manager.py:inspect_hardware()."},{"line_number":274,"context_line":"machine.add_transition(INSPECTING, INSPECTED, \u0027inspect\u0027)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"# Inspection may fail."},{"line_number":277,"context_line":"machine.add_transition(INSPECTING, INSPECTFAIL, \u0027fail\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_3b6fe1fd","line":274,"in_reply_to":"da86d52c_7f7a37bb","updated":"2015-02-18 06:01:53.000000000","message":"Ok. I will use \u0027done\u0027 for both the transitions then.","commit_id":"b21812d4b231b502d047509d7f49185fb6c7444f"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"e532a0e9626fdf3eac3c7fa87d55a9910a9a9339","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"# Inspection successfully done."},{"line_number":280,"context_line":"# ironic/conductor/manager.py:inspect_hardware()"},{"line_number":281,"context_line":"machine.add_transition(INSPECTED, MANAGEABLE, \u0027done\u0027)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"# Move the node to manageable state for any other"},{"line_number":284,"context_line":"# action."}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_862cd64b","line":281,"updated":"2015-02-18 17:51:20.000000000","message":"see INSPECTED comments above","commit_id":"b21812d4b231b502d047509d7f49185fb6c7444f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"def8cabe532a120f8464f93e76f9ebed84f63473","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"# Inspection successfully done."},{"line_number":280,"context_line":"# ironic/conductor/manager.py:inspect_hardware()"},{"line_number":281,"context_line":"machine.add_transition(INSPECTED, MANAGEABLE, \u0027done\u0027)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"# Move the node to manageable state for any other"},{"line_number":284,"context_line":"# action."}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_652b4feb","line":281,"in_reply_to":"da86d52c_862cd64b","updated":"2015-02-18 22:05:44.000000000","message":"ditto :)","commit_id":"b21812d4b231b502d047509d7f49185fb6c7444f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"092ea362fb50e4861833dcfe77724f0dac4e4e1c","unresolved":false,"context_lines":[{"line_number":281,"context_line":"machine.add_transition(INSPECTED, MANAGEABLE, \u0027done\u0027)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"# Move the node to manageable state for any other"},{"line_number":284,"context_line":"# action."},{"line_number":285,"context_line":"machine.add_transition(INSPECTFAIL, MANAGEABLE, \u0027manage\u0027)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"# Reinitiate the inspect after inspectfail."}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_c268a8f7","line":284,"updated":"2015-02-17 20:13:15.000000000","message":"I don\u0027t know what you mean by \u0027for any other action\u0027.","commit_id":"b21812d4b231b502d047509d7f49185fb6c7444f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ed769d6332fbb929097317871dcece31ef0d1624","unresolved":false,"context_lines":[{"line_number":281,"context_line":"machine.add_transition(INSPECTED, MANAGEABLE, \u0027done\u0027)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"# Move the node to manageable state for any other"},{"line_number":284,"context_line":"# action."},{"line_number":285,"context_line":"machine.add_transition(INSPECTFAIL, MANAGEABLE, \u0027manage\u0027)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"# Reinitiate the inspect after inspectfail."}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_1b385ded","line":284,"in_reply_to":"da86d52c_c268a8f7","updated":"2015-02-18 06:01:53.000000000","message":"anyother action means the possible actions when the node is in \u0027MANAGEABLE\u0027 state, like zapping. Overall user should be able to move the node to manageable stateeven after inspection fails if he doesnt wish to redo inspection at that moment.","commit_id":"b21812d4b231b502d047509d7f49185fb6c7444f"}]}