)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"00af9d6931dfa7e3e953b29507b97837045f76da","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nisha Agarwal \u003cagarwalnisha1980@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-20 21:17:33 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"uefi-support-for-agent-ilo-driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"bug: fixes 1412559"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a930d6b_e981824b","line":7,"updated":"2015-01-21 13:05:39.000000000","message":"please provide a human-readable summary","commit_id":"aaaf841f157524759267997064a7fc05702d3f2a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"efecd624d145de7af50903e1e4841916d45d6087","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nisha Agarwal \u003cagarwalnisha1980@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-20 21:17:33 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"uefi-support-for-agent-ilo-driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"bug: fixes 1412559"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a930d6b_b2ffda00","line":7,"in_reply_to":"1a930d6b_e981824b","updated":"2015-01-21 16:01:59.000000000","message":"Ok. WIll update the commit message","commit_id":"aaaf841f157524759267997064a7fc05702d3f2a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7bf894e8d7f9f3a079b6241e8620950a0031222b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"uefi-support-for-agent-ilo-driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"bug: fixes 1412559"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Adds ability for the agent_ilo driver to switch modes"},{"line_number":12,"context_line":"from UEFI to BIOS and vice-versa."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a930d6b_862b8dea","line":9,"updated":"2015-01-21 12:49:11.000000000","message":"Should be Closes-bug: #1412559","commit_id":"aaaf841f157524759267997064a7fc05702d3f2a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"efecd624d145de7af50903e1e4841916d45d6087","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"uefi-support-for-agent-ilo-driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"bug: fixes 1412559"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Adds ability for the agent_ilo driver to switch modes"},{"line_number":12,"context_line":"from UEFI to BIOS and vice-versa."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a930d6b_f209622d","line":9,"in_reply_to":"1a930d6b_862b8dea","updated":"2015-01-21 16:01:59.000000000","message":"Thanks.","commit_id":"aaaf841f157524759267997064a7fc05702d3f2a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5dca7a432a1e17059f3d3382404bcc2aee7cf140","unresolved":false,"context_lines":[{"line_number":9,"context_line":"bug: fixes 1412559"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Adds ability for the agent_ilo driver to switch modes"},{"line_number":12,"context_line":"from UEFI to BIOS and vice-versa."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3e8f853d0b044da3c25c17e415097a0f2ae40df2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a930d6b_1f927c57","line":12,"updated":"2015-01-21 14:14:11.000000000","message":"Here\u0027s a summary for the expected commit message structure\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"aaaf841f157524759267997064a7fc05702d3f2a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"efecd624d145de7af50903e1e4841916d45d6087","unresolved":false,"context_lines":[{"line_number":9,"context_line":"bug: fixes 1412559"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Adds ability for the agent_ilo driver to switch modes"},{"line_number":12,"context_line":"from UEFI to BIOS and vice-versa."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3e8f853d0b044da3c25c17e415097a0f2ae40df2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a930d6b_120fce31","line":12,"in_reply_to":"1a930d6b_1f927c57","updated":"2015-01-21 16:01:59.000000000","message":"Ok.","commit_id":"aaaf841f157524759267997064a7fc05702d3f2a"}],"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5dca7a432a1e17059f3d3382404bcc2aee7cf140","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        :param task: a TaskManager instance."},{"line_number":379,"context_line":"        \"\"\""},{"line_number":380,"context_line":"        boot_mode \u003d driver_utils.get_node_capability(task.node, \u0027boot_mode\u0027)"},{"line_number":381,"context_line":"        if boot_mode is not None:"},{"line_number":382,"context_line":"            ilo_common.set_boot_mode(task.node, boot_mode)"},{"line_number":383,"context_line":"        else:"},{"line_number":384,"context_line":"            ilo_common.update_boot_mode_capability(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_7fdd4014","line":381,"updated":"2015-01-21 14:14:11.000000000","message":"super nit: Can it be something diff than None if not specified? If not let\u0027s keep the syntax simpler:\n\n if boot_mode:","commit_id":"aaaf841f157524759267997064a7fc05702d3f2a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"efecd624d145de7af50903e1e4841916d45d6087","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        :param task: a TaskManager instance."},{"line_number":379,"context_line":"        \"\"\""},{"line_number":380,"context_line":"        boot_mode \u003d driver_utils.get_node_capability(task.node, \u0027boot_mode\u0027)"},{"line_number":381,"context_line":"        if boot_mode is not None:"},{"line_number":382,"context_line":"            ilo_common.set_boot_mode(task.node, boot_mode)"},{"line_number":383,"context_line":"        else:"},{"line_number":384,"context_line":"            ilo_common.update_boot_mode_capability(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_4ff53182","line":381,"in_reply_to":"1a930d6b_7fdd4014","updated":"2015-01-21 16:01:59.000000000","message":"Ok.","commit_id":"aaaf841f157524759267997064a7fc05702d3f2a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"00af9d6931dfa7e3e953b29507b97837045f76da","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        if boot_mode is not None:"},{"line_number":382,"context_line":"            ilo_common.set_boot_mode(task.node, boot_mode)"},{"line_number":383,"context_line":"        else:"},{"line_number":384,"context_line":"            ilo_common.update_boot_mode_capability(task)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        node \u003d task.node"},{"line_number":387,"context_line":"        node.instance_info \u003d agent.build_instance_info_for_deploy(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_49b9b62d","line":384,"updated":"2015-01-21 13:05:39.000000000","message":"that\u0027s a small snippet, but it\u0027s likely to be repeated in every ilo-related prepare. maybe create function like ilo_common.prepare_boot_mode(task)?","commit_id":"aaaf841f157524759267997064a7fc05702d3f2a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"efecd624d145de7af50903e1e4841916d45d6087","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        if boot_mode is not None:"},{"line_number":382,"context_line":"            ilo_common.set_boot_mode(task.node, boot_mode)"},{"line_number":383,"context_line":"        else:"},{"line_number":384,"context_line":"            ilo_common.update_boot_mode_capability(task)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        node \u003d task.node"},{"line_number":387,"context_line":"        node.instance_info \u003d agent.build_instance_info_for_deploy(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_2f262517","line":384,"in_reply_to":"1a930d6b_49b9b62d","updated":"2015-01-21 16:01:59.000000000","message":"Ok. will update. :)","commit_id":"aaaf841f157524759267997064a7fc05702d3f2a"}],"ironic/tests/drivers/ilo/test_deploy.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7bf894e8d7f9f3a079b6241e8620950a0031222b","unresolved":false,"context_lines":[{"line_number":317,"context_line":"    #    with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":318,"context_line":"    #                              shared\u003dFalse) as task:"},{"line_number":319,"context_line":"    #        task.driver.deploy.prepare(task)"},{"line_number":320,"context_line":"    #        self.assertEqual(deploy_opts, task.node.instance_info)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    @mock.patch.object(agent, \u0027build_instance_info_for_deploy\u0027)"},{"line_number":323,"context_line":"    @mock.patch.object(ilo_common, \u0027set_boot_mode\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_a6096997","line":320,"updated":"2015-01-21 12:49:11.000000000","message":"This doesn\u0027t look good, please remove it.","commit_id":"aaaf841f157524759267997064a7fc05702d3f2a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"efecd624d145de7af50903e1e4841916d45d6087","unresolved":false,"context_lines":[{"line_number":317,"context_line":"    #    with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":318,"context_line":"    #                              shared\u003dFalse) as task:"},{"line_number":319,"context_line":"    #        task.driver.deploy.prepare(task)"},{"line_number":320,"context_line":"    #        self.assertEqual(deploy_opts, task.node.instance_info)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    @mock.patch.object(agent, \u0027build_instance_info_for_deploy\u0027)"},{"line_number":323,"context_line":"    @mock.patch.object(ilo_common, \u0027set_boot_mode\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_af605536","line":320,"in_reply_to":"1a930d6b_3ff2d89a","updated":"2015-01-21 16:01:59.000000000","message":"I will remove, forgot to remove","commit_id":"aaaf841f157524759267997064a7fc05702d3f2a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5dca7a432a1e17059f3d3382404bcc2aee7cf140","unresolved":false,"context_lines":[{"line_number":317,"context_line":"    #    with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":318,"context_line":"    #                              shared\u003dFalse) as task:"},{"line_number":319,"context_line":"    #        task.driver.deploy.prepare(task)"},{"line_number":320,"context_line":"    #        self.assertEqual(deploy_opts, task.node.instance_info)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    @mock.patch.object(agent, \u0027build_instance_info_for_deploy\u0027)"},{"line_number":323,"context_line":"    @mock.patch.object(ilo_common, \u0027set_boot_mode\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_3ff2d89a","line":320,"in_reply_to":"1a930d6b_a6096997","updated":"2015-01-21 14:14:11.000000000","message":"+1, it\u0027s also causing pep8 to fail","commit_id":"aaaf841f157524759267997064a7fc05702d3f2a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"efecd624d145de7af50903e1e4841916d45d6087","unresolved":false,"context_lines":[{"line_number":317,"context_line":"    #    with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":318,"context_line":"    #                              shared\u003dFalse) as task:"},{"line_number":319,"context_line":"    #        task.driver.deploy.prepare(task)"},{"line_number":320,"context_line":"    #        self.assertEqual(deploy_opts, task.node.instance_info)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    @mock.patch.object(agent, \u0027build_instance_info_for_deploy\u0027)"},{"line_number":323,"context_line":"    @mock.patch.object(ilo_common, \u0027set_boot_mode\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_2f6d4533","line":320,"in_reply_to":"1a930d6b_a6096997","updated":"2015-01-21 16:01:59.000000000","message":"Sorry i forgot to remove :(","commit_id":"aaaf841f157524759267997064a7fc05702d3f2a"}]}