)]}'
{"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0946602e71a06fd46f13a07b463b7fb3b5daf952","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        else:"},{"line_number":341,"context_line":"            raise exception.InvalidStateRequested(state\u003dtarget, node\u003dnode_uuid)"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        if processing and rpc_node.provision_state !\u003d ir_states.DEPLOYFAIL:"},{"line_number":344,"context_line":"            msg \u003d (_(\u0027Node %s is already being provisioned or decommissioned.\u0027)"},{"line_number":345,"context_line":"                   % rpc_node.uuid)"},{"line_number":346,"context_line":"            raise wsme.exc.ClientSideError(msg, status_code\u003d409)  # Conflict"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_a62a202a","line":343,"updated":"2015-01-22 11:53:57.000000000","message":"it\u0027s most a nit but I think that this check should be part of setting the \"processing\" variable.\n\nIt\u0027s the same as testing \"!\u003d ir_state.DEPLOYWAIT\" on line 339.\n\nWhat about:\n\n        if target in (ir_states.ACTIVE, ir_states.REBUILD):\n            valid_states \u003d (ir_states.DEPLOYFAIL)\n        elif target \u003d\u003d ir_states.DELETED:\n            valid_states \u003d (ir_states.DEPLOYFAIL, ir_states.DEPLOYWAIT)\n        else:\n            raise exception.InvalidStateRequested(state\u003dtarget, node\u003dnode_uuid)\n\n        # Check if the node is not mid-operation\n        processing \u003d (rpc_node.target_provision_state is not None and\n                      rpc_node.provision_state not in valid_states)\n\n\n        if processing:\n              raise ...","commit_id":"17d86a94297167580ebf198fbbb4bcc7336dcee3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f06dc92072a4d68c1b7524a5c7666f660c10c7f5","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        else:"},{"line_number":341,"context_line":"            raise exception.InvalidStateRequested(state\u003dtarget, node\u003dnode_uuid)"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        if processing and rpc_node.provision_state !\u003d ir_states.DEPLOYFAIL:"},{"line_number":344,"context_line":"            msg \u003d (_(\u0027Node %s is already being provisioned or decommissioned.\u0027)"},{"line_number":345,"context_line":"                   % rpc_node.uuid)"},{"line_number":346,"context_line":"            raise wsme.exc.ClientSideError(msg, status_code\u003d409)  # Conflict"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_6fc80423","line":343,"in_reply_to":"1a930d6b_a62a202a","updated":"2015-01-22 15:05:03.000000000","message":"That\u0027s a good point. I wanted to minimize the amount of changes until we started adding the new states, so that it would be easier to see what the code did before vs while we\u0027re making changes to get towards the new state machine. (I saw this as temporary fix.)\n\nBut that probably doesn\u0027t matter much I guess.\n\nLet me know what you think (I modified it slightly from your suggestion).","commit_id":"17d86a94297167580ebf198fbbb4bcc7336dcee3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8a1daa009213bc06aacc8fc14cafd93b98191141","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                          ir_states.REBUILD):"},{"line_number":337,"context_line":"            raise exception.InvalidStateRequested(state\u003dtarget, node\u003dnode_uuid)"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        valid_states_if_processing \u003d [ir_states.DEPLOYFAIL]"},{"line_number":340,"context_line":"        if target \u003d\u003d ir_states.DELETED:"},{"line_number":341,"context_line":"            valid_states_if_processing.append(ir_states.DEPLOYWAIT)"},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_9cee23b3","line":339,"updated":"2015-01-23 13:36:27.000000000","message":"nit: this better be a set","commit_id":"7b16cb7401e72cce31f7fa53af11255283f792f4"}]}