)]}'
{"ironic/conductor/manager.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"374874d12e4ebc21478b514ce3bad2299d6e0109","unresolved":false,"context_lines":[{"line_number":1161,"context_line":"                                          node_uuid,"},{"line_number":1162,"context_line":"                                          shared\u003dTrue) as task:"},{"line_number":1163,"context_line":"                    if not task.driver.management:"},{"line_number":1164,"context_line":"                        LOG.warn(_LW(\"Unable to send sensor data for node \""},{"line_number":1165,"context_line":"                                     \"%(node)s. The driver %(driver)s does \""},{"line_number":1166,"context_line":"                                     \"not support management, which is \""},{"line_number":1167,"context_line":"                                     \"necessary for getting sensor data.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_e56895bc","line":1164,"updated":"2015-01-22 15:31:57.000000000","message":"I\u0027m not sure it should be a warning, I\u0027d say rather a debug. Imagine your logs full with such warnings happening every N seconds.","commit_id":"3e913014af73f13bddb349792d63842ed9326475"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a1f5f43f71f1220fe4c6c9eeefb32ba162cc28f","unresolved":false,"context_lines":[{"line_number":1161,"context_line":"                                          node_uuid,"},{"line_number":1162,"context_line":"                                          shared\u003dTrue) as task:"},{"line_number":1163,"context_line":"                    if not task.driver.management:"},{"line_number":1164,"context_line":"                        LOG.warn(_LW(\"Unable to send sensor data for node \""},{"line_number":1165,"context_line":"                                     \"%(node)s. The driver %(driver)s does \""},{"line_number":1166,"context_line":"                                     \"not support management, which is \""},{"line_number":1167,"context_line":"                                     \"necessary for getting sensor data.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_00558f4f","line":1164,"in_reply_to":"1a930d6b_e56895bc","updated":"2015-01-22 16:22:12.000000000","message":"I could be wrong, but this looks like a periodic task that will send sensor data if the driver is capable of doing so. If there isn\u0027t any management interface, that isn\u0027t an error. Do we even want to log anything, even in debug?\n\nThe original code logged this as a warning and no one has complained yet. Presumably, if you want sensor data, you want it from all your drivers so you wouldn\u0027t load any that didn\u0027t support this. I guess.\n\nSo maybe debug is useful? (I\u0027m not sure I convinced myself that it is but...)","commit_id":"3e913014af73f13bddb349792d63842ed9326475"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"374874d12e4ebc21478b514ce3bad2299d6e0109","unresolved":false,"context_lines":[{"line_number":1163,"context_line":"                    if not task.driver.management:"},{"line_number":1164,"context_line":"                        LOG.warn(_LW(\"Unable to send sensor data for node \""},{"line_number":1165,"context_line":"                                     \"%(node)s. The driver %(driver)s does \""},{"line_number":1166,"context_line":"                                     \"not support management, which is \""},{"line_number":1167,"context_line":"                                     \"necessary for getting sensor data.\"),"},{"line_number":1168,"context_line":"                                     {\u0027node\u0027: node_uuid, \u0027driver\u0027: driver})"},{"line_number":1169,"context_line":"                        continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_e541753a","line":1166,"updated":"2015-01-22 15:31:57.000000000","message":"s/support management/have management interface/","commit_id":"3e913014af73f13bddb349792d63842ed9326475"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a1f5f43f71f1220fe4c6c9eeefb32ba162cc28f","unresolved":false,"context_lines":[{"line_number":1174,"context_line":"            except NotImplementedError:"},{"line_number":1175,"context_line":"                LOG.warn(_LW(\u0027get_sensors_data is not implemented for driver\u0027"},{"line_number":1176,"context_line":"                    \u0027 %(driver)s, node_uuid is %(node)s\u0027),"},{"line_number":1177,"context_line":"                    {\u0027node\u0027: node_uuid, \u0027driver\u0027: driver})"},{"line_number":1178,"context_line":"            except exception.FailedToParseSensorData as fps:"},{"line_number":1179,"context_line":"                LOG.warn(_LW(\"During get_sensors_data, could not parse \""},{"line_number":1180,"context_line":"                    \"sensor data for node %(node)s. Error: %(err)s.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_40e6b7b5","line":1177,"updated":"2015-01-22 16:22:12.000000000","message":"outside the scope or maybe you can fix if you agree. If get_sensors_data isn\u0027t implemented, why are we logging a warning about it. Drivers don\u0027t need to implement it. At most, it seems like it would be a debug to me.","commit_id":"3e913014af73f13bddb349792d63842ed9326475"}]}